search

ONDC-Official / v1.1.0-logs

2 stars 107 forks source link

eSamudaay SNP (RSF) - compliance check #742

Closed sandeepshahi closed 7 months ago

sandeepshahi commented 8 months ago

/on_receiver_recon

@Namratha102000

Namratha102000 commented 8 months ago

@bluecypher Hi I have raised a PR with corrections

Namratha102000 commented 8 months ago

Hi please review this

On Mon, 18 Dec 2023 at 6:02 PM, Sandeep Shahi @.***> wrote:

/on_receiver_recon

  • context/timestamp can't be earlier than /receiver_recon timestamp
  • receiver_app_id mismatches with context/bpp_id

@Namratha102000 https://github.com/Namratha102000

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.1.0-logs/issues/742, or unsubscribe https://github.com/notifications/unsubscribe-auth/A726ZOCSVYW573FXYQGEQ7LYKAZVZAVCNFSM6AAAAABAZOLDN2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DMNJWHEZDKMA . You are receiving this because you were mentioned.Message ID: @.***>

sandeepshahi commented 7 months ago

@Namratha102000, please test with mock server utility to avoid counterparty related issues.

developers-esamudaay commented 7 months ago

@bluecypher There was a error in logs extraction at our end. I printed the payload directly, hence the message/orderbook/orders path was missing. Will resubmit with the proper recon request again!

sandeepshahi commented 7 months ago

orderbook timestamps and "@ondc/org/buyer_app_finder_fee_type" enum related issues in /receiver_recon.

@developers-esamudaay, proper checks and balances must be in place.

sandeepshahi commented 7 months ago

Logs approved for RSF v1.0.0, subject to above validations and fixes.

@Namratha102000 @developers-esamudaay