NishthaMonga commented 8 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp~1providers/2/items/0/category_id Invalid category ID found for item for on_search
/message/catalog/bpp/providers/loc0/time/schedule/holidays": "Holidays cannot be past 2024-02-28

Flow 2

on_select

Invalid Item Id provided in /on_select: 1_4964

on_confirm

updated_at timestamp should be equal to context timestamp for /on_confirm

on_status_pending, on_status_packed, on_status_picked,on_status_delivered

/message/order/payment/@ondc~1org~1settlement_basis must be equal to one of the allowed values (shipment,delivery,return_window_expiry)

on_status_out_for_delivery

Message_id cannot be same for on_status.packed and on_status.out_for_delivery
fulfillments/state Should be out-for-delivery for /on_status_Out-for-delivery

Flow 3

on_select_out_of_stock

Item with id: 1_4962 does not exist in items list of select

on_select

item with id: F46812 in quote.breakup[4] does not exist in items[] (should be a valid item id)

on_confirm

updated_at timestamp should be equal to context timestamp for /on_confirm

Flow 4

on_cancel

/message/order/billing/address must have required property 'building
/message/order/fulfillments/0/end/location/address must have required property 'building'

@Retailware

Retailware commented 7 months ago

Hi, We have resubmitted all logs again, Please test.

Jagannath-Padhy commented 7 months ago

Flow 2,3,4,5

On Init

Message Order Tags 0 List: Pan_id is different in tax_number and provider_tax_number in message.order.tags[1].list

On Confirm

SchemaErr0: /message/order/tags/1/list/1/value Value for tax_number must be a valid tax number i.e alphanumeric with 15 characters
Message Order Tags Bpp Terms: List of bpp_terms mismatched in message/order/tags/bpp_terms for on_init and on_confirm as accept_bap_terms is not required currently as static terms are not require .
Static Terms: Static terms are not required right now

Flow 5

On Cancel

On Cancel MsgId: Message id should not be same with previous calls
Invld Quote Trail Prices: Quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm
RTO Fulfillment Start Location: RTO fulfillment start location object is missing in on_cancel
RTO Fulfillment End: RTO fulfillment end object is missing in on_cancel
RTO Start Location/Delivery Fulfillment End Location: RTO fulfillment start or Delivery fulfillment end location is missing in on_cancel
RTO End Location/Delivery Fulfillment Start Location: RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel

Flow 6-a

On Update

On Update MsgId: Message id should not be same with previous calls

Update

Update MsgId: Message id should not be same with previous calls

Flow 6-b

Same as above

Flow 6-c

On Update Liquidated

On Update Liquidated MsgId: Message id should not be same with previous calls
Invld Quote Trail Prices: Quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm

@Retailware

Retailware commented 7 months ago

Hi we are mailed regarding this but did not response from tech team, Please guide on this.

"message/order/tags/bpp_terms": "List of bpp_terms mismatched in message/order/tags/bpp_terms for on_init and on_confirm"

-When we added RTO charges that time getting this error and all calculation are corrected.

"invldQuoteTrailPrices": "quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm"

Please help on this.

@Jagannath-Padhy

Jagannath-wits commented 7 months ago

Hi we are mailed regarding this but did not response from tech team, Please guide on this.

"message/order/tags/bpp_terms": "List of bpp_terms mismatched in message/order/tags/bpp_terms for on_init and on_confirm"

-When we added RTO charges that time getting this error and all calculation are corrected. 2. "invldQuoteTrailPrices": "quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm"

Please help on this.

@Jagannath-Padhy

Bap terms are not required for now and will be implemented later, hence accept bap terms is also not required in bpp terms.
Please ignore the quote error

Retailware commented 7 months ago

ok, thanks. As per the suggestion we have made the changes and re-uploaded the logs (created a PR). Please check our logs.

@Jagannath-Padhy

sahil-ondc commented 7 months ago

Flow 1

on_search (full_catalog)

code is an optional property in /message/catalog/bpp/providers
timing tags should be provided as per the API contract
area_code provided in /message/catalog/bpp/providers/locations/address should be as per provided GPS
Correct item descriptor code for branded items (EAN for grocery)
short_desc and long_desc should not be same in /message/catalog/bpp/providers/items/descriptor
@ondc/org/mandatory_reqs_veggies_fruits is an optional property
veg_nonveg is not mapped correctly as per the item description

on_search (inc_catalog)

@ondc/org/contact_details_consumer_care should be provided in /message/catalog/bpp/providers/items
code provided /message/catalog/bpp/providers/items should be in particular format

Flow 2

on_select

/message/order/quote/breakup/quantity logic should remain same as provided in on_search (full catalog)
discount and tax should only be provided in case of non-zero values

on_init

@ondc/org/settlement_basis, @ondc/org/settlement_window, @ondc/org/withholding_amount should not be provided in on_init
cancellation_terms should not be provided as those are not enabled yet
only np_type, provider_tax_number, and tax_number should be provided in /message/order/tags/bpp_terms

on_confirm

documents should only be provided once order is picked up
/message/order/fulfillment/range/start should not be smaller than context/timestamp
only np_type, provider_tax_number, and tax_number should be provided in /message/order/tags/bpp_terms
payment details mismatch

on_status

/message/order/documents/url should be publically accessible
instructions should not have placeholder values (ex: https://lsp.com/delivery_image.png)
timestamps should be managed correctly

Flow 3

Same as flow 2

Flow 4

same as flow 2

on_cancel

/message/order/payment/url mismatch with /confirm

Flow 5

same as flow 2

on_cancel

/message/order/fulfillment/tags/precancel_state updated_at is not captured correctly
RTO-disposed or RTO-delivered missing

Flow 6

Partial-cancellation, reverse-QC, Liquidation should be provided within a single order

@Retailware

Retailware commented 6 months ago

As per suggestion we have submitted order flows logs and also we have submitted a single order for flow 6.

@sahil-ondc

sahil-ondc commented 6 months ago

Flow 1

on_search (full catalog)

/message/catalog/bpp/fulfillments/1/type must be equal to one of the allowed values (Delivery,Self-Pickup)
code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor
symbol provided in /message/catalog/bpp/descriptor should be publically accessible
area_code provided in /message/catalog/bpp/providers[0]/locations should be as per provided gps
rateable is an optional property in /message/catalog/bpp/providers[0]/locations
placeholders should not be provided in brand_owner_FSSAI_license_no, other_FSSAI_license_no, importer_FSSAI_license_no (provided catalog should be subset of actual production catalog)
locality and street should not be provided as 'NA'
/message/catalog/bpp/providers/0/locations/0/time must have required property 'schedule'
/message/catalog/bpp/providers/0/items/0/quantity/available/count available count must be either 99 or 0 only
variants should be provided

on_search (inc catalog)

@ondc/org/contact_details_consumer_care should be in format "name, email, phone"
same as full catalog

Flow 2

on_init

settlement_ifsc_code, upi_address, settlement_bank_account_no, bank_name should not have placeholder values
/message/order/payment/tags should not have bpp_collect
item/unitized/measure/unit should not be provided in /message/order/quote/item

on_status

start and end range should remain same as provided in on_confirm
if instructions are provided, those should not be placeholders
invoice provided should be publically accessible, and should not be webpage url
agent details provided should not be placeholders (phone: 0000000000)
settlement_timestamp should be provided only if settlement is done
authorization valid_from and valid_to cannot be same

Flow 4

on_cancel

precancel_state updated_at not captured correctly

Flow 5

same as above

on_cancel (rto)

precancel_state updated_at not captured correctly

on_status (after rto)

how same order is being rto-disposed, and rto-delivered

Flow 6

Optional keys should not be provided
@ondc/org/settlement_details should get /update settlement trail appended

Note

on_search

in case of same timing and same days, use type 'All'

@Retailware

Retailware commented 6 months ago

Flow 6 Optional keys should not be provided @ondc/org/settlement_details should get /update settlement trail appended

In flow-6 which API need to change required?

@sahil-ondc

Jagannath-wits commented 5 months ago

Flow 1

Search

search_full_catalog.json has an on_search payload, kindly provide the search_full_catalog request in it

On_search

short_desc and long_desc can't be same
if the timing construct for order and delivery are same, you can use enum 'All' instead of it
This 'net_quantity_or_measure_of_commodity_in_pkg' field is not required in the @ondc/org/statutory_reqs_packaged_commodities
Why the '@ondc/org/statutory_reqs_prepackaged_food' are there in case of 'Dals and Pulses’; it should be @ondc/org/statutory_reqs_packaged_commodities
There are two statutory_reqs are there which shouldn't be there and all are same. Kindly refer to the following sheet: 'https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=0’. ,
How 'CLINIC PLUS + NATURALLY STRONG HEALTH SHAMPOO 340ML' can fall under the category_id 'Dals and Pulses'.
Kindly provide a reasonable number for maximum_count

Flow 2

On_select

Why is price sent in order.items ? Please refer to contract
Quote.breakup.item.unitized is not required as per contract
quote.item.quantity.maximum should be either 99(no-limit) or a reasonable amount of maximum number of quantity of the item which can be ordered.

Init

order.items.location_id is not required

On_status_picked

Invoice should be publically accessible and correct

Flow 3

same as above

Flow 4

On_cancel

same as above
Delivery_fulfillment.end.address has extra key ward.

Flow 5

On_cancel

same as above
Either rto-initiated or disposed is required not both, Also the timestamp and transaction_id mismatch
Delivery_fulfillment.end.address has extra key ward.

Flow 6

Please provide flow 6 in a single order flow i.e you select multiple items then you part-cancel first, then reverse qc, and finally liquidation.
Make sure that the invoice is updated after part-cancel
Make sure that the settlement details and fulfillments.quote_trail are carried forward in correct format and the audit trail is mantained.

@Retailware

ONDC-Official / v1.2.0-logs

Retailware (SA: RET10) — compliance checks #1049

Flow 1

on_search_full_catalog_refresh

Flow 2

on_select

on_confirm

on_status_pending, on_status_packed, on_status_picked,on_status_delivered

on_status_out_for_delivery

Flow 3

on_select_out_of_stock

on_select

on_confirm

Flow 4

on_cancel

Flow 2,3,4,5

On Init

On Confirm

Flow 5

On Cancel

Flow 6-a

On Update

Update

Flow 6-b

Flow 6-c

On Update Liquidated

Flow 1

on_search (full_catalog)

on_search (inc_catalog)

Flow 2

on_select

on_init

on_confirm

on_status

Flow 3

Flow 4

on_cancel

Flow 5

on_cancel

Flow 6

Flow 1

on_search (full catalog)

on_search (inc catalog)

Flow 2

on_init

on_status

Flow 4

on_cancel

Flow 5

on_cancel (rto)

on_status (after rto)

Flow 6

Note

on_search

Flow 1

Search

On_search

Flow 2

On_select

Init

On_status_picked

Flow 3

Flow 4

On_cancel

Flow 5

On_cancel

Flow 6