Krenai (SA: RET10) - compliance check

[sahil-ondc]

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/items/quantity/unitized/measure must have required property 'value'
• /bpp/providers/locations/gps coordinates must be specified with at least six decimal places of precision
• category in serviceability construct should be one of the category ids bpp/providers/items/category_id

on_search_inc_refresh

• /message/catalog/bpp/providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)
• /message/catalog/bpp/providers/items/quantity/unitized/measure must have required property 'value'

on_select

• quote.price.value 3365.05 does not match with the price breakup 3338.26
• Quote breakup Payment title type "tax_f" is not as per the API contract
• Quote breakup Payment title "Delivery Charges Tax" is not as per the API Contract

init

• gps coordinates in fulfillments.end.location mismatch in /select & /init

on_init

• gps coordinates in fulfillments.end.location mismatch in /select & /on_init

on_confirm

• /message/order/fulfillments/start/location/address must be object
• /message/order/fulfillments/end/time/range must have required property 'start'
• /message/order/fulfillments/end/time/range must have required property 'end'
• store name /fulfillments/start/location/descriptor/name can't change

on_status

• /message/order/fulfillments must have required property '@ondc/org/TAT'

common

• /message/order/payment must have required property '@ondc/org/settlement_basis'
• /message/order/payment must have required property '@ondc/org/settlement_window'

@AnchalSharma07

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/items/quantity/unitized/measure must have required property 'value'
• /message/catalog/bpp/providers/items/quantity/available/count must be equal to one of the allowed values (99,0)
• /message/catalog/bpp/providers/items/category_id should be from https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=1130527843
• category in serviceability construct should be one of the category ids bpp/providers[0]/items/category_id

on_search_inc_refresh

• location label (/bpp/providers/locations/time/label) for /on_search_inc_refresh should not be equal to /on_search_full_catalog_refresh.label

Flow 2

on_select

• City code mismatch in /search and /on_select

on_confirm

• /message/order/fulfillments/0/start/instructions must have required property 'code'
• /message/order/fulfillments/0/start/instructions must have required property 'name'
• /message/order/fulfillments/0/start/instructions must have required property 'short_desc'
• /message/order/fulfillments/0/start/instructions must have required property 'long_desc'
• store name /fulfillments[0]/start/location/descriptor/name can't change
• bpp_terms should be passed once in the /message/order/tags

Flow 3 not submitted

@AnchalSharma07

[sahil-ondc]

Flow 1

search_full_catalog_refresh

• invalid keys 'storeIds', 'serviceabilityConstructHelper' provided in root

on_search_full_catalog_refresh

• /message/catalog/bpp~1providers/0/items/0/quantity/unitized/measure must have required property 'value'
• on_search_full_catalog_refresh has taken 1 hour 46 minutes which is longer than expected by buyer application
• /message/catalog/bpp/providers/descriptor should not have empty property 'tags'
• 'name', 'long_desc', 'short_desc' should not have formatting in /message/catalog/bpp/providers/items
• 'tags' cannot be empty in /message/catalog/bpp/providers/items/descriptor
• invalid code 'Pcs' provided in /message/catalog/bpp/providers/items/tags/attribute

search_inc_refresh

• invalid keys 'storeIds', 'serviceabilityConstructHelper' provided in root

on_search_inc_refresh

• location label (/bpp/providers/locations/time/label) for /on_search_inc_refresh should not be equal to /on_search_full_catalog_refresh.label
• context/message_id should not be equal to /search context/message_id in case of mode 'start'
• invalid key 'categories' provided in /message/catalog/bpp/providers
• /message/catalog/bpp/providers/items should only be provided in case of change in delta
• 'name', 'long_desc', 'short_desc' should not have formatting in /message/catalog/bpp/providers/items
• timestamp should not change without any change in label in /message/catalog/bpp/providers/items/time

Other flows

on_select

• /message/order/quote/breakup/item/quantity/maximum/count must be equal to one of the allowed values (99,0)
• quote.price.value 575.68 does not match with the price breakup 595.68
• /message/order/items should be as per the API contract

on_init

• /message/order/quote mismatch from on_select ('F2-606' missing)
• /message/order/fulfillments/end/person value cannot be null

on_confirm

• store name /fulfillments[0]/start/location/descriptor/name can't change
• /message/order/fulfillments/end/location/descriptor value cannot be null

on_status

• /message/order/fulfillments/end/location/descriptor/name can't be different from on_init
• /message/order/fulfillments/end/time/timestamp should be in end/time/range

@AnchalSharma07

[sahil-ondc]

FLow 1

on_search_full_catalog_refresh

• message/catalog/bpp/providers/categories should have variants based on 'item.quantity.unitized.measure'
• context/city should be provided as per the provided gps in message/catalog/bpp/providers/locations
• remove formatting from message/catalog/bpp/providers/items/descriptor
• message/catalog/bpp/providers/items/tags should not have attributes

on_search_inc_catalog_refresh

• /message/catalog/bpp/providers/items must have required property '@ondc/org/contact_details_consumer_care'
• missing property 'parent_item_id' for item id '100745'
• /message/catalog/bpp/providers/items/time/timestamp should only change in case of change in /message/catalog/bpp/providers/items/time/label

Other Flows

• Timestamp for /on_search api cannot be greater than to /select api 'FLOWS SHOULD BE SUBMITTED IN SEQUENCIAL ORDER'

@AnchalSharma07

[sahil-ondc]

FLow 1

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/locations/timestamp cannot be greater than context/timestamp
• /message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp
• correct path should be provided for variants in /message/catalog/bpp/providers/categories/tags/list
• /message/catalog/bpp/providers/items/quantity/unitized/measure should have different values in case of variants

on_search_inc_catalog_refresh

• message/catalog/bpp/providers/items/tags should not have attributes
• /message/catalog/bpp/providers/locations/time/timestamp should only change in case of change in its time/label

Flow 2

on_select

• /message/order/quote/breakup/title mistmatches for item.id '100745', as compare to provided in /on_search

on_init

• /message/order should not have provided value 'provider_location'

on_confirm

• /message/order/fulfillments cannot have empty array named 'tags'

on_status

• timestamp provided in /message/order/fulfillments/end/time should be in range

Flow 3

Transactional logs should be provided as per the sheet https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

Flow 4

on_cancel

• /message/order/quote/breakup/title mistmatches for item.id '100745', as compare to provided in /on_search

@AnchalSharma07

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• /message/catalog/bpp/fulfillments should be mapped with the /message/catalog/bpp/providers/fulfillments

on_search_inc_catalog_refresh

• /message/catalog/locations should not be part of the on_search_inc if there is not change in its label as Per Api contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit
• /message/catalog/bpp/providers/items should only be provided in case of change in delta, no change found in '100745'

common

on_init

• /message/order should not have property 'provider_locations' (Deprecated)

@AnchalSharma07

[sandeepshahi]

Please remove all the irrelevant files and folders and share logs as per the test case scenarios

Flow 1

/on_search

• remove "accept_bap_terms" block; will have to be provided when the static terms are accepted by bpp;
• schedule/holidays is missing in bpp/providers/locations
• unitized measure for item "100745" is set as 24 units; is this intended?
• invalid format of country of origin; check item: 8901972083, the value should be IND (instead of India)
• invalid variant group definition in /categories; tags/type is missing for id:"7449"

/on_search (incremental)

• invalid code in /items/descriptor/code; can't be null, should be a valid HSN code

Flow 2 (Common Issues)

/on_confirm

• person is not required in /fulfillments/start
• invalid DCC code in /fulfillments/end/instructions/short_desc; should only be provided when order is Out-for-delivery; check contract for the format
• cancellation_terms should not be provided;

/on_status

• estimated pickup/delivery timings should not change
• settlement_timestamp and settlement_amount should not be provided in "@ondc/org/settlement_details" until settled by the collector

Flow 3

/on_select (OOS)

• error message should be in valid stringified JSON format with escaped quotes for keys and values

Flow 4

/on_cancel

• invalid cancellation reason id called by the buyer NP; should be NACK'd by SNP
• invalid cancellation flow; new cancellation fulfillment should be created and all the items must be assigned to that fulfillment; check contract

Flow 5

• Invalid RTO Flow;

Flow 6

• must be submitted for verification

@AnchalSharma07

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• /message/catalog/bpp~1providers/0/locations/0/time/schedule must be object
• fulfillment_id in /bpp/providers/items should map to one of the fulfillments id in bpp/fulfillments
• "accept_bap_terms" code should not be provided. It should be enabled when static terms are defined by the BNP and accepted by the seller app

on_search_inc_catalog_refresh

• /message/catalog/bpp/providers/categories should not be sent if that are already sent in on_search_full_catalog_refresh

Flow 2

on_confirm

• cancellation_terms should not be provided; static/dynamic terms need not be provided as part of phase 1
• /message/order/fulfillment/end/instructions should not be provided as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.9sth5gn87hj1
• provider_tax_number (pan number of merchant) should be provided in /tags/bpp_terms

on_status

• /message/order/created_at should remain same as provided in /confirm

Flow 3

on_select (out-of-stock)

• error object should be exactly as per the API contract (error.message should be in the escaped quote format ) https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

Flow 4

on_cancel

• /message/order/tags should have property 'quote_trail', refer to API contract (https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec)

Flow 5

on_cancel

• /message/order/cancelation/cancelled_by should not be buyer application as 'cancellation must be initiated by seller'

Flow 6

on_update

• /context/message_id cannot be same as context/message_id in confirm request
• /context/message_id should be unique for all unsolicited on_update calls

Note

• multiple issues in 'Flow 6', Please check the contract and resolve

@AnchalSharma07

[sahil-ondc]

Flow 2

on_select

• /fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search

on_init

• Mismatch found for item with item_id 717

confirm

• Mismatch found for item with item_id 717
• Quoted Price in /confirm INR 537 does not match with the quoted price in /on_select INR 537.37

on_confirm

• Mismatch found for item with item_id 717
• Quoted Price in /on_confirm 537 does not match with the quoted price in /on_select 537.37
• np_type is missing in message/order/tags/bpp_terms for ON_CONFIRM

on_status

• /message/order/fulfillments/0/@ondc~1org~1TAT must match format duration
• /message/order/quote/breakup/3 must have required property '@ondc/org/item_id'

Flow 3

• Same issues as above

Flow 4

• Same issues as above

on_cancel

• quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm
• billing issues
  • Key 'created_at' mismatch: 2024-03-08T13:47:53.557Z !== 2024-03-08T13:47:54.000Z when compared with init billing object",
  • Key 'updated_at' mismatch: 2024-03-08T13:47:53.557Z !== 2024-03-08T13:47:54.000Z when compared with init billing object",
• Pre Cancel is mandatory for on_cancel

Flow 5

• Same issues as above

• /message/order/fulfillments/1/tags/0 must have required property 'code'

• /message/order/fulfillments/1/tags/0/list/1/code must be equal to one of the allowed values (reason_id,initiated_by,fulfillment_state,updated_at,retry_count,rto_id,id,currency,value,type)",

• quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm

• billing issues

  • Key 'created_at' mismatch: 2024-03-08T13:56:03.497Z !== 2024-03-08T13:56:03.000Z when compared with init billing object
  • Key 'updated_at' mismatch: 2024-03-08T13:56:03.497Z !== 2024-03-08T13:56:03.000Z when compared with init billing object

• Delivery state should be Cancelled for on_cancel

• Pre Cancel is mandatory for on_cancel

@AnchalSharma07

[AnchalSharma07]

@sahil-ondc @sandeepshahi I am unable to get this issue. "on_init => Mismatch found for item with item_id 717". Can you please elaborate it more, It would be a great help

[sahil-ondc]

Hi Anchal,

So this Indicates that there is some mismatch in the breakup with item_id 717, Can you please check. Apologies for delay, will fix this error message.

@AnchalSharma07

[AnchalSharma07]

@sahil-ondc @sandeepshahi We have updated the logs as per your feedbacks. We have generated a new PR please review it.

[Jagannath-wits]

Flow 1

On Search Full Catalog Refresh

Schema Errors

• Error: /message/catalog/bpp~1providers/0/tags/1/list/0/value timing for fulfillment type, enum - 'Order' (online order processing timings 'Delivery' (order shipment timings, will be same as delivery timings for hyperlocal), 'Self-Pickup' (self-pickup timings) not All.

Provider Code Errors

• Error: item/descriptor/code should be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
• Error: item/descriptor/code should be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
• Error: item/descriptor/code should be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
• Error: item/descriptor/code should be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others

Flow 2

On Init

Provider Tax Number

• Error: provider_tax_number must be present for on_init

Flow 3

• Same as above

Flow 5

On Cancel

Invalid Quote Trail Prices

• Error: quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm

Settlement Details

• Error: payment settlement_details mismatch in /on_init & /confirm

Flow 6-a(Part-cancel)

On Confirm

Missing NP Type

• Error: np_type is missing in message/order/tags/bpp_terms for ON_CONFIRM

On Update

Schema Error

• Error: /message/order/billing/address must have required property 'name'

Flow 6-b(reverse qc)

Update

Schema Error

• Error: /message/order/fulfillments/0/tags/0/list/2 must have required property 'value'

Update Reason ID

• Error: reason_id is not a valid reason id (buyer app initiated)

On Update Interim

Schema Error

• Error: /message/order/billing/address must have required property 'name'

On Update Approval

Schema Error

• Error: /message/order/billing/address must have required property 'name'

On Update Picked

Schema Error

• Error: /message/order/billing/address must have required property 'name'

On Update Delivered

Schema Error

• Error: /message/order/billing/address must have required property 'name'

Flow 6-c (Liquidation)

Update

Schema Error

• Error: /message/order/fulfillments/0/tags/0/list/2 must have required property 'value'

On Update Interim

Schema Error

• Error: /message/order/billing/address must have required property 'name'

On Update Liquidated

Schema Error

• Error: /message/order/billing/address must have required property 'name'

Invalid Quote Trail Prices

• Error: quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm

@AnchalSharma07

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR. Please review them. @sandeepshahi @sahil-ondc @Jagannath-wits

[sahil-ondc]

Flow 1

on_search_full_catalog

• provided area_code should be as per provided GPS

Flow 2

on_status (pending)

• start and end provided in /message/order/fulfillment/start/time/range cannot be same

Flow 4

on_cancel

• updated_at provided in /message/order/fulfillment/tags/precancel_state should be captured correctly

Flow 5

• RTO-disposed or RTO-delivered missing

Flow 6

on_update (part-cancellation)

• tax was not provided in breakup, why its provided in quote_trail (item_id: 4800024664)
• ttl should not be provided as empty string ("")

on_update (liquidated return_interim)

• @ondc/org/settlement_details should be updated as refund is initiated for part-cancellation refund

@AnchalSharma07

[AnchalSharma07]

@sahil-ondc @sandeepshahi

1. For Flow 1 ->on_search_full_catalog -> provided area_code should be as per provided GPS We are using google maps api to extract postal code from lat lang (& vice versa) . We have validated the gps and postal code being sent in the response using google maps, it appears to be same(122004) as well. But if we check it on online geolocators , we are getting a different postal code(122005)

2. For Flow 6 ->on_update (liquidated return_interim) : Can you please elaborate this, as we are unable to find relevant example in document. Also we have asked this over the community call , they are unable to identify the issue as well

[sahil-ondc]

1. ACK.
2. Once Seller will do the part-cancellation, then buyer application is supposed to send an /update which will be related to refund initiated, that refund trail should be maintained in future calls of same order.

@AnchalSharma07

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR Please review them. @sahil-ondc @sandeepshahi

[AnchalSharma07]

@sandeepshahi @sahil-ondc We generated a new PR for RET:16 logs, Please preview them as well

[sahil-ondc]

Flow 1

on_search (full_catalog)

• short_desc and long_desc should be provided as will be provided in production and should not be same (provided: 'Krenai BPP')
• Self-Pickup is not provided in /message/catalog/bpp/providers/fulfillments then why its timing is provided in /message/catalog/bpp/providers/tags
• short_desc and long_desc should not be provided with placeholder values
• incorrect mapping of day_from and day_to with /message/catalog/bpp/providers/locations/time/days
• Placeholders should not be provided in /categories/descriptor/name
• invalid mapping of time_from and time_to with /message/catalog/bpp/providers/locations/frequency (0000 to 2359 is mentioned in tags, PT4H and 1200 is provided in locations)

Flow 2

on_init

• @ondc/org/settlement_basis, @ondc/org/settlement_window and @ondc/org/withholding_amount should not be provided

on_confirm

• invalid parameter settlement_timestamp

on_status

• pickup time range and delivery time range should remain same as provided in on_confirm

Flow 4

on_cancel

• pickup time range and delivery time range should remain same as provided in on_confirm
• /message/order/fulfillment/precancel_state updated_at is not mapped correctly

Flow 5

on_cancel (rto)

• fulfillment_state and updated_at provided in precancel_state is not correct
• /message/order/fulfillment/start location should be provided

on_status (rto-disposed)

• same issues as above
• /message/order/fulfillment/end location should be provided

Flow 6

• same issues as flow 2 and flow 5

@AnchalSharma07

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR . Please review them @sandeepshahi @sahil-ondc

[NishthaMonga]

Flow 2, Flow 3

on_select

• Warning: Quoted Price in /on_select INR 406 does not match with the total price of items in /select INR 166 i.e price for the item mismatch in on_search and on_select

on_confirm

• /message/order/tags/1/list/0/value Value for tax_number must be a valid tax number i.e alphanumeric with 15 characters
• List of bpp_terms mismatched in message/order/tags/bpp_terms for on_init and on_confirm
• bap_terms terms is not required for now! in on_confirm

on_status_delivered

• Message id should not be same with previous calls
• order/state should be \"Completed\" for /on_status_delivered
• fulfillments/state should be Order-delivered for /on_status_Order-delivered

Flow 5

on_cancel

• /message/order/fulfillments/1/start/location must have required property 'id'
• /message/order/fulfillments/1/start/location must have required property 'descriptor'
• RTO fulfillment end object is missing in on_cancel
• RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel

Flow 6A

on_update

• initiated_by should be storepreprod.krenai.in

@AnchalSharma07

[AnchalSharma07]

@NishthaMonga @sandeepshahi @sahil-ondc We are unable to identify the issues mentioned in on_select (quote price) and on_confirm(tax_number). Could you please help us with this

[NishthaMonga]

on_select (quote price)

This item_id 4ca77026 is not present on_search

on_confirm(tax_number)

Provider tax number is incorrect

@AnchalSharma07

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR. Please review them @sahil-ondc @sandeepshahi @NishthaMonga

[sahil-ondc]

Flow 1

on_search (full_catalog)

• code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code (Grocery)

Flow 2

on_init

• np_type should be provided in /message/order/tags/bpp_terms

Flow 4

on_cancel

• /message/order/fulfillment/tags/precancel_state is not captured correctly

Flow 5

on_cancel (rto)

• /message/order/fulfillment/tags/precancel_state is not captured correctly

on_status (rto-disposed)

• /message/order/fulfillment/tags/precancel_state is not captured correctly

Flow 6

on_update (part-cancellation) (return)

• cancelled_items is not mapped correctly

@AnchalSharma07

[AnchalSharma07]

1. on_search (full_catalog) -> EAN is mandatory for grocery products ? As it is not mentioned in the doc we are sending "other" code if any of the ean,sku , hsn is not available
2. Flow 2 -> on_init -> np_type is required -> We are unable to find it in the doc
3. precancel_state is not captured correctly -> we have matched it the the doc , but we are unable to find any discrepancy . 4. Flow 6: the 'cancelled_items' are not mapped correctly. We have submitted similar data in our previous log entries but did not encounter this error before. Could you please provide more detailed feedback? This will help us understand the issue better and address it effectively. @sahil-ondc @sahil-ondc

[sahil-ondc]

• EAN should be provided in case of branded items.

• its optional, but its better to provide np_type so that buyer applications can handle accordingly.

• precancel_state updated_at should be the value when your order is last updated before cancellation.

• items which you have cancelled should have quantity zero ('0') in the items array, but that is missing.

@AnchalSharma07

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR Please review them @sahil-ondc @sandeepshahi

[sahil-ondc]

Flow 1

on_search (full_catalog)

• EAN number mentioned on the product image, and provided in /message/catalog/bpp/providers/items/descriptor/code should be same (catalog provided should be subset of production catalog)
• item's unitized measure should be as per description (PARACHCHTE HOT OIL 90ML should have unitized measure accordingly not unit 1)
• is only (Masala & Seasoning) category supported ?
• Lahori zeera should fall under category: Energy and Soft Drinks. isn't ? (if yes, categories should be mapped correctly)

on_search (inc_catalog)

• instead of description changes, any major change like quantity or price changes should be provided

Flow 2

on_confirm

• Additional information in /message/order/provider/locations should not be provided

on_status

• is Agent-assigned fulfillment state supported ?
• settlement_timestamp should be provided only when settlement is confirmed
• routing and tracking information should be provided at fulfillment level

on_track

• tracking information should be provided, when order is picked up (currently on_track gps co-ordinates are matching with start location)

Flow 3

• same as flow 2

Flow 4

on_cancel

• Additional information in /message/order/provider/locations should not be provided (Kindly follow API contract)

Flow 5

on_cancel (rto)

• @ondc/org/item_quantity/count should be zero in case of cancelled items

Flow 6

• same as flow 2

@AnchalSharma07

[AnchalSharma07]

Hyy Team We have submitted the updated logs last week. Please review them and provide the feedbacks at your earliest convenience. @sandeepshahi @sahil-ondc

[sahil-ondc]

Flow 1

on_search (full catalog)

• /message/catalog/bpp/providers/items must have required property '@ondc/org/return_window'
• code should provided in /message/catalog/bpp/providers[0]/items[6]/descriptor/code should be number and have a between length 8 to 13
• in ONDC:RET10 @ondc/org/statutory_reqs_prepackaged_food following fields are valid and required 'nutritional_info', 'additives_info','other_FSSAI_license_no', 'brand_owner_FSSAI_license_no', 'importer_FSSAI_license_no'
• invalid category provided in /message/catalog/bpp/providers/tags/serviceability https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

on_search (inc catalog)

• /message/catalog/bpp/providers/items must have required property '@ondc/org/return_window'
• is quantity changes supported ?

Flow 2

on_select

• is fulfillment_id static, its been same from last 2 months (717)

Flow 3

on_cancel

• why Delivery Charges, Convenience Fee are not refunded even if fulfillment-state is Pending

Flow 6

on_update (part-cancellation)

• invalid reason_id provided 'One or more items in the Order not available'
• cancelled items are not mapped correctly, cancelled product (id:16050842) should remain in /quote/breakup

on_status (delivered)

• @ondc/org/settlement_details should have all the properties provided in /update refund settlement request (settlement_timestamp)

on_update (interim)

• /message/order/fulfillment/717-Return-273/return_request should be as per API contract

on_update (return initiated)

• @ondc/org/settlement_details should have all the properties provided in /update refund settlement request (settlement_timestamp)

@AnchalSharma07

[AnchalSharma07]

Flow 1 : on_search-> invalid category provided in /message/catalog/bpp/providers/tags/serviceability We are sending it as per API contact V1.2 and the values exist in updated sub-category sheet. Could you please help us to identify the issue. @sahil-ondc @sandeepshahi

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR Please review them. @sahil-ondc @sandeepshahi

[sahil-ondc]

Flow 1

on_search

• Timestamp for item[0] can't be greater than context.timestamp
• /'@ondc/org/statutory_reqs_prepackaged_food'/other_FSSAI_license_no and '@ondc/org/statutory_reqs_prepackaged_food'/importer_FSSAI_license_no4 is missing in bpp/providers/items[1].

Flow 2

on_select

• Quoted Price in /on_select INR 340 does not match with the total price of items in /select INR 300 i.e price for the item mismatch in on_search and on_select. The price was changed for the item_id : '4ca77026' from 30 to 50

on_init

• Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. Incase seller wants to collect the payment then you can send it the way you sent.

on_status_delivered

• The timestamp for delivery is not in the range of timestamps provided in end object of 'Delivery' fulfillment

on_confirm

• order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added

Flow 2 errors are processed in other flows as well

Flow 4

on_cancel

• precancel_state.updated_at of on_cancel is not equal with the on_confirm order.updated_at

Flow 6

on_update_part_cancel

• Fulfillment Tracking mismatch with the on_select call

on_update_iterim_reverse_qc

• Mismatch occur between the fulfillment Id of on_update_interim_reverse_qc 717_cdd16d00-1181-4122-b6cc-7bdfc26dbdcf-Return-276 and fulfillment Id of update_reverse_qc 6674000cac1a33e3cbef5f97 for Return fulfillment for Return fulfillment
• start and end object is not required in the 'Return' fulfillment, Is it manually added as the ranges are same for both of them ?

on_update_delivered

• The timestamp for delivered is not in the range of timestamps provided in end object of 'Return' fulfillment

on_update_iterim_liquidated

• Mismatch occur between the fulfillment Id of on_update_interim_liquidated 717_cdd16d00-1181-4122-b6cc-7bdfc26dbdcf-Return-275 and fulfillment Id of update_liquidated 6673ff03ac1a33e3cbef5d22 for Return fulfillment
• start and end object is not required in the 'Return' fulfillment, Is it manually added as the ranges are same for both of them ?

@AnchalSharma07

[AnchalSharma07]

1. /'@ondc/org/statutory_reqs_prepackaged_food'/other_FSSAI_license_no and '@ondc/org/statutory_reqs_prepackaged_food'/importer_FSSAI_license_no4 is missing in bpp/providers/items[1] REMARK : As concluded in our previous conversion , not all 4 FSSAI licenses are mandatory.
2. Quoted Price in /on_select INR 340 does not match with the total price of items in /select INR 300 i.e price for the item mismatch in on_search and on_select. The price was changed for the item_id : '4ca77026' from 30 to 50 REASON: Price updated in incremnetal_on_search
3. Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. Incase seller wants to collect the payment then you can send it the way you sent. REMARK : Unable to understand this , please help us with this . We are sending the following object : "payment": { "@ondc/org/buyer_app_finder_fee_type": "percent", "@ondc/org/buyer_app_finder_fee_amount": "3.0", "@ondc/org/settlement_details": [ { "settlement_counterparty": "seller-app", "settlement_phase": "sale-amount", "settlement_type": "upi", "settlement_bank_account_no": "33610759357", "settlement_ifsc_code": "SBIN0000567", "beneficiary_name": "Pradeep Yadav", "bank_name": "State Bank Of India", "branch_name": "Badshahpur", "upi_address": "7053708236@paytm" } ] }

Could you please help us to identify the issue @sahil-ondc @sandeepshahi

[BLR-0118]

ref 3 above:

• for settlement_type "upi", following reqd: upi_address;
• for settlement_type "neft", following reqd: settlement_bank_account_no, settlement_ifsc_code, beneficiary_name, bank_name, branch_name
• @AnchalSharma07

[AnchalSharma07]

We have updated the logs as per feedbacks & have generated a new PR . Please review them @sahil-ondc @sandeepshahi

[sahil-ondc]

Krenai RET:10

Flow 1

On Search

• ttl should be PT30S as per the API Contract
• category_id ‘Cleaning & Household’ is replaced by ‘Detergents and Dishwash’
• "other_FSSAI_license_no" and “importer_FSSAI_license_no” is missing for the item_id : ‘88549691’
• For the item_id : ‘6e170175’ unitized/measure/unit. should be a whole number not in decimal format

On Search Inc

• ttl should be PT30S as per the API Contract

Flow 2

Init

• In item[0], location_id is not required as per the API Contract
• In fulfillments, the contact/email is optional in nature

On Init

• In fulfillments, the contact/email is optional in nature
• /message/order/payment/@ondc/org/settlement_details/0 must have required property 'settlement_type

Confirm

• /message/order/payment/@ondc/org/settlement_details/0 must have required property 'settlement_type'

On Confirm

• person/name is not required in the start object of fulfillments
• /message/order/payment/@ondc/org/settlement_details/0 must have required property 'settlement_type'
• order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)

On Status Pending

• For Delivery fulfillment, In the start object, range can’t be past dated from the context.timestamp

On Status Picked

• For Delivery fulfillment, In the start object, the timestamp is not in the range provided
• Invoice is not publically accessible

On Status Delivered

• How the delivery can be done in less than 30sec ?
• The range provided for time_to_ship is not as per the on_search for the given item

Flow 3, 4, 5

• Same as flow 2

Flow 6

• Same as flow 2

On Update Part Cancel

• /message/order/payment/@ondc/org/settlement_details/0 must have required property 'settlement_type'

On Update Liquidated

• return fullfillment id is not created in the on_update_liquidated

On Update Picked

• return fullfillment id is not created in the on_update_picked
• For Return fulfillment, In the start object, the timestamp is not in the range provided for the pickup

On Update Delivered

• For Return fulfillment, In the end object, the timestamp is not in the range provided

@AnchalSharma07

[AnchalSharma07]

1. on_search -> ttl should be PT30S as per the API Contract REMARK : ttl has been removed from on_search api context. Reference attached below.
2. on_search-> "other_FSSAI_license_no" and “importer_FSSAI_license_no” is missing for the item_id : ‘88549691’ REMARK : As discussed in our pervious conversions(over the mail) Only one of the fssai licence number is required. If this product falls under special case please help us to understand this.
3. init -> In item[0], location_id is not required as per the API Contract REMARK: Buyer app responsible for this if any thing changes in init API
4. For Delivery fulfillment, In the start object, range can’t be past dated from the context.timestamp REMARK: AS per our previous discussion estimated pickup/delivery timings should not change thats why we allocate a time range when order is placed and we are using it throughout the order journey.
5. On Status Delivered -> How the delivery can be done in less than 30sec ? REMARK: Since these are testing orders, we're updating statuses quickly, causing inconsistencies in delivery times.
6. The range provided for time_to_ship is not as per the on_search for the given item REMARK: same as above
7. On Update Liquidated-> return fullfillment id is not created in the on_update_liquidated REMARK:We are using the same id that received in the update API. Is this incorrect ?

@sandeepshahi @sahil-ondc Seeking your guidance to understand & conclude the above mentioned pointers. TTL reference :

Reference for FSSAI licence number :

Reference for fulfillment time range :

[sandeepshahi]

Flow 1

/on_search

• quantity/unitized/measure/unit can't change for variants; How can unit be dozen and grams for the same variant group?
• unicode literal should not be provided in the payload; eg: "\n"

Flow 2

/on_confirm

• how can estimated time ranges be provided even before the order is accepted?
• estimated time ranges should not be earlier than context/timestamp; check fulfillments/start/time/range/start

/on_status

• settlement_amount in "@ondc/org/settlement_details" should only be provided once the amount is settled by the collector
• "@ondc/org/settlement_basis", "@ondc/org/settlement_window", "@ondc/org/withholding_amount" are provided by the collector

Flow 4

/on_cancel

• value of "tracking" attribute should not change
• "updated_at" in "precancel_state" is not captured correctly
• ttl in quote/breakup should not change

Flow 5

/on_cancel

• RTO initiation timestamp /fulfillments/start/time/timestamp can't be future dated
• ttl in quote/breakup should not change
• "@ondc/org/item_quantity" count in quote/breakup should be 0 when item is cancelled

Flow 6

/on_update (part cancel)

• How can item be cancelled even before the order is accepted?

/on_update (Return)

• return_request tag group should remain the same as received in /update; check the missing code and values
• Liquidated:
  • invalid start and end info in "Return" fulfillment
  • liquidated item mapped with forward shipment should also be present in /items with count=0; audit trail must be maintained
• Approved:
  • estimated return pickup/delivery ranges should be calculated correctly; can't have same values
• Picked:
  • Returned mapped with forward shipment should also be present in /items and quote/breakup with remaining quantity (count=0 here); audit trail must be maintained

@AnchalSharma07

[sandeepshahi]

Flow 1

/on_search

• both the protocol key mappings "@ondc/org/statutory_reqs_prepackaged_food" and "@ondc/org/statutory_reqs_packaged_commodities" must be provided for the relevant category; eg: "Chocolates and Biscuits"
• quantity/unitized/measure should be correct and should be the same as mentioned in the description; eg- check for item: 22563112 (100 gram vs 100 unit)

/on_search (inc)

• context/timestamp can't be earlier than /search
• are all the scenarios of incremental search supported (as mentioned in the contract)?

Flow 2

/on_select

• isn't delivery TAT (@ondc/org/TAT) calculated dynamically?

/on_confirm

• from where is the info /fulfillments/end/contact/email being captured; it wasn't provided in /confirm

/on_status

• estimated time ranges should not be earlier than context/timestamp; check fulfillments/start/time/range/start
• convenience fee is not captured correctly in the invoice

Flow 4

/on_cancel

• tracking is not a valid attribute for cancelled fulfillment: 717_16f29648-9960-4fb9-b7b5-ce31d7ca2490-Cancel
• order/updated_at is not captured correctly; can't be earlier than /on_confirm timestamp

Flow 5

/on_status (RTO-disposed)

• RTO Initiation timestamp should not change; must remain the same as in /on_cancel (RTO)

Flow 6

/on_update (Return)

• Approved:
  • estimated return pickup/delivery ranges should be calculated correctly; can't have same values
• Picked:
  • estimated return time ranges should not change

The timestamp-related issues still persist. Please resolve all issues and address the mentioned queries. Once completed, do mention it on the issue board. No need to resubmit the logs.

[sandeepshahi]

@AnchalSharma07

[AnchalSharma07]

@sandeepshahi We have addressed the issues mentioned. Please find our response below :

Request | Issue | Remark -- | -- | -- /on_search | both the protocol key mappings "@ondc/org/statutory_reqs_prepackaged_food" and "@ondc/org/statutory_reqs_packaged_commodities" must be provided for the relevant category; eg: "Chocolates and Biscuits" | We missed the update in category taxonomy1.2 . Now we have added the multiple protocol keys for the categories. /on_search | quantity/unitized/measure should be correct and should be the same as mentioned in the description; eg- check for item: 22563112 (100 gram vs 100 unit) | It was an issue while saving product from our seller panel. We have identified & fixed it. /on_search_inc | context/timestamp can't be earlier than /search | It was caused due to multithreading.We have identified & fixed it. /on_search_inc | are all the scenarios of incremental search supported (as mentioned in the contract)? | Yes all of them are covered. /on_select | isn't delivery TAT (@ondc/org/TAT) calculated dynamically? | It is being calculated dynamically. Since the seller do off network manual delivery , so he provides us with his average delivery time. /on_confirm | from where is the info /fulfillments/end/contact/email being captured; it wasn't provided in /confirm | It was missing in our request entity which receives the /confirm. We have added it now. /on_status | estimated time ranges should not be earlier than context/timestamp; check fulfillments/start/time/range/start | It was caused due to multithreading.We have identified & fixed it. /on_status | convenience fee is not captured correctly in the invoice | It was round off to show integer value only. Now we have updated the value with two decimal points. /on_cancel | tracking is not a valid attribute for cancelled fulfillment: 717_16f29648-9960-4fb9-b7b5-ce31d7ca2490-Cancel | It was going null in all of our cancelation sections. We have removed this value , for the case when it will be null. /on_cancel | RTO initiation timestamp /fulfillments/start/time/timestamp can't be future dated | It was caused due to multithreading.We have identified & fixed it. Approved | estimated return pickup/delivery ranges should be calculated correctly; can't have same values | We were updating the dates after sending the response. It is fixed now. Picked | estimated return time ranges should not change | We were updating the dates after sending the response. It is fixed now.

[sandeepshahi]

@AnchalSharma07, logs are fine. Please complete the pending submissions on NP portal for QA movement.