sahil-ondc commented 6 months ago

Flow 1

on_search_full_catalog_refresh

Invalid category ID found for item for on_search: /message/catalog/bpp/providers/0/items/0/category_id; i.e deprecated category_id is used.
STD code does not match with correct area_code on /on_search

Flow 2

on_select

/fulfillments/@ondc/org/TAT (O2D) in /on_select can't be less than @ondc/org/time_ship (O2S) in /on_search

on_confirm

np_type is missing in message/order/tags/bpp_terms

on_status

Context timestamp for /on_status_picked should be equal to order.created_at
Missing required data of : on_status_packed

Flow3

on_select_out_of_stock

items with same item_id cant be selected twice and if both items only have same 1 availability there cant be 2 orders placed. = Invalid item 65dc70fe57ba70878f59fed2 present in in [{"item_id":"65dc70fe57ba70878f59fecc","error":"40002"},{"item_id":"65dc70fe57ba70878f59fed2","error":"40002"}]

select

Transaction Id should be different for flow 3 from /select_out_of_stock onwards

Flow4

on_cancel

cancelled_by entity should be same as context/bap_id
order.created_at timestamp should match context.timestamp

Flow5

on_cancel

RTO object is mandatory for on_cancel
order.created_at timestamp should match context.timestamp
RTO Id is mandatory field for on_cancel

sandeepshahi commented 6 months ago

@aatif24

sahil-ondc commented 5 months ago

Flow 1

on_search (full catalog)

/message/catalog/bpp/providers/locations/time/schedule/frequency must be string
either one of frequency or range should be provided for timing
/message/catalog/bpp/providers/locations/time/schedule/times must NOT have fewer than 1 items
'accept_bap_terms' and 'collect_payment' should not be provided as these are not enabled yet
invalid attribute '_id' provided in /message/catalog/bpp/providers/locations/circle
/message/catalog/bpp/providers/items/descriptor/code item/descriptor/code should be in this format - 'type:code' where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
/message/catalog/bpp/providers/items/tags should have mandatory attributes as per the sheet https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=983332432
store enable/disable timestamp (bpp/providers/time/timestamp) should be less then or equal to context.timestamp
invalid attribute '_id' provided in /message/catalog/bpp/providers/items

search (inc catalog)

context/city should be '*'

on_search (full catalog)

context/city should be '*'
provider id: 660416787fbbdb1492114977 in bpp/providers didn't matched for providers id of /on_search (full catalog)

Flow 2

init

cityId/$oid should not be provided in context

on_init

only tax_number, 'provider_tax_number', and 'np_type' should be provided in bpp_terms

on_confirm

'cancellation_terms' in /message/order should not be provided as those are not enabled yet
'accept_bap_terms' should not be provided in /message/order/tags/bpp_terms
'np_type' should be provided in /message/order/tags/bpp_terms

on_status (pending)

/message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)
context/timestamp for /on_confirm api cannot be greater than or equal to /on_status (pending) api
order.updated_at timestamp should be less than or eqaul to context timestamp for /on_status (pending) api

on_status (packed)

same as above

on_status (picked)

same as above
context/timestamp in previous /on_status api cannot be greater than or equal to /on_status (picked) api
pickup timestamp should be equal or less than context/timestamp and can't be future dated

on_status (out-for-delivery)

same as above

on_status (delivered)

same as above
delivery timestamp should be less than or equal to context/timestamp and can't be future dated as this on_status is sent after the the product is delivered; as delivery timestamp is 2024-04-12T14:07:52.860Z and context timestamp is 2024-04-12T13:41:08.624Z

Flow 3

Same as flow 2

on_select (out-of-stock)

in error/message item_id: 65e1a4c6649f4aa1eec4ae74 is provided as out-of-stock, but quote is provided as item is in stock

Flow 4

Same as flow 2

on_cancel

/message/order/fulfillment/tags/precancel_state/updated_at is not captured correctly as per last call context/timestamp
invalid context/timestamp, how its matching /confirm context/timestamp

Flow 5

Same as flow 2

Flow 6

on_status

@ondc/org/settlement_details should get populated with the refund settlement details of part-cancellation

Note

context/timestamps are not captured correctly in every api call

@aatif24

sahil-ondc commented 4 months ago

RET 13

Flow 1

on_search (full_catalog)

Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
remove formatting from /message/catalog/bpp/providers[0]/items/descriptor/long_desc

on_search (inc_catalog)

Similar Item as in /on_search api call, item id- 65e1a4c6649f4aa1eec4ae7a (item should only be provided when there is some change in delta)

Flow 2

on_init

in case of MSN, tax_number and provider_tax_number should be of different entity

on_confirm

/message/order/tags/bpp_terms must have property provider_tax_number

on_status (packed)

/message/order/documents should be provided as empty array

on_status (picked)

/message/order/documents/url should be publically accessible

on_status

/context/message_id should be unique in every unsolicited request

Flow 3, 4

same as above

Flow 5

on_cancel

RTO Delivered or Disposed missing

Flow 6

/update refund settlement request missing

@aatif24

aatif24 commented 4 months ago

on_status (packed)

/message/order/documents should be provided as empty array - It is already an empty array

on_status (picked)

/message/order/documents/url should be publically accessible - The link will be publicly accessible in prod. We will put in a static public link for now. Hope that's okay?

@sahil-ondc

sahil-ondc commented 4 months ago

RET 13

Flow 1

on_search (full_catalog)

Correct item descriptor code for branded items (EAN for BPC)
in case of same timing (start_time and end_time) multiple timing should not be provided use 'All'
/message/catalog/bpp/providers/items/quantity available and maximum should be provided (99,0)

Flow 2

on_select

/message/order/quote/breakup/item quantity should be provided with same logic as provided in on_search

on_init

In case of MSN tax_number and provider_tax_number should be different

on_status

/message/order/documents/url should be publically accessible in pre-prod environment as well

@aatif24

NishthaMonga commented 4 months ago

Flow 2

on_confirm

Pan_id shouldn't be same in tax_number and provider_tax_number in message.order.tags[0].list

Flow 3

on_select_out_of_stock

65e1a4c6649f4aa1eec4ae8b Id should be present in error message as the count is reduced in on_select_out_of_stock

Flow 5

on_cancel

/message/order/fulfillments/1/start/location must have required property 'id'
/message/order/fulfillments/1/start/location must have required property 'descriptor'
/message/order/fulfillments/1/end must have required property 'time'
/message/order/fulfillments/1/end must have required property 'person'
/message/order/fulfillments/1/end must have required property 'contact'
/message/order/fulfillments/1/end/location/address must have required properties name , building , country
Message id should not be same with previous calls

@aatif24

Jagannath-wits commented 4 months ago

Instastack: RET:13

Flow 1

Schema Error 0: /message/catalog/bpp~1fulfillments/2/type - must be equal to one of the allowed values (Delivery, Self-Pickup)

For other flows the errors are same as Ret10

@aatif24

Jagannath-wits commented 4 months ago

Instastack : RET: 13

Flow1

on_search_full_catalog_refresh

schemaErr0: /message/catalog/bpp~1providers/0/items/7/quantity/available/count available count must be either 99 or 0 only

Flow3

on_select_out_of_stock

msg/err/items_id0: Item isn't reduced 65e1a4c6649f4aa1eec4ae7e in [{\"item_id\":\"65e1a4c6649f4aa1eec4ae7e\",\"error\":\"40002\"}] is not present in fullfillments/items
brkcnt0: Available count can't be less than @ondc/org/item_quantity.count

Flow5

on_cancel

schemaErr0: /message/order/fulfillments/1/end must have required property 'time'

Flow6

on_status_packed

message/order.fulfillments/0: Mismatch occured while comparing 'Cancel' fulfillment object with on_update_part_cancel

on_status_picked

missingRouting/Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_picked
message/order.fulfillments/0: Mismatch occured while comparing 'Cancel' fulfillment object with on_update_part_cancel

on_status_out_for_delivery

missingRouting/Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_out_for_delivery
message/order.fulfillments/0: Mismatch occured while comparing 'Cancel' fulfillment object with on_update_part_cancel

on_status_delivered

Same as above

on_update_interim_reverse_qc

schemaErr0: /message/order/payment/@ondc~1org~1settlement_details/1/settlement_type must be equal to one of the allowed values (upi,neft,rtgs)
message/order/fulfillments2/tags0: on_update_interim_reverse_qc must have initiated_by code in fulfillments/tags/list

on_update_approval

Same as above

on_update_picked

Same as above

on_update_delivered

Same as above

on_update_interim_liquidated

Same as above

on_update_liquidated

Same as above

@aatif24 Please fix the above mentioned errors before reiteration.

Jagannath-wits commented 4 months ago

Flow 1

On Search Full Catalog Refresh

Categories must be present in bpp/providers to check for support for variants,custom_group,etc (Important).

Flow 2

sending on_status (Accepted) call is optional if the order is auto accepted in /on_confirm

Flow 5

On Status

on_status_rto_delivered or on_status_rto_disposed must be provided in the flow 5 after on_cancel_rto_intiated and not on_cancel_rto_deliveredoron_cancel_rto_disposed.

Flow 6

On Status Pending

Transaction Id should be the same from /select onwards.
Order id in /confirm and /on_status_pending do not match.
Start time "2024-05-14T11:33:17.181Z" of on_confirm mismatched with start time "2024-05-14T10:17:43.329Z" of on_status_pending for Delivery fulfillment.
End time "2024-05-14T12:03:17.181Z" of on_confirm mismatched with end time "2024-05-14T10:47:43.329Z" of on_status_pending for Delivery fulfillment.
End range start time "2024-05-14T12:03:17.181Z" of on_confirm mismatched with end range start time "2024-05-14T10:47:43.329Z" of on_status_pending for Delivery fulfillment.
End range end time "2024-05-14T12:33:17.181Z" of on_confirm mismatched with end range end time "2024-05-14T11:17:43.329Z" of on_status_pending for Delivery fulfillment.
Created At timestamp for /on_status_pending should be equal to context timestamp at confirm.
Timestamp for /on_confirm API cannot be greater than or equal to /on_status_pending API.

On Status Packed

Message/Order.Fulfillments/1/Start

Mismatch occurred while comparing 'Delivery' fulfillment object with on_status_pending on key 'start' time/range.

Message/Order.Fulfillments/1/End

Mismatch occurred while comparing 'Delivery' fulfillment object with on_status_pending on key 'end' time/range.

On Status Picked

Same as above

On Status Out For Delivery

Same as above

On Status Delivered

Same as above

@aatif24

sahil-ondc commented 3 months ago

Flow 1

on_search (full catalog)

context/timestamp for /search api cannot be equal to /on_search api (provided: '2024-05-21T18:00:01.978Z')
area_code should be provided on the basis of provided GPS (lat & long: 19.129076,72.825803, and gps: 400093)
fulfillment_types provided in bpp/fulfillments should be exactly mapped to fulfillments
additional properties 'code' should not be provided in /message/catalog/bpp/providers/descriptor

Other flows

select

latest select call not provided

on_select onwards

context/timestamp should be same with /select call

on_confirm

duplicate tax_number and provider_tax_number should not be provided
range is not provided as per the TAT provided in on_select

on_status (picked)

correct invoice should be provided (not placeholder)
tracking url should not be placeholder

@aatif24

Jagannath-wits commented 3 months ago

Flow 1

on_search_full_catalog_refresh

Why is self-pickup in fulfillments when provider does not supports self-pickup?

fulfillments: "self pickup option not provided in bpp/providers/fulfillments; if it's not supported, it should not be present in /bpp/fulfillments"
invldAreaCode: "STD code does not match with correct area_code on /on_search, area_code:302018 is mapped with std_code:0141"

Flow 2

on_status_picked

invoice: "Invoice is incorrect, kindly provide the invoice with the proper items and total price”
tracking_url: tracking url cant be an image, please provide actual tracking url
Flow 5

on_cancel

txnId: "Transaction Id should be same from /select onwards"

Flow 6

on_status_picked

invoice: "Invoice is incorrect, kindly provide the invoice with the proper items and total price and it should update after part_cancel"

@aatif24

Please note that some errors are either repeating or new errors which were not there previously are there in current iteration

sahil-ondc commented 2 months ago

Flow 1

on_search

For the @ondc/org/statutory_reqs_packaged_commodities, there are only four fields supported as per the contract but you have provided more than that. Kindly refer to the API contract
STD code does not match with correct area_code on /on_search, area_code:302018 is mapped with std_code:0141

on_search_inc

Message id should not be same with previous calls as it's incremental push based call

Other flows

select

City code mismatch in /on_search_full_catalog_refresh and /select and it's processed in other calls as well

on_init

Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. Incase seller wants to collect the payment then you can send it the way you sent

on_status_picked

Invoice should be publically accessible
tracking_url is not accessible

on_status_delivered

The timestamp for Delivery fulfillment is not in the given range provided for end object

Flow 6

on_update_picked

The timestamp provided for picked for Return fulfillment_id '6677f656b5a8661461300fbd' is not in the given range provided in on_update_approval

@aatif24

aatif24 commented 1 month ago

Flow 1

on_search

STD code does not match with correct area_code on /on_search, area_code:302018 is mapped with std_code:0141 This is accurate mapping. pincode 302018 does belong to std code 0141. What is the issue here? Other flows

select

City code mismatch in /on_search_full_catalog_refresh and /select and it's processed in other calls as well Same as above

on_init

Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. Incase seller wants to collect the payment then you can send it the way you sent We are only sending the above mentioned attributes. What is the issue here?

on_status_picked

Invoice should be publically accessible - It is publicly accessible tracking_url is not accessible - It is publicly accessible

cc @sahil-ondc

sahil-ondc commented 1 month ago

ACK for all above points, please ignore these issues and proceed for other fixes and log submission.

@aatif24

sahil-ondc commented 1 month ago

Flow 2, 3

on_select

/fulfillments/@ondc/org/TAT (O2D) in /on_select can't be less than @ondc/org/time_ship (O2S) in /on_search

on_status

fulfillment/state 'Agent-Assigned' should be provided
as per provided start and end location, routing can't be P2P
tracking url seems incorrect

on_track

if GPS was sent no in on_status, tracking url should be sent in on_track

Flow 4

Why only Flow 4 has been submitted with RET10 Grocery having BPC items ?

Flow 5

same as Flow 2

on_status

invalid invoice date provided in invoice url: 2024-46-29

on_cancel

why default_RTO_1 has been added in quote trail but not in breakup ? or if it's zero no need to mention it anywhere

Flow 6

same as Flow 2

on_status

invalid invoice date provided in invoice url: 2024-46-29

@aatif24

sandeepshahi commented 4 weeks ago

Flow 1

/on_search

callback /on_search shouldn't take this long (> 5 hours) to be responded to
tracking is not a valid attribute in "bpp/providers"
value of "time_to_ship" appears to be invalid; can't be 5 months (P5M)
return/cancellation must be allowed for BPC products
categories/id should be alphanumeric and upto 12 characters

/on_search (inc)

message_id of unsolicited inc call should be unique
context/city should be "*"
timestamp at item, location or provider should be captured correctly; the item level timesamp should be updated if there is any change in the record

Flow 2

/on_status

tracking and routing info should be provided on or before Agent-assigned state
invalid tracking url in /fulfillments/tags/tracking

Flow 3

/select

cart must be continued with the same txn id as in /select (OOS)

Flow 4

/on_cancel

invalid reason code "009"; can't be used for preshipment cancellation

Flow 5

/on_cancel

cancellation reason id mismatch in /cancellation and /fulfillments/tags/cancel_request/reason_id

Flow 6

/on_update (Approved)

estimated return pickup time range can't be earlier; check start/time/range/start

@aatif24

sahil-ondc commented 2 weeks ago

@aatif24, Manual log generation is not allowed as per the compliance, How minutes, seconds are microseconds are same, just date is changes.

https://github.com/ONDC-Official/v1.2.0-logs/commit/3cb97b0f1393dbc67319cebf9a85c43b3dd26697

ONDC-Official / v1.2.0-logs

Instastack (SA: RET13) - compliance check #1096

Flow 1

on_search_full_catalog_refresh

Flow 2

on_select

on_confirm

on_status

Flow3

on_select_out_of_stock

select

Flow4

on_cancel

Flow5

on_cancel

Flow 1

on_search (full catalog)

search (inc catalog)

on_search (full catalog)

Flow 2

init

on_init

on_confirm

on_status (pending)

on_status (packed)

on_status (picked)

on_status (out-for-delivery)

on_status (delivered)

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

Flow 5

Flow 6

on_status

Note

RET 13

Flow 1

on_search (full_catalog)

on_search (inc_catalog)

Flow 2

on_init

on_confirm

on_status (packed)

on_status (picked)

on_status

Flow 3, 4

Flow 5

on_cancel

Flow 6

on_status (packed)

on_status (picked)

RET 13

Flow 1

on_search (full_catalog)

Flow 2

on_select

on_init

on_status

Flow 2

on_confirm

Flow 3

on_select_out_of_stock

Flow 5

on_cancel

Instastack: RET:13

Flow 1

For other flows the errors are same as Ret10

Instastack : RET: 13

Flow1

on_search_full_catalog_refresh

Flow3

on_select_out_of_stock

Flow5

on_cancel

Flow6

on_status_packed

on_status_picked

on_status_out_for_delivery

on_status_delivered