Thrive (Seller App - RET11 ) - Compliance Check

[Jagannath-wits]

Flow 1

on_search_full_catalog_refresh

• schemaErr: /message/catalog/bpp~providers/categories/ must have required property 'parent_category_id'
• bpp/providers/categories/descriptor: Images should not be provided as empty array for categories/descriptor
• prvdritemctgryId: item0-15 should have category_ids one of the Catalog/categories/id
• prvdr1item0tag0cstmgrp_id-15: item_id: 319590-468815 should have custom_group_id one of the ids passed in categories bpp/providers[1]
• bpp/providers/items/descriptor: short_desc and long_desc should not be provided as empty string “” and also avoid using placeholder values like ’test category 1002'

search_inc_refresh

• Missing required data of : search_inc_refresh and inc_on_search

Flow 2

on_init

• schemaErr0-1: /message/order must NOT have additional properties (provider_location, cancellation_terms)
• quoteErr: Mismatch found for items with item_id, 468815 while comparing quote object of on_select and on_init as extra tags provided in item 468815 for custom_groups

Confirm

• schemaErr0: /message/order/id Should be alphanumeric upto 32 letters max
• txnId: Transaction Id should be same from /select onwards
• billingErr0: Key 'address.building' mismatch: TTTTT !== TTT when compared with init billing object
• billingErr1: Key 'created_at' mismatch: 2024-01-31T06:15:09.140Z !== 2024-01-31T06:52:53.414Z when compared with init billing object
• billingErr2: Key 'updated_at' mismatch: 2024-01-31T06:15:09.140Z !== 2024-01-31T06:52:53.414Z when compared with init billing object
• quoteErr : same as above
• bapGstTags: Tags/bap_terms should have valid gst number and fields in /confirm

On Confirm

• schemaErr0: /message/order/id Should be alphanumeric upto 32 letters max
• txnId: Transaction Id should be same from /select onwards
• crtdtmstmp: order.created_at timestamp mismatches in /confirm and /on_confirm
• updtdtmstmp: order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
• invldUpdtdTmstp: updated_at timestamp should be equal to context timestamp for /on_confirm
• billingErr0: Key 'address.building' mismatch: TTTTT !== TTT when compared with init billing object
• billingErr1: Key 'created_at' mismatch: 2024-01-31T06:15:09.140Z !== 2024-01-31T06:52:53.414Z when compared with init billing object
• billingErr2: Key 'updated_at' mismatch: 2024-01-31T06:15:09.140Z !== 2024-01-31T06:52:53.414Z when compared with init billing object
• sellerNameErr: store name /fulfillments[0]/start/location/descriptor/name can't change
• quoteErr:same as above
• pymntObj: payment object mismatches in /confirm & /on_confirm
• message/order/tags/bpp_terms/np_type: np_type is missing in message/order/tags/bpp_terms for ON_CONFIRM
• tags_bap_terms: Tags should have same and valid gst_number as passed in /confirm

On Status Pending

• schemaErr0: /message/order/id Should be alphanumeric upto 32 letters max
• city: City code mismatch in /search and /on_status
• txnId: Transaction Id should be same from /select onwards
• onStatusOdrId: Order id in /confirm and /on_status_pending do not match
• tmpstmp: Created At timestamp for /on_status_pending should be equal to context timestamp at confirm

On Status Packed

• schemaErr0: /message/order/id Should be alphanumeric upto 32 letters max
• city: City code mismatch in /search and /on_status
• txnId: Transaction Id should be same from /select onwards
• onStatusOdrId: Order id in /confirm and /on_status_packed do not match
• tmpstmp: Created At timestamp for /on_status_packed should be equal to context timestamp at confirm

On Status Picked

• Missing payload

On Status Out For Delivery

• schemaErr0: /message/order/id Should be alphanumeric upto 32 letters max
• city: City code mismatch in /search and /on_status
• txnId: Transaction Id should be same from /select onwards
• onStatusOdrId: Order id in /confirm and /on_status_out-for-delivery do not match
• tmpstmp: Created At timestamp for /on_status_out-for-delivery should be equal to context timestamp at confirm
• out_for_delivery_time: Out_for_delivery timestamp is missing

On Status Delivered

• schemaErr0: /message/order/id Should be alphanumeric upto 32 letters max
• city: City code mismatch in /search and /on_status
• txnId: Transaction Id should be same from /select onwards
• onStatusOdrId: Order id in /confirm and /on_status_delivered do not match
• tmpstmp: Created At timestamp for /on_status_delivered should be equal to context timestamp at confirm
• deliverytime: delivery timestamp is missing

Flow 3

on_select_store_unavailable

• store still serviceable when closed

on_select_out_of_stock

• @ondc/org/item_quantity for item 468815 should be 0 (completely out of stock) or the reduced quantity in stock

  Item isn't reduced 468815 in [{"item_id":"468815","error":"40002"}] is not present in fullfillments/items

  Available count can't be less than @ondc/org/item_quantity.count

Flow 4

cancel

• txnId: Transaction Id should be same from /select onwards

On Cancel

• schemaErr0: /message/order must NOT have additional properties (provider_location)
• schemaErr1: /message/order must NOT have additional properties (tags)
• schemaErr3: /message/order/fulfillments/0/tags/0/code must be equal to one of the allowed values (cancel_request,igm_request,precancel_state,quote_trail)
• schemaErr4: /message/order/fulfillments/0/tags/0/list/0/code must be equal to one of the allowed values (reason_id,initiated_by,fulfillment_state,updated_at,retry_count,rto_id,id,currency,value,type,subtype)
• city: City code mismatch in /search and /on_cancel
• txnId: Transaction Id should be same from /select onwards
• itemCount[0]: Item count should be 0 for /on_cancel in forward shipment
• CancelFulfillmentMissing: Fulfillment type cancel is missing in /on_cancel
• invldCancellationID: Invalid CancellationID 003 or not allowed for SNP
• invalidCancelledByEntity: Cancelled_by entity should be same as context/bap_id
• Fulfillment_mismatch: The count of cancellation fulfillments is not equal to the count of forward fulfillments or invalid fulfillment id.
• orderCrtd: Order.created_at timestamp should match context.timestamp of confirm
• missingCancel: Cancel object is mandatory for on_cancel
• missingCancelRequest: Cancel Request is mandatory for on_cancel in fulfillment type delivery
• missingPreCancel: Pre Cancel is mandatory for on_cancel
• missingReasonID: Reason ID is mandatory field for on_cancel
• missingInitiatedBy: Initiated_by is mandatory field for on_cancel

Flow 5

• on_cancel payload missing

Flow 6-a

On Update

• city: City code mismatch in /search and /on_update
• invldQuotePrices: Item quote breakup prices for /on_update should be equal to the net price.

Update

• update: Missing required data of : update

Flow 6-b(reverse QC) and Flow 6-c(Liquidation)

-Please provide complete logs with proper labels

@AB @sandeepshahi

[amitkbadheka]

Hi @Jagannath-wits , can you explain the difference between picked up and out for delivery?

[Jagannath-Padhy]

Hi @amitkbadheka order-picked up is the terminal state for self-pickup orders; but in case of normal delivery it means the order has been picked up from the seller after agent has been assigned, out for delivery occurs when the order has the left the logistics hub after it has been picked from the seller by agent

[Jagannath-wits]

On Search Full Catalog Refresh

• Schema Error 0: /message/catalog/bpp~1descriptor/tags/0/list/0/value must be equal to one of the allowed values (MSN, ISN); you've used small case instead of capital.
• BPP/Descriptor/Accept BAP Terms: accept_bap_terms is not required in bpp/descriptor/tags.

Flow 4

On Cancel

• Order Created: order.created_at timestamp should match context.timestamp of confirm.

Flow 5

same as above

@amitkbadheka

[amitkbadheka]

checking and updating here

[amitkbadheka]

https://github.com/ONDC-Official/v1.2.0-logs/pull/1341

[sandeepshahi]

Flow 1

/on_search

• context/timestamp can't be the same as in /search
• remove accept_bap_terms block in /bpp/descriptor/tags; should be enabled once BNP send their static terms in /search and are later accepted by SNP
• all the timestamps must be in RFC3339 UTC format; none of the timestamps in /message are in correct format; there must be no offset
• empty values should not be provided in bpp/providers/descriptor;
• np_type should should be MSN (in upper case)
• entire address should not be provided in /locations/address/locality; separate attributes are provided
• empty list of timing block in /categories/tags should not be provided; if custom menu timings are same as store timings, timing block should not be provided
• display rank "0" is not a valid rank; should start from "1"
• "parent_category_id" and "id" in /categories can't have same values; use emtpy string in "parent_category_id" for now
• display sequence of an item in a custom menu must start with seq 1 and not 0; check /items/category_ids[]
• default_selection price and lower/upper range must be provided for customizable items
• tags/type is optional for non-customizable (standalone) SKUs
• customization and custom_group can't have same id
• no need to set a default customization for a custom_group where min selection = 0; eg: for custom group "3478571_3478513", default is set as yes while config/min = 0
• @ondc/org/time_to_ship, "@ondc/org/return_window", "@ondc/org/seller_pickup_return" and "@ondc/org/available_on_cod" are missing in /items;
• Order timings should also be provided in bpp/providers/tags/timing; if the timings are same for all, use the enum "All"; check contract for the details
• Self-Pickup timings are provided in /tags/timing but corresponding fulfillment is not mentioned /fulfillments

/search (inc)

• push based incremental refresh (mode=start) must be supported

/on_search (inc)

• city must be "*" in incremental refresh
• all the scenarios of incremental refresh must be supported (item record changes, store closure etc.)

Flow 2

• order flow for customizable product must be submitted for verification

/on_select

• tags/type should not be provided in quote/breakup for non-customizable product

/on_init

• fulfillments/tags/ need not be provided for seller led delivery
• PAN number of merchant should be provided in bpp_terms/provider_tax_nmber

/on_confirm

• cancellation_terms need not be provided; since it's not provided in /on_init, where is it flowing from?
• why is provider_tax_number removed in /tags/bpp_terms/; trail must be maintained
• TAT must be provided in /fulfillments/@ondc/org/TAT

/on_status

• Pending:

  • why is it called next day from the order confirmation?
  • order must be accepted through on_status; Why is it even called when the order is still in "Created" state?
  • provider_location is not a valid attribute; where is it flowing from? remove from all the APIs
  • payment/ondc_order_id is not a valid attribute
  • incorrect delivery and pickup time ranges provided;
  • order/updated_at timestamp value is incorrect
  • invalid attributes "@ondc/org/settlement_basis", "@ondc/org/settlement_window"; should be sent only when provided by the collector

• Packed:

  • updated at should be corrected in every API; either the issue is in updated_at or context/timestamp;

• Agent-assigned state is missing

• routing and tracking info must be provided (in /fulfillments) on or before Agent-assigned state

• Picked:

  • actual pickup timestamp (/fulfillments/start/time/timestamp) is not captured correctly
  • Invoice must be provided once the order is picked and in subsequent calls
  • why is actual delivery timestamp provided even when the order is still in picked state?
  • rto action should be removed from all the APIs

• Out-for-delivery:

  • message_id should be unique for every unsolicited call
  • context/timestamp can't be the same as in Order-picked-up state
  • actual pickup timestamp should not change; must remain the same as in the picked state; why is this changing in the subsequent APIs as well?

/track

• must be supported

Flow 3

• similar issues as above

/on_select (OOS)

• unicode characters (such as: \u0026) should be avoided in the payloads

/select

• Why is OOS item again selected?
• flow must continue from the earlier cart in /on_select (OOS);

Flow 4

• similar as above

/on_cancel

• check the timestamp and delayed response related issues
• TAT is not required in the newly created cancelled fulfillment
• updated_at for precancel_state must be provided

Flow 5

/on_cancel

• why is the value of delivery TAT changing in the subsequent APIs? What does TAT of 2 min mean?
• precancel_state is not captured correctly;
• updated_at missing for precancel_state
• retry_count must be provided in cancel_request
• value of "initiated_by" and "reason_id" in cancel_request is incorrect; RTO is triggered by SNP or LSP
• cancellation reason id mismatches in /fulfillments and /cancellation
• cancelled_by is incorrect; and subscriber_id should be provided instead of url
• remove TAT from RTO fulfillment (RTO1)

/on_status (RTO)

• RTO disposed or delivered state must be provided

Flow 6

• all the scenarios must be part of the same order

several issues in Flow 6 as well, please perform a QA at your end before resubmitting the logs

@amitkbadheka

[sandeepshahi]

Flow 1

• latest logs must be submitted for verification

Flow 2

• logs seem manipulated; parent_item_id in /select is not in the format as created by the ref buyer app which is further getting changed later
• all the previously identified issues must be resolved

/on_select

• parent_item_id should also be provided for base item in quote/breakup/item
• exclusive tax is missing for customization with non-zero price in quote/breakup

/on_init

• fulfillments/tags/ need not be provided for seller led delivery
• "@ondc/org/settlement_basis" and "@ondc/org/settlement_window" would be provided by the payment collector; need not be provided here
• value of tracking in /fulfillments should not change

/on_status

• no need to send unsolicited /on_status if the order is still in created state
• Packed: updated_at timestamp can't be future dated; should be <= context/timestamp
• estimated pickup and delivery time ranges can't be the same
• estimated time ranges should not change in the subsequent APIs; must be in compliant with the time_to_ship and delivery TAT provided in the earlier APIs
• value of tracking in /fulfillments should not change
• actual pickup and delivery timestamps are missing in the relevant states and should not change in the subsequent APIs
• invoice must be provided once the order is picked
• routing and tracking info must be provided on or before Agent-assigned state and same should flow in subsequent APIs; check the schema too

/on_track

• live tracking must be supported; tracking must be set as inactive once the order is delivered

Flow 3

• similar issues as above

/on_select (OOS)

• error/message is invalid for customizable item; should be as per the contract; check on_select (scenario 4) in the contract

Flow 4

/on_cancel

• order/id can't change
• updated_at is missing for "precancel_state"
• quote/price and quote/breakup should be updated

Flow 5

/on_cancel

• RTO must be disposed through on_status; since it's a status change with no update in the order
• timestamp and message_id can't be same for the above point
• quantity in /items with forward shipment must be mapped to the RTO shipment; both the shipments can't have item quantities available
• retry_count is missing in /cancel_request
• precancel fulfillment_state is not captured correctly
• start and end location are missing
• quote/breakup quantity and item's total price should be updated
• updated_at can't be future dated

Flow 6

• provider_location is still not removed
• similar issues as above

/on_update (part cancel)

• tags/id is invalid tag block in cancelled fulfillment
• Completed is an invalid fulfillment state
• part cancel should be initiated pre shipment
• quote should be updated

/on_update (initiated)

• message_id for solicited call should be the same as in /update
• check the return_request details received; those should not be changed
• entire trail should be maintained; part cancel fulfillment block and other details should not be removed

@amitkbadheka

[amitkbadheka]

@sandeepshahi any feedback on IGM and RSF?

[amitkbadheka]

@sandeepshahi any update here?

[sandeepshahi]

• use log validation utility before submitting the logs; most of the issues are flagged by the utility

Flow 1

• full and incremental pull should be performed through same application; won't be able to verify the changes

/on_search

• fssai license no should be of 14 digits only
• holidays schedule must be provided in /locations/time
• unicode escape sequences should be avoided in the payload eg: instead of "F\u0026B", "F&B" should be used
• placeholder values should not be provided in offers; optional feature for now
• if the timings are same for Delivery, Order, Self-Pickup, use the enum "All"; check contract for the details
• upper/lower price range for customizable items are still not provided
• calculation of default selection price is incorrect
• display sequence of an item in a custom menu must start with seq 1 and not 0; check /items/category_ids[]
• placeholder values of customizations should be avoided
• parent custom group id must be provided for customizations in tags/parent; eg: check for customization: "3478636_3501501"
• type should be provided in /tags to specify base item or customization; eg: check for SKU: "3478576"
• please share tabular data for all the items and nested customizations as shared in /on_search

/search (inc pull based)

• no callback response provided

/on_search (inc push based)

• bpp_id and bpp_uri missing in /context; therefore, full and incremental catalog should be tested with same buyer app
• time range for closing of store can't be past dated;

Flow 2

/on_select

• dynamic item id should be the same as created by the buyer app

/on_confirm

• fulfillments/tags/ need not be provided for seller led delivery; trail must be maintained and previous trail should not be broken

/on_status

• invoice must be provided once the order is picked
• gps is not a valid tracking tag in /fulfillments/tags/tracking
• estimated time ranges should not change in the subsequent APIs;
• time difference between actual pickup and the API call for Order-picked-up shouldn't be large

/on_track

• live tracking should be provided; location/time/timestamp and updated_at can't be earlier than /track call

Flow 3,4,5,6

• similar issues as mentioned earlier

@amitkbadheka, There are repeated issues, as mentioned multiple times earlier. Please fix all the issues and perform a sanity check before submitting the logs.

[amitkbadheka]

@sandeepshahi

For Flow 2,

/on_select

• dynamic item id should be the same as created by the buyer app. I had demoed it to you on the call that the order flow breaks on the buyer app breaks when I use the the dynamic item id that comes in the select call.

/on_confirm

• gps is not a valid tracking tag in /fulfillments/tags/tracking, What should be the key that I need to send?
• time difference between actual pickup and the API call for Order-picked-up shouldn't be large - It is happening only because we are triggering the order status from our end itself. For Prod orders, it will be proper

[amitkbadheka]

@sandeepshahi

For Flow 2,

/on_select

dynamic item id should be the same as created by the buyer app. I had demoed it to you on the call that the order flow breaks on the buyer app breaks when I use the the dynamic item id that comes in the select call.

can you assist with that?

[amitkbadheka]

Hi @sandeepshahi , Can we get this checked today?

[sahil-ondc]

• @amitkbadheka Manipulation of logs are not allowed as per the compliance. Please resubmit flows again

1. https://github.com/ONDC-Official/v1.2.0-logs/commit/bf3b7e6ad0ba9daf106db70149bcf4b15edba929
2. https://github.com/ONDC-Official/v1.2.0-logs/commit/f7d8f0a744618e8dc3c1c2324762d4635751d639

[amitkbadheka]

Hey Getting this checked internally. I am regenerating the logs and sharing an updated PR.

[amitkbadheka]

Hi @sandeepshahi @sahil-ondc , Have updated fresh logs. Can you review it?

[sahil-ondc]

Flow 1

on_search (full catalog)

• categories.tags.list[type]: Error: parent_category_id should not be present while type is custom_group.
• items: Error: /message/catalog/bpp/providers/items must have default_selection price and lower/upper range for customizable items.
• srvcabilityValErr: Error: Value passed in serviceability tags[1] should be same as passed in location/circle.

Flow 2

on_confirm

• placeholders should not be provided in provider_tax_number

Flow 3

on_select (out-of-stock)

• priceBreakup: "Item's unit and total price mismatch for id: 636_3501500"
• brkcnt5: "Available count can't be less than @ondc/org/item_quantity.count "

Flow 4

on_cancel

• schemaErr0: "/message/order/items/2/quantity/count must be integer"
• itemCount[2]: "Item count should be 0 for /on_cancel in forward shipment"
• precancelState.updatedAt: "precancel_state.updated_at of on_cancel is not equal with the on_confirm order.updated_at”

Flow 5

on_cancel (rto)

• schemaErr0: "/message/order/items/2/quantity/count must be integer"
• schemaErr1: "/message/order/items/4/quantity/count must be integer"
• schemaErr6: "/message/order/quote/breakup/3/item must have required property 'price'"
• itemCount[2]: "Item count should be integer 0 for /on_cancel in forward shipment"
• itemCount[4]: "Item count should be integer 0 for /on_cancel in forward shipment"
• precancelState.updatedAt: "precancel_state.updated_at of on_cancel is not equal with the on_status_out_for_delivery order.updated_at"

Flow 6

on_update (part-cancel)

• schemaErr0: "/message/order/fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Cancelled,Pending,Order-delivered,Return_Initiated,Return_Pick_Failed,Return_Approved,Return_Picked,Return_Delivered,Liquidated,Return_Rejected)"

update_settlement (part-cancel)

• missing payload

on_status (out-for-delivery)

• message/order.fulfillments/0: "Mismatch occured while comparing 'Cancel' fulfillment object with on_update_part_cancel as its missing"

update_settlement (liquidated)

• Domain[update]: "Domain should be same in each action"
• city: "City code mismatch in /search and /update_settlement_liquidated"
• tmpstmp: "Timestamp for /on_init api cannot be greater than or equal to /update_settlement_liquidated api"
• txnId: "Transaction Id should be same from /select onwards"

@amitkbadheka, I have provided feedback but logs still seems manipulated. This should not happen again.

[amitkbadheka]

Checking. Thanks

[amitkbadheka]

The log is not edited and purely coincidental. I can vouch for it as I have updated it myself.

[madlad33]

@sahil-ondc Flow 1 -> items: Error: /message/catalog/bpp/providers/items must have default_selection price and lower/upper range for customizable items.

Can you please elaborate further on this? default_selection and upper/lower range are already present for all the customizable items.