Open BLR-0118 opened 7 months ago
/on_update_return_approved:
/on_update_return_picked:
/on_update_return_delivered:
pls share logs for return rejection due to pickup failure;
@Namratha102000
@BLR-0118 I have fixed the above said issues, and raised a PR(#1797) please review and merger
@sahil-ondc - pls merge & check
@codezyngPranav please fix the issues as discussed on the mail and resubmit the PR.
/on_search:
(cancel_flow) /on_status_cancelled:
(return_flow) /on_status_completed:
where is /update log for return request?
@codezyngPranav - pls see above;
@BLR-0118, Thanks for reviewing, will resolve the issues you have specified and resubmit the logs also with missing logs that you have specified.
The Tea&Coffee.... were auto generated as the business somehow had these products belonging to these categories in it and I am working on fixing the respective logic in our code base.
@BLR-0118 Please review the resubmitted flow of logs
name: Serviceable
is not required in fulfillmentsPending
is not required in fulfillments@codezyngPranav
@sahil-ondc @sandeepshahi
Regarding the issue "Transaction Id should be same from /select onwards" I reviewed the last submission and verified that we have same "transaction_id" throughout the flow. Could you please confirm if this issue was reported mistakenly or, am I overlooking something ?
I am curious to understand about your process of reviewing the logs, that Is it a manual check or an automated one ?
Are the test results obtained Pramaan tool 100% accurate ?
Hi @sandeepshahi @sahil-ondc, I have re-submitted the logs after resolving all the above said issues and other issues that I found non compliant with schema. Please review at the earliest.
@codezyngPranav
@codezyngPranav
@sahil-ondc Thanks for the review, will resolve these issues and resubmit the logs.
There are some queries,
Last time we submitted logs. It was reported(Previous Issues Reported) that "If the delivery charges are ‘0’, shouldn’t be added in the quote" but now it has been reported that "delivery line item must be present in quote/breakup (if location is serviceable)" . Our delivery charges for this particular item is "0" and hence it was not added.
"/fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search", time_to_ship should always be less than TAT?
"Is only chains category supported ?", No we support other categories as well.
"Is variants on multiple attributes supported ?", Depends upon the product and category.
Currently on our production environment we are aligning with the less than 5 seconds TAT.
As submitted logs were generated in staging environment the TAT is more than 5 seconds due to lower capability infrastructure in staging environment.
@sahil-ondc, I have resubmitted the logs after fixing the above mentioned issue and have also added the missing incremental search and on_search logs. Please verify
Also please consider that submitted logs were generated in staging environment and the TAT is more than 5 seconds due to lower configuration of infrastructure in staging environment.
here's the link to PR
context/timestamp difference between /on_select and /select should be less than 5 sec
P2D can’t be considered as ‘Immediate Delivery’
TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search
@codezyngPranav
Hi @sahil-ondc, I have resubmitted the logs please merge and review
@codezyngPranav
@sahil-ondc , I have submitted the new please merge and review.
Routing object has not been added in on_status_pending and on_status_packed as it is optional.
@codezyngPranav, Wrong on_search (full catalog) has been provided, please resubmit correct (RET12) logs, so that we can proceed for testing and verifications.
@codezyngPranav, Wrong on_search (full catalog) has been provided, please resubmit correct (RET12) logs, so that we can proceed for testing and verifications.
Hi @sahil-ondc, The wrong search and on_search and were mistakenly uploaded, I have raised an another PR replacing them with RET12 search and on_search json's. Please consider
Link to PR
@codezyngPranav
Flow 1
On Search
- time_to_ship is having invalid format ‘P3H’, It should be ‘PT3H’.
On Search Inc
- context/city should be "*" in /on_search_inc_refresh
- Transaction Id for /search_inc_refresh and /on_search_inc_refresh api should be same
Flow 6
On Update Part Cancel
- item quantity for part cancelled item is not reduced in the quote for the item_id: ’43769’
- /message/order/items/1/quantity/count must be integer
- /message/order/quote/breakup/1/price/value must be string
On Status Pending
- /message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places
- /message/order/items/1/quantity/count must be integer
- Same issues is processed in other on_status calls as well
On Update Delivered
- How the item is again back in stock ?
- Return fulfillment is also missing in the items
- Quote trail is missing for item_id : ‘39046’
- Return Picked timestamp is missing in the Return Fulfillment
@codezyngPranav
@sahil-ondc , Thanks for review. Will work on the fixes, resolve and resubmit.
Hi @sahil-ondc, thanks for the review. My name is Srinivas, ceo of Codezyng(company which is working with Esamudaay for Ondc technology support). I wanted to understand if we are missing something here. Are there any documentation or best practices available which will help us not to do these errors in the pr. It has been long time @codezyngPranav is trying to make fashion category work for us. However, most of the pr's are getting rejected with improvement a suggested( appreciate that). Appreciate any suggestions on how we can improve our pr's are welcome. Happy to get on a call and understand.
/on_search:
/on_update_partial_cancel:
/on_status:
/on_update_return_initiated: