eSamudaay (RET12) - compliance check

BLR-0118 commented 8 months ago

/on_search:
- pls remove "@ondc/org/fssai_license_no"; data type is string & null is not valid for string;
- attribute values for item 39046 (& others) invalid - colour should be hex value, gender/plating in lower case (valid enums are here);
- what does veg/non-veg in fashion catalog mean?
/on_update_partial_cancel:
- has same message_id as /on_confirm;
/on_status:
- type of shipment, i.e. hyperlocal (P2P) or intercity (P2H2P) needs to be provided in routing.type;
/on_update_return_initiated:
- return_request doesn't have id;
- pickup time has been provided even though return hasn't been picked yet;

BLR-0118 commented 8 months ago

/on_update_return_approved:
- message_id for this & on_update_return_initiated same;
- remove rateable;
- bpp_terms should have np_type;
/on_update_return_picked:
- same issue with message_id;
/on_update_return_delivered:
- same issue with message_id;
- delivery time to be provided;
pls share logs for return rejection due to pickup failure;

BLR-0118 commented 8 months ago

@Namratha102000

codezyngPranav commented 5 months ago

@BLR-0118 I have fixed the above said issues, and raised a PR(#1797) please review and merger

BLR-0118 commented 5 months ago

@sahil-ondc - pls merge & check

sahil-ondc commented 5 months ago

@codezyngPranav please fix the issues as discussed on the mail and resubmit the PR.

BLR-0118 commented 5 months ago

/on_search:
- custom menu has names that are cut & pasted from elsewhere e.g. "Tea & Coffee", "Atta, Flour...";
(cancel_flow) /on_status_cancelled:
- cancel initiated_by should have bpp_id (as seller initiated);
(return_flow) /on_status_completed:
- pickup time was 03:55:31.196Z in /on_status_picked, but changed to 04:12:40.196Z in /on_status_completed?
where is /update log for return request?

BLR-0118 commented 5 months ago

@codezyngPranav - pls see above;

codezyngPranav commented 5 months ago

@BLR-0118, Thanks for reviewing, will resolve the issues you have specified and resubmit the logs also with missing logs that you have specified.

The Tea&Coffee.... were auto generated as the business somehow had these products belonging to these categories in it and I am working on fixing the respective logic in our code base.

codezyngPranav commented 4 months ago

@BLR-0118 Please review the resubmitted flow of logs

sahil-ondc commented 4 months ago

Flow 1

On Search (full-catalog)

Images, short_desc and long_desc can’t be empty for category_id : ‘12756’
No item is listed for category id : ‘12120’
Invalid custom_menu created for category_id : ‘12768’
Variants are not captured properly for category_id : ‘30738’, ‘25383’
If the timings are same for Delivery/self-Pickup/Order, you can use ‘All’ enum for the same
What’s the role of ‘Tea & Coffee’ , ‘Atta, Flour & Sooji’ in the logs

search (incremental)

Search Inc and On Search Inc can’t be empty

Select

bpp_suffix is not required in select payload

On Select

name: Serviceable is not required in fulfillments
If the delivery charges are ‘0’, shouldn’t be added in the quote

Init

Transaction Id should be same from /select onwards

On Init

context/timestamp difference between /on_init and /init should be less than 5 sec
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object
Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. Incase seller wants to collect the payment then you can send it the way you sent

Confirm

Transaction Id should be same from /select onwards
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

On Confirm

context/timestamp difference between /on_confirm and /confirm should be less than 5 sec
Transaction Id should be same from /select onwards
name:Pending is not required in fulfillments
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object
documents is not required in on_confirm action call

On Update Part Cancel

Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object
quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm as quote_trail is not provided for the item_cancellled
Cancel fullfillment is not present in the fulfillments
fullfillment id’s are not captured properly for the part cancellaiton

Update Settlement Part Cancel

JSON cannot be empty

On Status Pending

Transaction Id should be same from /select onwards
documents is not required in on_status_pending, packed action call
stat/descriptor/name is not required in fulfillments
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object
For on_status_picked the invoice is not updated as per the part cancellation

On Status Picked

Transaction Id should be same from /select onwards
RoutingTag object is mandatory in Tags of Delivery Object for on_status_picked
timestamp for pickup is not in given range
stat/descriptor/name is not required in fulfillments
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

On Update Interim Reverse QC

Message Ids for /update_reverse_qc and /on_update_interim_reverse_qc API should be same
Fulfillments/Cancel is missing in on_update_interim_reverse_qc

on update Approval

/message/order/fulfillments/1/start/contact and person is not required in on_update_approval
/message/order/fulfillments/1/start/end object is missing
Fulfillments/Cancel is missing in on_update_approval

on update Picked

/message/order/fulfillments/1/start/contact and person is not required in on_update_picked
Fulfillments/Cancel is missing in on_update_picked
/message/order/fulfillments/1/start/end object is missing
return picked timestamp is not in the given range provided

update (Reverse QC)

update: JSON cannot be empty

on Update Delivered

/message/order/fulfillments/1/start/contact and person is not required in on_update_delivered
Fulfillments/Cancel is missing in on_update_delivered
How the start and end object for 'Return' fulfillment is same ?

@codezyngPranav

codezyngPranav commented 4 months ago

@sahil-ondc @sandeepshahi

Regarding the issue "Transaction Id should be same from /select onwards" I reviewed the last submission and verified that we have same "transaction_id" throughout the flow. Could you please confirm if this issue was reported mistakenly or, am I overlooking something ?
I am curious to understand about your process of reviewing the logs, that Is it a manual check or an automated one ?
Are the test results obtained Pramaan tool 100% accurate ?

codezyngPranav commented 3 months ago

Hi @sandeepshahi @sahil-ondc, I have re-submitted the logs after resolving all the above said issues and other issues that I found non compliant with schema. Please review at the earliest.

https://github.com/ONDC-Official/v1.2.0-logs/pull/2142

sahil-ondc commented 3 months ago

Flow 1

on_search

/message/catalog/bpp~1providers/0/tags/2/list/0/value timing for fulfillment type, enum - 'Order' (online order processing timings) 'Delivery' (order shipment timings, will be same as delivery timings for hyperlocal), 'Self-Pickup' (self-pickup timings), All
area_code should be as per GPS provided in /message/catalog/bpp/providers/locations/address
value passed in serviceability tags[0] should be same as passed in location/circle
Is variants on multiple attributes supported ?
Is only chains category supported ?

search & on_search (incremental request)

incremental requests should be submitted

@codezyngPranav

sahil-ondc commented 3 months ago

Flow 6

on_select

context/timestamp difference between /on_select and /select should be less than 5 sec
/fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search
delivery line item must be present in quote/breakup (if location is serviceable)

on_init

context/timestamp difference between /on_init and /init should be less than 5 sec
'cancellation_terms' in /message/order should not be provided as those are not enabled yet

on_confirm

context/timestamp difference between /on_confirm and /confirm should be less than 5 sec
'cancellation_terms' in /message/order should not be provided as those are not enabled yet

on_update (part-cancellation)

items array should be as per API contract
cancel_request/initiated_by should match with bpp_id as seller is cancelling the partial items

on_update

items array should be as per API contract
@ondc/org/settlement_details should have refund details which was issued for partial-cancellation

@codezyngPranav

codezyngPranav commented 3 months ago

@sahil-ondc Thanks for the review, will resolve these issues and resubmit the logs.

There are some queries,

Last time we submitted logs. It was reported(Previous Issues Reported) that "If the delivery charges are ‘0’, shouldn’t be added in the quote" but now it has been reported that "delivery line item must be present in quote/breakup (if location is serviceable)" . Our delivery charges for this particular item is "0" and hence it was not added.
"/fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search", time_to_ship should always be less than TAT?
"Is only chains category supported ?", No we support other categories as well.
"Is variants on multiple attributes supported ?", Depends upon the product and category.
Currently on our production environment we are aligning with the less than 5 seconds TAT.

As submitted logs were generated in staging environment the TAT is more than 5 seconds due to lower capability infrastructure in staging environment.

codezyngPranav commented 3 months ago

@sahil-ondc, I have resubmitted the logs after fixing the above mentioned issue and have also added the missing incremental search and on_search logs. Please verify

Also please consider that submitted logs were generated in staging environment and the TAT is more than 5 seconds due to lower configuration of infrastructure in staging environment.

here's the link to PR

sahil-ondc commented 2 months ago

On Search

‘creds’ is a invalid field provided in the bpp/providers[0]
In categories with id: ‘30819’ , seq : ‘1’ is missing for the variant created for bpp/providers[0]
Value provided in serviceability ‘100’ km doesn’t matches with the value provided in the locations for bpp/providers
If the the timing are same for Delivery/Self-Pickup/Order, You can use enum ‘All’ instead
In categories with id: ‘33186’, seq : ‘1’ is missing for the variant created for bpp/providers[1]
In categories with id: ‘33187’, seq : ‘2’, ‘3’ is missing for the variant created for bpp/providers[1]

On Search Inc

No incremental changes are observed for the given items

On Select

context/timestamp difference between /on_select and /select should be less than 5 sec
P2D can’t be considered as ‘Immediate Delivery’
TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search

On Init

context/timestamp difference between /on_init and /init should be less than 5 sec

On Confirm

context/timestamp difference between /on_confirm and /confirm should be less than 5 sec
@ondc/org/item_id: Fulfillment1, with title ‘delivery’ is missing as compared to on_select action call

On Update Part Cancel

Item count isn’t reduced in the forward fulfillment provided
Item_id ‘43769’ is missing in the quote breakup
extra quote_trail is provided for ‘tax’ which was not present in on_confirm
Invalid reason code provided for the part_cancellation

On Update Approval

start/time/range/start time of return fulfillment should be greater than context/timestamp of on_update_approval

@codezyngPranav

codezyngPranav commented 2 months ago

Hi @sahil-ondc, I have resubmitted the logs please merge and review

sahil-ondc commented 2 months ago

Flow 1

On Search

Why 2 ‘catalogs’ keywords are there in payload nested in each other ?
creds/desc/name is missing in the bpp/providers/0/cress
Value provided in serviceability ‘100’ km doesn’t matches with the value provided in the locations for bpp/providers
If the timings are same for Delivery/Self-Pickup/Order, you can use enum ‘All’
In categories with id: ‘30819’ , seq : ‘1’ is missing for the variant created for bpp/providers[0].
In categories with id: ‘33186’ , seq : ‘1’ is missing for the variant created for bpp/providers[1].
In categories with id: ‘33187’ , seq : ‘1’, ‘2’ is missing for the variant created for bpp/providers[1].

Flow 2

On Select

/fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search

On Update Part Cancel

quote.price for the part cancellation item is not reduced in the quote.breakup

On Status Pending, Packed

routing object is missing

On Status Delivered

wrong payload is provided, kindly check once

On Update Approval

context/timestamp should be greater than message/order/updated_at timestamp

On Update Picked

Item quote breakup prices for /on_update_picked should be equal to the net price.

@codezyngPranav

codezyngPranav commented 2 months ago

@sahil-ondc , I have submitted the new please merge and review.

Routing object has not been added in on_status_pending and on_status_packed as it is optional.

sahil-ondc commented 2 months ago

@codezyngPranav, Wrong on_search (full catalog) has been provided, please resubmit correct (RET12) logs, so that we can proceed for testing and verifications.

codezyngPranav commented 2 months ago

@codezyngPranav, Wrong on_search (full catalog) has been provided, please resubmit correct (RET12) logs, so that we can proceed for testing and verifications.

Hi @sahil-ondc, The wrong search and on_search and were mistakenly uploaded, I have raised an another PR replacing them with RET12 search and on_search json's. Please consider

Link to PR

sahil-ondc commented 2 months ago

Flow 1

On Search

time_to_ship is having invalid format ‘P3H’, It should be ‘PT3H’.

On Search Inc

context/city should be \"*\" in /on_search_inc_refresh
Transaction Id for /search_inc_refresh and /on_search_inc_refresh api should be same

Flow 6

On Update Part Cancel

item quantity for part cancelled item is not reduced in the quote for the item_id: ’43769’
/message/order/items/1/quantity/count must be integer
/message/order/quote/breakup/1/price/value must be string 
On Status Pending
/message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places
/message/order/items/1/quantity/count must be integer
Same issues is processed in other on_status calls as well

On Update Delivered

How the item is again back in stock ?
Return fulfillment is also missing in the items
Quote trail is missing for item_id : ‘39046’
Return Picked timestamp is missing in the Return Fulfillment

@codezyngPranav

codezyngPranav commented 2 months ago

Flow 1

On Search

time_to_ship is having invalid format ‘P3H’, It should be ‘PT3H’.

On Search Inc

context/city should be "*" in /on_search_inc_refresh

Transaction Id for /search_inc_refresh and /on_search_inc_refresh api should be same

Flow 6

On Update Part Cancel

item quantity for part cancelled item is not reduced in the quote for the item_id: ’43769’

/message/order/items/1/quantity/count must be integer

/message/order/quote/breakup/1/price/value must be string

On Status Pending

/message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places

/message/order/items/1/quantity/count must be integer

Same issues is processed in other on_status calls as well

On Update Delivered

How the item is again back in stock ?

Return fulfillment is also missing in the items

Quote trail is missing for item_id : ‘39046’

Return Picked timestamp is missing in the Return Fulfillment

@codezyngPranav

@sahil-ondc , Thanks for review. Will work on the fixes, resolve and resubmit.

srinivas-codezyng commented 2 months ago

Hi @sahil-ondc, thanks for the review. My name is Srinivas, ceo of Codezyng(company which is working with Esamudaay for Ondc technology support). I wanted to understand if we are missing something here. Are there any documentation or best practices available which will help us not to do these errors in the pr. It has been long time @codezyngPranav is trying to make fashion category work for us. However, most of the pr's are getting rejected with improvement a suggested( appreciate that). Appreciate any suggestions on how we can improve our pr's are welcome. Happy to get on a call and understand.

ONDC-Official / v1.2.0-logs