ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 271 forks source link

nStore - SA (RET11) - compliance check #1206

Closed BLR-0118 closed 5 months ago

BLR-0118 commented 7 months ago

RET12

  1. suggest you use HSN code for item.descriptor.code as this seems to be most common;
  2. quantity.unitized.measure.unit of "each" is invalid - pls check valid enums here;
  3. pls add at least all mandatory attrs, for the category, defined here, while checking the mapping from attrs in the sheet to the keys as defined in contract;
  4. why are returnable/cancellable/seller_pickup_return set to false for all items?
BLR-0118 commented 7 months ago

RET13

  1. suggest you use EAN code for items;
  2. while quantity.unitized.measure.unit value is valid, it's not usable here (pls follow same rule as RET10);
  3. 3 & 4 above for RET12 also apply here;
BLR-0118 commented 7 months ago

RET14

  1. consider using GTIN code for items, as this seems to be the industry standard;
  2. 3 & 4 above for RET12 also apply here;
BLR-0118 commented 7 months ago

RET15, 16 & 18 - pls follow the above as well;

BLR-0118 commented 7 months ago

@nstoretech

BLR-0118 commented 7 months ago

RET11 - customization to be supported, logs for all flows required;

BLR-0118 commented 7 months ago

RET12

  1. item.tags.attribute.keys wrong:
    • should be lowercase, e.g. "gender";
    • values should be as per enum defined here, e.g. for gender;
BLR-0118 commented 7 months ago

RET13

  1. same issue as RET12;
  2. use proper unitized measure e.g. for item 230376, should be "100 gram";
BLR-0118 commented 7 months ago

RET14

  1. same issue as RET12;
  2. for attrs like weight / length / breadth / height, values to be defaulted as defined here;
BLR-0118 commented 7 months ago

RET15

  1. same as RET14;
BLR-0118 commented 7 months ago

RET16

  1. same as RET14;
BLR-0118 commented 7 months ago

RET18

  1. same as RET13;
BLR-0118 commented 7 months ago

@nstoretech - request to carefully review contract & submit logs in proper shape;

BLR-0118 commented 6 months ago

RET12

  1. for sarees, use "Free Size" for size;
  2. use proper name for variant definition, something that buyer apps can show;

RET13

  1. BPC has branded items, so EAN code should be used;
  2. item 108 has invalid attribute "flavour"; attributes should be as per this list;

RET14

  1. use proper name for variant definition, something that buyer apps can show;
  2. weight/length/breadth/height values are invalid for Video Player / Power Bank; values have to be defined in gram / cm / cm / cm as doc here;

RET15

  1. same issue as RET14 above;

RET16

  1. use proper name for variant definition, something that buyer apps can show;

RET18

  1. unitized measure to be properly defined e.g. if 60 capsules, show as 60 unit;
BLR-0118 commented 6 months ago

@nstoretech - clearing RET12, RET16 but pls make sure issues mentioned above are fixed for everything; other logs to be resubmitted

nstoretech commented 6 months ago

+Ajeeth Boaz @.> +Arunraj Selvam @.> +Sudharsan Srinivasan @.> +AdminTeam @.>

On Wed, 17 Apr, 2024, 6:31 pm Supriyo Ghosh, @.***> wrote:

@nstoretech https://github.com/nstoretech - clearing RET12, RET16 but pls make sure issues mentioned above are fixed for everything; other logs to be resubmitted

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1206#issuecomment-2061209249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXFYIVHGBVXQGWB4EXQZ7ZTY5ZXCNAVCNFSM6AAAAABFKIRTF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGIYDSMRUHE . You are receiving this because you were mentioned.Message ID: @.***>

BLR-0118 commented 6 months ago

RET13

  1. what does time_to_ship of 100ml for item 246829 mean?
  2. what's the difference between items 254473 & 12254473?
BLR-0118 commented 6 months ago

RET14

  1. pls also send colour_name;
BLR-0118 commented 6 months ago

RET15

  1. pls also send colour_name;
  2. considering these are branded items, why aren't you sending EAN codes?
BLR-0118 commented 6 months ago

RET18

  1. why aren't you sending EAN codes for items?
BLR-0118 commented 6 months ago

@nstoretech

BLR-0118 commented 6 months ago

RET13 - ok;

BLR-0118 commented 6 months ago

RET14 - ok;

BLR-0118 commented 6 months ago

RET15 - ok;

BLR-0118 commented 6 months ago

RET18

prescription_required has values "yes", "no";

BLR-0118 commented 6 months ago

logs for RET13/14/15 cleared for v1.2.0; pls fix RET18 & update here;

BLR-0118 commented 6 months ago

@nstoretech

BLR-0118 commented 6 months ago

@nstoretech - before deploying in Prod, pls make sure you also send "@ondc/org/statutory_reqs_packaged_commodities" for all categories (as doc in the contract); without this, many buyer apps may not show your catalog;

arunraj-nstore commented 6 months ago

@BLR-0118 - We have updated the value of the "prescription_required" attribute and also included the "@ondc/org/statutory_reqs_packaged_commodities" as suggested.

Here is the payload with updated 'prescription_required' field. http://jsonblob.com/1239820012834643968

BLR-0118 commented 6 months ago

RET11 flows:

Flow 1

  1. /on_search:
    • bpp/providers.categories.id max length is 12;
    • category_id should be F&B;
    • remove item.descriptor.code;
    • item.price.range & item.price.default_selection reqd only if base price is 0;
    • structure for multiple customizations for item 111 is wrong;
    • count of "max" customizations for "customization1" should match the no of customizations assigned to this custom group (i.e. 8);
BLR-0118 commented 6 months ago
  1. /on_search_incremental:
    • since incremental updates are thru push, use different message_id for each push update (diff from message_id in search_incremental);
BLR-0118 commented 6 months ago

Flow 2

  1. /on_select:
    • since you have 2 fulfillment options, the charges for fulfillment specified for one of the options should also be specified for the other e.g. delivery charge of 0 for F1, but no delivery charge for F2;
BLR-0118 commented 6 months ago
  1. /on_init:
    • pls add provider_tax_number to bpp_terms;
BLR-0118 commented 6 months ago
  1. others:
    • pickup & delivery slots are provided in /on_confirm when order isn't yet accepted by store; this is incorrect as the sequence should be: store accepts order -> starts prep -> packs etc.;
    • order accepted state not shown anywhere, i.e. goes from Created to In-progress directly; is this auto-accept based on timer or store manually accepts each order?
    • tracking is shown as false, even though it's mandatory for F&B orders;
BLR-0118 commented 6 months ago

Flow 3 - is there example where customization is out-of-stock?

BLR-0118 commented 6 months ago

flow 4 - ok;

BLR-0118 commented 6 months ago

flow 5 - not really RTO (cancel_request missing addl rto attributes) but looks ok; flow 6:

BLR-0118 commented 6 months ago

@nstoretech - pls resubmit logs for flows 1 & 1/2 additional flows where all the above issues can be checked (flow 5/6 or anything else?)

arunraj-nstore commented 6 months ago

@BLR-0118

count of "max" customizations for "customization1" should match the no of customizations assigned to this custom group (i.e. 8);
since you have 2 fulfillment options, the charges for fulfillment specified for one of the options should also be specified for the other e.g. delivery charge of 0 for F1, but no delivery charge for F2;

Also pls clarify "pickup & delivery slots are provided in /on_confirm when order isn't yet accepted by store; this is incorrect as the sequence should be: store accepts order -> starts prep -> packs etc.;" . We were not sending the pickup and delivery slot attributes in on_confirm.

BLR-0118 commented 5 months ago

Flow 1

  1. /on_search_full_catalog_refresh:

    • 7 customizations (113, 115, 116, 117, 118, 119, 120) are assigned to custom group CM1 but "max" for CM1 is 5?
    • some items need to be created as customization for better UX e.g. items 106, 109;
  2. /on_search_incremental_refresh:

    • item structure is different from what's in full catalog refresh e.g. descriptor.code, invalid custom menu id ("menu1")?

Flow 3

  1. /on_select:

    • quote.breakup[] should include delivery cost for all fulfillments; currently, showing for F1, not for F2;
  2. /on_select_out_of_stock:

    • error.message invalid: check the format here;

Flow 6

  1. /on_update_part_cancel:

    • cancellation reason code "010" is not valid for part cancel;
    • if there is no change in value for a quote line item, it shouldn't be a part of quote_trail e.g. tax line items in "C3008";
  2. /on_update_liquidated:

    • I'm assuming you're sending solicited /on_update response (for Return_Initiated);
    • otherwise, looks ok but 2nd point above needs to be handled;
BLR-0118 commented 5 months ago

@nstoretech - I'm clearing the logs, but pls make sure the above are fixed before deploying to Prod;