sahil-ondc commented 5 months ago

Flow 2

confirm

quote/breakup/item should not have properties quantity/available and quantity/maximum with value '{}'

on_status (packed)

order/state should be 'In-progress' for /on_status_packed (BNP should have validations)

Flow 5

update call with settlement should be provided after on_cancel

Flow 6

update settlement should be provided

@ep-aws

Jagannath-wits commented 5 months ago

Flow 2

select

on_search_full_catalog_refresh_city: City code mismatch in /on_search_full_catalog_refresh and /select
invalidItemId[4800024664]: Invalid item found in /select id: 4800024664
providerId: provider with provider.id: 717 does not exist in on_search
providerChecks: Warning: Missed checks for provider as provider with ID: 717 does not exist on on_search API

Please use the search and on_search provided in flow 1 in rest of the flows

Flow 6-a

on_update

invalid_initiated_by: initiated_by should be storepreprod.krenai.in
ttl: cant be empty

Flow 6-c

update

updateRid: reason_id is not a valid reason id (buyer app initiated)

Flow 6-b

updateRid: reason_id is not a valid reason id (buyer app initiated)
Update settlement missing

@ep-aws

sandeepshahi commented 5 months ago

Please test with a verified seller app in preprod

is incremental pull supported (through start_time and end time)?
while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?

Flow 1

/on_search

discrepancies in the store timings provided in /locations and /tags/timing; How is this being handled?

Flow 2

/select

inaccurate mapping of gps and area code in fulfillments/end/location
message_id should be unique for a message pair; can't be same for the entire txn
For above point, also ensure that the message_id is unique for every unsolicited call while processing callbacks

/init

entire address should not be provided in /billing/address/name; separate attributes are provided for area code, city etc.
mapping of area code and city is incorrect

/confirm

payment/params/transaction_id can't be the same as order/id
payment type should be ON-ORDER for prepaid orders
"@ondc/org/settlement_basis" is provided as delivery; is this intended?
np_type should also be provided in /tags
static terms should not be provided until enabled on the network; refer to the repo where static terms have to be uploaded: https://github.com/ONDC-Official/static-terms
"accept_bpp_terms" block should be removed;
is retry mechanism enabled as mentioned in the contract?

/track

tracking should be supported

/on_status

no routing/tracking info provided; how is hyperlocal vs intercity fulfillment states being processed?

Flow 3

similar issues as above

/select

txn id should remain the same as in /select (OOS)

Flow 4

similar issues as above

/cancel

are all the BNP initiated cancellation reason ids supported?

Flow 5

similar issues as above
are the cancellation reason codes when initiated by SNP being validated?

/on_cancel

invalid precancel_state provided; BNP must respond with a NACK

/update (settlement)

Could you clarify this API call? The transaction id and order id don't correspond to the entire transaction, yet the timestamp falls within the same order timeframe.

Flow 6

/on_update (part cancel)

cancellation reason id in /cancel_request is invalid. BNP must respond with a NACK

/update

invalid enum for fulfillments/type; should be "Return" (R in upper case)
are all the reason codes for return supported?
return id in "return_request" should be unique id; "1" might be the already used forward shipment id used by SNP

/on_update (Return)

return fulfillment id is changed by SNP; why is this return processed? BNP must respond with a NACK

/update (settlement)

settlment_timestamp can't be future dated;
fulfillments/type should be "Return"

- BNP must validate each incoming request and issue a proper NACK in case of failures

- Please fix all the issues and submit a demo video of the app along with the logs

@ep-aws

sandeepshahi commented 4 months ago

Flow 1

are variants supported? path of variant grouping attribute seems to be incorrect in /on_search
while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?

Flow 2

/confirm

settlement_basis is mentioned as "delivery"; is this intended?

/track

is tracking supported?

Flow 6

/update

update call missing for Reverse QC request

@ep-aws, please answer the mentioned queries and also the questions raised earlier.

ep-aws commented 4 months ago

Dear Sandeep,

Please find my inline comments.

Flow 1

are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue
while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes

Flow 2

/confirm

settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response.

/track

is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place.

Flow 6

/update

update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR.

@Sandeep Shahi @.***> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP.

On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

are variants supported? path of variant grouping attribute seems to be incorrect in /on_search

while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?

Flow 2

/confirm

settlement_basis is mentioned as "delivery"; is this intended?

/track

is tracking supported?

Flow 6

/update

update call missing for Reverse QC request

@ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier.

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1268#issuecomment-2092487920, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regard,

Jay Mehta

Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in

Mobile: 9033891671

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 4 months ago

++Rohit and Neeraj

On Fri, May 3, 2024 at 5:15 PM Jay Mehta @.***> wrote:

Dear Sandeep,

Please find my inline comments.

Flow 1

are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue

while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes

Flow 2

/confirm

settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response.

/track

is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place.

Flow 6

/update

update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR.

@Sandeep Shahi @.***> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP.

On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

are variants supported? path of variant grouping attribute seems to be incorrect in /on_search

while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?

Flow 2

/confirm

settlement_basis is mentioned as "delivery"; is this intended?

/track

is tracking supported?

Flow 6

/update

update call missing for Reverse QC request

@ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier.

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1268#issuecomment-2092487920, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regard,

Jay Mehta

Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in

Mobile: 9033891671

-- Thanks & Regard,

Jay Mehta

Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in

Mobile: 9033891671

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 4 months ago

Dear Sandeep,

The logs were prepare with the live seller, how we will able to clear the logs ever you keep rejecting our logs even we are doing it with live seller NP? Kindly suggest the work around.

Regards,

Vijay

From: Jay Mehta @.> Date: Friday, 3 May 2024 at 7:24 PM To: Sandeep Shahi @.>, Rohit Garg @.>, Neeraj Jain @.> Cc: "ONDC-Official/v1.2.0-logs" @.>, "ONDC-Official/v1.2.0-logs" @.>, ep-aws @.>, Mention @.>, Usman Shaikh @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

++Rohit and Neeraj

On Fri, May 3, 2024 at 5:15 PM Jay Mehta @.***> wrote:

Dear Sandeep,

Please find my inline comments.

Flow 1 · are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue

· while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes Flow 2 /confirm

· settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response.

/track

· is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place. Flow 6 /update

· update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR.

@Sandeep Shahi Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP.

On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS @.***> wrote: Flow 1 are variants supported? path of variant grouping attribute seems to be incorrect in /on_search while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Flow 2 /confirm settlement_basis is mentioned as "delivery"; is this intended? /track is tracking supported? Flow 6 /update update call missing for Reverse QC request @ep-aws, please answer the mentioned queries and also the questions raised earlier.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

--

Thanks & Regard,

Jay Mehta

Easy Pay Pvt. Ltd.

Panchshil Tech Park 1, Yerwada, Pune 411006, India.

www.easypay.in

Mobile: 9033891671

--

Thanks & Regard,

Jay Mehta

Easy Pay Pvt. Ltd.

Panchshil Tech Park 1, Yerwada, Pune 411006, India.

www.easypay.in

Mobile: 9033891671

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

sandeepshahi commented 4 months ago

Dear Sandeep, Please find my inline comments. Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response. /track - is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place. Flow 6 /update - update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR. @sandeep Shahi @.> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP. … On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.> wrote: Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? /track - is tracking supported? Flow 6 /update - update call missing for Reverse QC request @ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier. — Reply to this email directly, view it on GitHub <#1268 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***> -- Thanks & Regard, Jay Mehta Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in Mobile: 9033891671 -- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

Buyer app must respond with a NACK if there are issues in the schema or provide a catalog rejection report to the seller app. Have you implemented the catalog rejection report?
settlement_basis and other settlement related information are provided by the collector; Please understand that the values shared on the network are part of transactional level contract. "delivery" as settlement basis means settlement will be initiated by you (BNP) once the order is delivered
Are both types of tracking supported? GPS and URL based?

@ep-aws

ep-aws commented 4 months ago

Dear Sandeep,

Currently, we have not implemented any catalog rejection report. Could you please share the format of the report or any reference documents?

Yes, we have integrated both the tracing module (GPS and URL-based).

On Tue, May 7, 2024 at 12:42 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Dear Sandeep, Please find my inline comments. Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response. /track - is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place. Flow 6 /update - update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR. @sandeep https://github.com/sandeep Shahi @.

> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP. … <#m-5050927498634053842> On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.> wrote: Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? /track - is tracking supported? Flow 6 /update - update call missing for Reverse QC request @ep-aws https://github.com/ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier. — Reply to this email directly, view it on GitHub <#1268 (comment) https://github.com/ONDC-Official/v1.2.0-logs/issues/1268#issuecomment-2092487920>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***> -- Thanks & Regard, Jay Mehta Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in Mobile: 9033891671 -- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

Buyer app must respond with a NACK if there are issues in the schema or provide a catalog rejection report to the seller app. Have you implemented the catalog rejection report?

settlement_basis and other settlement related information are provided by the collector; Please understand that the values shared on the network are part of transactional level contract. "delivery" as settlement basis means settlement will be initiated by you (BNP) once the order is delivered

Are both types of tracking supported? GPS and URL based?

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1268#issuecomment-2097603055, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGEWZSTUTUGGJH6NXBTZBB5FZAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGYYDGMBVGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regard,

Jay Mehta

Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in

Mobile: 9033891671

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

sandeepshahi commented 4 months ago

Here is the catalog rejection report framework doc: https://docs.google.com/document/d/1y_kBhwSwyN2D39VucTtqEQdp7WSEGYMg/edit

@ep-aws

ep-aws commented 4 months ago

@Sandeep Shahi, from where this catalog rejection appears suddenly? Does all the BAP went live recently have implemented this? If not then why we were being blocked to go-live? Are we practicing selective approach here?

@Rohit Garg / @Neeraj Jain , Please help to move to next stage.

From: 'Sandeep Shahi' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" @.> Date: Tuesday, 7 May 2024 at 12:42 PM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

Dear Sandeep, Please find my inline comments. Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response. /track - is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place. Flow 6 /update - update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR. @sandeep Shahi @.> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP. … On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.> wrote: Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? /track - is tracking supported? Flow 6 /update - update call missing for Reverse QC request @ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier. — Reply to this email directly, view it on GitHub <#1268 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***> -- Thanks & Regard, Jay Mehta Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in Mobile: 9033891671 -- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects. Buyer app must respond with a NACK if there are issues in the schema or provide a catalog rejection report to the seller app. Have you implemented the catalog rejection report? settlement_basis and other settlement related information are provided by the collector; Please understand that the values shared on the network are part of transactional level contract. "delivery" as settlement basis means settlement will be initiated by you (BNP) once the order is delivered Are both types of tracking supported? GPS and URL based? @ep-aws

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 4 months ago

HI Vijay

Although it is a mandatory requirement it won't be a blocker for you to move to prod.

Thanks,

Regards

On Tue, 7 May 2024 at 17:09, Vijay Yadav @.***> wrote:

@Sandeep Shahi @.***>, from where this catalog rejection appears suddenly? Does all the BAP went live recently have implemented this? If not then why we were being blocked to go-live? Are we practicing selective approach here?

@Rohit Garg @.> / @Neeraj Jain @.> , Please help to move to next stage.

From: 'Sandeep Shahi' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" < @.> Date: Tuesday, 7 May 2024 at 12:42 PM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.**> Subject: *Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

Dear Sandeep, Please find my inline comments. Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response. /track - is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place. Flow 6 /update - update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR. @sandeep https://github.com/sandeep Shahi @.> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP.

…On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.> wrote: Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? /track - is tracking supported? Flow 6 /update - update call missing for Reverse QC request @ep-aws https://github.com/ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier. — Reply to this email directly, view it on GitHub <#1268 (comment) https://github.com/ONDC-Official/v1.2.0-logs/issues/1268#issuecomment-2092487920>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***> -- Thanks & Regard, Jay Mehta Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in Mobile: 9033891671 -- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

Buyer app must respond with a NACK if there are issues in the schema or provide a catalog rejection report to the seller app. Have you implemented the catalog rejection report?

settlement_basis and other settlement related information are provided by the collector; Please understand that the values shared on the network are part of transactional level contract. "delivery" as settlement basis means settlement will be initiated by you (BNP) once the order is delivered

Are both types of tracking supported? GPS and URL based?

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1268#issuecomment-2097603055, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGEWZSTUTUGGJH6NXBTZBB5FZAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGYYDGMBVGU . You are receiving this because you were mentioned.Message ID: @.***>

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 4 months ago

Noted. Thanks

@Sandeep Shahi , Request your consideration.

Regards,

Vijay

From: Neeraj Jain @.> Date: Thursday, 9 May 2024 at 6:03 AM To: Vijay Yadav @.> Cc: "ONDC-Official/v1.2.0-logs" @.>, "ONDC-Official/v1.2.0-logs" @.>, Sandeep Shahi @.>, Rohit Garg @.>, ep-aws @.>, Mention @.> Subject: Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

HI Vijay

Although it is a mandatory requirement it won't be a blocker for you to move to prod.

Thanks,

Regards

On Tue, 7 May 2024 at 17:09, Vijay Yadav @.***> wrote:

@Sandeep Shahi, from where this catalog rejection appears suddenly? Does all the BAP went live recently have implemented this? If not then why we were being blocked to go-live? Are we practicing selective approach here?

@Rohit Garg / @Neeraj Jain , Please help to move to next stage.

From: 'Sandeep Shahi' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" @.> Date: Tuesday, 7 May 2024 at 12:42 PM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

Dear Sandeep, Please find my inline comments. Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search ->Seller NP issue - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?->Yes Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? ->We are sending this because we received it in the on_init response. /track - is tracking supported? - Seller is not provided. If the seller supports tracking, we would have a tracking API in place. Flow 6 /update - update call missing for Reverse QC request ->.We have the log, but some of it is missing from this PR. We will update it in the next PR. @sandeep Shahi @.> Please suggest the next step. If you prefer, we can resubmit flow 1 with a different NP. … On Fri, May 3, 2024 at 1:20 PM 'Sandeep Shahi' via Easy Pay AWS < @.> wrote: Flow 1 - are variants supported? path of variant grouping attribute seems to be incorrect in /on_search - while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Flow 2 /confirm - settlement_basis is mentioned as "delivery"; is this intended? /track - is tracking supported? Flow 6 /update - update call missing for Reverse QC request @ep-aws https://github.com/ep-aws, please answer the mentioned queries and also the questions raised earlier. — Reply to this email directly, view it on GitHub <#1268 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGBB34LZILT7DRTMZ6DZAM6UTAVCNFSM6AAAAABFT7R27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ4DOOJSGA . You are receiving this because you were mentioned.Message ID: @.***> -- Thanks & Regard, Jay Mehta Easy Pay Pvt. Ltd. Panchshil Tech Park 1, Yerwada, Pune 411006, India. www.easypay.in Mobile: 9033891671 -- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects. Buyer app must respond with a NACK if there are issues in the schema or provide a catalog rejection report to the seller app. Have you implemented the catalog rejection report? settlement_basis and other settlement related information are provided by the collector; Please understand that the values shared on the network are part of transactional level contract. "delivery" as settlement basis means settlement will be initiated by you (BNP) once the order is delivered Are both types of tracking supported? GPS and URL based? @ep-aws

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

DISCLAIMER

———————-

The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 3 days ago

Hi Farheen,

The observations you have mentioned below are coming for seller app. How buyer app will fix this?

Regards,

Vijay

From: 'FarheenNazQA' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" @.> Date: Monday, 16 September 2024 at 7:17 PM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

RET-14 Flow-01 On_search radius should be under 500 km range in the bpp/providers/locations location days should be in sequence not random in the bpp/providers/locations fulfillments which are not present in bpp/provider should not be present in bpp/fulfillments RET-15 Flow-01 On_search radius should be under 500 km range in the bpp/providers/locations fulfillments which are not present in bpp/provider should not be present in bpp/fulfillments — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

FarheenNazQA commented 3 days ago

Please Note -**Buyer should send 'NACK' for the following :** RET-14

Flow-01

On_search

radius should be under 500 km range in the bpp/providers/locations location days should be in sequence not random in the bpp/providers/locations fulfillments which are not present in bpp/provider should not be present in bpp/fulfillments

RET-15

Flow-01

On_search

radius should be under 500 km range in the bpp/providers/locations fulfillments which are not present in bpp/provider should not be present in bpp/fulfillments

sorry for the miss. @ep-aws

ep-aws commented 3 days ago

Then you will reject it again because it’s just “NACK”

My point here is, these details coming from seller app , how we can fix sellers things? And why such sellers are there on prod? And if it is working fine in production for them then why buyer app logs are getting rejected for issue from sellers side?

From: 'FarheenNazQA' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" @.> Date: Monday, 16 September 2024 at 7:36 PM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easypay BA - compliance check (Issue #1268)

Please Note -Buyer should send 'NACK' for the following : RET-14

Flow-01

On_search

radius should be under 500 km range in the bpp/providers/locations location days should be in sequence not random in the bpp/providers/locations fulfillments which are not present in bpp/provider should not be present in bpp/fulfillments

RET-15

Flow-01

On_search

radius should be under 500 km range in the bpp/providers/locations fulfillments which are not present in bpp/provider should not be present in bpp/fulfillments

sorry for the miss. @ep-aws

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ONDC-Official / v1.2.0-logs

Easypay BA - compliance check #1268

Flow 2

confirm

on_status (packed)

Flow 5

Flow 6

Flow 2

select

Please use the search and on_search provided in flow 1 in rest of the flows

Flow 6-a

on_update

Flow 6-c

update

Flow 6-b

Update settlement missing

Please test with a verified seller app in preprod

Flow 1

Flow 2

Flow 3

Flow 4

Flow 5

Flow 6

- BNP must validate each incoming request and issue a proper NACK in case of failures

- Please fix all the issues and submit a demo video of the app along with the logs

Flow 1

Flow 2

Flow 6

Flow-01

On_search

Flow-01

On_search

Flow-01

On_search

Flow-01

On_search