Ref-Buyer (RET10, RET11, RET12) - compliance check

[sandeepshahi]

Full Catalog Pull

/on_search

• short_desc, long_desc in bpp/descriptor and bpp/providers/descriptor can't be empty
• images in bpp/descriptor and bpp/providers/descriptor should have valid urls
• attributes for split timings (frequency and times) should not be present in case of fixed timing
• same attribute should not be repeated for a particular variant group
• invalid variant groups; different variant groups with same id should not be created
• mapping of statutory reqs and categories should be correct; statutory reqs for prepackaged food is not required in case of "Oil & Ghee" & "Masala & Seasoning"
• code should be either of veg/non_veg/egg in /items/tags (code: "veg_nonveg") with value always set to yes
• fulfillment_id in /items should be one of the valid fulfillment ids in /bpp/fulfillments
• serviceability in /bpp/providers/tags should be defined for each subcategory
• valid value and unit should be provided for serviceability of type "12" as per the serviceability construct
• enums for setting customization group as default for a customization are "yes"/"no" (lowercase)
• enums of attributes values in RET-12 should be in lowercase or as defined in the suggestive enum list
• quantity/available/count>= quantity/maximum/count
• category in serviceability construct should consist of the relevant subcategory as per the domain

Incremental Pull

/search

• Invalid incremental pull; for 1-time incremental refresh start_time < context/timestamp, end_time < context/timestamp & end_time > start_time

/on_search (store closed temporarily)

• range/end is not in valid RFC3339 UTC format
• time/timestamp <= context/timestamp

/select

• end/location is outside the serviceability area of the seller; should be handled by buyer app
• /created_at is not a valid attribute

/on_select

• @ondc/org/category should be a valid fulfillment category
• provider_id is not a valid attribute in /fulfillments
• @ondc/org/TAT can't be smaller than max(time_to_ship) in /on_search
• quote/price/value should be string
• "@ondc/org/item_id" missing for delivery line item in quote/breakup
• fulfillment_id in /items should be a valid id present in /fulfillments
• @ondc/org/provider_name in /fulfillments does not match with provider name in /on_search catalog

/init

• door is invalid attribute in /billing
• invalid value of building in /billing
• items/fulfillment_id is missing

/confirm

• bap_terms are missing in /tags
• payment/type can't change in /confirm; should be ON-ORDER as per /on_init
• @ondc/org/buyer_app_finder_fee_type enum value should be "percent" (in lowercase)
• payment/transaction_id can't be the same as context/transaction_id; should not be present in case type= ON-FULFILLMENT
• items/fulfillment_id is missing
• all the payment related attributes in /on_init should be present in /confirm

/on_confirm

• estimated pickup and delivery time ranges can't be past dated
• order/updated_at should be updated
• PCC/DCC values in start and end in /fulfillments should have valid value as per the code

@wemakshaychavan

[sandeepshahi]

Buyer App Issues:

inc_search

• context/city should be "*"
• context/timestamp of /on_search callback can't be past dated (should be in UTC format with no offset)

/select

• context/city must match the city for fulfillments/end/location

Seller App Issues:

Catalog

• custom groups at the same level can share the same sequence, defined in /categories
• bpp/providers/category_id property is not required
• locations/gps must have atleast 6 digits of decimal precision
• display sequence of items in a custom menu should be unique; multiple items can't have the same display sequence, as defined in /items/category_ids
• attributes like "symbol", "short_desc", "long_desc" in /descriptor are not required for type=customization
• one of the customizations in a custom_group must be set as default where min=1
• related = true can be used for customizations that do not need to be shown as standalone SKUs

/on_select

• delivery TAT (/fulfillments/@ondc/org/TAT) can't be equal to the time_to_ship defined in the catalog

@wemakshaychavan

[sandeepshahi]

inc_search

• context/city should be "*"

/select

• context/city must match the city for fulfillments/end/location

Seller App Issues:

inc_on_search

• 1 time incremental pull can only have solicited callback response; multiple callback responses should not be provided

/on_search

• custom groups at the same level can share the same sequence, defined in /categories
• bpp/providers/category_id property is not required
• display sequence of items in a custom menu should be unique; multiple items can't have the same display sequence, as defined in /items/category_ids
• attributes like "symbol", "short_desc", "long_desc" in /descriptor are not required for type=customization

/on_select

• delivery TAT can't be the same as max(time_to_ship)
• error.message (in OOS case) should be in stringified json format as mentioned in the contract

/on_init

• invalid attribute "discount" in /items

/on_confirm

• incorrect gps coordinates of store in /fulfillments/start/gps

@wemakshaychavan

[shubhamuengage]

on_select

delivery tat is same as time_to_ship because this merchant is doing self delivery therefore its time to ship and delivery tat will be same

@bluecypher

[shubhamuengage]

@bluecypher in on_select regarding oos whats the issue i am unable to understand.

[sandeepshahi]

@shubhamuengage

• delivery TAT and time_to_ship can't be same, even in the case of self-delivery
• For MTO orders with customizations, the error message for OOS scenario must be in JSON stringified format as mentioned in the contract e.g., “[{dynamic_item_id:DI1,item_id:I1}, {dynamic_item_id:DI2,customization_id:C15,customization_group_id:CG3}]" where base item "I1" for dynamic item "DI1" and customization "C15" for dynamic item "DI2" are both out of stock

[sandeepshahi]

Reference Buyer App

/search

• /on_search callback response is taking longer than the ttl; buyer app must repspond with a NACK

/confirm

• invalid tax_number in bpp_terms; should be the same as provided by the seller app
• payment/params/transaction_id can't be the same as context/transaction_id

/update

• buyer initiated part cancellation should be disabled

/cancel

• 012 is not a valid buyer initiated cancellation reason id
• message/descriptor is only required for a specific fulfillment cancellation (optional if the entire order is being cancelled)

Krenai Seller App

/on_search

• geocoding of store gps and area_code is inaccurate
• bpp/fulfillments must be present as part of phase 1 (until deprecated)
• invalid value of fulfillment_id in /items (must be mapped with the bpp/fulfillments and /bpp/providers/fulfillments)
• "net_quantity_or_measure_of_commodity_in_pkg", "imported_product_country_of_origin" are not required
• "month_year_of_manufacture_packing_import" must be in the correct format
• invalid value of location id in timing in /tags

/on_select

• Self-Pickup fulfillment type is not a part of phase 1; also missing from the catalog
• many invalid attributes in /items (refer API contract for the required attributes)
• quote.price.value = Σ quote line items, i.e., quote.breakup[].price.value; (Self pickup is not a part of phase 1)

/on_init

• all the invalid attributed must be removed from the payload
• fulfillments/start is not required
• invalid value of settlement_basis (refer API contract for the enums)
• cancellation terms are not a part of phase 1;
• spell errors in attributes of bpp_terms; (only tax_number is in phase 1)

/on_confirm

• estimated time range must be feasible and realistic

/on_status

• "settlement_timestamp" in /@ondc/org/settlement_details should be provided when actual settlement takes place as per the settlement_basis
• all the forward shipment related status calls must be provided
• estimated pickup/delivery time range must be feasible and realistic

/on_update

• invalid object of refund settlement in Return_Initiated state
• actual pickup and delivery timestamps can't be the same for forward shipment in /fulfillments/0

/on_cancel

• cancellation reason id must be provided in /cancellation for entire order cancellation (tags deprecated)
• fulfillment state must be "Cancelled" (instead of Pending)
• quote_trail is missing in /fulfillments
• quote.price.value = Σ quote line items, i.e. quote.breakup[].price.value;

@wemakshaychavan

[sandeepshahi]

several issues in the seller app; pls test with their latest build.

Flow 1

/on_search

• values of colour attributes are invalid (either empty values or hex value without "#"); variant groups are defined based on the size and colour attributes. How is the catalog processed?
• context/city STD code mismatches with store's area_code

Flow 2

/select

• city/code must map with the delivery location (/fulfillments/end/location)

/on_init

• invalid settlement terms (settlement_basis, settlement_window, withholding_amount ) provided; should be provided by collector (BNP here)

/track

• tracking is set as false and no tracking info is provided in /on_status;

Flow 3

/select1

• items out of stock should not be allowed to select again

Flow 6

/on_update

• invalid schema; quote/price should be in string format; BNP must respond with a NACK

@wemakshaychavan

[BLR-0118]

RET10 logs:

1. Pls check issues reported here for flows 2, 4 & 5 for Kiko Live;
2. from the above, these issues need to be fixed: uniqueness check for message_id, invalid keys;
3. for Flow 6, in /updatep1 & /updatep2, refund will be using same mode of payment as used by the buyer for placing the order; I hope we're not hardcoding anything here

[BLR-0118]

@wemakshaychavan - pls check the above

[BLR-0118]

RET12 logs:

• pls check issues raised here, specific for return responses (on_update_R3, on_update_R4);

[BLR-0118]

@wemakshaychavan

[BLR-0118]

RET11

1. Flow 5 /on_cancel* is invalid (communicated to Uengage); are we NACK'ing this?
2. Flow 6 /update is invalid - for make-to-order items, you need to send the item & customization(s) in same return request;
3. Are we enforcing min/max for nested customizations e.g. in flow 2, customization 2455698/2455705 have nested customization groups 128078 / 128074 / 128075 / 128076 / 128068 - min is 0 for all (flow 2 is thus ok), but if min is 1 for one or more of these, are we forcing buyer to select the min no of customizations?

[BLR-0118]

@wemakshaychavan - pls check above for RET11

[BLR-0118]

RET13

1. /on_search:
   • unitized qty for item ENGFLFRPKT18 should be "18 ml" but is blank; what are we showing?

[BLR-0118]

@wemakshaychavan - pls see comment for RET13 above

[BLR-0118]

@wemakshaychavan - as discussed today morning, pls respond to issues raised above for RET10/11/12

[wemakshaychavan]

RET:10

Flow 1 /on_search

values of colour attributes are invalid (either empty values or hex value without "#"); variant groups are defined based on the size and colour attributes. How is the catalog processed? - Adding this as a validation where we do not get color with # then will send NACK. context/city STD code mismatches with store's area_code - Fixed Flow 2 /select

city/code must map with the delivery location (/fulfillments/end/location) - Fixed /on_init

invalid settlement terms (settlement_basis, settlement_window, withholding_amount ) provided; should be provided by collector (BNP here) /track inprogress

tracking is set as false and no tracking info is provided in /on_status; Flow 3 /select1 seller had updated qty during log generation

items out of stock should not be allowed to be selected again Flow 6 /on_update fixed

invalid schema; quote/price should be in string format; BNP must respond with a NACK

[wemakshaychavan]

RET:11

Flow 5 /on_cancel* is invalid (communicated to Uengage); are we NACK'ing this? We are sending NACK Flow 6 /update is invalid - for make-to-order items, you need to send the item & customization(s) in same return request; Please share the valid sample request for the same @BLR-0118 Are we enforcing min/max for nested customizations e.g. in flow 2, customization 2455698/2455705 have nested customization groups 128078 / 128074 / 128075 / 128076 / 128068 - min is 0 for all (flow 2 is thus ok), but if min is 1 for one or more of these, are we forcing buyer to select the min no of customizations? Yes

[wemakshaychavan]

RET12:

quote.price.value should be string (strange that's wrong only here); Fixed quote entries are incorrect: quote.price.value should be "4000", quote.breakup[] has 2 entries for item "7803924_L" for qty 2 & 1 (not sure why the qty 1 entry is here as that was part cancelled earlier); Adding this as a part of validation