Sabhyasha (SA) - compliance check

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• STD code does not match with correct area_code on /on_search
• accept_bap_terms is not required in bpp/descriptor/tags as part of phase 1
• collect_payment is not required in bpp/descriptor/tags as part of phase 1
• mandatory attributes should be provided as per the sheet https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=2063907654

search_inc

• Transaction logs should be provided

on_search_inc

• Transaction logs should be provided

Flow 2

on_select

• context/timestamp difference between /on_select and /select should be less than 5 sec (why its taking more than 20 seconds)
• invalid quote breakup

on_init

• /message/order must have required property 'tags'
• /message/order/payment must have required property '@ondc/org/buyer_app_finder_fee_type'
• /message/order/payment must have required property '@ondc/org/buyer_app_finder_fee_amount'
• /message/order/payment must have required property '@ondc/org/settlement_details'
• Buyer app finder fee can't change in /on_init
• Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

confirm

• /message/order/tags/0/list/0 must have required property 'value'

on_status

• Settlements missing

Flow 3

Same as above

on_select (out-of-stock)

• error/message should be as per the API contract

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

Flow 4

Same as above

on_cancel

• /message/order/fulfillments/0/start/time must have required property 'range'
• /message/order/fulfillments/0/end/time must have required property 'range'
• /message/order/payment must have required property '@ondc/org/settlement_details'
• Item count should be 0 for /on_cancel in forward shipment
• billing issues
  • Key 'created_at' mismatch: 2024-03-29T14:35:39.284Z !== 2024-03-29T14:36:07.000Z when compared with init billing object
  • Key 'updated_at' mismatch: 2024-03-29T14:35:39.284Z !== 2024-03-29T14:36:07.000Z when compared with init billing object
• Tags are mandatory for on_cancel on cancelled state for fulfillment type delivery
• Initiated_by is mandatory field for on_cancel

Flow 5

Same as above

Flow 6

• Partial Cancellation, Reverse-QC, Liquidation should be done within an single order

Note

• Kindly do check your logs using log-validation-utility https://github.com/ONDC-Official/log-validation-utility

  @SatyaranjanSwain

[SatyaranjanSwain]

Why I am not getting these errors while testing with the log validation utility? @sahil-ondc

[SatyaranjanSwain]

I have one doubt regarding the catalog, in incremental search if we didn't find any change by any seller... Do we need to pass NACK or a proper response with an empty node? @sahil-ondc

[SatyaranjanSwain]

In flow 6, is liquidation mandatory to be there? @sahil-ondc @sandeepshahi

[Jagannath-wits]

Sabhyasha: RET: 16

Flow 1

On Search Full Catalog Refresh

• bpp/providers[0]/items[0]/descriptor/code code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
• prvdr0item0ff fulfillment_id in /bpp/providers[0]/items[0] should map to one of the fulfillments id in bpp/prvdr0/fulfillments

On Search Inc Refresh

• schemaErr0 /context/action must be equal to constant (on_search)
• prvdr0item0ff fulfillment_id in /bpp/providers[0]/items[0] should map to one of the fulfillments id in bpp/prvdr0/fulfillments

Flow 2

On Select

• schemaErr0 /message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places
• priceErr Warning: Quoted Price in /on_select INR 2420 does not match with the total price of items in /select INR 1536 i.e price for the item id: 13 and 16 mismatch in on_search and on_select

On Init

• schemaErr0 /message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places
• schemaErr2 /message/order/payment must have required property '@ondc/org/settlement_details'
• quoteErr0 Mismatch found for item with item_id 13 while comparing quote object of on_select and on_init
• quoteErr1 Mismatch found for item with item_id 16 while comparing quote object of on_select and on_init

Confirm

• Same as above
• message.order.tags[0].list Pan_id shouldn't be same in tax_number and provider_tax_number in message.order.tags[0].list
• message/order/tags/bpp_terms List of bpp_terms mismatched in message/order/tags/bpp_terms for on_init and on_confirm here Code 'accept_bap_terms' present in first list but not in second list.

On Confirm

• Same as above

Flow 3

On Select Out of Stock

• schemaErr0 /message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places

Flow 4

On Cancel

• schemaErr0 /message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places
• schemaErr1 /message/order/payment must have required property '@ondc/org/settlement_details'
• on_cancel_msgId Message Ids for /cancel and /on_cancel api should be same
• itemCount Total item count in message/order/items doesn't match with item count of /on_select
• invldQuotePrices item quote breakup prices for on_cancel should be equal to the total price.
• Fulfillment_mismatch The count of cancellation fulfillments is not equal to the count of forward fulfillments or invalid fulfillment id.
• missingCancel Cancel fulfillment object is mandatory for on_cancel
• missingPreCancel Pre Cancel is mandatory for on_cancel

Flow 5

On Cancel

• schemaErr0 /message/order/fulfillments/0/tags/1/code must be equal to one of the allowed values (cancel_request,igm_request,precancel_state,quote_trail,routing,tracking)
• schemaErr1 /message/order/fulfillments/0/tags/1/list/2/code must be equal to one of the allowed values (reason_id,initiated_by,fulfillment_state,updated_at,retry_count,rto_id,id,currency,value,type,gps_enabled,url_enabled,url)
• schemaErr2 /message/order/fulfillments/1 must have required property 'tags'
• schemaErr3 /message/order/fulfillments/1/ must have required property 'end'
• schemaErr4 /message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places
• schemaErr5 /message/order/quote/breakup/3 must have required property 'title'
• schemaErr6 /message/order/payment must have required property '@ondc/org/settlement_details'
• itemCount Total item count in message/order/items doesn't match with item count of /on_select
• Fulfillment_mismatch The count of cancellation fulfillments is not equal to the count of forward fulfillments or invalid fulfillment id.
• ffID mp2_immediate_f1 fulfillment id mp2_immediate_f1 does not exist in /on_cancel items.fulfillment_id
• ffID mp2_immediate_f1-RTO fulfillment id mp2_immediate_f1-RTO does not exist in /on_cancel items.fulfillment_id
• RTOfulfillment.end RTO fulfillment end object is missing in on_cancel
• RTO.start.location/DeliveryFulfillment.end.location RTO fulfillment start or Delivery fulfillment end location is missing in on_cancel
• RTO.end.location/DeliveryFulfillment.start.location RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel
• missingCancelRequest Cancel Request is mandatory for on_cancel in fulfillment type delivery
• precancelState.updatedAt precancel_state.updated_at of on_cancel is not equal with the on_status_out_for_delivery order.updated_at
• missingReasonID Reason ID is mandatory field for on_cancel
• missingInitiatedBy Initiated_by is mandatory field for on_cancel

Flow 6

On Update Part Cancel

• invldQuotePrices Item quote breakup prices for /on_update_part_cancel should be equal to the net price.
• Delivery.start.location.id Delivery fulfillment start location id is missing in on_update_part_cancel
• invalid_partcancel_return_request_reason reason code allowed are 002,012

On Status Pending

• city City code mismatch in /search and /on_status

On Status Packed

• message/order.fulfillments/0 Mismatch occured while comparing 'Cancel' fulfillment object with on_update_part_cancel

On Status Picked

• missingTags Tags are mandatory in Delivery Object for on_status_picked
• message/order.fulfillments/0 Mismatch occured while comparing 'Cancel' fulfillment object with on_update_part_cancel

On Status Out for Delivery

• Same as above

On Status Delivered

• Same as above

On Update Interim Reverse QC

• invldQuotePrices Item quote breakup prices for /on_update_interim_reverse_qc should be equal to the net price.
• message/order.fulfillments/Cancel/tags/quote_trail Missing fulfillments/Cancel/tags/quote_trail as compare to the previous calls
• invalid_initiated_by initiated_by should be buyer-app-preprod-v2.ondc.org

On Update Approval

• invldQuotePrices Item quote breakup prices for /on_update_approval should be equal to the net price.
• Delivery.start.location.id Delivery fulfillment start location id is missing in on_update_approval
• message/order.fulfillments/Cancel Fulfillments/Cancel is missing in on_update_approval
• invalid_initiated_by initiated_by should be buyer-app-preprod-v2.ondc.org

On Update Picked

Same as above

Update Settlement Reverse QC

• update_settlement_reverse_qc_msgId Message id should not be same with previous calls

On Update Delivered

same as above

@SatyaranjanSwain

[SatyaranjanSwain]

On Search Full Catalog Refresh

• bpp/providers[0]/items[0]/descriptor/code code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code - What should be the value of GTIN and what is it?

@Jagannath-wits @sahil-ondc @sandeepshahi

[SatyaranjanSwain]

So as of now, we have not enabled this GTIN. Can we provide 4-HSN in the item->descriptor->code(but it will not be unique as many of the items could belong to the same category? Please suggest.

@Jagannath-wits

[Jagannath-wits]

On Search Full Catalog Refresh

• bpp/providers[0]/items[0]/descriptor/code code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code - What should be the value of GTIN and what is it?

@Jagannath-wits @sahil-ondc @sandeepshahi

Ok you can use the previous key of 5:others as you're selling handmade items

[SatyaranjanSwain]

Okay, thanks for the clarification.

@Jagannath-wits

[Jagannath-wits]

Sabhyasha RET 16

Flow 1

On Search Full Catalog Refresh

• Timestamp Difference: Context timestamp difference between /on_search and /search should be less than 5 seconds.

Flow 2

On Select

• Timestamp Difference: Context timestamp difference between /on_select and /select should be less than 5 seconds.
• Price Error: Warning: Quoted Price in /on_select INR 2420 does not match with the total price of items in /select INR 1536. Consider the base value instead of maximum_price for item IDs "13" and "16".

On Status Packed

• JSON File Similarity: on_status_packed is exactly similar to on_status_pending.
• Order State: Order state should be "In-progress" for /on_status_packed.

On Status Picked

• Missing Routing Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_picked.

On Status Out For Delivery

• Missing Routing Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_out_for_delivery.

On Status Delivered

• Missing Routing Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_delivered.

Flow 4

On Cancel

• Invalid Quote Trail Prices: Quote trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm. The discount object is missing in the quote trail.

Invalid Schema

Schema Error: Why was there a schema error i.e., a comma , wasn’t there? Was this handled manually?

Flow 5

On Select

• Price Error: Warning: Quoted Price in /on_select INR 1000 does not match with the total price of items in /select INR 600. Consider the base value instead of maximum_price for item ID "16".

On Status Picked

• Missing Routing Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_picked.

On Status Out For Delivery

• Missing Routing Tag: RoutingTag object is mandatory in Tags of Delivery Object for on_status_out_for_delivery.

On Cancel

• Discount object should be added in quote trail as well as the sum of quote and quote trail would always be equal to quote price of on_confirm

Flow 6

On Select

• Price Error: Warning: Quoted Price in /on_select INR 2000 does not match with the total price of items in /select INR 1200. Consider the base value instead of maximum_price for item IDs "16" and "64".

On Update Interim Reverse QC

• Settlement Details Missing: Missing payment/@ondc/org/settlement_details as compared to update_settlement_part_cancel.

On Update Approval

• Invalid Quote Prices: Item quote breakup prices for /on_update_approval should be equal to the net price.
• Settlement Details Missing: Missing payment/@ondc/org/settlement_details as compared to update_settlement_part_cancel.

On Update Picked

= Same as above Return fulfillment missing quote trail

On Update Delivered

• Schema Error: /message/order/payment must have the required property @ondc/org/settlement_details.
• Invalid Quote Prices: Item quote breakup prices for /on_update_approval should be equal to the net price.

Note :

• The price error and quote error were raised previously as well; Please fix previously mentioned errors before reiteration to reduce time for each iteration. If there are any doubts you can ask here.
• Also If the logs were manually handled It is not allowed.

@SatyaranjanSwain

[Jagannath-wits]

Flow 1

on_search_full_catalog_refresh

• bpp/providers[0]/items[0]/descriptor/code: "code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code Or as per you requested to use 4:HSN, why you are not using that?"
• categoriesErr: "variants are not captured correctly in items, parent_item_id should be mapped with variants
• long_desc: "Why the html tag <p> is being is used in long_desc in the items"

on_search_inc

• bpp/providers[0]/items[0]/descriptor/code: "Why the descriptor.code type different i.e others for the item_id: 13"

Flow 2

on_status_picked

• invoice: "Invoice should be provided and publicly accessible"

Flow 5

on_cancel

• rtoFFObj/end/time: "fulfillment type rto end/time should not be present in /on_cancel when state/desc/code is RTO-Initiated” Please provide on_status_rto_delivered or rto_disposed with updated end.timstamp of return fulfillment.

Flow 6

on_status_picked:

– invoice missing and should be updated after part-cancel as well.

on_update_interim_reverse_qc

• returnFulfillment/id: "Mismatch occur between the fulfillment Id of on_update_interim_reverse_qc R1 and fulfillment Id of update_reverse_qc 66606014a4c0e402f41ff48c"

on_update_approval

• returnFulfillment/id: "Mismatch occur between the fulfillment Id of on_update_approval R1 and fulfillment Id of update_reverse_qc 66606014a4c0e402f41ff48c"
• Return.end.location: "Return fulfillment end location object is missing in on_update_approval"
• Return.start.location: "Return fulfillment start location object is missing in on_update_approval"
• returnFF/start/time/range/start: "start/time/range/start time of return fulfillment should be greater than context/timestamp of on_update_approval"
• returnFF/start/time/range/end: "start/time/range/end time of return fulfillment should be greater than context/timestamp of on_update_approval"

on_update_picked

• returnFulfillment/id: "Mismatch occur between the fulfillment Id of on_update_picked R1 and fulfillment Id of update_reverse_qc 66606014a4c0e402f41ff48c"
• message/order/items: "Forward fulfillment for the item_id '68' is missing!"
• Return.end.location: "Return fulfillment end location object is missing in on_update_picked"
• Return.start.location: "Return fulfillment start location object is missing in on_update_picked"
• invldQuoteTrailPrices: "quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm, quote_trail of item_id '68' is missing"

on_update_delivered

• Similar as above

@SatyaranjanSwain

[Jagannath-wits]

Flow 1

on_search

• Escape characters or formatting is not allowed at seller end and are not allowed in payload (repeated issue)
• Variants are not created correctly as there should be at least 2 items with the variants (repeated issue)
• @ondc/org/statutory_reqs_packaged_commodities missing in items

Flow 2

On_init

• Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount, @ondc/org/settlement_details are required in payment object as only buyer is collecting payment currently. In case seller wants to collect the payment then you can send it the way you sent but then it won't change in confirm call; right now payment is only accepted by buyer on network so the payment object in confirm is correct

on_status

• item/tags/type in items is not required for standalone SKUs (non-customizable)
• tracking in /tags should not be provided if tracking = "false"

Flow 4

On_cancel

• why are delivery fees still being charged even when the order is cancelled preshipment?

Flow 6

On_update_part_cancel

• Delivery_fulfillment.start.time.range missing.
• Delivery_fulfillment.end.time.range missing.

On_update_picked

• Return_fulfillment.end.time is not required

@SatyaranjanSwain

[sandeepshahi]

Flow 1

/on_search

• are attributes like brand/colour/material, item.descriptor.code and category_id hardcoded? all the SKUs seem to have the placeholder values
• can you share the screenshot of the onboarding journey for defining variants and setting variant group?
• descriptor/name should be meaningful for variant grouping in bpp/providers/categories

/on_search (inc)

• timestamp at item/time level should be updated to indicate the time of the event for the buyer apps to handle the race condition
• are all the scenarios of incremental catalog supported?

Flow 2

/on_select

• why is the delivery TAT provided as around 7 days for a nearby delivery location? Is it being sent by the logistics provider?

/on_confirm

• why is the "@ondc/org/provider_name" changing; is the logistics providers getting changed for the same txn?

/on_status

• why are the delivery/pickup time ranges not in sync with the TAT provided? TAT provided is of 7 days and 55 minutes while the order is getting delivered on the same day
• routing info should be provided on or before Agent assigned state;

Flow 5

/on_cancel

• estimated pickup/delivery time ranges should not change; must remain the same as provided earlier
• fulfillment state is incorrect in precancel_state; should be the as per the enums defined
• invalid quote/breakup line item for RTO delivery taxes; tags/quote must be provided to identify fulfillment level taxes

/on_status (RTO Delivered)

• similar issues as in /on_cancel
• all the tag objects must be provided for cancel_request

@SatyaranjanSwain, please answer the above queries and resolve the issues

[SatyaranjanSwain]

Flow 1

/on_search

• are attributes like brand/colour/material, item.descriptor.code and categoryid hardcoded? all the SKUs seem to have the placeholder values - No these are not hardcoded, whatever is present(recorded form the sellers) in the DB I am providing the same_.
• can you share the screenshot of the onboarding journey for defining variants and setting variant group? - Currently we are dealing with only handicraft items which doesn't have any variants. But there is a provision for implementing it as we will soon deal with other categories.
• descriptor/name should be meaningful for variant grouping in bpp/providers/categories - After variant implementation it will be made as asked.

/on_search (inc)

• timestamp at item/time level should be updated to indicate the time of the event for the buyer apps to handle the race condition - Will change it.
• are all the scenarios of incremental catalog supported? - Yes all are supported like start, stop and 1-time also.

Flow 2

/on_select

• why is the delivery TAT provided as around 7 days for a nearby delivery location? Is it being sent by the logistics provider? - No, this is not sent by the LSP(only sent the delivery time - 55m). It's the order preparation time(7d - in this case) that the seller defines while listing the item.

/on_confirm

• why is the "@ondc/org/providername" changing; is the logistics providers getting changed for the same txn? - **Will change it._**

/on_status

• why are the delivery/pickup time ranges not in sync with the TAT provided? TAT provided is of 7 days and 55 minutes while the order is getting delivered on the same day - For testing purpose only we are providing this value.
• routing info should be provided on or before Agent assigned state; - Will change it.

Flow 5

/on_cancel

• estimated pickup/delivery time ranges should not change; must remain the same as provided earlier - Will change it.
• fulfillment state is incorrect in precancelstate; should be the as per the enums defined - **Will change it._**
• invalid quote/breakup line item for RTO delivery taxes; tags/quote must be provided to identify fulfillment level taxes - Will change it.

/on_status (RTO Delivered)

• similar issues as in /oncancel - **Will address this issue soon._**
• all the tag objects must be provided for cancelrequest - **Will address this issue soon._**

@sandeepshahi

[sandeepshahi]

@SatyaranjanSwain, please provide the ETA for implementation of variants.

[SatyaranjanSwain]

It will take 4-5 working days. @sandeepshahi