Nearshop (Buyer App) - Compliance Check

sahil-ondc commented 11 months ago

search_full_catalog_refresh

reverse geocoding of /message/intent/fulfillment/end/location/gps is invalid with provided area_code

on_search_inc_refresh

/message/catalog/bpp/providers/locations/time/label must be equal to one of the allowed values (enable,disable,close)
Message Id for /search_inc_refresh and /on_search_inc_refresh api should be same

on_select

Item's unit and total price mismatch for id: ded21392-1a41-11ee-8ddd-2bac5af1417f:MR8mcezPPQEA-r8EhP6UN9

init

reverse geocoding of /message/order/fulfillments/end/location/gps is invalid with provided area_code

@RonitKumarSinha

sahil-ondc commented 11 months ago

on_search_full_catalog_refresh

/message/catalog/bpp/providers/0/items/8/tags/2 must have required property 'list'
/message/catalog/bpp/providers/1/items/4/quantity/unitized/measure must have required property 'value'
value passed in serviceability tags should be same as passed in location/circle
invalid area_code as per the provided /message/catalog/bpp/providers/location

on_search_inc_refresh

there should be unique message_id when in search_inc catalog_inc mode is start/stop

select

bpp_id mismatch in on_search and select

init

invalid attributes lat, lng provided in /message/order/billing and /message/order/fulfillments

confirm

invalid settlement_bank_account_no provided in payment: "661505602069\","

track

bpp_id mismatch in confirm and track

@RonitKumarSinha

RonitKumarSinha commented 11 months ago

@sharmasahil0331 Please find latest PR link with fixes https://github.com/ONDC-Official/v1.2.0-logs/pull/245

sahil-ondc commented 10 months ago

search_inc_catalog

if tags/bap_terms/effective_date is getting updated then static_terms should have the old value and static_terms_new should have the new value

confirm

billing issues
- Key 'created_at' mismatch: 2023-12-08T05:45:44.284Z !== 2023-12-08T05:53:54.796Z
- Key 'updated_at' mismatch: 2023-12-08T05:45:44.284Z !== 2023-12-08T05:53:54.796Z
/message/order/tags should have bap_terms

@RonitKumarSinha

sahil-ondc commented 10 months ago

Flow 1

search_inc_catalog

/message/intent/tags/0 must be object

on_search_inc_catalog

Transaction Id for /search_inc_refresh and /on_search_inc_refresh api should be same

@RonitKumarSinha

sudhakara11 commented 10 months ago

Thank you @sahil-ondc for the quick review.

Good Day!

We will resolve Flow 1 incremental issues and can submit Flow 1 incremental search only?

Hoping Flow 2,3,4,5 accepted

Regards, Sudhakar G

sahil-ondc commented 9 months ago

Flow 1

search_inc

/message/intent/tags/list/start_time/value cannot be greater than or equal to /context/timestamp
message/intent/tags/list/end_time/value cannot be greater than /context/timestamp

@RonitKumarSinha

sahil-ondc commented 9 months ago

Flow 1

on_search_inc_refresh (buyer application should handle this validation)

The bpp/fulfillments sent in payload should not be part of /on_search_inc_refresh api.
The bpp/descriptor sent in payload should not be part of /on_search_inc_refresh api.
provider id: ab06292c-a206-4bcb-b270-f16e149be05e in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh

@RonitKumarSinha

RonitKumarSinha commented 9 months ago

@sahil-ondc @bluecypher Hello, We submitted the logs with an updated flow one 2 weeks ago, and they were merged and there is no comments. I hope everything is fine in all flows for buyer app.

sandeepshahi commented 9 months ago

Flow 1

/search (full catalog)

search full catalog should be initiated using search by city (not by fulfillment end location)

/on_search

serviceability is not defined for all the category_id in the catalog; BNP must not process the catalog and throw catalog_rejection report to SNP
invalid veg/non_veg categorization in the catalog; veg SKUs are marked as non-veg; share the latest logs;

/search (inc)

no on_search callback response provided

Flow 2

/select

if the catalog is cached, the txn id of search and select would be different
buyer location and seller location are same; please select a different location for verification

/confirm

invalid p/g link in payment/uri. Why is bpp_uri of SNP provided?

/on_confirm

SNP is changing order creation timestamp; How is this handled at BNP end?

/track

tracking must be supported

/status

status API must be supported

Flow 3

similar issues as above

Flow 4

are all the buyer related cancellation reason ids supported?

Flow 5

all the states of RTO must be supported; RTO must be initiated in /on_cancel and then subsequent status must be provided through /on_status

Flow 6

seller side part cancellation must be allowed by BNP
FYI /update call for refund info must be provided
How is return request for multiple items supported?

@RonitKumarSinha

sandeepshahi commented 8 months ago

Flow 1

/on_search

unitized measure is mentioned as 500 units for an item of 500gm;

Flow 2

/select

payment type should be inside payment object

/on_confirm

provider_tax_number can't be "undefined"; BNP must respond with a NACK

please answer the previously raised queries

Flow 6

/update (refund)

refund must be initiated after part cancellation by SNP
"settlement_amount" must be in string format

@RonitKumarSinha

RonitKumarSinha commented 8 months ago

@bluecypher we have submitted the logs last week (Retail Buyer app) with all the comments Fixes. We havent received any comments for new PR. Please review and update.

@sudhakara11

RonitKumarSinha commented 8 months ago

@sandeepshahi any update on this?

@sudhakara11

sahil-ondc commented 8 months ago

Flow 1

search_inc and on_search_inc

Transactional logs not provided

Flow 2

confirm

/message/order/id Should be alphanumeric upto 32 letters max

on_confirm

provider_tax_number can't be "undefined"; BNP must respond with a NACK

Flow 5 and 6

update

settlement_amount should be positive

@RonitKumarSinha

sudhakara11 commented 8 months ago

Dear Sahil,

Flow 1

search_inc and on_search_inc

Transactional logs not provided

Nearshop Comments:

In the last commit - we have received the feedback on search_full_catalog and on_search_full_catalog, that is resolved and updated the same. regarding search_inc it is already cleared.

Flow 2

confirm

/message/order/id Should be alphanumeric upto 32 letters max
Nearshop Comments:

Kindly recheck the order ID - it is alphanumeric and in standard UUID format

on_confirm

provider_tax_number can't be "undefined"; BNP must respond with a NACK

Nearshop Comments:

provider_tax_number - the issues is fixed from our side raised MR with the same, Please find the below screenshot with the fixed logs

Flow 5 and 6

update

settlement_amount should be positive

Nearshop Comments:

We will review this and provide an update

@RonitKumarSinha

RonitKumarSinha commented 8 months ago

@sahil-ondc We have gone through the comments provided by you and we have some queries commented above by @sudhakara11

Please have a look and update

RonitKumarSinha commented 8 months ago

@sandeepshahi @sahil-ondc Please clarify above mentioned comments by @sudhakara11

sandeepshahi commented 8 months ago

@RonitKumarSinha,

Please submit all the logs. Final clearance will be provided by Supriyo.
uuid format exceeds 32 characters. It's mentioned in the feedback.

RonitKumarSinha commented 8 months ago

@sandeepshahi Thanks... will submit the full flow for final clearance by supriyo

@sudhakara11

RonitKumarSinha commented 7 months ago

@sandeepshahi We have submitted the logs for final review by Mr. Supriyo. Please find the PR link below

https://github.com/ONDC-Official/v1.2.0-logs/pull/1143

@sudhakara11

sahil-ondc commented 7 months ago

Flow 4

on_cancel

/message/order/fulfillments/1/start must have required property 'location'
fulfillment type cancel is missing in /on_cancel

Note

Flow 4 should be related to buyer cancellation before pickup not RTO

Flow 6

on_update

@ondc/org/settlement_details" should be updated as per the refund trails, after any refund has been done for order BNP Should have validations

@RonitKumarSinha

sudhakara11 commented 7 months ago

@sandeepshahi We have submitted the logs for final review by Mr. Supriyo. Please find the PR link below

https://github.com/ONDC-Official/v1.2.0-logs/pull/1175

@RonitKumarSinha

sandeepshahi commented 7 months ago

@RonitKumarSinha, Refunds are still being initiated even before the refund triggering state is received from SNP as mentioned here: https://github.com/ONDC-Official/v1.2.0-logs/issues/133#issuecomment-1956132815

sandeepshahi commented 7 months ago

Flow 1

/search (inc)

push based incremental search may be supported (mode = start/stop)

/on_search (ACK)

why are the message id and city changed for sync response?

Flow 2

/select

txn id of select and select (OOS) must be same, being part of the same session

/on_status

Invalid length of PCC code in /fulfillments/start/instructions/short_desc (for code 2: max length should be of 6 digits)

@RonitKumarSinha, check these issues too

RonitKumarSinha commented 7 months ago

@sandeepshahi Please find Latest logs submission PR link

https://github.com/ONDC-Official/v1.2.0-logs/pull/1256

Flow 1 /search (inc) push based incremental search may be supported (mode = start/stop): Yes, Start/Stop mode we are supporting

/on_search (ACK) why are the message id and city changed for sync response? : This is from seller app side and we are using Chattybao seller which is already v1.2 verified

Flow 2 /select txn id of select and select (OOS) must be same, being part of the same session: Fixed

/on_status Invalid length of PCC code in /fulfillments/start/instructions/short_desc (for code 2: max length should be of 6 digits): This is from seller app side and we are using Chattybao seller which is already v1.2 verified

Flow 6: Fixed

Requesting you to please review and let us know as soon as possible

@sudhakara11

sandeepshahi commented 7 months ago

Please submit the logs for push based inc for verification.
ACK response is provided by the BNP upon receiving the on_search callback

@RonitKumarSinha

RonitKumarSinha commented 7 months ago

@sandeepshahi please find below link with updated logs PR

https://github.com/ONDC-Official/v1.2.0-logs/pull/1259

Please submit the logs for push based inc for verification. : Added ACK response is provided by the BNP upon receiving the on_search callback: Added

@sudhakara11

sudhakara11 commented 7 months ago

@sahil-ondc please find below link with updated logs PR ( merge conflicts resolved)

https://github.com/ONDC-Official/v1.2.0-logs/pull/1284

Please submit the logs for push based inc for verification. : Added ACK response is provided by the BNP upon receiving the on_search callback: Added

@RonitKumarSinha

RonitKumarSinha commented 7 months ago

@sandeepshahi

We have submitted the logs for final review on 03/04/2024 with above mentioned feedback received by you

https://github.com/ONDC-Official/v1.2.0-logs/issues/133#issuecomment-2031117579

PR LINK: https://github.com/ONDC-Official/v1.2.0-logs/pull/1284

Please let us know if the logs are okay, and we can move to 1.2, Thanks

@sudhakara11

RonitKumarSinha commented 7 months ago

PR LINK: https://github.com/ONDC-Official/v1.2.0-logs/pull/1284

@sandeepshahi Any update on submitted logs. Please let us know if the logs are okay, and we can move to 1.2, Thanks

@sudhakara11

sandeepshahi commented 7 months ago

@RonitKumarSinha, the logs seem fine. @BLR-0118 will be reviewing the logs and providing the final clearance.

RonitKumarSinha commented 6 months ago

@BLR-0118 Any update on submitted logs. Please let us know if the logs are okay, and we can move to 1.2, Thanks

@sudhakara11

BLR-0118 commented 6 months ago

pls clarify the following:

are you supporting incremental catalog push & pull?
while processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning?
is /select being called for every change in cart, with same transaction_id?
how are you processing callbacks (e.g. /on_select) received out of sequence?
while processing unsolicited callbacks, are you ensuring that each such callback response has unique message_id for a specific transaction_id?
have you enabled the /confirm & /on_confirm process flow as doc here?
validation of cancellation reason codes when initiated by SNP?
processing hyperlocal vs intercity fulfillment states using routing.type of "P2P" or "P2H2P";

@RonitKumarSinha:

pls clarify the above;
would be great if you can share a recorded demo;
if you need clarifications, we can have a call where you can also show the demo?

RonitKumarSinha commented 6 months ago

Hi @BLR-0118, Please find details below:

Are you supporting incremental catalog push & pull? Yes - We are supporting catalog push and pull incremental search, verified the search cases
While processing concurrent catalog updates (full, incremental), are you using the timestamp at provider / item level for correct versioning? Yes - To maintain correct versioning, we are doing catalog update based on the provider timestamp

3) is /select being called for every change in the cart, with the same transaction_id? Yes, we are maintaining the session with the same transaction_id

4) How are you processing callbacks (e.g. /on_select) received out of sequence? Init api will be called if the on_select provides ACK without any error, same way for other flows

5) While processing unsolicited callbacks, are you ensuring that each such callback response has unique message_id for a specific transaction_id? We are maintaining unique transaction_id for the transactions and have validations for the duplicated calls

6) Have you enabled the /confirm & /on_confirm process flow as doc here? Yes, we have covered all the mentioned points and retry check also been done for SNP internal server errors

7) Validation of cancellation reason codes when initiated by SNP? We have validations for the cancellation reason codes

8) Processing hyperlocal vs intercity fulfillment states using routing.type of "P2P" or "P2H2P"; We are supporting hyperlocal fulfillment states as per the API contracts

We will schedule a call to show the recorded demo by early next week.

@sudhakara11

RonitKumarSinha commented 6 months ago

Hi @BLR-0118 PFA Demo video URL below

https://drive.google.com/drive/folders/1eCXljBwNsq762MFD1yoyIJI0HPM-U9zV?usp=drive_link

We have given URL access to supriyo@ondc.org

@sudhakara11

BLR-0118 commented 6 months ago

@RonitKumarSinha - pls schedule a live demo this week for your buyer app;

BLR-0118 commented 5 months ago

logs verified, request QA to test before onboarding to beta prod;

ONDC-Official / v1.2.0-logs