Open sandeepshahi opened 4 months ago
@sandeepshahi , Have one question on the Flow 5:, ON_cancel. comment. If the seller wants to charge for foward delivery, misc and Packaging,. Then he does not need to add in quote trail ? Leave the positive value in quote and buyer apps will bear that cost as RTO with valid reason, is failure at buyerapp side. . Please let us know. . If this is acceptable, we dont need to add delivery & packaging to quote_trail.
@AnanthBo, Yes, if the RTO reason id is valid where the cost is attributed to BNP, then it's acceptable. But make sure, any adjustment in quote is reflected in the quote_trail.
@sandeepshahi , Also On the comment 1: Does it mean that empty string from buyer is not acceptable. ? quote: " invalid static terms provided by BNP; SNP must respond with a NACK."
At onsearch > tags> code: bap_terms > { "code": "static_terms", "value": "" <<<< Empty string is not acceptable. & should be NACKed ? },
@sandeepshahi , could you please comment on the above. quote: " invalid static terms provided by BNP; SNP must respond with a NACK."
At onsearch > tags> code: bap_terms > { "code": "static_terms", "value": "" <<<< Empty string is not acceptable. & should be NACKed ? },
@AnanthBo, static terms are not yet enabled by the NPs. Once enabled, the counterparty NPs (SNP) have to accept the terms in /on_search after going through the static terms. Can you explain why are these static terms accepted here?
@sandeepshahi , could i understand the comment is. As of today, If any one sends static_terms. (unsupported feature), should we NACK it instead of ignoring it . Ignoring has value, as we could get more orders. would that be accepted. ? Could we chat over phone few mins.
@sandeepshahi RET13 logs have been submitted with the minor corrections commented. PR#1447 https://github.com/ONDC-Official/v1.2.0-logs/pull/1447
@sandeepshahi , Since we are already present on RET10 & RET15. and we have fixed the requested information. Could you please approve RET13. Also Search is where we will have difference.
@sandeepshahi Certification team has given a go ahead (pass) for RET13 . Could you approve as well.
on_status_picked:
invldQuoteTrailPrices:
Please provide complete logs for Flow 6-b and 6-c ( on_update_interim, on_update_approval, on_update_picked, update_settlement are missing )
@AnanthBo @sandeepshahi
@jagannath-wits. @sandeepshahi
Flow 2 and Flow 3. - updated_at timer fixes. we have reupdated the logs directly. with Flow 2.
Flow 5 - We discussed with Sandeep, in our case, Because we are charging the RTO cost on the buyer App, which has given a wrong consumer address. quote trail overall will not match. but item level it will match.
Flow 6b -logs are added for liquidation . 6c - Return approval flow is must for Fashion only. We have a exception for this. We will manually handle this flow in interim. As of now 0% return cases for us in live.
Lets connect over phone call. if you need more clarification.
@AnanthBo, can you please share the latest PR.
For Flow 5, any adjustment in quote should be reflected in quote_trail. Therefore, the calculation must be correct as mentioned by @Jagannath-wits
For Flow 6b, can you share the approval email with us.
@sandeepshahi @Jagannath-wits
I do not have email or phone num of jagannath...Hence attaching the older screenshots of email & Message on the RTO quote_trail. above. (We will charge the Buyerapp for the RTO costs because buyer address issue,). with this overall quote will not match. (but item level it will match).
@sandeepshahi @Jagannath-wits Please update us at the earliest.
"schemaErr0"
: /message/catalog/bpp~1fulfillments/2/type
must be equal to one of the allowed values (Delivery, Self-Pickup)."tmpstmp"
: Timestamp for /on_search
API cannot be greater than or equal to /select
API."invalidItemId[5b26ad1746f3492a88a166f504d25ec4]"
: Invalid item found in /select
with ID: 5b26ad1746f3492a88a166f504d25ec4."itemProvider[1]"
: Item with ID 5b26ad1746f3492a88a166f504d25ec4 is not available for provider with ID 7bf9b561199f4a898b3f8a3cef91b6e6."precancelState.updatedAt"
: precancel_state.updated_at of on_cancel is not equal with the on_confirm order.updated_at."invldQuoteTrailPrices"
: Quote trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm.
On_status_rto_disposed : end.timestamp missing in RTO fulfillment object@AnanthBo Please Fix the above issues; No need to re-submit the logs.
Flow 1
/on_search
/on_search (inc)
Flow 2
/on_init
/on_status
Flow 5
/on_cancel (RTO)
/on_status (RTO-Disposed)
Flow 6
/on_update (return)
@AnanthBo