ShiSellerApp (RET 10/13) - compliance checks

[sandeepshahi]

Flow 1

/on_search

• tracking is optional attribute in bpp/fulfillments
• value of parent_category_id in /categories is invalid; should be empty string for now
• variants must be supported for grocery domain
• display rank is missing for custom menu
• Self-Pickup is provided in bpp/fulfillments but missing in /bpp/providers/fulfillments
• entire address should not be provided in /locations; separate attributes are present to provide locality/area code related info
• invalid value of state in /locations
• default_selection in /items should only be provided in case of customizable items
• days is not required in /items/time
• net_quantity_or_measure_of_commodity_in_pkg and imported_product_country_of_origin are not required in @ondc/org/statutory_reqs_packaged_commodities;
• unitized measure is not captured correctly; item's description shows different unit
• veg_nonveg should only be provided if applicable (in case of F&B and prepackaged food)
• separate timing block for item is optional; should only be provided if store timing and item's availability timings are different
• available count should be either 99 or 0 as per the availability; need not provide the actual inventory count
• duplicate tag attribute "type" in /items/tags; type = "item" is only required in case of customizable item
• Delivery related timing block should be provided in /bpp/providers/tags/timing; in case timings are same for Order and Delivery, use "All" enum

/on_search (inc)

• similar issues as above
• incremental changes should also be provided in full catalog later

Flow 2

/on_select

• Express Delivery in "@ondc/org/category" should only be used in case the shipment is by Air; not applicable for hyperlocal deliveries
• available/maximum count should be either 99 or 0; as mentioned in /on_search

/on_init

• provider_id is invalid property in /fulfillments
• cancellation_terms should not be provided; not yet enabled on the network
• only tax_number, np_type and provider_tax number should be provided in bpp_terms until static/dynamic terms are enabled and notified; applicable for all the subsequent APIs

/on_confirm

• multiple invalid properties in /start/locaiton/address; check contract for the applicable attributes

/on_status

• Agent-assigned state is missing
• routing and tracking info should be provided in /fulfillments on or before agent assigned state

/on_track

• tracking url is missing

Flow 3

• similar issues as above

/on_select (OOS)

• error/message is invalid; should be in valid JSON stringified format as mentioned in the contract

Flow 4

/on_cancel

• JSON parsing error; JSON is invalid
• store location should not change in /fulfillments/start/location/descriptor
• precancel_state is not captured correctly; updated_at is also incorrect
• descriptor in /cancellation/reason/ is invalid

Flow 5

• similar issues as above

/on_cancel

• similar issues as in Flow 4
• retry_count is missing in tags/cancel_request
• start and end location missing in RTO fulfillment

/on_status

• call missing for RTO disposed/delivered

Flow 6

• all the scenarios must be part of the same order

/on_update (part cancel)

• tags in /items is not required

/on_update (return)

• fulfillment trail should not change; start and end location and other attributes missing in forward shipment fulfillment
• ttl_reverseqc missing in "return_request"
• timestamp of liquidated call can't be earlier than return initiated
• quote_trail and quote must be updated as per the refund to be intiated

@ucansubodh1

[sahil-ondc]

Flow 1

on_search (full catalog)

• manufacturer_or_packer_name, manufacturer_or_packer_address should be provided correctly (provided: 'NA')
• /message/catalog/bpp/providers/categories/tags should have code == type defining the type of category (ex: variant_group, custom_menu)
• variants must be provided

on_search (inc catalog)

• category_ids were provided in full_catalog but now got removed from the item (id: 76198)

Flow 2

on_init

• /message/order/items/tags/type should only be provided in case of customization

on_confirm

• rateable is optional for /message/order/provider
• /message/order/items/tags/type should only be provided in case of customization
• time to ship is provided 1 hour in on_search, therefore pickup range should be within 1 hour (provided: 2 hours after order placement)

Flow 3, Flow 4

• Same as above

Flow 5

• Same as flow 2

on_cancel

• end/time/timestamp for rto fulfillment should only be provided once rto is getting delivered

on_status (rto-delivered)

• start/time/timestamp for rto fulfillment should remain same as provided when rto-initiated

Flow 6

on_update (part-cancellation)

• tags in /items is not required

on_status

• after partial cancellation refund information should get appended to @ondc/org/settlement_details

@ucansubodh1

[sandeepshahi]

Flow 1

/on_search

• If there are no variant_group/custom_menu/custom_group in bpp/providers/categories, please remove the placeholder definition where no type is specified
• holiday must be provided in /locations/time/schedule

/on_search (inc)

• message_id should be unique for unsolicited calls (push based incremental)
• provider level tags and ttl need not be provided in incremental refresh

Flow 2

/on_confirm

• estimated delivery time range should be in sync with the delivery TAT (@ondc/org/TAT)

/on_status

• tracking info is invalid; url_enabled should have values yes/no and url must be provided in separate url block
• remove "state" ready_to_ship block in fulfillments/tags; should only be provided in case of buyer app delivery

/on_track

• tracking url mismatches with the tracking info provided earlier

Flow 3, 4

• similar issues as above

Flow 5

• similar issues as above

/on_cancel

• trail must be maintained; delivery tat info for forward shipment should not change
• pickup timestamp is missing in forward shipment

/on_status (RTO)

• message_id should be unique

Flow 6

/on_update (part cancel)

• order state is changed to Accepted; For order state changes, /on_status must be called
• tracking sttribute in cancelled shipment need not be provided

/on_update (return)

• return fulfillment id is invalid; should be the same as provided by BNP in /update
• returned items should only be mapped to return fulfillment only once the return is liquidated/picked
• estimated time ranges and location in return fulfillment need not be provided in Initiated state; avoid using placeholder values

@ucansubodh1

[sandeepshahi]

/on_search

• holidays must be provided in /locations/time/schedule

/track

• NACK must be issued if tracking is set as false

@ucansubodh1

[sandeepshahi]

@ucansubodh1, the RTO is getting delivered back to the seller, but the return is being liquidated (and not returned to the seller); Can you explain this? Because, either, If the items are in a liquid form, the RTO is disposed of. Alternatively, if the items are not in a liquid form, they should undergo ReverseQC.

[ucansubodh1]

@sandeepshahi both options are available (Delivery and Disposed)

[ucansubodh1]

Tracking URL is not enabled - We have acknowledge this point and will have the lite delivery tracking app integrated with our platform Menu Customization and Variants - We will make our api structure compliant to this.

[sandeepshahi]

RET 13

• value of "time_from" in delivery timing block should be valid timing in hours format;

@ucansubodh1

[ucansubodh1]

@sandeepshahi Fixed this issue. Do I need to resubmit logs again?