search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
6 stars 179 forks source link

Digiledge (RET: 11/12/13/14/15/16/18) - compliance check #1470

Open sahil-ondc opened 3 weeks ago

sahil-ondc commented 3 weeks ago

RET 11

on_search (full catalog)

RET 12

on_search (full catalog)

RET 13, 18

on_search (full catalog)

RET 14, 15

on_search (full catalog)

Note

@shabirahamed

Jagannath-wits commented 1 week ago

Digiledge: RET11

Flow 1

On Search Full Catalog Refresh

On Search Incremental Refresh

Flow 2

On Select

On Init

Confirm

On Confirm

Flow 3

Select Out Of Stock

On Select Out Of Stock

Flow 6

On Update Part Cancel

On Status Packed

On Update Interim Reverse QC

On Update Approval

On Update Picked

On Update Delivered

Reverse QC flow is unusal for F&B but Liquidation flow is mandatory for RET11

@shabirahamed

shabirahamed commented 1 week ago

Digiledge: RET11

Flow 1

On Search Full Catalog Refresh

  • Schema Error 0: /message/catalog/bpp~1providers/0/fulfillments/0 - must NOT have additional properties (tracking)
  • Schema Error 1: /message/catalog/bpp~1providers/0/fulfillments/1 - must NOT have additional properties (tracking)
  • Schema Error 2: /message/catalog/bpp~1providers/0/categories/1/descriptor/images/0 - must match format "url"
  • Duplicate Variant: DuplicateVarient[1] - Duplicate variant found for item in bpp/providers/items
  • Serviceability Value Error: srvcabilityValErr - value passed in serviceability tags[6] should be same as passed in location/circle
  • Last time i received the comments for RET10 from Sahil like /message/catalog/bpp/providers/locations/address must have required property 'circle'
  • I have asked In case of PAN-INDIA serviceability, he told that you can send this circle as dummy for now. later you can remove.

On Search Incremental Refresh

  • Schema Error 0: /message/catalog/bpp~1providers/0/items/0 - must have required property '@ondc/org/return_window'

Flow 2

On Select

  • Schema Error 0: /message/order/fulfillments/1 - must have required property '@ondc/org/provider_name'
  • '@ondc/org/provider_name'` is optional for other fulfillment types.
  • Breakup Fulfillment Titles 3: brkupfftitles3 - invalid id: F2 in packing line item (should be a valid fulfillment_id)
  • Breakup Fulfillment Titles 4: brkupfftitles4 - invalid id: F2 in delivery line item (should be a valid fulfillment_id)
  • Price Error: priceErr - Warning: Quoted Price in /on_select INR 258 does not match with the total price of items in /select INR 358 i.e price for the item mismatch in on_search and on_select
  • This issue have discussed already. That prices vary based on the fulfillmnet.type

On Init

  • On Init Price Error 2: onInitPriceErr2 - Quoted Price in /on_init INR 398 does not match with the quoted price in /on_select INR 438.00
  • Quote Error 0: quoteErr0 - Mismatch found for item with item_id F2 while comparing quote object of on_select and on_init
  • This issue have discussed already. That prices vary based on the fulfillmnet.type

Confirm

  • Quote Error 0: quoteErr0 - Mismatch found for item with item_id F2 while comparing quote object of on_select and confirm
  • Quote Error: quoteErr - Quoted Price in /confirm INR 398 does not match with the quoted price in /on_select INR 438.00
  • This issue have discussed already. That prices vary based on the fulfillmnet.type

On Confirm

  • Quote Error 0: quoteErr0 - Mismatch found for item with item_id F2 while comparing quote object of on_confirm and on_select
  • Quote Error: quoteErr - Quoted Price in /on_confirm 398 does not match with the quoted price in /on_select 438.00
  • This issue have discussed already. That prices vary based on the fulfillmnet.type

Flow 3

Select Out Of Stock

  • Timestamp Error: tmpstmp - Timestamp for /on_search api cannot be greater than or equal to /select api

On Select Out Of Stock

  • Schema Error 0: /message/order/fulfillments/1 - must have required property '@ondc/org/provider_name'

  • '@ondc/org/provider_name'` is optional for other fulfillment types.

  • Message Error Items ID 0: msg/err/items_id0 - message/order/items for item eb8d6b12-b9e8-4cd7-8b2e-e1b840231a87 does not match in [{\"item_id\":\"ff4ede29-e59f-4d2d-8e23-4ea0ac02494c\",\"error\":\"40002\"}]

  • Above error mapping is correct and i have checked

  • Price Breakup: priceBreakup - Item's unit and total price mismatch for id: eb8d6b12-b9e8-4cd7-8b2e-e1b840231a87

  • Delivery Line Item: deliveryLineItem - delivery line item must be present in quote/breakup (if location is serviceable)

  • This issue have discussed already. That prices vary based on the fulfillmnet.type

Flow 6

On Update Part Cancel

  • Invalid Part Cancel Return Request Reason: invalid_partcancel_return_request_reason - reason code allowed are 002,012

On Status Packed

  • Fulfillment Tracking: ffTracking - Fulfillment Tracking mismatch with the on_select call
  • Tracking object value is fixed from on_select api to delivered state

    On Update Interim Reverse QC

  • Schema Error 0: /message/order/payment/@ondc~1org~1settlement_details/1/settlement_type - must be equal to one of the allowed values (upi,neft,rtgs) and not wallet
  • ONDC Buyer App is sending this settlement_type value

On Update Approval

  • Same As Above

On Update Picked

  • Same As Above
  • Invalid Quote Trail Prices: invldQuoteTrailPrices - quote_trail price and item quote price sum for on_update should be equal to the price as in on_confirm
  • It wont be the same. Because one of the item is cancelled then how that quote price will be the same.

On Update Delivered

  • Same As Above

Reverse QC flow is unusal for F&B but Liquidation flow is mandatory for RET11

  • Will collect for the same

@Jagannath-wits could you please help please find the inline comments

Jagannath-wits commented 6 days ago

Digiledge RET:11

Flow 1

On Search Full Catalog Refresh

Flow 2

On Select

On Init

Confirm

On Confirm

Flow 4

On Cancel

Flow 6

On Update Interim Liquidated

On Update Liquidated

Digiledge RET:10

Flow 1

On Search Full Catalog Refresh

Digiledge RET:12

Flow 1

On Search Full Catalog Refresh

Digiledge RET:13

Flow 1

On Search Full Catalog Refresh

Digiledge RET:14

Flow 1

On Search Full Catalog Refresh

Digiledge RET:15

Flow 1

On Search Full Catalog Refresh

Digiledge RET:16

Flow 1

On Search Full Catalog Refresh

Digiledge RET:18

Flow 1

On Search Full Catalog Refresh

@shabirahamed

shabirahamed commented 6 days ago

Digiledge RET:11

Flow 1

On Search Full Catalog Refresh

  • srvcabilityValErr: Value passed in serviceability tags[15] should be same as passed in location/circle
  • Last time i received the comments for RET10 from Sahil like /message/catalog/bpp/providers/locations/address must have required property 'circle'
  • have asked In case of PAN-INDIA serviceability, he told that you can send this circle as dummy for now. later you can remove.

Flow 2

On Select

  • schemaErr0: /message/order/fulfillments/1 must have required property @ondc/org/provider_name

  • '@ondc/org/provider_name'` is optional for other fulfillment types.

  • brkupfftitles4: Invalid id: F2 in packing line item (should be a valid fulfillment_id as provided in message.items for the items)

  • brkupfftitles5: Invalid id: F2 in delivery line item (should be a valid fulfillment_id as provided in message.items for the items)

  • As per the API contract we are sending the correct values

On Init

  • onInitPriceErr2: Quoted Price in /on_init INR 478 does not match with the quoted price in /on_select INR 518.00 as F2 packing charges is there
  • quoteErr0: Mismatch found for item with item_id F2 while comparing quote object of on_select and on_init
  • quoteErr1: Mismatch found for item with item_id F2 while comparing quote object of on_select and on_init
  • Above errors are log validation tool.

Confirm

  • Same as above

On Confirm

  • Same as above
  • Above errors are log validation tool.

Flow 4

On Cancel

  • schemaErr0: /message/order/fulfillments/0/start must have required property 'time'
  • schemaErr1: /message/order/fulfillments/0/end must have required property 'time'
  • After Order is accepted, start and end time will be created

Flow 6

On Update Interim Liquidated

  • schemaErr0: /message/order/payment/@ondc~1org~1settlement_details/1/settlement_type must be equal to one of the allowed values (upi,neft,rtgs)
  • ONDC Buyer App is sending /message/order/payment/@ondc~1org~1settlement_details/1/settlement_type value

On Update Liquidated

  • Same as above
  • ONDC Buyer App is sending /message/order/payment/@ondc~1org~1settlement_details/1/settlement_type value

Digiledge RET:10

  • RET10 logs were verified. please ignore RET10

@Jagannath-wits please find the inline comments

Jagannath-wits commented 6 days ago

'@ondc/org/provider_name'` is optional for other fulfillment types.

  • where is this in contract ?

As per the API contract we are sending the correct values

  • how is F2 correct fulfillment id when it has not been declared before { "fulfillment_id": "F1", "id": "ff4ede29-e59f-4d2d-8e23-4ea0ac02494c" }, { "fulfillment_id": "F1", "id": "eb8d6b12-b9e8-4cd7-8b2e-e1b840231a87" } both fulfillment id are F1

@shabirahamed

sahil-ondc commented 3 days ago

RET 12

Flow 1

on_search (full catalog)

RET 13

Flow 1

on_search (full catalog)

RET 14

Flow 1

on_search (full catalog)

RET 15

Flow 1

on_search (full catalog)

RET 18

Flow 1

on_search (full catalog)

Note