ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0

9 stars 245 forks source link

ENAM (AGR:11) - compliance check #1471

Open sahil-ondc opened 4 months ago

sahil-ondc commented 4 months ago

Flow 1

on_search (full catalog)

/message/catalog/bpp/providers/descriptor long_desc and short_desc should not be provided as empty string
/message/catalog/bpp/providers/descriptor/symbol should be publically accessible and valid url
categories should be provided as per the construct
/message/catalog/bpp/descriptor must have required property 'tags' defining the np_type either ISN or MSN
/message/catalog/bpp/providers/locations/time must have required property 'schedule'
area_code provided in /message/catalog/bpp/provider/locations should be as per gps provided
available and maximum provided in /message/catalog/bpp/provider/items/quantity should be either 99 or 0
serviceability should be provided in /message/catalog/bpp/providers/tags
/message/catalog/bpp/providers/items must have required property '@ondc/org/return_window'
Does variants supported ?
/context/message_id should be same as per /search
/context/city should be same as provided in /search
/message/catalog/bpp/providers/items @ondc/org/time_to_ship should be in ISO8601 format
/message/catalog/bpp/providers/items should have mandatory attributes

Flow 2

select

/message/order/items/quantity/count must be integer
selected count should be greater than 1

on_select

/message/order/quote/breakup/@ondc/org/item_quantity/count must be integer
context/timestamp for /select api cannot be greater than or equal to /on_select api
delivery line item must be present in quote/breakup (if location is serviceable)

init

/message/order/items/quantity/count must be integer

on_init

/message/order must have required property 'tags'
/message/order/items/quantity/count must be integer
/message/order/quote/breakup/@ondc/org/item_quantity/count must be integer
/message/order/fulfillment of type 'delivery' should not have tags
Buyer app finder fee can't change in /on_init

on_confirm

same as on_init

on_status

packed, agent-assigned out-for-delivery must be provided
/message/order/fulfillments/@ondc/org/TAT must match format "duration"
/message/order/fulfillments must have required property 'state'
/message/order/fulfillments/start must have required property 'time'
/message/order/fulfillments/end must have required property 'time'
/message/order/quote/breakup/@ondc/org/item_quantity/count must be integer

Flow 3

Invalid flow (item with out-of-stock should be selected)

Note

Buyer and Seller should be of different entity for log submission.
As per the AGR Test cases, payment type in flow 2 should be prepaid and flow 3 should be postpaid.
Breakup object needs to be changed for negotiation, and discounts should be provided. https://docs.google.com/document/d/1vFyw1aaCdnITW0i3PjJprdnHig1suHJ1btKIYndJG6I/edit#heading=h.mw7yzugna3rb

@vishalbitxia

vishalbitxia commented 4 months ago

Can you please confirm if this is based on : https://github.com/ONDC-Official/v1.2.0-logs/pull/1442 or https://github.com/ONDC-Official/v1.2.0-logs/pull/1461 ?

sahil-ondc commented 4 months ago

Flow 1:

/search

static_terms should not be provided as those are not enabled yet

/on_search

/message/catalog/bpp/descriptor must have required property 'tags' defining the np_type either ISN or MSN
area_code provided in /message/catalog/bpp/provider/locations should be as per gps provided
/message/catalog/bpp/providers/items @ondc/org/time_to_ship should be in ISO8601 format
/message/catalog/bpp/providers/locations/time/timestamp should be in valid format
/context/timestamp of /search and /on_search is exactly the same
timestamp should be in valid format /message/catalog/bpp/providers/locations/time/timestamp

Flow 2:

The payment type should be PRE-FULFILLMENT for this flow, but it’s given as ON-FULFILLMENT in this flow

/on_select

/context/timestamp of /select and /on_select is exactly the same
price provided in /message/order/quote/breakup should be multiple of count

/init

/message/order/billing/email is not a valid email
area_code provided in /message/order/fulfillments/location/address should be as per gps provided

/on_init

/context/timestamp of /init and /on_init is exactly the same
/message/order must have required property 'tags'

/confirm

/order/tags tax_number should be valid

on_confirm

/message/order updated_at should get update
cancellation should not be provided as empty object

/on_status

/message/order created_at and updated_at should not be same
If the fullfilment.type is “Self-Pickup”, fulfillment state cannot be agent-assigned, out-for-delivery or packed
If order is completed, the payment should be collected by BPP and status should be changed to “PAID”
ttl should be provided in ISO8601 format in /message/order/quote

Flow 3:

on_select (out-of-stock)

/message/order/quote/breakup/price should be zero in case of out-of-stock
/error object should be provided

Same as Flow 2

@vishalbitxia

sahil-ondc commented 4 months ago

Flow 1

on_search

context/message_id should be same as provided in /search
display is not a valid property in /message/catalog
tracking is an optional property in /message/catalog/bpp/fulfillments
accept_bap_terms should not be provided as bap is not providing any terms
short_desc and long_desc should not be same
urls should be publically accessible provided in /message/catalog/bpp/providers/descriptor
timing should be defined in /message/catalog/bpp/providers/tags
area_code should be provided as per the provided gps in /message/catalog/bpp/providers/locations
categories are not defined correctly
/message/catalog/bpp/fulfillments/type must be equal to one of the allowed values (Delivery,Self-Pickup)
/message/catalog/bpp/providers/fulfillments/contact must have required property 'email'
/message/catalog/bpp/providers/items must have required property '@ondc/org/return_window'
/message/catalog/bpp/providers/items/quantity/available/count available count must be either 99 or 0 only
STD code does not match with correct area_code on /on_search
code should provided in /message/catalog/bpp/providers[0]/items[0]/descriptor
@ondc/org/contact_details_consumer_care email should be in /bpp/providers[0]/items
context/city should be same provided in /search

Flow 2

select

context/city mismatch in /on_search and /select

on_select

/message/order/quote/breakup/0/item/quantity/available/count available count must be either 99 or 0 only
/message/order/quote/breakup/0/item/quantity/maximum/count must be string
context/timestamp difference between /on_select and /select should be less than 5 sec (select timestamp: 2024-05-03T22:51:24.983Z and on_select timestamp: 2024-05-04T04:21:25.052Z)
delivery line item must be present in quote/breakup (if location is serviceable)

init

context/timestamp for /on_select api cannot be greater than or equal to /init api
address.area_code in fulfillments[0].end.location mismatch in /select & /init
tax_number should not be provided as empty string in billing object

on_init

context/timestamp difference between /on_init and /init should be less than 5 sec
/message/order/quote/breakup/0/item/quantity/available/count available count must be either 99 or 0 only
/message/order/quote/breakup/0/item/quantity/maximum/count must be string
/message/order/tags/0/list/0/value Value for tax_number must be a valid tax number i.e alphanumeric with 15 characters
provider_tax_number must be present for on_init
Key 'created_at' mismatch: 2024-05-01T13:12:40.522Z !== 2024-05-02T00:12:40.522Z when compared with init billing object
Key 'updated_at' mismatch: 2024-05-01T13:12:40.522Z !== 2024-05-02T00:12:40.522Z when compared with init billing object
/message/order/fulfillment/start/descriptor/name should not be placeholder
@ondc/org/withholding_amount should not be zero in case of @ondc/org/buyer_app_finder_fee_amount: '3'

on_confirm

static_terms, accept_bap_terms should not be provided as those are not enabled yet
/message/order/fulfillments/0 must have required property '@ondc/org/provider_name'
/message/order/fulfillments/0 must have required property 'state'
/message/order/tags/0 must NOT have additional properties (display)
/message/order/tags/0/list/2/value Value for tax_number must be a valid tax number i.e alphanumeric with 15 characters
context/timestamp difference between /on_confirm and /confirm should be less than 5 sec
'TAT' must be provided in message/order/fulfillments
order.created_at timestamp mismatches in /confirm and /on_confirm
Key 'created_at' mismatch: 2024-05-01T13:12:40.522Z !== 2024-05-02T11:12:40.522Z when compared with init billing object
"Key 'updated_at' mismatch: 2024-05-01T13:12:40.522Z !== 2024-05-02T11:12:40.522Z when compared with init billing object

on_status

packed state should be provided
/message/order must have required property 'documents' (delivered)
ttl should be valid (provided: PT18H44M35.772S)

Flow 3

Same as above

select

multiple items should be selected and flow should proceed with the item which are in stock

on_select

error/message is not in correct format "[{\"item_id\":\"I1\",\"error\":\"40002\"},{\"item_id\":\"I2\",\"error\":\"40002\"},{\"item_id\":\"I3\",\"error\":\"40002\"}]"

Note

Quote nagotiations is still not being done

sahil-ondc commented 3 months ago

Flow 1

on_search

code should provided in /message/catalog/bpp/providers[0]/items[0]/descriptor
range should be provided in /message/catalog/bpp/providers/locations
/message/catalog/bpp/fulfillments/1/type must be equal to one of the allowed values (Delivery,Self-Pickup)
/message/catalog/bpp/providers/0/items/0/descriptor must have required property 'images'
/message/catalog/bpp/providers/0/items/0/quantity/unitized/measure/value enter a valid number

Flow 2

on_select

/message/order/quote/breakup/quantity should remain same as provided in /on_search
delivery fulfillment TAT cannot be same as time_to_ship provided in /on_search
delivery line item must be present in quote/breakup (if location is serviceable)
provider_tax_number should be valid

on_init

offers should be provided

confirm

/message/order/quote/breakup/0/price/value Price value should be a number in string with upto 2 decimal places
/message/order created_at and updated_at should not be greater than context/timestamp
display is not a valid property
additional properties should not be provided in /message/order/quote/breakup/item

on_confirm

/message/order/billing/tax_number should not be provided as empty string
/message/order/updated_at should not be greater than context/timestamp

on_status

invalid format @ondc/org/settlement_window (on_status accepted)
range should remain same in every on_status call
actual delivery timestamp should be provided (on_status delivered)

Flow 3

on_select (out-of-stock)

available/count should be string
fulfillment/state should not be provided as empty object (serviceability should be provided)

Flow 4

on_cancel

invalid timestamp format
invalid TAT provided
quote_trail must be provided

@vishalbitxia

sahil-ondc commented 3 months ago

Flow 1

on_search

code should provided in /message/catalog/bpp/providers[0]/items[0]/descriptor
provided area_code should be as per provided gps in /message/catalog/bpp/providers[0]/locations
phone number provided should not be placeholder (provided: 2222222222)
categories provided should be mapped to items
provided category_id should be one of the categories provided in the following sheet https://docs.google.com/spreadsheets/d/1IVz6vevUbBzNPXBn3PaemE1XbomRdaYO/edit#gid=1209539245
provided url should be publically accessible in /message/catalog/bpp/providers[0]/items/descriptor/additional_desc https://s3-ap-south-1.amazonaws.com/staging-seller-bucket/seller/74/items/361/additionalDoc/null/1716021949895_nv_p1.drawio

Flow 2

select

context/city should be as per provided area_code and gps

on_select

provided fulfillment should be mapped in breakup
in /message/order/quote/breakup/@ondc/org/title_type having value delivery should have @ondc/org/item_id one of the provided fulfillment options
/message/order/fulfillments should have required property 'type'

init

address should not have placeholder values
gps coordinates in fulfillments[0].end.location mismatch in /select & /init

on_init

invalid tax number format
gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

confirm

fulfillments[0].end.location gps is not matching with gps in /select

on_confirm

cancellation should not be provided as empty object
bpp_terms missing which are provided in on_init (provider_tax_number, np_type)
store name /fulfillments[0]/start/location/descriptor/name can't change
Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

on_status (pending)

billing object created_at and updated_at mismatches
Order state should be accepted whenever Status is being sent 'Accepted'. Current state: Created

on_status (packed)

context/message_id should not be same with previous calls
created_at mismatches with /confirm
order/state should be 'In-progress'

on_status (delivered)

created_at mismatches with /confirm

Flow 3

same as Flow 2

select

item with id: 362 is not provided in on_search, how its being selected

Flow 4

same as Flow 2

on_cancel

billing object mismatches
for cancellation new fulfillment should be created and cancelled items should be mapped to that new fulfillement
timestamps are not captured correctly

Note

on_search

short_desc and long_desc should be different (provided catalog should be subset of production catalog)
in case of @ondc/org/returnable being 'false' @ondc/org/return_window will be considered as window of raising IGM, and you are providing it as zero days. Hope its okay

@vishalbitxia

sahil-ondc commented 3 months ago

Flow 5

rto flow must be submitted as per rollout plan sheet https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

@vishalbitxia

sahil-ondc commented 3 months ago

Transaction logs with repeated issues has been submitted

Flow 1

on_search

provided area_code should be as per provided gps in /message/catalog/bpp/providers[0]/locations
categories provided should be mapped to items using parent_item_id

Flow 2 and Flow 3

select

provided area_code should be as per provided gps

on_select

provided fulfillment should be mapped in breakup
why 'Standard Delivery' is provided two times ?
/message/order/fulfillments should have required property 'type'
all the fulfillments mentioned in /message/order and are serviceable should be mapped in breakup also

init

address should not have placeholder values

on_init

/message/order/fulfillment/start should not be provided

confirm

/message/order/items/quantity/selected should not be provided

on_confirm

/message/order/items/quantity/selected should not be provided
store name /fulfillments[0]/start/location/descriptor/name can't change
/message/order/items/quantity/selected should not be provided

on_status (pending)

billing object created_at and updated_at mismatches
Order state should be accepted whenever Status is being sent 'Accepted'. Current state: Created

Flow 4

same as Flow 2

on_cancel

billing object mismatches

Note

in case of @ondc/org/returnable being 'false' @ondc/org/return_window will be considered as window of raising IGM, and you are providing it as zero days. Hope its okay
how pickup and delivery ranges are same in every flow
how billing object created_at and updated_at remains same in multiple flows

@vishalbitxia

sandeepshahi commented 3 months ago

Flow 1

/search

isn't caching of catalog supported?
invalid attribute tracking in /fulfillment; buyer never specifies their intent about tracking

/on_search

contact, tracking are not valid attributes in bpp/fulfillments
incorrect value of location in /tags/timing
Invalid geocoding of GPS coordinates and area codes: since these are static values that will be used only once, correct values should be provided
available count should be either "99" or "0" specifying just the availability of the stock and not the actual inventory count;
what does maximum count of "10000" mean? if there is no cap, use the value "99"
invalid property minimum count in /items/quantity
why is self pickup mapped as the default fulfillment option in /items/fulfillment_id; For PAN India shipment, delivery option should be provided
please provide multiple items in the catalog; what's the utilization of creating variant group if there is only 1 SKU in the entire catalog;
invalid schema of variant group definition in /categories/tags; "type" is missing

Flow 2

provide order flow for delivery fulfillment option;

/select

fulfillment end location changed in /search and /select; why? the catalog is not even pulled for the new location
provide a delivery location which is different from the seller's location
tracking is invalid property

/on_select

available and maximum count values are invalid; check the feedback for /on_search
time_to_ship is marked as 24 hours in /on_search, then why is the O2S tat in "@ondc/org/TAT" as 48 hours?
Standard Delivery is not a valid delivery category for self pickup; check the contract for correct enums
delivery fulfillment option should be included in /fulfillments, as the seller supports both options. The buyer must be given the choice, and the selected fulfillment option should be specified in /init
why is fulfillment provider name ("@ondc/org/provider_name") marked as "e-NAM" when it's a self pickup delivery

/init

invalid properties door, ward and street in /billing and /fulfillments/end/location
invalid property fulfillments/end/location/id

/on_init

"@ondc/org/title_type" should be offer in quote/breakup for offer line item and type = discount should be provided in /tags/offer
offers in /order is an optional property
why is the payment gateway url provided for self pickup PoD option?
settlement basis is marked as delivery. Is this intended? will the settlement be intiated once the order is picked by the buyer?
invalid property /tags/rto_action; check the contract for usage
no need to provide /fulfillments/start until order is confirmed
invalid details provided in "@ondc/org/settlement_details"; if payment is collected by BPP, settlement details should be provided by BAP in /confirm

/confirm

invalid property items/quantity/selected
payment/transaction_id should only be provided once the payment is collected

/on_status

invalid value of quote/ttl
trail for quote/breakup must be maintained; why are the objects and tags removed from offer line item?
O2S tat is mentioned as 48 hours but estimated time ranges around 2 minutes
invalid mapping of order state and fulfillment state; fulfillment state can't be "Packed" when order is just "Accepted"; check the contract for correct mapping
estimated delivery time ranges shouldn't be provided; buyer will be self picking and that can't be predicted
invalid fulfillment state Order-deliverd; for Self-pickup the terminal state is Order-picked-up
pickup through OTP/PCC (pickup confirmation code) is mandatory for Self-pickup fulfillment
invoice must be provided once the order is picked
payment timestamp and transaction_id must be captured upon successful pickup

Flow 3

provide multiple SKUs in the cart and make one of them OOS while contuing the same txn with the available item
similar issues as above

/confirm

payment option was selected as ON-FULFILLMENT and to be collected_by BPP; why is it changed to Prepaid order (collected by BAP)?

/on_status

estimated pickup and delivery time ranges can't be same; delivery must start only after the order is picked
Order-picked-up: how can actual delivery timestamp (in fulfillments/end/time/timestamp) be provided when the order is just picked;
actual pickup and delivery timestamps are not even provided correctly; how can future timestamps be provided? Also, once captured in the call, the timestamps should remain unchanged in subsequent APIs.

Flow 4

similar issues as above
share the logs for the cancellation of offer flow

/on_cancel

invalid "updated_at" timestamp for precancel_state; should be RFC3339 UTC format with 3 digits of milliseconds

- issues raised for previous API calls are also applicable for subsequent APIs; trail must be maintained correctly

@vishalbitxia

sandeepshahi commented 3 months ago

Flow 1

/search

search by category is not a valid search request;

/on_search

invalid usage of /categories in bpp/providers; no need to define categories if there is no variant_group/custom_menu/custom_group
why are duplicate objects for delivery and self pickup provided in /bpp/fulfillments
short_desc/long_desc can't be empty in bpp/providers/descriptor
serviceability defined for provider 45 is incorrect; for every unique combination of category+location for a provider, a separate serviceability block must be defined
inaccurate geocoding of store address; gps and area code totally mismatch for several store locations;
"@ondc/org/contact_details_consumer_care" is not in correct format; should be in the format: "name,email,contact no."
email can't be null/empty in /fulfillments
all the mandatory attributes are not present for address for store id: "245"

Flow 2

/select

Invalid provider: 116. Please provide the correct catalog for validation
still placeholder value of /payment being used
context/city mismatch with buyer's location (fulfillments/end/location); where is the context/city being captured from if it's neither buyer's or seller's city

/on_select

why is the maximum quantity provided as 10000? This number in agri use case is still unclear
Why are both delivery and self-pickup options available when there's only one item in the cart? Has this issue been resolved?
If the previous issue is fixed, can the buyer now choose between delivery and self-pickup during the /init step?

/on_init

for ON-FULFILLMENT payment, collected by should be BPP; further settlement details should be provided by BNP in /confirm
"@ondc/org/TAT" can't change for Self-Pickup

/confirm

tax_number provided in /bap_terms shouldn't be placeholder value in prod
collected by now changed from BAP to BPP with settlement details of the buyer app
payment/params/transaction_id should only be provided once the payment is collected; null value is not allowed

/on_status

audit trail for offer line item in /items must be maintained; "tags" is missing
why is the maximum/available count still being provided? even though it was stopped being provided from /on_init
line item for delivery charges should not be removed
order/fulfillment state mapping is incorrect; fulfillment state can't be "Packed" when order is just "Accepted"
Invalid values provided for /contact/email in both the start and end objects
pickup time range should be in the future and must not overlap with the context/timestamp
attributes and values in end/location/address can't change
"@ondc/org/category" can't change; optional property in /on_status
For self-pickup, Order-picked-up is the terminal state
Once the order is picked (in Self-pickup), transaction_id and timestamp must be provided in /payment/params
actual pickup timestamp and invoice are still missing
pickup through OTP/PCC (pickup confirmation code) is mandatory for Self-pickup fulfillment

/status

why is there no solicited callback response provided?

Flow 3

similar issues as above
select must be called again if there are any changes in the cart (OOS here);
please share payload with multiple offers in the cart

/on_select

message in error/message is not required
duplicate line item for delivery charges can't be provided for same fulfillment id

/on_init

for fulfillment type = Delivery, how can pickup and delivery gps coordinates be same? provide a delivery location which is different from the seller's location

/confirm

payment type changed from PoD to Prepaid; similar issues as raised earlier

/on_confirm

why is the fulfillment object for Self-pickup removed?

/on_status

delivery time range must start only after the order pickup range
duplicate object in provider/locations with same id
in case of intercity, routing info must also be provided; not applicable here
sequencing of fulfillment state for multiple fulfillments are not being updated properly; Self-pickup fulfillment is moved from pending to out-for-pickup (not even a valid state for Self-pickup)
why is the delivery time range provided for self-pickup (wasn't provided in flow 2 earlier)
estimated time ranges should not change in subsequent APIs
actual pickup and delivery timestamps issues still persist; check out for delivery state
fulfillment states are not being updated correctly for Self-pickup;

Flow 4

share the logs for the cancellation of offer flow

/on_cancel

audit trail for /items must be maintained
payment/uri is not a valid property here
updated_at timestamp in precancel_state is not captured correctly

Flow 5

/on_cancel

precancel_state is not captured correctly; earlier it was correct
updated_at for precancel_state is not captured correctly
retry_count, rto_id are missing in tags/cancel_request
estimated rto delivery time range need not be provided;
check address related issue as mentioned earlier
start and end addresses are not captured correctly for RTO fulfillment

/on_status (rto initiated)

Why is the RTO-initiated call also triggered through on_status?

/on_status (rto delivered)

estimated time ranges are invalid for both cancelled forward shipment and rto fulfillment
actual timestamp for RTO-delivered must be captured in fulfillments/end/time/timestamp (type=RTO)
audit trail for quote/breakup must be maintained
incorrect values in /cancellation object

@vishalbitxia

sandeepshahi commented 2 months ago

Flow 1

/on_search

time/timestamp can't be future dated
Item and category mapping must be correct; eg: Hajmola is not an agri output (AGR11) product and should not be mapped with "Spices" category
timing should be provided for all the store locations; eg for Provider: "35", timing is not being provided for store locations: "267" and "274"
consumer care must be in correct format: check for provider: "43", item: "76"; default email id was supposed to be sent
name/short_desc/long_desc should be valid; check for provider: "114", item: "1228", "1229"
unicode literal should not be provided in product description: name,images etc

Flow 2

/on_status

order/created_at timestamp should not change; must remain the same as in /confirm
"collected_by" should not change in picked state

/status

why is there no solicited callback response provided?

Flow 3

/select (OOS)

context/city is invalid; should be the city code of buyer;

/init

In the case of a PoD order with two separate fulfillment options—Self Pickup and Delivery—when will the payment be made by the buyer? Will the payment be made during the Delivery by the delivery agent, or directly to the seller at the time of Self Pickup?

/on_status

are separate fulfillment states update being supported for multi fulfillment?
payment/params/transaction_id need not be provided until payment is successful

Flow 4

/on_cancel

order/created_at must not change; should remain the same as in /confirm

@vishalbitxia

sandeepshahi commented 2 months ago

@vishalbitxia, please submit the logs for the scenarios: RTO/Part Cancellation/Return i.e. Flow 5 and 6

sahil-ondc commented 1 month ago

Flow 1

on_search

STD code does not match with correct area_code on /on_search
why repeative items are provided multiple times in catalog
Support for variants is mandatory, categories must be present in bpp/providers
timing construct /bpp/providers[0]/tags[6] should not be same with the previous timing constructs (provided repeated timing constructs)
only stores related to provided search's context/city should be provided in on_search

Flow 2, 3

select

multiple items with multiple quantity should be selected (selected only 1 item)

on_select

Quoted Price in /on_select INR 404 does not match with the total price of items in /select INR 400 i.e price for the item mismatch in on_search and on_select (items should be inclusive of taxes)

init

/message/order/fulfillments/0 must have required property 'end'

on_init

/message/order/fulfillments/0 must have required property 'end'
type, status, and collected_by are optional properties in payment object

confirm

fulfillments[0].end.person object is missing
Tags/bap_terms should have valid gst number and fields in /confirm

on_confirm

fulfillments[0] start and end locations are mandatory

on_status (pending)

transaction_id missing in message/order/payment

on_status (delivered)

Delivery object is mandatory for on_status_delivered
fulfillments/state should be Order-delivered

Flow 4, 5

on_cancel

/message/order/bap_terms should not have empty space in tax_number
/message/order/fulfillment/tags/precancel_state/updated_at should be captured correctly

Flow 6

liquidation flow not provided

on_update (part-cancellation)
how settlment_details have settlement_details of refund before even cancellation

@vishalbitxia

vibhav-bitxia commented 1 month ago

Flow 1

on_search

STD code does not match with correct area_code on /on_search

eNAM to eNAM all products will be provided, irrespective of location. Other buyer to eNAM seller will return only STD code specific products. This was discussed and approved with Sandeep and Abhishek

Only stores related to provided search's context/city should be provided in on_search

Same as above
Support for variants is mandatory, categories must be present in bpp/providers

Currently eNAM doesn't support variants

Flow 2, 3

on_select

Quoted Price in /on_select INR 404 does not match with the total price of items in /select INR 400 i.e price for the item mismatch in on_search and on_select (items should be inclusive of taxes)

_As per this comment, do we need to add tax in original item price in onsearch? Please confirm

init

/message/order/fulfillments/0 must have required property 'end'

Flow 2 - As per API contract For fulfillment type "Self-pickup" we don't have end. Note: Flow 2 is executed with "Self-pickup" items. Flow 3 - Fulfillment type "Delivery" End tag is present.

on_init

/message/order/fulfillments/0 must have required property 'end'

Same as above
type, status, and collected_by are optional properties in payment object

_Since the properties are optional, type, status and collectedby are present in payment object.

confirm

fulfillments[0].end.person object is missing

This issue occurs only the when fulfilment type is "Self-pickup". No example found in ONDC API contract for end object in fulfilment when type is "Self-pickup"

on_confirm

fulfillments[0] start and end locations are mandatory

What to populate in end in case of "Self-pickup"? ONDC API contract has no example to support

on_status (delivered)

Delivery object is mandatory for on_status_delivered

Couldn't find anything on the contract for reference, can you please share an example?

@sahil-ondc Please assist on these queries