ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 264 forks source link

Digiledge (BA : RET10) - Compliance check #1517

Open Jagannath-wits opened 6 months ago

Jagannath-wits commented 6 months ago

Flow 5

Cancel:

Flow 6-a

Update:

@shabirahamed

shabirahamed commented 6 months ago

Flow 2

Select:

  • tmpstmp: Timestamp for /on_search API cannot be greater than or equal to /select API.

  • select timestamp('"timestamp": "2024-04-23T04:26:11.554Z"') is greater than on_search timestamp ('"timestamp": "2024-04-23T03:59:08.036Z",'). could you please confirm once

  • invalidItemId[5X1c7CCthoUAuYD1hT1F]: Invalid item found in /select with ID: 5X1c7CCthoUAuYD1hT1F.

  • could you please compare our on_search respone. because we dont have this 5X1c7CCthoUAuYD1hT1F itemId.

  • invalidItemId[E5dCfF2s0xmgdsQ4mGvi]: Invalid item found in /select with ID: E5dCfF2s0xmgdsQ4mGvi.

  • could you please compare our on_search respone. because we dont have this E5dCfF2s0xmgdsQ4mGvi itemId.

  • providerId: Provider with ID: H6JplBH0HQxkVoKWAnD3 does not exist in /on_search.

  • could you please compare our on_search respone. because we dont have this H6JplBH0HQxkVoKWAnD3 providerId.

  • providerChecks: Missed checks for provider as provider with ID: H6JplBH0HQxkVoKWAnD3 does not exist on /on_search API.

  • could you please compare our on_search respone. because we dont have this H6JplBH0HQxkVoKWAnD3 providerId.

  • We have added the provider check.

Confirm:

  • quoteErr: Quoted Price in /confirm INR 1928 does not match with the quoted price in /on_select INR 1956.00.
  • /on_select quote and confirm quote should be vary as per tha API contract.
  • In the /on_select quote price contains addition of multiple fulfillment prices. Once buyer selects any one of the fulfillment.type and initiate init request. In the on_init order.quote will be the final quote that contains selected fulfillment price.
  • could you please verify once

@Jagannath-wits

please find the inline comments

Jagannath-wits commented 6 months ago

Flow 2

Select:

Init:

Confirm:

@shabirahamed seems to be mixup from my end Please refer to these for flow 2

Also if the seller is responding with different item ids in on_actions buyer should send nack

shabirahamed commented 6 months ago

Flow 2

Confirm:

  • quoteErr0: Mismatch found for item with item_id F2 while comparing quote object of on_select and confirm.
  • quoteErr1: Mismatch found for item with item_id F2 while comparing quote object of on_select and confirm.
  • Above errors are not relevant that can be ignored and I have asked sandeep for the same he told me that can be ignored if its not relavent means

Also if the seller is responding with different item ids in on_actions buyer should send nack

  • Its the same itemIds. I have verified @Jagannath-wits could you please check
Jagannath-wits commented 6 months ago

Flow 2

Confirm:

  • quoteErr0: Mismatch found for item with item_id F2 while comparing quote object of on_select and confirm.
  • quoteErr1: Mismatch found for item with item_id F2 while comparing quote object of on_select and confirm.
  • Above errors are not relevant that can be ignored and I have asked sandeep for the same he told me that can be ignored if its not relavent means

Also if the seller is responding with different item ids in on_actions buyer should send nack

  • Its the same itemIds. I have verified @Jagannath-wits could you please check

Ok please continue with the same

sahil-ondc commented 1 month ago

The Buyer should send ‘NACK’ for the following :

Flow 1

On Search

Flow 2

Init

On Status Picked

Flow 6

Update Settlement Partial Cancel

shabirahamed commented 1 month ago

The Buyer should send ‘NACK’ for the following :

Flow 1

On Search

  • The item2/'@ondc/org/statutory_reqs_prepackaged_food'/other_FSSAI_license_no3 is missing in bpp/providers/items for /on_search
  • In ONDC:RET10 @ondc/org/statutory_reqs_prepackaged_food following fields are valid and required 'nutritional_info', 'additives_info','other_FSSAI_license_no', 'brand_owner_FSSAI_license_no','importer_FSSAI_license_no'

-- As per the API contract. all the values are valid and have checked. It might be log utility tool issue

could you please check

@sahil-ondc

shabirahamed commented 1 month ago

The Buyer should send ‘NACK’ for the following :

Flow 2

Init

  • address.building should be more than 3 chars
  • address validation added

On Status Picked

  • The tracking URL is not displaying the start and end locations along with the route.
  • Tracking app is currently in progress

Flow 6

Update Settlement Partial Cancel

  • ‘upi_address’ is not required in the settlement_details
  • upi_address removed and added account details

could you please help

@sahil-ondc