Shopclues (SA: RET12) - compliance check

[sahil-ondc]

Flow 1

on_search (full_catalog)

• /message/catalog/bpp/providers/items/@ondc/org/time_to_ship must match format \"duration\"
• serviceability should not be replecated
• /message/catalog/bpp/providers/categories/descriptor/name should not be placeholder
• invalid attributes should not be provided (ex: item.tags.attribute.size men's upper)
• html should not be provided in /message/catalog/bpp/providers/items/descriptor short_desc and long_desc
• HSN code provided should be correct, and should not be placeholder (provided: 0000)
• invalid attributes provided, attributes should be one of the following https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=1130527843

on_search (inc_catalog)

• same as above
• location label (/bpp/providers/locations/time/label) for /on_search_inc_refresh should not be equal to /on_search_full_catalog_refresh.label
• Similar Item as in /on_search_full_catalog_refresh api call, item id- 127104092_1485966234 (item should only be provided in only when there is any change in delta)

Flow 2

select

• Buyer selects multiple items (> 1 qty for each item) for checkout

https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

on_init

• placeholder values should not be provided in payment objects (provided: XXXXXXXXXX)
• np_type is a required property for bpp_terms provided in /message/order/tags/bpp_terms
• @ondc/org/provider_name should have company name who is handling logistics

on_confirm

• /message/order/items/tags/type is optional
• /message/order/fulfillment/start/range should not match /message/order/fulfillment/end/range

on_status (picked)

• invalid pickup timestamp (provided: 1970-01-01T00:00:00.368Z)

Flow 3

• same as above

select (out-of-stock)

• Buyer selects multiple items (> 1 qty for each item) for checkout, and flow should proceed with items which are in stock

https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

Flow 4

• same as above

on_cancel

• ttl is provided as PT600S, prefer providing in minutes
• precancel_state updated_at is not captured correctly

Flow 5

on_cancel (rto)

• precancel_state updated_at is not captured correctly
• rto-fulfillment/start/timestamp is not captured correctly
• if delivery is zero, no need to provide that in quote_trail

Flow 6

• partial-cancellation, reverse-qc, liquidation should be provided within single order

@ajayGargSc

[ajayGargSc]

@sahil-ondc thanks for the reply we are looking into it. And will resolve asap. Can you please confirm for error msg in flow 2 a. Buyer selects multiple items (> 1 qty for each item) for checkout; in this scenario we can provide 2 items with 2 qty each then it is enough right? or we have to provide more than 2 items? and one more query like attributes which you provided and mandate we are giving but if we sending extra then buyer can use it or not. It should not provide error. So please confirm if we need to remove extra attributes which are not as per your sheet? The errors like not needed or optional we can provide those right?

[ajayGargSc]

Also we do not do partial-cancellation in ondc orders so we can skip those right.

[sahil-ondc]

Flow 1

on_search (full_catalog)

• area_code provided in /message/catalog/bpp/providers/locations should be as per provided GPS
• attributes which are defined in categories should be in small case (provided: Size)
• /message/catalog/bpp/providers/categories/descriptor/name should not be provided as placeholder values
• in case of items having same parent_item_id, it should not have same values for attributes, on which variants are made
• cateogory_ids should be one of the sub categories provided in the sheet below
• order timing should be provided in the provider level timing tags
• mandatory attributes should be provided in /message/catalog/bpp/providers/items/tags https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=1130527843

Flow 2

on_init

• /message/order/payment should not have placeholder values
• @ondc/org/TAT should remain same as provided in on_select

on_confirm

• @ondc/org/TAT should remain same as provided in on_select

on_status (picked)

• why on_status is being sent after 2 hours of pickup (pickup timestamp: 2024-05-05T19:32:29.368Z", context.timestamp: 2024-05-05T21:21:41.368Z)

on_status (delivered)

• pickup timestamp should remain same as provided in on_status (picked)
• on_status should be sent whenever order is delivered and its timestamp (delivery timestamp) should not have much difference with context.timestamp

Flow 5

• order should not get cancelled (rto) after delivery

Flow 6

on_update (part-cancellation)

• forward fulfillment state should not be cancelled in case of partial-order-cancellation
• pickup and delivery range should remain same as provided in previous requests

on_status

• pickup and delivery range should remain same as provided in previous requests
• pickup timestamp should remain same as provided in on_status (picked)
• @ondc/org/settlement_details should have settlement details appended once refund is initiated by BNP

on_update (reverse-qc)

• return reverse-qc fulfillment should have start and end location
• return reverse-qc fulfillment should have pickup and delivery time ranges

Note

on_search

• short_desc and long_desc should not be provided same

@ajayGargSc

[sahil-ondc]

@ajayGargSc, Manipulation of logs is not allowed as per the compliance. Please resubmit flows again.

Github commit history

[ajayGargSc]

Hi Sahil,

In the flow 6 scenario our code was changed thats why this happens. We will resubmit the flow 6 again. But flow1 to 5 were correct so please review them. If we have to resubmit flow 1-5 then please confirm.

Thanks, Ajay Garg

---

From: Sahil Sharma @.> Sent: Tuesday, May 14, 2024 5:59 PM To: ONDC-Official/v1.2.0-logs @.> Cc: Ajay Garg @.>; Mention @.> Subject: Re: [ONDC-Official/v1.2.0-logs] Shopclues SA - compliance check (Issue #1543)

@ajayGargSchttps://github.com/ajayGargSc, Manipulation of logs is not allowed as per the compliance. Please resubmit flows again.

Github commit historyhttps://github.com/ONDC-Official/v1.2.0-logs/commit/ec42ad8a1655747355044ff55b37600efa02ee40#diff-098ff2606423bafbb06a16591d0594436a82d51a93029746c9ed8e2c82d579de

Screenshot.2024-05-14.at.5.54.47.PM.png (view on web)https://github.com/ONDC-Official/v1.2.0-logs/assets/129926973/ec82e98b-079a-4637-aaaa-01f9f7ca8210 Screenshot.2024-05-14.at.5.54.59.PM.png (view on web)https://github.com/ONDC-Official/v1.2.0-logs/assets/129926973/56c0f8e4-4f2e-4636-9760-9d8dfbd409fb

— Reply to this email directly, view it on GitHubhttps://github.com/ONDC-Official/v1.2.0-logs/issues/1543#issuecomment-2110084635, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BE7ABJ6TN32DLUGM6GDM4GTZCH7SBAVCNFSM6AAAAABHDXVHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGA4DINRTGU. You are receiving this because you were mentioned.Message ID: @.***>

[sahil-ondc]

@ajayGargSc, Kindly resubmit entire logs. And please make sure, there is not manual manipulation done.

[ajayGargSc]

Hi Sahil,

Submitted again. Please check. https://github.com/ONDC-Official/v1.2.0-logs/pull/1629 [https://opengraph.githubassets.com/424f87b496feab22b4491d76ba5796d2b5eb22bf5e51cafe3dadb149c8eca373/ONDC-Official/v1.2.0-logs/pull/1629]https://github.com/ONDC-Official/v1.2.0-logs/pull/1629 shopclues ret flow by ajayGargSc · Pull Request #1629 · ONDC-Official/v1.2.0-logshttps://github.com/ONDC-Official/v1.2.0-logs/pull/1629 flow 1-6 submittd github.com

Thanks, Ajay

---

From: Sahil Sharma @.> Sent: Wednesday, May 15, 2024 1:50 PM To: ONDC-Official/v1.2.0-logs @.> Cc: Ajay Garg @.>; Mention @.> Subject: Re: [ONDC-Official/v1.2.0-logs] Shopclues SA - compliance check (Issue #1543)

@ajayGargSchttps://github.com/ajayGargSc, Kindly resubmit entire logs. And please make sure, there is not manual manipulation done.

— Reply to this email directly, view it on GitHubhttps://github.com/ONDC-Official/v1.2.0-logs/issues/1543#issuecomment-2111871235, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BE7ABJ2ZDZ4DUPKKUWPRDT3ZCMLDTAVCNFSM6AAAAABHDXVHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRHA3TCMRTGU. You are receiving this because you were mentioned.Message ID: @.***>

[Jagannath-wits]

Shopclues : RET 12

Flow 1

On Search

How is the timestamp for both search and on-search same ?

• bpp/provider: "In categories, descriptor name shouldn't be a placeholder i.e instead of naming varient group 0 or 1 ; name it according to the type variant."

On Search Incremental Refresh

How is the timestamp for both search_inc and on-search_inc same ?

• on_search_inc_refresh_msgId: "Message id should not be same with previous calls as it's incremental push based call"

Flow 2 and Flow 3

On Status All

why is there "parent_item_id": “1” in items ? Its only required for RET11 i.e when there are dynamic item id generated.

On Status Picked

• "Tags are mandatory in Delivery Fulfillment for on_status_picked

On Status Out For Delivery

• Same as above

On Status Delivered

• Same as above

Flow 5

On Status Picked

• "Tags are mandatory in Delivery Fulfillment for on_status_picked"

On Status Out For Delivery

• Same as above

  On Status RTO Delivered

  RTO fulfillment is missing

Flow 6

Settlement details Object of update are not carried forward in entire flow/missing i.e settlement details of update_settlement_part_cancel is not present in on_status, etc.

Update Settlement Part Cancel

• Missing payload and is required

On Status Pending

• "The start/timestamp can't be there in on_status_pending as it will come in on_status_picked"
• "The end/timestamp can't be there in on_status_pending as it will come in on_status_delivered"

On Status Picked

• "Tags are mandatory in Delivery Fulfillment for on_status_picked"

On Status Out For Delivery

• Same as above

On Status Delivered

• Same as above

On Update Delivered

• "Missing payment/@ondc/org/settlement_details as compare to update_settlement_reverse_qc i.e. {\"settlement_counterparty\":\"buyer\",\"settlement_phase\":\"refund\",\"settlement_type\":\"paylater\",\"settlement_amount\":\"1660\",\"settlement_timestamp\":\"2024-05-21T10:53:55.596Z\"}"

On Update Interim Liquidated

• Same as above

On Update Liquidated

• Same as above

Update Settlement Liquidated

• Missing payload and is required

  Please provide the missing action calls for Flow 6

@ajayGargSc

[Jagannath-wits]

Flow 1

On_search_full_catalog:

• Timing object for order is missing.

On_search_inc

• ‘abbey’ is not a right colour code. Please don't change colour from hex code to name.

  Flow 2

on_status

• If the order is in same city; routing won’t be p2h2p as in your case it’d be going directly from warehouse to buyer so in this scenario it’d be p2p.

Flow 5

On_cancel:

• RTO-fulfillment.end.timestamp wont be present as state is RTO-initiated and only present in on_status-rto-delivered/disposed.

Flow 6

on_status_picked

• Invoice should be updated after part cancel.

on_update_part cancel

• Missing cancel_request in cancel-fulfillment.tags.

on_update_approval onwards

• Return fulfillment missing start and end.

@ajayGargSc

[ajayGargSc]

As we already told you partial cancel will not happen in our system. So invoice will not gonna change so can you ignore partial cancel issues like invoice. other we will resolve.

[ajayGargSc]

@sandeepshahi , please confirm in flow 2 we a giving P2H2P as akshay said for P2P tracking is mandate we do not provide gps tracking, we send tracking false in confirm api. So please ignore P2H2P error as well. If tracking not mandate for P2P then we will send P2P. Please confirm.

[ajayGargSc]

flow 1-5-6 errors resolved. Please review and approve. https://github.com/ONDC-Official/v1.2.0-logs/pull/1762

[sandeepshahi]

Flow 1

/on_search

• can variants based on multiple attributes be created?
• back_image attribute in items/tags/image must be provided if values are not being provided in statutory reqs
• placeholder values of item images/description/HSN/size_chart should not be provided
• "sku" is not a valid code in items/tags/attribute

Flow 2

/on_search

• why are the catalog provided in flow 1 and 2 different? even though the context details are the same; check info like time_to_ship etc.

/on_select

• is 4 days TAT fixed or is it being calculated dynamically based on store/delivery location
• Is multiple fulfillment supported within a single order? In Fashion domain, the store location/TAT may differ based on the item
• ttl in /quote should not change in subsequent APIs
• items/quantity need not be provided in /on_select

/on_init

• "@ondc/org/provider_name", "@ondc/org/category", "@ondc/org/TAT", "state" etc. are not required in /fulfillments

/on_confirm

• store id in /start/location/id is incorrect; should be "1L1" instead of "L1"
• If the maximum time to ship for the items in the cart is mentioned as 4 hours (as per the catalog), why is the estimated pickup time range given as 3 days?
• where is the start/contact information being captured from?
• why is routing provided as P2H2P for hyperlocal order?
• tracking in /tags need not be provided if tracking=false

/on_status

• since the order is being auto accepted in /on_confirm, no need to call /on_status (Pending) later
• routing info must be provided before order picked state
• "@ondc/org/TAT" should not change in the subsequent APIs; must remain the same as provided in /on_select
• why is the millisecond value always "368" in all the unsolicited calls?

Flow 3,4

• similar issues as above

Flow 5

/on_cancel

• value of "rto_id" in /tags/cancel_request is incorrect; should be the fulfillment id of RTO shipment

Flow 6

/on_update (part cancel)

• fulfillment id of part cancellation is also created as "C1"; what would the fulfillment ID be if the buyer triggers a full order cancellation afterward?

/on_status

• why is on_status pending called after part cancellation
• why is the invoice not being sent correctly? Since, invoice is generated once the order is shipped, it should not contain the part cancelled item

/on_update (return)

• "id" code need not be provided in /tags/return_request
• "images" and "reason_desc" must be provided in return_request;
• Return Approved: estimated return pickup time ranges must be feasible and realistic
• returned item should not be removed from quote/breakup; must be present with count=0

@ajayGargSc

[amandeepverma2908]

Hi Sandeep,

We have few issues as it's not clarified.

As discussed with Jagan in previous meeting there were no errors in flow 2,3,4 so we submitted the same again except P2H2P which was suggested by Akshay and Robin to share the same so we were asked to submit the same, as per the same in flow 6 we're getting approval from nishtha for part-cancel as it's not integrated in our system, so kindly ignore it. And few questions which we're not able to understand so, we have mailed you a link for meet. For clarifying our doubts. Please confirm

[ajayGargSc]

1.can variants based on multiple attributes be created? = yes

2. is 4 days TAT fixed or is it being calculated dynamically based on store/delivery location = not fixed comes from api
3. Is multiple fulfillment supported within a single order? In Fashion domain, the store location/TAT may differ based on the item = only one fulfillment for each merchant for each order.
4. items/quantity need not be provided in /on_select = extra input not a issue
5. why is the millisecond value always "368" in all the unsolicited calls? = the time of output api will always be greater than input api.
6. partial cancel ignore
7. extra inputs also not a issue as discussed.

[ajayGargSc]

@sandeepshahi we have submitted logs and raised the pull req please check and confirm. https://github.com/ONDC-Official/v1.2.0-logs/pull/1822

[sandeepshahi]

Flow 1

/on_search

• the provider ID was supposed to be added as a prefix to the location ID, or has this changed?
• HSN code provided is mapped incorrectly with the item; eg: HSN - "61071100" is not related to Tshirts

/on_status

• since the order is being auto accepted in /on_confirm, no need to call /on_status (Pending) later
• millisecond value is still "368" in all the unsolicited calls?

Flow 5

/on_confirm

• The delivery TAT is provided as 4 days but the estimated range shows 6 to 7 days for delivery. Why is the consignment timing logic changing in the flows?

/on_status (RTO-Delivered)

• order state should not change from "Cancelled" to "Completed"

Flow 6

/on_update (part cancel)

• as discussed, you were not supposed to send the logs for this; The invoice is not being sent accordingly

/on_update (interim liquidated)

• multiple duplicate "routing" and "tracking" blocks in the /fulfillments

@ajayGargSc

[ajayGargSc]

1. the provider ID was supposed to be added as a prefix to the location ID, or has this changed? we have updated our location by not sending provider id before but if you are expecting we have changed now with provider id. but its not a error.
2. HSN code provided is mapped incorrectly with the item; eg: HSN - "61071100" is not related to Tshirts = for hsn code its test pid so we have updated the hsn code in product.
3. millisecond value is still "368" in all the unsolicited calls? = we converting our value to gm format using this. echo gmdate("Y-m-d\TH:i:s.368\Z",1718408244); but now we will use gmdate("Y-m-d\TH:i:s.999\Z",1718408244); so that to provide always the highest value.
4. since the order is being auto accepted in /on_confirm, no need to call /on_status (Pending) later = okk we will not send that.
5. The delivery TAT is provided as 4 days but the estimated range shows 6 to 7 days for delivery. Why is the consignment timing logic changing in the flows? = we are using the product edd api from where we get the estimated time before and order edd api after order. But after order placed order edd api is giving different time for these test pids. We will fix this. but this will not come for actual merchant and actual pid.

[amandeepverma2908]

Hi Sandeep,

Can we submit pramaan utility logs.

[ajayGargSc]

@sandeepshahi we have raised pull req for duplicate routing and cancelled in flow 5 and flow6. Others were okk. So please merge and provide approval. Thanks. https://github.com/ONDC-Official/v1.2.0-logs/pull/1843