Open sahil-ondc opened 4 months ago
@sahil-ondc thanks for the reply we are looking into it. And will resolve asap. Can you please confirm for error msg in flow 2 a. Buyer selects multiple items (> 1 qty for each item) for checkout; in this scenario we can provide 2 items with 2 qty each then it is enough right? or we have to provide more than 2 items? and one more query like attributes which you provided and mandate we are giving but if we sending extra then buyer can use it or not. It should not provide error. So please confirm if we need to remove extra attributes which are not as per your sheet? The errors like not needed or optional we can provide those right?
Also we do not do partial-cancellation in ondc orders so we can skip those right.
https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=1130527843
@ajayGargSc
@ajayGargSc, Manipulation of logs is not allowed as per the compliance. Please resubmit flows again.
Hi Sahil,
In the flow 6 scenario our code was changed thats why this happens. We will resubmit the flow 6 again. But flow1 to 5 were correct so please review them. If we have to resubmit flow 1-5 then please confirm.
Thanks, Ajay Garg
From: Sahil Sharma @.> Sent: Tuesday, May 14, 2024 5:59 PM To: ONDC-Official/v1.2.0-logs @.> Cc: Ajay Garg @.>; Mention @.> Subject: Re: [ONDC-Official/v1.2.0-logs] Shopclues SA - compliance check (Issue #1543)
@ajayGargSchttps://github.com/ajayGargSc, Manipulation of logs is not allowed as per the compliance. Please resubmit flows again.
Github commit historyhttps://github.com/ONDC-Official/v1.2.0-logs/commit/ec42ad8a1655747355044ff55b37600efa02ee40#diff-098ff2606423bafbb06a16591d0594436a82d51a93029746c9ed8e2c82d579de
Screenshot.2024-05-14.at.5.54.47.PM.png (view on web)https://github.com/ONDC-Official/v1.2.0-logs/assets/129926973/ec82e98b-079a-4637-aaaa-01f9f7ca8210 Screenshot.2024-05-14.at.5.54.59.PM.png (view on web)https://github.com/ONDC-Official/v1.2.0-logs/assets/129926973/56c0f8e4-4f2e-4636-9760-9d8dfbd409fb
— Reply to this email directly, view it on GitHubhttps://github.com/ONDC-Official/v1.2.0-logs/issues/1543#issuecomment-2110084635, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BE7ABJ6TN32DLUGM6GDM4GTZCH7SBAVCNFSM6AAAAABHDXVHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGA4DINRTGU. You are receiving this because you were mentioned.Message ID: @.***>
@ajayGargSc, Kindly resubmit entire logs. And please make sure, there is not manual manipulation done.
Hi Sahil,
Submitted again. Please check. https://github.com/ONDC-Official/v1.2.0-logs/pull/1629 [https://opengraph.githubassets.com/424f87b496feab22b4491d76ba5796d2b5eb22bf5e51cafe3dadb149c8eca373/ONDC-Official/v1.2.0-logs/pull/1629]https://github.com/ONDC-Official/v1.2.0-logs/pull/1629 shopclues ret flow by ajayGargSc · Pull Request #1629 · ONDC-Official/v1.2.0-logshttps://github.com/ONDC-Official/v1.2.0-logs/pull/1629 flow 1-6 submittd github.com
Thanks, Ajay
From: Sahil Sharma @.> Sent: Wednesday, May 15, 2024 1:50 PM To: ONDC-Official/v1.2.0-logs @.> Cc: Ajay Garg @.>; Mention @.> Subject: Re: [ONDC-Official/v1.2.0-logs] Shopclues SA - compliance check (Issue #1543)
@ajayGargSchttps://github.com/ajayGargSc, Kindly resubmit entire logs. And please make sure, there is not manual manipulation done.
— Reply to this email directly, view it on GitHubhttps://github.com/ONDC-Official/v1.2.0-logs/issues/1543#issuecomment-2111871235, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BE7ABJ2ZDZ4DUPKKUWPRDT3ZCMLDTAVCNFSM6AAAAABHDXVHR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRHA3TCMRTGU. You are receiving this because you were mentioned.Message ID: @.***>
How is the timestamp for both search and on-search same ?
How is the timestamp for both search_inc and on-search_inc same ?
why is there "parent_item_id": “1” in items ? Its only required for RET11 i.e when there are dynamic item id generated.
RTO fulfillment is missing
@ajayGargSc
@ajayGargSc
As we already told you partial cancel will not happen in our system. So invoice will not gonna change so can you ignore partial cancel issues like invoice. other we will resolve.
@sandeepshahi , please confirm in flow 2 we a giving P2H2P as akshay said for P2P tracking is mandate we do not provide gps tracking, we send tracking false in confirm api. So please ignore P2H2P error as well. If tracking not mandate for P2P then we will send P2P. Please confirm.
flow 1-5-6 errors resolved. Please review and approve. https://github.com/ONDC-Official/v1.2.0-logs/pull/1762
/on_search
/on_search
/on_select
/on_init
/on_confirm
/on_status
/on_cancel
/on_update (part cancel)
/on_status
/on_update (return)
@ajayGargSc
Hi Sandeep,
We have few issues as it's not clarified.
As discussed with Jagan in previous meeting there were no errors in flow 2,3,4 so we submitted the same again except P2H2P which was suggested by Akshay and Robin to share the same so we were asked to submit the same, as per the same in flow 6 we're getting approval from nishtha for part-cancel as it's not integrated in our system, so kindly ignore it. And few questions which we're not able to understand so, we have mailed you a link for meet. For clarifying our doubts. Please confirm
1.can variants based on multiple attributes be created? = yes
@sandeepshahi we have submitted logs and raised the pull req please check and confirm. https://github.com/ONDC-Official/v1.2.0-logs/pull/1822
/on_search
/on_status
/on_confirm
/on_status (RTO-Delivered)
/on_update (part cancel)
/on_update (interim liquidated)
@ajayGargSc
Hi Sandeep,
Can we submit pramaan utility logs.
@sandeepshahi we have raised pull req for duplicate routing and cancelled in flow 5 and flow6. Others were okk. So please merge and provide approval. Thanks. https://github.com/ONDC-Official/v1.2.0-logs/pull/1843
Flow 1
on_search (full_catalog)
https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=1130527843
on_search (inc_catalog)
Flow 2
select
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
on_init
on_confirm
on_status (picked)
Flow 3
select (out-of-stock)
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
Flow 4
on_cancel
Flow 5
on_cancel (rto)
Flow 6
@ajayGargSc