ENAM (RET:10) - compliance check

sahil-ondc commented 3 months ago

Flow 1

on_search (full_catalog)

code should provided in /message/catalog/bpp/providers[0]/items[0]/descriptor
contact number and email should not be provided as placeholder (provided: 2222222222, test@gmail.com)
variants should be provided
categories provided should be mapped to items
provided area_code should be as per provided gps in /message/catalog/bpp/providers[0]/locations
@ondc/org/statutory_reqs_prepackaged_food should be provided as per the sheet https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=0

search and on_search (inc catalog)

Transactional logs should be submitted https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

Flow 2, Flow 3

on_select

all the fulfillments mentioned in /message/order and are serviceable should be mapped in breakup also
why 'Standard Delivery' is provided two times ?

init

address should not have placeholder values

confirm

till /on_init, payment was about to be collected by BPP, but now collected_by is BAP

on_confirm

store name /fulfillments[0]/start/location/descriptor/name can't change
cancellation should not be provided as empty object

on_status

billing object created_at and updated_at mismatches
fulfillment state 'Agent-assigned', 'Pending' is missing
invalid pickup and delivery range provided
while fulfillment state is 'Packed', order state cannot be 'Accepted'
pickup timestamp not captured correctly
for solicited /status, on_status must be provided (message_id: 8caba301-e064-43f8-8122-9305dd30c217)

Flow 4

on_cancel

invalid pickup and delivery range provided

Note

Kindly submit missing flows (5 and 6) https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

@vishalbitxia

sandeepshahi commented 3 months ago

@vishalbitxia, please check for similar issues raised in AGR11 and rectify them for retail logs. Also, submit the log validation utility report along with the logs.

sandeepshahi commented 3 months ago

RTO

similar issues as raised for AGR10

/on_cancel

similar issues as /on_cancel (flow 4)
invalid schema of /cancellation object; should be /reason (instead of reasons)
/cancellation is optional for RTO cancellation;
actual pickup timestamp is missing from forward shipment: "246"; audit trail must be maintained
invalid value of "type" for RTO shipment "ERET-29835663-3fe3-4269-9853-14c22f534d88"; should be "RTO" instead of "Return"
start and end objects information are missing in RTO fulfillment

/on_status (RTO-disposed)

similar issues as abvoe
invalid quantity in /items; entire audit trail must be maintained
trail for quote/breakup must be maintained; unit price must be provided
calculation of item prices must be correct;
fulfillment state should be RTO-disposed;
is RTO delivery (back to seller) supported?

Return

/on_update (shortfall)

"provider_id" is not a valid attribute
fulfillment state is not captured correctly; packed is called later
initiated_by is not captured correctly in cancel_request;
item id is incorrect in tags/quote_trail for part cancel fulfillment

/on_status (packed onwards)

trail for quote should be maintained; price should not change from 450 to 600
refund related FYI info received in /update should be appended as part of @ondc/org/settlement_details

/on_status (delivered)

why is the item quantity mapped with part cancel fulfillment changed to -1;
how can return be initiated even before item is delivered?

/on_update (Return)

RTO was disposed but during return, it is being delivered back to the seller. How?
For liquid products, liquidation flow must be provided
invalid "@ondc/org/settlement_window"

/update (Return)

Return_Initiated state can't be provided by buyer app; fulfillments/state is not valid

/on_update (Return Initiated)

message_id should be same as in /update for solicited call
tracking/provider_id/tat/provider_name are invalid properties for Return fulfillment

/on_update (Approved)

estimated return pickup and delivery ranges should be feasible and realistic
actual return pickup timestamp can't be provided in approved state

/on_update (Picked)

/items are not correctly updated
quote issue as mentioned earlier

@vishalbitxia @animesh-bitxia

sandeepshahi commented 3 months ago

/on_search

provide multiple items in the catalog for verification
item images must be accessible
How can EAN code be provided for non-branded products?

@animesh-bitxia

sandeepshahi commented 3 months ago

similar issues as raised for Agri logs

Flow 1

/on_search

store's location must be the same as the city in context/city; since search by city was initiated
duplicate objects in serviceability block
unitized measure for items must be correctly used; eg: milkshake should be in millilitre/litre
proper statutory reqs must be provided as per the category_id; check the mapping here
returnable is set as true but return window is provided as 0 days; eg check for item id: "1392"
invalid objects still provided in /categories

/on_select

multi fulfillment option received from seller app must be allowed to be selected by buyer
why is the maximum count of item changed in quote/breakup

order flow issues same as raised for Agri logs

Flow 6

/on_update (shortfall)

message_id and timestamp can't be the same as in /on_status (packed)
part cancel must be initiated

/on_status (picked)

why is the fulfillment state not updated?
Out-for-delivery and Order-delivered states are missing

/update

payload missing

/on_update

several discrepancies in the audit trail of items/fulfillments; item ids getting changed; pickup and delivery timestamp not being maintained

@vishalbitxia

sahil-ondc commented 1 month ago

Flow 1

Kindly provided flow for RET:10

Flow 2

On Select - If the delivery charges are zero, shouldn’t be provided

Init

email is optional in nature in the fulfillments
tracking field is not required in fulfillments

On Init

start object in delivery fulfilment is not required
payment settlement_details missing in /on_init

Confirm

In on_init the payment was being collected by ‘BPP’ but why it’s being changed to ‘BAP’

On Confirm

Payment object mismatches as compare to Confirm action call

On Status Delivered

The timestamp provided for end object is not in the given range provided for delivery fulfillment

Flow 3, 4, 5

same as flow 2

On Confirm

Kindly provide on_confirm action call instead of confirm call

On Cancel

/message/order must NOT have additional properties (tags)
/message/order must NOT have additional properties (documents)
Transaction_id missing in message/order/payment
precancel_state.updated_at of on_cancel is not equal with the on_status_out_for_delivery order.updated_at
Key 'created_at' mismatch: 2024-07-16T06:32:05.658Z !== 2024-07-16T06:32:05.000Z when compared with init billing object
Key 'updated_at' mismatch: 2024-07-16T06:32:05.658Z !== 2024-07-16T06:32:05.000Z when compared with init billing object

Flow 6

Same as flow 2

On Update Part Cancel

/context/action must be equal to constant (on_update)

Update Reverse_Qc

Kindly provided valid payload for update reverse_qc

On Update Interim Reverse Qc

/message/order/payment/params must have required property 'transaction_id'
Message Ids for /update_reverse_qc and /on_update_interim_reverse_qc api should be same

On Update Approval

Return fulfillment start and end object is missing in on_update_approval

On Update Return Picked

timestamp for return pickup should be in the given range provided for ‘Return’ fulfilment

Kindly provide proper flow 6 according to the contract. Somewhere the update settlement calls are missing and somewhere the payloads are wrong provided like in update reverse_Qc. Also provide the updated flow1 for more precise checking of logs

@vishalbitxia

ONDC-Official / v1.2.0-logs