ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 254 forks source link

Wits Adapter - LSP - compliance #1700

Open abhinavv245 opened 4 months ago

abhinavv245 commented 4 months ago

/on_search

/on_init

/on_update

/on_status_cancelled (RTO)

P2H2P

@robinchauhan2

BLR-0118 commented 3 months ago

Deferred:

  1. /on_search: what logic is used to compute motorable distance & how can motorable distance of 45km have S2D of 60min?
  2. /on_init: tax of 5.5% is based on what logic?
  3. /on_update:
    • max pickup time is 15 min but pickup slot has range of 25 min from /on_update timestamp?
    • TAT quoted is 45 min but delivery start slot is 45 min from pickup start slot but corresponding end slot isn't matching?
  4. /on_status_order_picked_up:
    • following in fulfillment.end is invalid:
    • "tags": [{ "code": "url_enabled", "value": "yes" }]

@witslab-nikita - pls see issues above;

witslab-nikita commented 3 months ago

@BLR-0118 @abhinavv245, Thanks for your feedback.

  1. We are using geolib to find motorable distance and duration for the trip, between start and end location.
  2. For log submission purposes we have followed these tax norms, but we are flexible to change these as per our clients. https://cleartax.in/s/goods-transport-agency-under-gst
  3. We have followed these instructions formula for calculating pickup and delivery time ranges. (start/range/start- context/timestamp)+ (start/range/end - context/timestmap)/2 = average pickup time (edited)
  4. We are resubmiting with updated fulfillment.end.