ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 274 forks source link

KNS Retail (SA : RET16) - Compliance Check #1709

Open Jagannath-wits opened 5 months ago

Jagannath-wits commented 5 months ago

KNS Retail

Flow 1 - On_search

Flow 2 - On_confirm

Flow 3 - on_select_oos

Flow 5 - On_cancel

Flow 6

@VirajjKAS

Jagannath-wits commented 5 months ago

Flow 1

On Search Full Catalog Refresh

Flow 2

On Init

Flow 4

Flow 6

On Status Picked

On Update Reverse_Qc

On Update Approval

On Update Picked

On Update Delivered

Update Settlement Reverse QC

@VirajjKAS

aniketmishra13122 commented 5 months ago

@Jagannath-wits hey jagannathan here Update Settlement Reverse QC context/timestamp/: Context timestamp of /update_settlement_reverse_qc should be greater than context timestamp of /on_update_delivered.

how can be update_settlement_reverse_qc can be greater then on_update_delivered becuse we get update_settlment_reverse_qc when item is picked up

aniketmishra13122 commented 5 months ago

bpp/providers[0]/items[0]/descriptor/code: Code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

for this i am passing the GTIN number 3:GTIN as mention on the log validation utility i am putting 1:EAN number it throws error in utilty

Jagannath-wits commented 5 months ago

@Jagannath-wits hey jagannathan here Update Settlement Reverse QC context/timestamp/: Context timestamp of /update_settlement_reverse_qc should be greater than context timestamp of /on_update_delivered.

how can be update_settlement_reverse_qc can be greater then on_update_delivered becuse we get update_settlment_reverse_qc when item is picked up

@aniketmishra13122 Please Disregard this error

Jagannath-wits commented 5 months ago

bpp/providers[0]/items[0]/descriptor/code: Code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

for this i am passing the GTIN number 3:GTIN as mention on the log validation utility i am putting 1:EAN number it throws error in utilty

@aniketmishra13122 Utility hasn't been merged yet please proceed with EAN.

Jagannath-wits commented 5 months ago

Flow 1

on_search

Flow 2

on_status_picked:

Flow 5

Flow 6

on_update_interim_reverse_qc

on_status_picked

@aniketmishra13122,

sandeepshahi commented 5 months ago

Flow 1

/on_search

/on_search (inc)

Flow 2

/on_select

/on_init

/on_confirm

/on_status

Flow 3

/select

Flow 4

/on_cancel

Flow 5

/on_cancel

Flow 6

/on_update (part cancel)

/on_update (return approved)

/on_update (liquidated)

@VirajjKAS

aniketmishra13122 commented 5 months ago

Hey @sandeepshahi ,

Thanks for your input. We have a few concerns regarding your checks. Could you please clarify the following:

EAN Code: The EAN code seems to be invalid. EAN codes are mostly provided for packaged branded products. For sofas and other similar products, we may need to use other codes. Jagannathan mentioned using EAN, which we are currently using, but previously, we were using GTIN. Could you suggest an appropriate code for unpacked items?

Serviceability for All Item Categories: Serviceability is not defined for categories like "Bathroom and Kitchen fixtures." Since these are subcategories under the parent category "Home and Kitchen," should we add serviceability for each subcategory individually, or should we define it once for the parent category "Home and Kitchen" (RET:16)?

Incremental Refresh Scenarios: As mentioned in the contract, are all scenarios of incremental refresh supported? We do handle store status and changes in items.

Delivery TAT: Is the delivery TAT hardcoded as 8 days, or is it dynamically calculated? Eight days seems like a long TAT given the delivery and pickup locations provided. This is dynamic, as our merchant receives orders from across India, so we asked them what the standard time to deliver an order should be.

Payment Fields: Fields such as type, collected_by, uri, status, settlement_basis, settlement_window, and withholding_amount in /payment should only be provided if the seller NP is collecting prepaid payment. Are you referring to the buyer's side payment while making the order?

Please review and let us know your thoughts

sandeepshahi commented 4 months ago

Flow 1

/on_search

/on_search (inc)

Flow 2

/on_status

Flow 4

/on_cancel

Flow 5

/on_cancel

/on_status (delivered)

Flow 6

/on_status

/on_update (return approved)

@VirajjKAS

aniketmishra13122 commented 4 months ago

Hey @sandeepshahi , thanks for the Suggestion we have few queries regarding your validation

1.back_image is optional and only required if details in "@ondc/org/statutory_reqs_packaged_commodities" are not present : in this case we are providing @ondc/org/statutory_reqs_packaged_commodities therefore we have shared the back image

2.billing object should not change; must remain the same as in /init : billing object seems same in both of the api

3>when the estimated pickup time range is given for the first time, it should always be a future time: these are future date only 4>pickup/delivery time ranges must be in sync with time to ship and delivery TAT: these are syn with TAT Only 4 days 5>why are estimated pickup/delivery time ranges being provided when the order is getting cancelled? wasn't provided in /on_confirm earlier : these is done as per contract in on_cancel api for forward shipment it is provieded

for FLow 5 also we have some issue

Hey Sandeep could we connect over call to discuss everything

sandeepshahi commented 4 months ago

Flow 1

/on_search (full/inc)

Flow 2

/on_status

Flow 5

/on_cancel

/on_status (delivered)

Flow 6

/on_update

@VirajjKAS

sandeepshahi commented 4 months ago

Flow 1

/on_search (full/inc)

Clarifications:

@VirajjKAS, please fix the above issues and complete the pending submissions on the portal for approval.