Open Jagannath-wits opened 5 months ago
bpp/providers[0]/items[0]/descriptor/code
: Code should have 1:EAN
as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
.desc
: Long desc and short desc code should not be the same. Example: For bpp/providers/descriptor
, bpp/providers/items/0
.prvdr0/tags/timing/Self-Pickup
: The timings object must be present for Self-Pickup in the tags.prvdr0/tags/timing/order
: The timings object must be present for Order in the tags.message.order
: 'cancellation_terms'
in /message/order
should not be provided as those are not enabled yet.inititated_by
: This should be bap_idinvoice
: invoice should be publically accessible, please remove any expiration from the urls; It should also be update after part_cancelprovider/items/1
: Tags are not required in the item with id: 614"
provider/items/1
: Return fulfillment for the item_id 614
should be created at on_update_pickedReturnFulfillment.end
: Return fulfillment end object is missing in on_update_approval
.ReturnFulfillment.start
: Return fulfillment start object is missing in on_update_approval
.ReturnFulfillment.end
: Return fulfillment end object is missing in on_update_picked
.ReturnFulfillment.start
: Return fulfillment start object is missing in on_update_picked
.ReturnFulfillment.end
: Return fulfillment end object is missing in on_update_delivered
.ReturnFulfillment.start
: Return fulfillment start object is missing in on_update_delivered
.context/timestamp/
: Context timestamp of /update_settlement_reverse_qc
should be greater than context timestamp of /on_update_delivered
.@VirajjKAS
@Jagannath-wits hey jagannathan here Update Settlement Reverse QC context/timestamp/: Context timestamp of /update_settlement_reverse_qc should be greater than context timestamp of /on_update_delivered.
how can be update_settlement_reverse_qc can be greater then on_update_delivered becuse we get update_settlment_reverse_qc when item is picked up
bpp/providers[0]/items[0]/descriptor/code: Code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
for this i am passing the GTIN number 3:GTIN as mention on the log validation utility i am putting 1:EAN number it throws error in utilty
@Jagannath-wits hey jagannathan here Update Settlement Reverse QC context/timestamp/: Context timestamp of /update_settlement_reverse_qc should be greater than context timestamp of /on_update_delivered.
how can be update_settlement_reverse_qc can be greater then on_update_delivered becuse we get update_settlment_reverse_qc when item is picked up
@aniketmishra13122 Please Disregard this error
bpp/providers[0]/items[0]/descriptor/code: Code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
for this i am passing the GTIN number 3:GTIN as mention on the log validation utility i am putting 1:EAN number it throws error in utilty
@aniketmishra13122 Utility hasn't been merged yet please proceed with EAN.
short_desc
and long_desc
shouldn’t be the same. For example:
"short_desc": "KAS Store"
"long_desc": "KAS Store"
retry_count
is missing in cancel_requestpart_cancel
.@aniketmishra13122,
/on_search
/on_search (inc)
/on_select
/on_init
/on_confirm
/on_status
/select
/on_cancel
/on_cancel
/on_update (part cancel)
/on_update (return approved)
/on_update (liquidated)
@VirajjKAS
Hey @sandeepshahi ,
Thanks for your input. We have a few concerns regarding your checks. Could you please clarify the following:
EAN Code: The EAN code seems to be invalid. EAN codes are mostly provided for packaged branded products. For sofas and other similar products, we may need to use other codes. Jagannathan mentioned using EAN, which we are currently using, but previously, we were using GTIN. Could you suggest an appropriate code for unpacked items?
Serviceability for All Item Categories: Serviceability is not defined for categories like "Bathroom and Kitchen fixtures." Since these are subcategories under the parent category "Home and Kitchen," should we add serviceability for each subcategory individually, or should we define it once for the parent category "Home and Kitchen" (RET:16)?
Incremental Refresh Scenarios: As mentioned in the contract, are all scenarios of incremental refresh supported? We do handle store status and changes in items.
Delivery TAT: Is the delivery TAT hardcoded as 8 days, or is it dynamically calculated? Eight days seems like a long TAT given the delivery and pickup locations provided. This is dynamic, as our merchant receives orders from across India, so we asked them what the standard time to deliver an order should be.
Payment Fields: Fields such as type, collected_by, uri, status, settlement_basis, settlement_window, and withholding_amount in /payment should only be provided if the seller NP is collecting prepaid payment. Are you referring to the buyer's side payment while making the order?
Please review and let us know your thoughts
/on_search
/on_search (inc)
/on_status
/on_cancel
/on_cancel
/on_status (delivered)
/on_status
/on_update (return approved)
@VirajjKAS
Hey @sandeepshahi , thanks for the Suggestion we have few queries regarding your validation
1.back_image is optional and only required if details in "@ondc/org/statutory_reqs_packaged_commodities" are not present : in this case we are providing @ondc/org/statutory_reqs_packaged_commodities therefore we have shared the back image
2.billing object should not change; must remain the same as in /init : billing object seems same in both of the api
3>when the estimated pickup time range is given for the first time, it should always be a future time: these are future date only 4>pickup/delivery time ranges must be in sync with time to ship and delivery TAT: these are syn with TAT Only 4 days 5>why are estimated pickup/delivery time ranges being provided when the order is getting cancelled? wasn't provided in /on_confirm earlier : these is done as per contract in on_cancel api for forward shipment it is provieded
for FLow 5 also we have some issue
Hey Sandeep could we connect over call to discuss everything
/on_search (full/inc)
/on_status
/on_cancel
/on_status (delivered)
/on_update
@VirajjKAS
/on_search (full/inc)
@VirajjKAS, please fix the above issues and complete the pending submissions on the portal for approval.
KNS Retail
Flow 1 - On_search
Coordinates: Please don't give space in between coordinates. Eg:
"gps": "19.1129587, 72.8656954"
Timestamp: How is the timestamp for search and on_search the same?
URL Formatting: Formatting (such as "\") should not be present in the URLs. Eg:
Maximum Value: Please provide a reasonable maximum value, i.e., 99 for no limit or some other reasonable value and not 194.
Categories: Categories must be present in bpp/providers so we can check support for variants.
Description: Short and long descriptions should not be the same.
Image URLs: Image URLs should be publicly available. Error e.g., example URL
Flow 2 - On_confirm
State: How can the state be Mumbai? Eg:
Flow 3 - on_select_oos
Error Message:
error.message
in the response should have the list of corresponding item IDs referenced in stringified object notation.For example, if items "I1", "I2", "I3" are out of stock,
error.message
would be encoded as:Flow 5 - On_cancel
rto-fulfillment.end.timestamp
should not be present as the state isrto_initiated
and should only be provided inon_status-rto-delivered
oron_status-rto-disposed
.Flow 6
update_settlement_liquidated
is missing.@VirajjKAS