ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 270 forks source link

Mappls (BA - RET13) - compliance check (SNP - Shopalyst) #1724

Open BLR-0118 opened 5 months ago

BLR-0118 commented 5 months ago

check logs [here]():

  1. /on_search (logs here):
    • variant definition uses attr for unitized qty measure but item unitized qty not correctly filled up for all items, e.g:
    • item 04F076F14C41D4EB60878CDC64054E1F_417_default: should be "10 millilitre" but shows "1 unit";
    • also value for above item is 1800 & max value is 295: this is invalid;
  1. /on_select (logs here):

    • item.quantity.maximum.count & item.quantity.available.count have different values & meaning, compared to what's in /on_search above;
  2. /on_init (logs here):

    • bpp_terms should also include tax_number & provider_tax_number;
  3. /on_confirm:

    • same issue as /on_init above (for tax_number, provider_tax_number);
    • fulfillment.start.contact.phone should be 10/11 digits (without +, spaces, etc);
  4. fulfillment tracking was true in /on_confirm, false in /on_status_Order_accepted, true in /on_status_Order_packed; why?

  5. /on_status_order_intransit:

    • order pickup time (fulfillment.start.time.timestamp) which was set in 5 above is missing for subsequent /on_status but reappears (with correct value) in /on_status_Order_out_for_delivery; why?
  6. not clear if tracking is available or not (see above) but tracking attributes (url_enabled, url) aren't set in /on_status;

  7. /on_select_with_out_of_stock (logs here):

    • item 97B76EE9B3AD7F396DEA4B4658B11959_550_default is out of stock, so item_quantity correctly set to 0; why is unit price (item.price.value being set to 0)?
    • error.message should have the keys & values within double quotes;
  8. /on_cancel (logs here):

    • precancel_state should also be added to forward fulfillment;
  9. /on_cancel_unsolicited (logs here):

    • items[], with items assigned to RTO fulfillment should have same count as what was in forward fulfillment (1 in this case);
    • forward fulfillment should have precancel_state;
    • RTO fulfillment should have start & end locations;
BLR-0118 commented 5 months ago

@kishorgandham - pls check the above;

BLR-0118 commented 5 months ago

@kalaivanansundaram - would be curious to know how you're handling the UX with all the errors mentioned here?

kalaivanansundaram commented 5 months ago

@BLR-0118 sir, sharing our comments against the issues which you have mentioned here.

https://docs.google.com/spreadsheets/d/1soqavHfEu8mXJZGCl2PaZMkn6lI4lT0Ss3dUo48ppC0/edit?usp=sharing