ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 248 forks source link

Mappls (BA - RET12) - compliance check (SNP - Shopcircuit) #1725

Open BLR-0118 opened 3 months ago

BLR-0118 commented 3 months ago
  1. /on_search (logs here):

    • will be helpful if colour_name is also added as attribute, along with colour;
    • category "Home Decor" is in RET16, why is serviceability being defined here?
  2. Incremental on_search (logs here):

    • items.time.timestamp here is same as value for corresponding item in full catalog search (link above); this will be a problem during concurrent processing of full & incremental catalog feeds as buyer app won't know the latest value to apply;
  3. /on_init (logs here):

    • bpp_terms should also include provider_tax_number;
  4. /on_confirm (logs here):

    • calculation of pickup / delivery slots / TAT needs to be checked:
    • for the 3 items in this order, time_to_ship (in /on_search) is 2 / 2 / 7 days: for the order, time_to_ship can be considered as 7 days but pickup slot has been given as 2 days from the /on_confirm Context.timestamp date;
    • TAT is O2D for buyer = T2S (time_to_ship by seller) + S2D (delivery partner);
    • if time_to_ship is 7 days (see above), TAT can't be 5 days;
    • pls ensure that the calculations are aligned;
  5. /on_status_order_delivered (logs here):

    • why is payment.time.timestamp being set here?
  6. /on_cancel (logs here):

    • pls also include precancel_state for forward fulfillment;
  7. /on_cancel - rto (logs here):

    • pls also include precancel_state for forward fulfillment;
    • RTO fulfillment also needs start & end locations;
  8. /on_update - return approved (logs here):

    • on return approved, return end location also to be provided;
    • return fulfillment should also have return_request id;
  9. /on_update - return picked (logs here):

    • return start location provided above is missing here?
  10. Also, considering that fulfillment states for hyperlocal & intercity are different, SNP should communicate the shipment type to buyer app, for them to be able to process & display this; accordingly, when order is accepted by seller, pls also add routing.type to the forward fulfillment as doc here;

BLR-0118 commented 3 months ago

@AtitiTranzita @get2abhi - pls check the above issues & have them fixed in Prod / Pre-prod;

BLR-0118 commented 3 months ago

@kalaivanansundaram - issues for RET12 for Shopcircuit above; for you, request you to put withholding_amount as "0.00", until we enable across the board;

kalaivanansundaram commented 3 months ago

@BLR-0118 we will change the withholding amount to 0. also sharing the other feedback handling in this sheet under RET12 feedback. https://docs.google.com/spreadsheets/d/1soqavHfEu8mXJZGCl2PaZMkn6lI4lT0Ss3dUo48ppC0/edit?usp=sharing