search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 259 forks source link

Costbo (RET10/16) - compliance check #172

Closed sahil-ondc closed 6 months ago

sahil-ondc commented 10 months ago

on_search_full_catalog_refresh

search_inc_refresh

on_search_inc_refresh

@AnanthBo

AnanthBo commented 7 months ago

@BLR-0118 As requested, we are attaching the logs for Flow 1, 2 and 6.
PR# 1116. https://github.com/ONDC-Official/v1.2.0-logs/pull/1116

AnanthBo commented 6 months ago

@BLR-0118 , Supriyo. We have resubmitted 1, 2 & 6 as per your requests. OPS test have cleared all the scenarios as well. Please give us a go ahead for BetaProd.

BLR-0118 commented 6 months ago

Flow 1

  1. /on_search:
    • why is EAN code not being used for items?
    • catalog has items in 1 category; however, category mapping is inconsistent, e.g. item 0106d139963743aea8598533de03feab & d4e6ff6371044c49965c4c48773961c5 are both marmalade but category is different;
BLR-0118 commented 6 months ago

Flow 2

  1. /on_confirm:
    • TAT is 2 days, pickup slot is between 03:07 (15th) & 02:52 (16th), while delivery slot is between 03:52 (15th) & 02:52 (15th): this doesn't add up;

Flow 6

  1. seller invoice is being added in /on_update (part cancel); typically, this is done at Order-picked-up so that additional part cancels can be considered;
  2. since these are resaleable items, why isn't return with pickup being enabled?
BLR-0118 commented 6 months ago

@AnanthBo

AnanthBo commented 6 months ago

@BLR-0118 Sir, Response to your comment:

We are a MSN seller for Brands and this is our sample (replica of original) seller for approval. We have 100s of existing D2C brands which will be thoroughly verified, corrected and updated by our operations team as per ONDC requirement & Brands Input - once our RET10 is validated. Eventually into other Categories.

1). We have 4 options. EAN , HSN & others. We provide a drop down for the brand to enter any one of the options. Brand has given us HSN code. They deal with Jams only. & hence the HSN code is same for all their items. This is acceptable as per contract.

2). Agree, for testing and implementation perspective we have added to similar products into different categories. This is dynamic based on our product table. (This is a drop parameter for brand to choose the category & We also have approval team for live products thats being added before getting live). This is a demo (duplicate of original) seller & We will fix this before we go live . This brand will not go live. This will stay in preprod environment for testing. So please give a exception to this comment.

I would like to give a demo of our system in detail, if you could spare some time & also take inputs for improvement.

AnanthBo commented 6 months ago

@BLR-0118 For Flow 2 & Flow 6, have sent a email for your review. Please let us know.

AnanthBo commented 6 months ago

@BLR-0118 . Thanks Supriyo for your comments. Please confirm if the below is appropriate output based on our discussion.

same city Logistics timeToShip ⇒ 1D +0 ordered - Mar27, 10 am +1 day - Pickup Slot:     Mar28, 2 pm  - Mar 28, 7pm +2 day - Delivery Slot:   Mar29, 10am -   Mar 29, 2pm.

AnanthBo commented 6 months ago

@BLR-0118 please review our logs . this logs addresses comments on the below as requested

PR# 1227

COSTBO-comments from Supriyo addressed for flow1-2-6

  1. flow1 - Onsearch - Grocery tagged to EAN
  2. Flow6 - onupdate- partial CANCEL to remove the Invoice URL & add from "order-picked-up"
  3. flow2 - onconfirm - TAT 2D , pickup slot, delivery slot corrected.
BLR-0118 commented 6 months ago

logs cleared for v1.2.0 (RET10)

BLR-0118 commented 6 months ago

logs cleared for v1.2.0 (RET16)

AnanthBo commented 6 months ago

@BLR-0118 @sahil-ondc @sandeepshahi Thank you Supriyo, Sahil and Sandeep for clearing our RET10 & RET 16 logs.