search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 272 forks source link

Magicpin (SA) - Compliance Check #180

Closed sahil-ondc closed 10 months ago

sahil-ondc commented 11 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_refresh

search_inc_refresh

Flow 2

select

init

on_init

on_status

common

Flows should be submitted as per the sheet

https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

@harshmohta1611

barjinderpaul-mp commented 11 months ago

Hi team.

Can you please re-evaluate this comment - _on_search_increfresh: /message/catalog/bpp/providers/0/locations/0/time/label must be equal to one of the allowed values (enable,disable,close)

The on_search_inc_refresh supports "open" as well. Please, refer to this doc for reference - https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.9duk76cmmly

image
harshmohta1611 commented 11 months ago

@sharmasahil0331

on_search: /message/catalog/bpp/providers/0/items/1/category_ids is already an array of strings, can you please check.

on_select: Quote breakup Payment titles are dependent on seller apps, and aren't standardized. Although we'll make it same as mentioned in protocol.

on_status: /message/order/fulfillments/0/agent already have required property 'name' & 'phone' for assigned, pickedUp and Delivered on_statuses.

BLR-0118 commented 11 months ago
  1. /on_search:
    • callback has timestamp of 14th Nov, while request has timestamp of 27th Oct => is this for the same search request?
    • Magicpin is aggregator (MSN), so np_type should be "MSN";
    • all 3 providers here (45295768, 45949808, 45949809) are being disabled; need enabled providers to check logs;
  2. /incremental_on_search:
    • logs to be submitted for all incremental flows, as per contract;
  3. Logs submitted only up to flow 2. Need logs for all Group B test scenarios here;
BLR-0118 commented 11 months ago

@harshmohta1611

harshmohta1611 commented 11 months ago

Hi Supriyo,

  1. We Have resubmitted the logs till flow 2. GitGuardian checks failed for some reason so can you please explain how to resolve those failures. Is passing the GitGuardian checks mandatory?
  2. What are we supposed to do in flow 3 as a seller NP. Is the flow regarding part cancellation from seller side?

We may get on a call if required. Your response is awaited.

Regards, Harsh Mohta +91 9654543769

On Sat, Dec 16, 2023 at 2:02 PM Supriyo Ghosh @.***> wrote:

@harshmohta1611 https://github.com/harshmohta1611

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/180#issuecomment-1858761608, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6YRCWOUT4T5XEA5BBBNDT3YJVMCNAVCNFSM6AAAAABAA2FPOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYG43DCNRQHA . You are receiving this because you were mentioned.Message ID: @.***>

--

https://www.youtube.com/watch?v=mow6Cl90iJU Local Savings SuperApp 10 Million+ Users | 50+ Cities Android https://play.google.com/store/apps/details?id=com.magicpin.local | iOS https://itunes.apple.com/in/app/magicpin-cashback-deals/id1171775851?mt=8  | Web https://magicpin.in

harshmohta1611 commented 11 months ago

https://github.com/ONDC-Official/v1.2.0-logs/pull/304 @BLR-0118

BLR-0118 commented 11 months ago

@harshmohta1611 - pls submit logs for all flows as per the testcase scenarios. If there are GitGuardian errors, why don't you check the errors & mask the corresponding datapoints/

BLR-0118 commented 10 months ago
  1. /on_search:
    • item.customization_grp_ids is invalid key, must be removed;
  2. Logs are incomplete, need to be submitted as per test scenarios in Group B here;
  3. Only logs for flow 1 & 2 are submitted, need other logs as well;
  4. /on_status:
    • fulfillment.tags.tracking.gps_enabled may be used to indicate gps coordinates have been enabled for tracking to optimize the no of /track requests;
BLR-0118 commented 10 months ago

@harshmohta1611

BLR-0118 commented 10 months ago

Flow 2

  1. /on_select:
    • for 2 items (52418721, 52418713), there's a rounding error in quote.breakup (item unit price * qty != total price);
  2. /on_init:
    • remove provider_location;
  3. /on_confirm:
    • remove order.documents (invoice should be attached when fulfillment state is "Order-picked-up");
  4. /on_status_picked:
    • fulfillment.agent.gps & fulfillment.agent.url are invalid keys;
    • you may set gps_enabled using fulfillment.tags.tracking.gps_enabled (check in /on_status here);
  5. /on_status_delivered:
    • seems to be same as /on_status_picked with fulfillment state changed to "Order-delivered";
    • message_id for /on_status_picked & /on_status_delivered is same as /track;
    • when state changed to "Order-delivered", the delivery time (fulfillment.end.time.timestamp) should also be updated;
  6. /on_status_cancelled:
    • payload is invalid, needs to be as per the format here;
    • cancellation.rejection_id is invalid key;

Flow 3

  1. /on_select_oos:
    • error format should be as defined here & here;

Flow 4

  1. /on_cancel:
    • should be as defined here;

Flow 5

  1. /on_cancel:
    • RTO payload should be as defined here;

Flow 6

I understand Magicpin has enabled part cancel by merchant, as defined here; if so, pls share logs;

BLR-0118 commented 10 months ago

@harshmohta1611 - pls resubmit logs only for the issues above;

BLR-0118 commented 10 months ago

Flow 2

  1. /on_status_picked:

    • gps_enabled, url_enabled has values "yes", "no"; if url_enabled is "yes", also send "url";

  2. /on_status_delivered:

    • same issue as above;
    • pickup time (fulfillment.start.time.timestamp) & delivery time (fulfillment.end.time.timestamp) are same;

  3. /track:

    • callback_url to be removed;

Flow 4

  1. /cancel:

    • 013 is invalid code for BNP; use valid code for BNP from here;

  2. /on_cancel:

    • cancel_request.initiated_by should have subscriber_id / bap_id pf BNP;

Flow 5

  1. /on_cancel:
    • doesn't have required attrs for RTO in cancel_request;
BLR-0118 commented 10 months ago

pls submit logs only for issues mentioned above @harshmohta1611

BLR-0118 commented 10 months ago

Flow 5

  1. Since this is RTO cancellation, rto_id & retry_count should also be part of cancel_request;

Pls have the above fixed. Logs need not be resubmitted;

Logs cleared for F&B, Grocery;