ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 254 forks source link

BuyNxt (SA : RET14) - Compliance check #1827

Open Jagannath-wits opened 3 months ago

Jagannath-wits commented 3 months ago

BuyNxt RET14

Flow 1

on_search_full_catalog_refresh

Flow 2

select

on_select

on_confirm

on_status_packed

on_status_picked

Flow 3

select_out_of_stock

Flow 4

on_cancel

Flow 5

on_cancel

on_status_rto

Flow 6

on_update_part_cancel

on_status_packed

on_status_picked

on_status_out_for_delivery

on_status_delivered

on_update_interim_reverse_qc

on_update_approval

on_update_picked

update_settlement_reverse_qc

on_update_delivered

on_update_interim_liquidated

on_update_liquidated

update_settlement_liquidate

@pranav-buynxt Please provide the utility payload you are using from next iteration onwards and the reports as well as most of these errors could've been flagged by utility

Jagannath-wits commented 3 months ago

Flow 2

on_init

confirm

timestamp should be in rfc3339 format i.e YYYY-MM-DDTHH:MN:SS.MSSZ.

on_status_picked

Flow 4

Flow 5

On_status_rto_delivered

Flow 6

on_update_interim_reverse_qc

update_settlement_reverse qc

update_settlement_liquidated

Settlement details missing hence not carried forward

Note: Please try to follow the flow i.e part-cancel, reverse qc, Liquidation to avoid false errors from utility.

@@pranav-buynxt

Jagannath-wits commented 3 months ago

Flow 1: on_search

Flow 2: on_init

Flow 2: on_status

Flow 3: on_status

Flow 5:

on_status_rto_delivered

on_cancel_rto

Flow 6: on_update_delivered onwards

Flow 6: on_update_liquidated

@pranav-buynxt

pranav-buynxt commented 3 months ago

1 - Flow 1,2,3 and 6 issues are resolved. 2 - For Flow 4, we submitted the on_cancel_rto payload. Could you please clarify why it was marked as missing in your comments?

Additionally, could we arrange a quick call to discuss and clarify a few points?

Jagannath-wits commented 3 months ago

1 - Flow 1,2,3 and 6 issues are resolved. 2 - For Flow 4, we submitted the on_cancel_rto payload. Could you please clarify why it was marked as missing in your comments?

Additionally, could we arrange a quick call to discuss and clarify a few points?

Hi Pranav the comment is for flow 5 where on_cancel_rto is missing @pranav-buynxt

Screenshot 2024-07-01 at 1 32 15 PM
Jagannath-wits commented 3 months ago

Flow 1

on_search

Flow 2

on_status_pending

Flow 3

on_select

Flow 5

on_status_rto_delivered

Flow 6

on_update_part_cancel

update_settlement_part_cancel

update_settlement_reverseqc

@pranav-buynxt

Note

pranav-buynxt commented 3 months ago

for flow 2 -- In our payload, "tracking" is set to "false." Do we still need to provide the routing object??

in Api contract it is optional -- optional, may be provided, on or before fulfillment state of "Agent-assigned", if tracking = "true"; if tracking="true" & this is not provided, default routing.type will be "P2P"

pranav-buynxt commented 3 months ago

??

Jagannath-wits commented 3 months ago

optional, may be provided, on or before fulfillment state of "Agent-assigned", if tracking = "true"; if tracking="true" & this is not provided, default routing.type will be "P2P"

- Yes, routing object is mandatory now

pranav-buynxt commented 3 months ago

okay, but please update these points in the API contract also.

pranav-buynxt commented 3 months ago

For Flow 5 -- on_status_rto_delivered:-- I have cross-checked, and we are passing the start object with the necessary details. Please verify it on your side.

I didn't fully understand your other point od flow 5 We have also cross-verified our logs with the verifier logs of other Seller NPs and found no reference to this in the API contract as well. Could you please provide a document or clarify these points in more detail?

Jagannath-wits commented 3 months ago

For Flow 5 -- on_status_rto_delivered:-- I have cross-checked, and we are passing the start object with the necessary details. Please verify it on your side.

I didn't fully understand your other point od flow 5 We have also cross-verified our logs with the verifier logs of other Seller NPs and found no reference to this in the API contract as well. Could you please provide a document or clarify these points in more detail?

on_status_rto_delivered

@pranav-buynxt updated

Jagannath-wits commented 2 months ago

Flow 5

on_cancel

On_status_rto_delivered

@pranav-buynxt

pranav-buynxt commented 2 months ago

For Eletroinics(RET:14) We only have some minor fixes for Flow 5 only. Could we resubmit only the logs for flow 5 for your review?

pranav-buynxt commented 2 months ago

For Flow 5:-- on_cancel(RTO_fulfillment.start.time should just have just timestamp and not time range): --

If I understand correctly, you mentioned that the RTO.fulfillment.start should only have a timestamp key and not a range object. I have checked our last submitted logs, and we are indeed only passing the timestamp and not the range object. Please cross-verify this at your end. I have also attached a screenshot for your reference. Screenshot (15)

sandeepshahi commented 2 months ago

Flow 1

/on_search

Flow 2

/on_confirm

/on_status (picked)

Flow 4

/on_cancel

Flow 5

/on_cancel

/on_status (RTO)

Flow 6

/on_update (part cancel)

/on_update (picked)

/on_update (delivered)

/on_update (liquidated)

@pranav-buynxt, please fix the above issues and resubmit the logs for Flow 5 and 6

pranav-buynxt commented 2 months ago

Subject: Updated Payloads for Review: Flow 2 /on_confirm and /on_status

Hi Sandeep, As per our discussion today, we have addressed the two points you raised:

1 - How can estimated pickup and delivery time ranges be provided even before the order is accepted? 2 - Considering that the 'time_to_ship' provided in /on_search is 3 hours, how can the estimated pickup time range be only 1 hour?

We have fixed these issues and attached the updated payloads for your review: on_confirm and on_status (order-accepted).

In the updated flow:

We appreciate your time and understanding.

on_confirm.json on_status(order-accepted).json

@sandeepshahi

sandeepshahi commented 2 months ago

Flow 5

/on_cancel

Flow 6

/on_update

@pranav-buynxt