Nivea (SA: RET13) - compliance checks

[sahil-ondc]

Group A

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/0/categories/0 must have required property 'descriptor'
• /message/catalog/bpp/providers/0/categories/0 must have required property 'tags'
• /message/catalog/bpp/providers/0/items/0 must have required property 'category_id'
• /message/catalog/bpp/providers/0/items/0/quantity/unitized/measure/value must be string
• /message/catalog/bpp/providers/0/items/0/quantity/available/count must be string
• /message/catalog/bpp/providers/0/items/0/quantity/available/count must be equal to one of the allowed values (99,0)
• /message/catalog/bpp/providers/0/items/0/quantity/maximum/count must be string
• /bpp/providers[0]/locations[0]/gps coordinates must be specified with at least six decimal places of precision.
• @ondc/org/contact_details_consumer_care should be in the format \"name,email,contactno\" in /bpp/providers[0]/items
• location_id in /bpp/providers/items should be one of the locations id in /bpp/providers[0]/locations
• category in serviceability construct should be one of the category ids bpp/providers[0]/items/category_id

search_inc_refresh

• context/city should be \"*\" while sending search_inc_catalog request
• /message/intent/tags/list/start_time/value cannot be greater than or equal to /context/timestamp
• /message/intent/tags/list/end_time/value cannot be less or equal to than /message/intent/tags/list/start_time/value

on_search_inc_refresh

• bpp/fulfillments sent in payload shoulnd't be part of /on_search_inc_refresh api
• bpp/descriptor sent in payload shoulnd't be part of /on_search_inc_refresh api
• provider id: 6206b4d50faeeaea0a744579 in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh
• /message/catalog/bpp/providers/0/categories/0 must have required property 'tags'

select

• provider.locations[0].id nivea-store-location-1 mismatches in /on_search and /select

on_select

• /message/order/items/0/parent_item_id must be string
• /message/order/quote/breakup/0/item/parent_item_id must be string
• /message/order/quote/breakup/0/item/quantity must have required property 'maximum'
• /message/order/quote/breakup/0/item/quantity/available/count must be string
• /message/order/quote/breakup/1 must have required property '@ondc/org/item_id'

on_init

• invalid json provided

confirm

• invalid json provided

on_confirm

• /message/order must have required property 'tags'
• /message/order must have required property 'updated_at'
• /message/order/billing/address must have required property 'locality'
• /message/order/fulfillments/0/state/descriptor/code must be equal to constant (Pending)
• /message/order/fulfillments/0/start/location must have required property 'id'
• /message/order/fulfillments/0/start/location must have required property 'address'
• /message/order/fulfillments/0/start/contact/phone must NOT have more than 11 characters
• /message/order/payment/@ondc/org/settlement_details/0 must have required property 'beneficiary_name'
• /message/order/payment/@ondc/org/settlement_details/0 must have required property 'bank_name'
• context/timestamp difference between /on_confirm and /confirm should be smaller than 5 sec

@Schbang-parmeshwar

[Schbang-parmeshwar]

Hi @sahil-ondc resubmitted the PR #494

[sahil-ondc]

@Schbang-parmeshwar, Entire new transaction logs should be submitted, any changes should not be done directly into the logs, https://github.com/ONDC-Official/v1.2.0-logs/commit/6c2efabca7d53049662f3cf4aa122e064c5d6d6b https://github.com/ONDC-Official/v1.2.0-logs/commit/11a0d29109048271a816bd518e7f5adb94671b61

[Schbang-parmeshwar]

okay @sahil-ondc

[Schbang-parmeshwar]

Hi @sahil-ondc added new transaction logs and flow 5 please review the PR #539

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• Either frequency and times or range should be provided in /message/catalog/bpp/providers/locations
• /message/catalog/bpp/providers/categories/descriptor should have valid value for 'name'
• /message/catalog/bpp/providers/categories should not have tags as empty array
• kilogram 0 is not a valid measure for Body lotion product provided in items with id: 43001177440483
• Mandatory attributes should be provided as per provided category id in /message/catalog/bpp/providers/items as per the sheet https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=983332432

on_search_inc_catalog_refresh

• Invalid JSON, keys should be provided as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.qjk2p91ld2iu

Flow 2

on_init

• 'provider_location' should not be provided (Deprecated)
• Invalid JSON, keys should be provided as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ks3uqu8tq83s

on_status (Picked)

• /message/order/fulfillments/start/time should have timestamp

on_status (Delivered)

• /message/order/fulfillments/end/time should have timestamp

Flow 4

on_cancel

• /message/order/tags should have property 'quote_trail'

@Schbang-parmeshwar

[Schbang-parmeshwar]

Hi @sahil-ondc please answer to below queries

Flow 1

on_search_full_catalog_refresh:

• Regarding the time or range, considering that it is deprecated in the contract, should it be passed or not?

Flow 2

on_init

• Since provider_location is deprecated, why do we still have to validate it during log validation?

[Schbang-parmeshwar]

Hi @sahil-ondc PR submitted for IGM #620 and Compliance Check #615

[Schbang-parmeshwar]

@sahil-ondc PR submitted for RSF #633

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• /context/transaction_id for /search and /on_search api should be same
• /context/message_id for /search and /on_search api should be same
• /context/timestamp for /search and /on_search api should not be three weeks
• /message/catalog/bpp/providers should not have creds and offers as empty array
• /message/catalog/bpp/providers/categories/id should be unique id for custom category (across customization group, custom menu, variant group); alphanumeric & up to 12 characters
• /message/catalog/bpp/providers/items/tags/attributes should not have value as 'NA'
• Either frequency and times or range should be provided in /message/catalog/bpp/providers/locations
• /context/city should be as per provider address in /message/catalog/bpp/providers/locations

on_search_inc_catalog_refresh

• /context/timestamp for /search and /on_search api should not be three weeks
• /message/catalog/bpp/providers/items/tags/attributes should not have value as 'NA'

Flow 3

on_select (out-of-stock)

• /message/order/quote/breakup/item/quantity should be positive in case of item is available in inventory

Other Flows

on_select

• invalid available and maximum in /message/order/quote/breakup/item/quantity provided as '0', but product is available

@Schbang-parmeshwar

[Schbang-parmeshwar]

• Either frequency and times or range should be provided in /message/catalog/bpp/providers/locations

@bluecypher @sahil-ondc for the above-mentioned point frequency and times are already their in the logs and the range is deprecated as per the contract, please correct me if i am wrong

[Schbang-parmeshwar]

@bluecypher please look into this

• Either frequency and times or range should be provided in /message/catalog/bpp/providers/locations

@bluecypher @sahil-ondc for the above-mentioned point frequency and times are already their in the logs and the range is deprecated as per the contract, please correct me if i am wrong

@bluecypher, Please let us know whether to implement deprecated changes or not

[sahil-ondc]

Flow 1

on_search_full_catalog

• 'accept_bap_terms' code should not be provided. It should be enabled when static terms are defined by the BNP and accepted by the seller app
• placeholder values should not be provided in /message/catalog/bpp/providers/items/tags/image
• remove formatting from /message/catalog/bpp/providers/items/descriptor short_desc and long_desc
• /item/quantity/unitized/measure should be different in case of variants
• one of frequency, times or range should be provided in /message/catalog/bpp/providers/locations
• invalid attribute 'Price' provided in /message/catalog/bpp/providers/items/tags
• invalid context/city as per provided area_code in /message/catalog/bpp/providers/locations

on_search_inc_catalog

• 'parent_item_id' was provided for item id: '43001180291299', but not provided in on_search_inc
• placeholder values should not be provided in /message/catalog/bpp/providers/items/tags/image

Flow 2

on_init

• /message/order should not have property 'provider_location' (Deprecated)
• invalid P/G link in payment/uri
• uri, type, collected_by, status, settlement_basis, settlement_window, withholding_amount should only be provided when prepaid payment to be collected by BPP
• cancellation_terms should not be provided; static/dynamic terms need not be provided as part of phase 1
• only tax_number should be provided in tags/bpp_terms; remove all the terms related properties

on_confirm

• invalid property 'provider_location' provided in /message/order
• cancellation_terms should not be provided; static/dynamic terms need not be provided as part of phase 1
• only tax_number and provider_tax_number should be provided in /tags/bpp_terms; remove other terms related properties
• placeholder values should not be provided in /message/order/tags/bpp_terms

on_status

• invalid property 'provider_location' provided in /message/order
• /message/order/fulfillment/start/time/timestamp cannot be equal to /message/order/fulfillment/end/time/timestamp

Flow 3

on_select (out-of-stock)

• /error/message should be exactly as per API Contract error.message in the response should have the list of corresponding item ids referenced in stringified object notation, e.g. if items "I1" is out of stock, error.message would be encoded as: "[{\"item_id\":\"I1\",\"error\":\"40002\"}]"

Flow 4

on_cancel

• invalid property 'provider_location' provided in /message/order
• /message/order/tags should not have property 'cancellation_reason_id' (Deprecated)
• Transaction should be as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec

Note

• serviceability code '11', not implemented by BNP, suggesting you to change it to '10' or '12'
• /track should be provided in flow 2 in case of tracking true

@Schbang-parmeshwar

[sahil-ondc]

Flow 1

on_search_full_catalog

• /message/catalog/bpp/providers/locations/address must have required property 'circle'
• /message/catalog/bpp/providers/items should not have property 'matched'

Flow 2

on_confirm

• "accept_bap_terms" code should not be provided. It should be enabled when static terms are defined by the BNP and accepted by the seller app

Flow 3

on_select (out-of-stock)

• /message/order/quote/breakup/item/quantity available and maximum should be zero in case of out-of-stock

Flow 4

on_cancel

• "accept_bap_terms" code should not be provided. It should be enabled when static terms are defined by the BNP and accepted by the seller app

Note

• City code mismatch in /search and other APIs

@Schbang-parmeshwar

[Schbang-parmeshwar]

Flow 1

• on_search_full_catalog /message/catalog/bpp/providers/locations/address must have required property 'circle'

As per the contract this is the correct sequence for circle property /message/catalog/bpp/providers/locations/circle

please find the below screenshot for reference @sahil-ondc @bluecypher

[sandeepshahi]

Flow 1

/on_search

• The quantity/unitized/measure is not captured correctly; eg, item description indicates the unit as millilitre, whereas gram is provided in unitized measure
• attribute codes in /tags/attribute should be in lowercase;
• invalid attribute code "Skin Type", should be "skin_type"; mapping of attributes to keys e.g "Skin Type" => "skin_type"
• invalid attribute code "Ingrediant", check the spelling and casing
• "@ondc/org/cancellation_window" is not a valid attribute
• "net_quantity_or_measure_of_commodity_in_pkg" is not required; info is captured in quantity/unitized/measure
• geocoding of store location (gps and area_code) in /bpp/providers/locations seems inaccurate
• only "min_value" list code should be provided for "order_value" tag block in bpp/providers/tags
• "category" is not required for timing tag block in bpp/providers/tags

Flow 2

/on_select

• invalid enum of "@ondc/org/category"; should be "Standard Delivery" in case of 5 days TAT
• fulfillment id is the same as in on_search; what happens in case of multiple fulfillment?
• tags are optional for non customized item in /items

/on_init

• provider/descriptor is not required;
• multiple invalid objects and attributes defined which are required in /on_confirm; check contract; eg: fulfillments/start etc.
• collected_by, status, type, uri, settlement_basis, settlement_window, withholding_amount should only be provided when SNP is collecting prepaid payment

/on_confirm

• estimated pickup range can't be earlier than estimated delivery range
• invalid PCC code in /fulfillments/start/instructions/short_desc; for code 2: PCC can only be upto 6 digit alphanumeric
• invalid value of provider_tax_number; should be the PAN number of merchant (not GSTIN)
• tax_number of bap in bap_terms is missing

/on_status

• Invoice should only be provided post shipment; at Order-picked-up state and thereafter
• Packed state is missing
• actual order pickup timestamp should not change in subsequent on_status APIs; should be the same as in Order-picked-up state

/on_track

• why is tracking still active after the order is delivered?
• tags should only be used to maintain the GPS sequence trail
• "location" should only be provided when live GPS tracking is enabled

Flow 3

• similar issues as above

/on_select (OOS)

• availability of inventory can't be "0" when item can be fulfilled

Flow 4

• similar issues as above

/on_cancel

• precancel_state should be provided in /tags

Flow 5

• similar issues as above

/on_cancel (RTO)

• message_id should be unique for all unsolicited calls
• quote/price and breakup must be updated appropriately
• RTO delivery charges are appended in quote/breakup but not included in quote_trail
• order pickup timestamp missing in forward shipment fulfillment
• delivery attempts must be performed before initiated RTO; retry_count can't be 0 for BPC fulfillment
• quote_trail need not be provided for line items where price value =0
• invalid RTO flow; RTO and return are different scenarios; RTO is initiated in /on_cancel and later state (disposed/delivered) is updated through /on_status

Flow 6

• similar issues as above
• why is unsolicited /on_status for merchant part cancel called after /on_update
• cancellation terms should be removed until enabled on the network;
• /update (Refund) FYI call is missing

/on_update (part cancel)

• transaction_id can't change
• quote must be updated
• value in quote_trail should be in string format

/on_update (return)

• earlier part cancelled item(s) should be part of the order object; trail must be maintained
• "initiated_by" code is missing in return_request
• interim state Return_Approved is missing
• fulfillment id of type= return is incorrect; should be the same as provided by BNP in /update;
• return states must be updated through unsolicited /on_update and not /on_status, since return flow modifies the order object; check the contract for example payloads
• incorrect return fulfillment_id in /items in Return_Picked state and thereafter
• item_quantity should be in string format
• quantity/count should be in number format (not string)
• return pickup timestamp is not provided in Return Picked state
• return delivery timestamp is not provided in Return Delivered state

@Schbang-parmeshwar

[Schbang-parmeshwar]

@bluecypher we are looking into the above issues please find below note fyi

Flow 2

on_select

• fulfillment id is the same as in on_search; what happens in case of multiple fulfillment? => All the orders are placed on the same provider, for now, it is the same as in on_search

on_status

• Packed state is missing we don't have packed status as we are not in the F&B category

Flow 6

cancellation terms should be removed until enabled on the network;

• It was confirmed by @sahil-ondc that we need to add cancellation terms in Group B/C for phase-2

[sahil-ondc]

Flow 1

on_search_full_catalog

• @ondc/org/return_window should be zero in case of /message/catalog/bpp/providers/items/@ondc/org/returnable is provided as false
• one attribute (concern) is provided as multiple times in /message/catalog/bpp/providers/items/tags (for ex: item.id: 43001183011043)
• /message/catalog/bpp/providers/items/category_id mapping seems invalid (for ex: item.id: '43001212731619' is mapped to 'Skin Care - Lotions, Moisturisers, and Creams', instead it should fall under Fragrance)

on_search_inc_catalog

• how can /message/catalog/bpp/providers/items/quantity/unitized/measure/value be zero, as in description above its provided as '400ml'

Flow 2

init

• Additional properties should not be provided in /message/order/items (location_id, parent_item_id)

on_status

• unsolicited (agent-assigned) states should be provided
• order/state should be 'In-progress' for /on_status (picked)
• delivery timestamp (/end/time/timestamp) can't be less than or equal to the pickup timestamp (start/time/timestamp) for /on_status (delivered)

Flow 3

• Same issues as above

Flow 4

on_cancel

• /message/order/fulfillment/tags/precancel_state/updated_at should be correct

Flow 5

• invalid flow (in /select multiple quantity is selected, and quote is provided then in init and confirm quantity reduced)

Flow 6

on_confirm

• context/timestamp difference between /on_confirm and /confirm should be less than 5 sec

on_update

• /message/order/quote/breakup/0/price/value must be string
• Invalid CancellationID 003 or not allowed for SNP

@Schbang-parmeshwar

[Schbang-parmeshwar]

Flow 4

• /message/order/fulfillment/tags/precancel_state/updated_at should be correct

@sahil-ondc could you please explain this point? There is no footnote for 'updated_at' in the contract document. We are passing it as the timestamp for order cancellation

[Schbang-parmeshwar]

Flow 4

• /message/order/fulfillment/tags/precancel_state/updated_at should be correct

@sahil-ondc could you please explain this point? There is no footnote for 'updated_at' in the contract document. We are passing it as the timestamp for order cancellation

@bluecypher

[Schbang-parmeshwar]

on_status

• unsolicited (agent-assigned) states should be provided

@sahil-ondc so as per our converstaion on mail Agent-assigned is not required. can you please confirm?

[sandeepshahi]

Flow 2

/init

• parent_item_id (dynamic item id) in /select and onwards are created for MTO orders

/on_init

• invalid attribute "created_at" in /order; order is created in /confirm;

/on_status

• Invoice should be provided only once the order is picked and thereafter
• Order-picked-up
  • actual pickup timestamp is not captured correctly; provided timestamp is even before the order was packed

Flow 4

/on_cancel

• "@ondc/org/item_quantity"/count in quote/breakup should be 0 if all the quantities are being cancelled; (calculation: unit price * count = total price); This is applicable for all the APIs
• updated_at of precancel_state (Pending) can't be the same as /on_cancel timestamp

/on_status

• why is unsolicited /on_status being called after cancellation;

Flow 5

• similar issues as in Flow 4

/on_cancel

• invalid fulfillment enum "Return_Initiated"; should be "RTO-Initiated" instead
• invalid quote/price; quote/price = sum of (quote/breakup/price);

Flow 6

• similar issues as above

[sandeepshahi]

@Schbang-parmeshwar

[BLR-0118]

Group A

Flow 1

1. /search (full catalog):

   • search is fanned out from the gateway to all seller NPs in a particular domain; hence, no bpp_id/bpp_uri is in Context;
   • curious how the search context here has bpp_id & bpp_uri?

2. /search (inc catalog):

   • item 43001178816739 has same timestamp in full & inc catalog and not sure what is being updated here?
   • item 43001178849507 has same timestamp in full catalog & inc catalog; full catalog shows item in-stock & inc catalog shows item out-of-stock; so is this item in stock or out-of-stock as of the timestamp?
   • similar issue with other items;
   • are you supporting incremental push?

Flow 2

1. /on_select:

   • parent_item_id in order.items[] refers to dynamic item id for make-to-order product created by buyer; this isn't valid here & should be removed from items;
   • fulfillment.type is required;

2. /on_confirm:

   • since this NP is ISN, seller PAN no (provider_tax_number) should match PAN no (within GST no) for aggregator;

3. /on_status_pending:

   • /on_confirm shows payment amount as 1048 but here the payment amount has changed to 1166 (with diff txn id);

4. From the start & end pin codes (1st 3 digits of pincode same), this looks like hyperlocal shipment:

   • why is TAT 5 days?
   • can you send routing.type to indicate whether this is hyperlocal (P2P) or intercity (P2H2P) shipment?

[BLR-0118]

Group C

1. Only 6a (part cancel by merchant) & b (return with liquidation) use cases provided;
2. BPC includes resaleable items, so why aren't you supporting return with pickup?

[BLR-0118]

@Schbang-parmeshwar

[Schbang-parmeshwar]

Group A

Flow 1

1. /search (full catalog):

• search is fanned out from the gateway to all seller NPs in a particular domain; hence, no bpp_id/bpp_uri is in Context;
• curious how the search context here has bpp_id & bpp_uri?

2. /search (inc catalog):

• item 43001178816739 has same timestamp in full & inc catalog and not sure what is being updated here?
• item 43001178849507 has same timestamp in full catalog & inc catalog; full catalog shows item in-stock & inc catalog shows item out-of-stock; so is this item in stock or out-of-stock as of the timestamp?
• similar issue with other items;
• are you supporting incremental push?

Flow 2

1. /on_select:

• parent_item_id in order.items[] refers to dynamic item id for make-to-order product created by buyer; this isn't valid here & should be removed from items;
• fulfillment.type is required;

2. /on_confirm:

• since this NP is ISN, seller PAN no (provider_tax_number) should match PAN no (within GST no) for aggregator;

3. /on_status_pending:

• /on_confirm shows payment amount as 1048 but here the payment amount has changed to 1166 (with diff txn id);

4. From the start & end pin codes (1st 3 digits of pincode same), this looks like hyperlocal shipment:

• why is TAT 5 days?
• can you send routing.type to indicate whether this is hyperlocal (P2P) or intercity (P2H2P) shipment?

@BLR-0118

• yes we support incremental push
• we support Standard Delivery that's why we have TAT 5 days

for flow 2 we have mistakenly uploaded logs of 2 different transactions and the same thing has been reflected here because of that on_confirm shows the payment difference.

re- submitting the flow 2 with correction