ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 245 forks source link

Esaras - SA - compliance check #1902

Open abhinavv245 opened 2 months ago

abhinavv245 commented 2 months ago

Flow 1

/on_search (RET12)

/on_search (RET13 and 16)

Flow 2

/on_search

/on_init

/confirm

/on_confirm

/on_status_pending

/on_status

Flow 3

/on_select_out_of_stock

 "error":
  {
    "type":"DOMAIN-ERROR",
    "code":"40002",
    "message":"M1"
  }

/on_select

/on_init

/on_confirm

on_status_pending

on_status_packed:

on_status_picked

on_status_out_for_delivery:

on_status_delivered:

@bindukallupurackal

Jagannath-wits commented 2 months ago

Additional issues

RET16 search

confirm

on_init

on_confirm

on_status

@bindukallupurackal

Jagannath-wits commented 2 months ago

ESaras

RET12

Flow 1 - on_search

RET13

Flow 1 - on_search

RET16

Flow 1 - on_search

Flow 3

on_select_oos

select

init

on_init

on_status

Flow 4

cancel

on_cancel

Flow 5

on_search

on_cancel

Note

@bindukallupurackal

Jagannath-wits commented 2 months ago

Esaras

RET16

on_search

Flow 2

confirm

on_status

on_status_delivered

Flow 3

on_select

Flow 4

on_cancel

on_status_RTO_delivered

Flow 6

Note

bindukallupurackal commented 2 months ago

Please check only the flows which are updated. Flow1 not yet updated after last comments received. Esaras not supporting partial cancel, RTO flow on flow5 also we are newly adding as these are handled by brown tape api on Esaras and they are not providing any api or status update.

On Thu, 4 Jul, 2024, 11:26 pm Jagannath Padhy, @.***> wrote:

Esaras

  • Unicode formatting ‘\’ and escape characters are not allowed in payload (repeated issue)

RET16 on_search

  • attribute.colour_name is now mandatory wherever colour is mandatory (flagged by utility).
  • Escape characters are not allowed in payload. For example: \n\t\t\t\t\t\t\t\t\t\t\t (repeated issue).
  • Circle.radius should be feasible; keep it up to 50 or 500 km even if its servicability is PAN India.
  • quantity.maximum.count should reasonably reflect the maximum amount of items allowed to be ordered. For example, if 100 units of dining table (repeated issue).
  • If month_year_of_manufacture_packing_import is not available, please provide "NA" and not an empty string (repeated issue).
  • Servicability should not be defined at item level, i.e., at items.tags.servicability.
  • Variants have not been implemented properly i.e variant has been declared but not used also, no attributes have been provided in the items on the path defined in the variant.
  • Servicability should be provided for each category_id (repeated issue).

Flow 2 confirm

  • If BPP is collecting payment, the payment details will be provided in on_init and carried forward, and not in confirm. But as currently only BAP is collecting, so collected by should be BAP in Confirm, and the rest will be the same as you have provided now (repeated issue).

on_status

  • Address mismatch with on_confirm in fulfillment and billing.
  • Why is there an additional settlement_details object?
  • Why did payment.collected_by change to BAP from BPP?
  • Why is the time.range for both start and end the same? Is it not calculated?
  • time.range can't change at each call.
  • Why is routing p2h2p when delivery is in the same city? Is this hardcoded? (repeated issue).
  • No need to provide tracking object when tracking is false (repeated issue).
  • fulfillment_delay object is only required when there is a delay in delivery. It seems you've added it directly from contract; please remove it (repeated issue).
  • fulfillment.tags.ready_to_ship is required only if fulfillment.type="Buyer-Delivery", indicating whether fulfillment is ready to ship; please remove it (repeated issue).

on_status_delivered

  • Payment status is still "NOT-PAID”.

Flow 3 on_select

  • How can you select the items which were not available as per on_select_oos?

Flow 4 on_cancel

  • precancel state not captured properly

on_status_RTO_delivered

  • Missing Payload

Flow 6

  • Incomplete Flow; no on_update call is provided for reverse qc.

Note

  • Please try to follow the flow i.e., part-cancel, reverse qc, Liquidation to avoid false errors from utility.
  • Please provide the utility payload and response to make verification quicker and easier.
  • Please format the on_action calls before submitting. @bindukallupurackal https://github.com/bindukallupurackal

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1902#issuecomment-2209409365, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJKQNM66CVGPOAXSAHZ4UHLZKWEEDAVCNFSM6AAAAABJUOI2MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGQYDSMZWGU . You are receiving this because you were mentioned.Message ID: @.***>

Jagannath-wits commented 1 month ago

Esaras

Flow 1

on_search

Flow 2

on_search

on_status

Flow 3

select_out_of_stock

on_status_out_for_delivery

Flow 5

on_cancel

on_status

on_status_rto_delivered

@bindukallupurackal

Jagannath-wits commented 1 month ago

Flow 2

On_status

Flow 5

On_status_rto_delivered

Flow 6

on_update

on_update_approval

on_update_picked

@bindukallupurackal

Jagannath-wits commented 1 month ago

Flow 2

On_status

Flow 5

On_status

Flow 6

On_update_interim_reverse_qc

on_update_picked

@bindukallupurackal

Jagannath-wits commented 1 month ago

Esaras

Flow 2

On_select

on_status

Flow 5

On_status_rto_delivered

Flow 6

on_update

on_update(delivered)

@bindukallupurackal

Jagannath-wits commented 1 day ago

Flow 1

on_search

on_search_inc


Flow 6: Part-Cancel

@bindukallupurackal