Open abhinavv245 opened 2 months ago
@bindukallupurackal
month_year_of_manufacture_packing_import
is unavailable, please provide “NA” and not an empty string.bpp/providers[0]/items/category_id
.items.quantity.maximum
should be a reasonable amount, i.e., 99 (if no limit on the number of items placed in order) or a reasonable number of items (not 90).\
is not allowed. Example: "https:\/\/uatesaras.digitalindiacorporation.in\/media\/catalog\/product\/p\/e\/pexels-pixabay-462235.jpg"select
and select_oos
same and same for on_select
.order.error
message is missing. Please refer to contract for correct format of error message.select
when they should’ve been out of stock. Please refer to contract.order.items.location_id
is not required as per contract.Tags.bpp_terms
: Only tax_number
, ’np_type' and provider_tax_number
are required; others are not enabled yet.Order.state
not updated after on_confirm
.track
and on_track
as well.fulfillment_delay
object is only required when there is a delay in delivery. It seems you've added it directly from contract; please remove it.\
is not allowed.fulfillment.state = "Order-picked-up"
and thereafter, and not before it.reason_id
. Please refer to the reason_code sheet."invldQuotePrices": "item quote breakup prices for on_cancel should be equal to the total price."
"Fulfillment_mismatch": "The count of cancellation fulfillments is not equal to the count of forward fulfillments or invalid fulfillment id."
precancelState.updatedAt
: precancel_state.updated_at
of on_cancel
is not equal with the on_confirm order.updated_at
.on_cancel
.order.items
not updated properly.@bindukallupurackal
attribute.colour_name
is now mandatory wherever colour is mandatory (flagged by utility).\n\t\t\t\t\t\t\t\t\t\t\t
(repeated issue).Circle.radius
should be feasible; keep it up to 50 or 500 km even if its servicability is PAN India.quantity.maximum.count
should reasonably reflect the maximum amount of items allowed to be ordered. For example, if 100 units of dining table (repeated issue).month_year_of_manufacture_packing_import
is not available, please provide "NA" and not an empty string (repeated issue).items.tags.servicability
.category_id
(repeated issue).on_init
and carried forward, and not in confirm
. But as currently only BAP is collecting, so collected by
should be BAP in Confirm
, and the rest will be the same as you have provided now (repeated issue).on_confirm
in fulfillment and billing.settlement_details
object?payment.collected_by
change to BAP from BPP?time.range
for both start and end the same? Is it not calculated?time.range
can't change at each call.p2h2p
when delivery is in the same city? Is this hardcoded? (repeated issue).tracking
object when tracking
is false (repeated issue).fulfillment_delay
object is only required when there is a delay in delivery. It seems you've added it directly from contract; please remove it (repeated issue).fulfillment.tags.ready_to_ship
is required only if fulfillment.type="Buyer-Delivery"
, indicating whether fulfillment is ready to ship; please remove it (repeated issue).on_action
calls before submitting.
@bindukallupurackalPlease check only the flows which are updated. Flow1 not yet updated after last comments received. Esaras not supporting partial cancel, RTO flow on flow5 also we are newly adding as these are handled by brown tape api on Esaras and they are not providing any api or status update.
On Thu, 4 Jul, 2024, 11:26 pm Jagannath Padhy, @.***> wrote:
Esaras
- Unicode formatting ‘\’ and escape characters are not allowed in payload (repeated issue)
RET16 on_search
- attribute.colour_name is now mandatory wherever colour is mandatory (flagged by utility).
- Escape characters are not allowed in payload. For example: \n\t\t\t\t\t\t\t\t\t\t\t (repeated issue).
- Circle.radius should be feasible; keep it up to 50 or 500 km even if its servicability is PAN India.
- quantity.maximum.count should reasonably reflect the maximum amount of items allowed to be ordered. For example, if 100 units of dining table (repeated issue).
- If month_year_of_manufacture_packing_import is not available, please provide "NA" and not an empty string (repeated issue).
- Servicability should not be defined at item level, i.e., at items.tags.servicability.
- Variants have not been implemented properly i.e variant has been declared but not used also, no attributes have been provided in the items on the path defined in the variant.
- Servicability should be provided for each category_id (repeated issue).
Flow 2 confirm
- If BPP is collecting payment, the payment details will be provided in on_init and carried forward, and not in confirm. But as currently only BAP is collecting, so collected by should be BAP in Confirm, and the rest will be the same as you have provided now (repeated issue).
on_status
- Address mismatch with on_confirm in fulfillment and billing.
- Why is there an additional settlement_details object?
- Why did payment.collected_by change to BAP from BPP?
- Why is the time.range for both start and end the same? Is it not calculated?
- time.range can't change at each call.
- Why is routing p2h2p when delivery is in the same city? Is this hardcoded? (repeated issue).
- No need to provide tracking object when tracking is false (repeated issue).
- fulfillment_delay object is only required when there is a delay in delivery. It seems you've added it directly from contract; please remove it (repeated issue).
- fulfillment.tags.ready_to_ship is required only if fulfillment.type="Buyer-Delivery", indicating whether fulfillment is ready to ship; please remove it (repeated issue).
on_status_delivered
- Payment status is still "NOT-PAID”.
Flow 3 on_select
- How can you select the items which were not available as per on_select_oos?
Flow 4 on_cancel
- precancel state not captured properly
on_status_RTO_delivered
- Missing Payload
Flow 6
- Incomplete Flow; no on_update call is provided for reverse qc.
Note
- Please try to follow the flow i.e., part-cancel, reverse qc, Liquidation to avoid false errors from utility.
- Please provide the utility payload and response to make verification quicker and easier.
- Please format the on_action calls before submitting. @bindukallupurackal https://github.com/bindukallupurackal
— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/1902#issuecomment-2209409365, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJKQNM66CVGPOAXSAHZ4UHLZKWEEDAVCNFSM6AAAAABJUOI2MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGQYDSMZWGU . You are receiving this because you were mentioned.Message ID: @.***>
category_id
should be provided (repeated)."parent_item_id": “F11472”
is used to link item with variant group. If no variant is applicable, please provide "parent_item_id": "”
. (repeated issue){ "code": "ingredient", "value": "" }
(RET13).context.bap_id
, etc. Eg: "”"\n\t\t\t\t\t\t\t\t\t\t\t\”””, “”"https:\/\/buyer-app-preprod-v2.ondc.org\/protocol\/v1””
(repeated issue)fulfillment.end.time.range
should be calculated based on the TAT (i.e., 7 days in your case), so the TAT and range should be calculated accordingly.context.bap_id
. Eg: "”"https:\/\/buyer-app-preprod-v2.ondc.org\/protocol\/v1””
.message_id
92128c64-c3d9-45a1-a1db-878a7428f6f3
should not be the same as provided in previous calls (i.e., confirm and on_confirm). (flagged by utility)@bindukallupurackal
on_confirm
. Quote.breakup
provided duplicate delivery charges, and its ID should be fulfillment id
as provided in on_confirm
.2024-07-11T08:47:46.361Z
used as a placeholder in multiple locations. For example:
on_status_pending
: fulfillment.time.range
should be calculated properly, i.e., the start range should not be less than context.timestamp
, but 2024-07-11T08:47:46.361Z
is used.on_status_picked
: fulfillment.start.time.timestamp
is again 2024-07-11T08:47:46.361Z
. How can it be picked at the same time as the init call? order.updated_at
should be updated whenever there is a change in the order object, so in no scenario can the updated_at
timestamp be less than created_at
.on_cancel_rto
: fulfillment.start.time.timestamp
is again 2024-07-11T08:47:46.361Z
.on_status.order.updated
is 2024-07-11T08:47:46.361Z
for all calls (order.updated_at
should be updated whenever there is a change in the order object, so in no scenario can the updated_at
timestamp be less than created_at
).orders.items
object not carried forward from on_cancel
.Fulfillments
object should also be carried forward from on_cancel_rto
, and the end.time.timestamp
of RTO_fulfillment
should be updated.on_cancel
.order.created_at
should remain the same as confirm
.@ondc/org/settlement_details
trail should be maintained. How are you getting settlement details for a refund before the order is picked for return? Please do not provide mock details.order.items
not mapped with new fulfillment.igm_request
is required in reference to the issue related to return request raised in IGM. This will be added here only after issue resolution and returned in all post-order APIs like /on_status
, /on_update
, /on_cancel
. If that's not the case, please do not provide this.settlement_amount
should be in string.@bindukallupurackal
@ondc/org/settlement_details
missing.@ondc/org/settlement_details
missing.delivery_fulfillment.start
and end.timestamp
updated after on_status
; trail must be maintained.@bindukallupurackal
Esaras
@bindukallupurackal
@ondc/org/return_window
:”” ; should not be an empty string and must contain a value, as it also serves as the IGM window.categories.descriptor.name
should be meaningful and not a code.on_search_inc
, and bpp_provider.tags
updates cannot be provided in on_search_inc
. For example, if there is an update in the items
array, then only the provider id
and items
array should be provided.@bindukallupurackal
Flow 1
/on_search (RET12)
/on_search (RET13 and 16)
Flow 2
/on_search
/on_init
/confirm
/on_confirm
/on_status_pending
/on_status
Flow 3
/on_select_out_of_stock
/on_select
/on_init
/on_confirm
on_status_pending
on_status_packed:
on_status_picked
on_status_out_for_delivery:
on_status_delivered:
@bindukallupurackal