Protean ( SA : RET13 ) - Compliance Check

Jagannath-wits commented 5 months ago

Flow 2

Confirm

Billing Error: Key 'address.building' mismatch: Main Building !== Pune when compared with init billing object.
Billing Error: Key 'address.city' mismatch: Bengaluru !== Pune when compared with init billing object.

On Status Pending

routing.type should be sent when order is accepted.

On Status Picked

Invoice URL should be publicly accessible and accurate.

Flow 6

On Update Part Cancel

Question: Why is on_update_part_cancel sent before order is accepted?

Update Settlement ReverseQC

Payload missing.

@RaviV-Protean

RaviV-Protean commented 4 months ago

Thanks @Jagannath-wits for feedback.

We will resubmit Flow 2.
As per our understanding and documentation we read sellers can edit the order before Accepting it, so there should not be any issue in that.
We have not received /update settlement for reverse-QC, we have checked with Delta force team and community call, they said Buyer-ref pre-prod does not send that. (Please confirm)

@Jagannath-wits @sandeepshahi , So we will be resubmitting Flow 2 as per the feedback received.

Jagannath-wits commented 4 months ago

@RaviV-Protean Acknowledged

RaviV-Protean commented 4 months ago

@Jagannath-wits we have resubmitted the logs for Flow-2 and PR is for your review.

https://github.com/ONDC-Official/v1.2.0-logs/pull/2015

sandeepshahi commented 4 months ago

Flow 1

/on_search

attribute enums must be followed as per defined in the repo here; eg: check value of "skin_type" attribute

Flow 2

/on_select

TAT with more than 24 hours can be converted into days

/on_confirm

how can estimated pickup/delivery time ranges be provided even before accepting the order

/on_status

Order-picked-up: "updated_at" timestamp can't be earlier than Agent-assigned state call
Invoice must be accessible

Flow 4

/on_cancel

updated_at in precancel_state is not captured correctly; check milliseonds value

Flow 5

/on_status (OFD)

context/timestamp is not in correct RFC3339 UTC format; "Z" suffix is missing

/on_status (RTO delivered)

invalid fulfillment state for forward shipment: "b405313d-9713-422a-aac2-60a029c6ca5b"
why are multiple delivery charges added for forward shipment in quote/breakup

@RaviV-Protean

RaviV-Protean commented 4 months ago

Thanks @sandeepshahi for the feedback, Previously we have confirmed that only Flow 2 had issues. But now again other flows have pointed out, while we haven't made any changes in those flows.

Flow 1

Acknowledged, we will resubmit full catalog refresh.

Flow 2

As per contract it should be in valid format, is there anything needs to be changed as per compliance ?
While sending on_confirm, we have pickup and delivery range as per the TAT sent in previous calls. Is there anything wrong and needs to be changed ?
Acknowledge, we will resubmit seems some micro-seconds issue.
In preprod environment access of invoice (cloud-storage) is uncertain it will not happen in production, we have checked in logs, in many of approved NPs, many urls and invoice is not accessible.

Flow 4

Acknowledge, we will resubmit seems some micro-seconds issue.

Flow 5

Acknowledge, we will resubmit RTO flow.

@sandeepshahi, @BLR-0118 Please let us know what needs to be changed as per comments and protocol.

RaviV-Protean commented 4 months ago

@sandeepshahi, @BLR-0118 Can you please provide your inputs ?

RaviV-Protean commented 4 months ago

@sandeepshahi we have resubmitted the logs.

https://github.com/ONDC-Official/v1.2.0-logs/pull/2049

sandeepshahi commented 4 months ago

RET 13

/on_search

attribute enums must be followed as per defined in the repo here; eg: check letter casing for formulation

/on_status

for invoices, the URL should be correctly formed to avoid inconsistencies, as different buyer apps may create the same order ID

RET 12

/on_search

store address seems incorrect; the street should not contain the entire address, and there is an inconsistency in the pincode provided in the street and area code.
HSN code seems incorrect in item/descriptor/code
unit weight need not be provided for clothings; unitized measure should be "1 unit" instead
invalid attributes: "net_quantity_or_measure_of_commodity_in_pkg" and "imported_product_country_of_origin" in "@ondc/org/statutory_reqs_packaged_commodities"
multiple items with same attribute value should not be provided for a variant; eg: variant is made on the basis of colour but multiple SKUs have same colour

RET 18

/on_search

city code should be the same as in /search
all the attributes of statutory reqs should be provided in "@ondc/org/statutory_reqs_packaged_commodities" as mentioned in the contract

RET 14, 15, 16

similar issues as above

@RaviV-Protean

RaviV-Protean commented 4 months ago

@sandeepshahi, thank you for your feedback.

We are working on revising Flow 1 for all domains and will resubmit it.
We set the invoice based on the order_id, but in the rare case that multiple buyer applications have the same order_id, this issue won’t affect the specific end user. We will address this internally and resolve it, but it should not be a blocker for Pramaan testing and beta production.

@sandeepshahi @BLR-0118, we request clearance for RET13 (BPC). We will resubmit Flow 1 with the suggested changes (changing the attribute from “Cream” to “cream”).

RaviV-Protean commented 4 months ago

@sandeepshahi, We have made the changes and raised PR https://github.com/ONDC-Official/v1.2.0-logs/pull/2064.

RaviV-Protean commented 4 months ago

@sandeepshahi, any update on the above PR https://github.com/ONDC-Official/v1.2.0-logs/pull/2064 ?

RaviV-Protean commented 4 months ago

@sandeepshahi, we have made the changes and raised PR https://github.com/ONDC-Official/v1.2.0-logs/pull/2094. Kindly check and provide approval accordingly.

sandeepshahi commented 4 months ago

RET 12

/on_search

can variants be created based on multiple attributes? bcz variant group is created on the basis of size but colour is also different

RET 14

"time_to_ship "must be in valid ISO 8601 duration format; should be P1D instead of PT1D

@RaviV-Protean

RaviV-Protean commented 4 months ago

Yes, variants can be created on multiple attributes. Is it mandatory to map that in a variant.

For ex - We have variants of Men t-shirt based on size, XL and XXL. And let's say those t shirt have different color as well. Is it mandatory to have that in categories ?

Resubmitting logs for RET14 today.

@sandeepshahi

RaviV-Protean commented 4 months ago

@sandeepshahi we have resubmitted RET14 logs for your review.

https://github.com/ONDC-Official/v1.2.0-logs/pull/2105

RaviV-Protean commented 4 months ago

@sandeepshahi Kindly let me know next course of action.

ONDC-Official / v1.2.0-logs