sahil-ondc commented 1 year ago

Full Catalog Pull

/on_search (RET:11)

/message/catalog/bpp~1providers/0 must have required property '@ondc/org/fssai_license_no'
/message/catalog/bpp~1providers/0/locations/0/time must have required property 'label'
/message/catalog/bpp~1providers/0/locations/0/time must have required property 'timestamp'
/message/catalog/bpp~1providers/0/locations/0/address must have required property 'locality'
context/timestamp difference between /on_search and /search should be smaller than 5 sec
transaction_id for /search and /on_search api should be same
message_id for /search and /on_search api should be same
Invalid time format for 'time_to': 12:00
Invalid value for 'input': input, it should be one of select, text at index: 11

Incremental Pull

/search

/message/intent/tags/list/start_time/value cannot be greater than or equal to /context/timestamp
/message/intent/tags/list/end_time/value cannot be less or equal to than /message/intent/tags/list/start_time/value

/on_search (store closed temporarily)

range/end is not in valid RFC3339 UTC format

@wemakshaychavan

sandeepshahi commented 12 months ago

Ref-Seller-App (with LSP)

/on_action callback response should be provided within 5 sec

/select

selected items are of grocery category; context/domain should be ONDC:RET10
tags in /items is optional non MTO items

/on_select

quote/price/value should be = sum of (quote/breakup[]/price/value)

/init

building is mandatory in /billing/address if name != house#

/on_init

delivery charges can't be -ve; invalid quote price

/confirm

delivery address can't change in /fulfillments/end/location
tax_number in bap_terms and bpp_terms can't be swapped
order/created_at and order/updated_at are not captured correctly
provider/descriptor is not required

/on_confirm

estimated pickup and delivery time ranges are incorrect; delivery TAT was of 60 mins

/on_status

updated_at timestamp should be updated as per the context/timestamp

/on_track

/tracking/location/updated_at is not captured correctly

Seller Side Cancel

/select

context/city should be correctly mapped

/on_select

context/timestamp can't be the same as /select timestamp
total price of item (quote/breakup/price) can't be the same as unit price (quote/breakup/item/price) when quantity = 2;

/on_init

uri in /payment should be provided if SNP is collecting the prepaid payment (collected_by = BPP)

/confirm

delivery address can't change in /fulfillments/end/location

/on_confirm

store and delivery address seem to be swapped
estimated pickup and delivery time ranges are incorrect; start and end can't be the same
value of PCC should be provided when fulfillment state is Packed; For code=2, value of short_desc (PCC) should be upto 6 digits
instructions in fulfillments/end/ is not required
updated_at timestamp can't be the same as created_at

/on_update (Part Cancellation)

order and fulfillment states are not correct; part item in a fulfillment can't be delivered alone
/items/quantity/count should be in number format
For new fulfillment (for part cancellation), type should be "Cancel" and state should be "Cancelled"
only reson_id and initiated_by should be provided in /tags/cancel_request for part cancellation fulfillment
"type" should be provided in "quote_trail" instead of title_type
invalid value of currency in quote_trail (should be "INR")
value of "@ondc/org/buyer_app_finder_fee_type" should be "percent"

Update Flows

/update

tags/return_request/parent_item_id is optional for non MTO items
valid url of images should be provided in /tags/return_request/images

on_update (Return_Initiated)

duplicate key: "id" in /order
entire trail of fulfillment for forward shipment should be provided in /fulfillments (type="Delivery")
initiated_by attr missing in /fulfillments/tags/return_request
order timestamps (created_at and updated_at) are missing

/on_update (Return_Rejected)

message_id for unsolicited call should be unique
returned item(s) should be mapped with new fulfillment in /items in Return_Rejected/Liquidated state

/on_update (Liquidated)

message_id for unsolicited call should be unique
returned item(s) should be mapped with new fulfillment in /items in Return_Rejected/Liquidated state
actual pickup and delivery timestamps are missing in forward shipment fulfillment

@wemakshaychavan

sandeepshahi commented 11 months ago

Seller Side Cancel

context/city should be the city of selected seller

/on_select

quote/price/value should be = sum of (quote/breakup[]/price/value)
item.available.count should be either 99 (inventory available) or 0 (out-of-stock)
item.maximum.count should be either default value 99 (no cap per order) or any other +ve value (cap per order)

/init

lat/lng are not valid attributes in /fulfillments/end/location

/on_init

"type", "collected_by": "BPP", "uri", "status" in /payment should only be provided when collected by BPP
available and maximum attributes are not required in quote/breakup/item/

/confirm

payment/params/txn id should be unique; can't be the same as context/txn id

/on_confirm

callback should not take long to be responded back
estimated pickup and delivery time ranges are incorrect; start and end can't be the same
delivery TAT was 60 mins in /on_select; estimated delivery time range can't be of 1 day

/on_update

similar issues as identified previously
refund should be initiated by BNP when request for part cancellation is ack'd

Return Flows

similar issues as identified previously

@wemakshaychavan

sandeepshahi commented 11 months ago

Seller Side Cancel

/select

context/city should be the city of selected seller; both the buyer and seller are located in Punjab

/on_select

quote/price/value should be = sum of (quote/breakup[]/price/value)
item.available.count should be either 99 (inventory available) or 0 (out-of-stock)
/on_action callback response should be provided within 3-5 secs

/on_confirm

callback should not take long to be responded back
estimated pickup and delivery time ranges are incorrect; start and end can't be the same
delivery TAT was 60 mins in /on_select; estimated delivery time range can't be of 1 day
value of "@ondc/org/buyer_app_finder_fee_type" should be "percent"; instead of "Percentage"
address is missing in /fulfillments/start/location

/on_update

Why are 2 new fulfillments created for a single part cancellation request?
mapping of order state and non-cancelled fulfillment state is not correct; order state should be in either "Created" or "Accepted" state when fulfillment state is "Pending"
invalid fulfillment state "pending"; should be "Pending" with upper case 'P'
reason_id "004" is deprecated; different reason code should be used for cancellation

/update (payment)

message_id should be unique

Update (Return) Flows

/on_update (Return_Initiated)

pickup timestamp missing in forward shipment in /fulfillments/start/time/timestamp

@wemakshaychavan

sandeepshahi commented 9 months ago

RET10

Flow 1

/on_search

id and type must be defined in bpp/providers/fulfillments/
either one of statutory reqs packaged_commoditied or prepackaged food must be defined for the category as per the protocol key mapping
invalid enum code "nonveg" in /items/tags/veg_nonveg/code; enum should be defined as per the item;
@ondc/org/mandatory_reqs_veggies_fruits attribute is not required
country of origin for item c5042c28-a4f2-419b-bf0e-8651f54123fc, should be in ISO 3166-1 format

Flow 2

/on_select

available count should be either 99 or 0 as per the catalog; maximum count should be the max cap per order

/on_init

provider_location is not required
duplicate objects created in quote/breakup
tracking attribute is missing

/confirm

tax_number of buyer app should be of 15 digits
tracking attribute is missing

/on_confirm

items list can't be empty
estimated pickup and delivery time ranges can't be same
provider_tax_number must also be provided in bpp_terms
tracking is set as false but track is enabled; pls rectify this
"@ondc/org/buyer_app_finder_fee_type" should be "percent" instead of "percentage"

/on_status

"Packed" state must be supported
order/updated_at should be captured correctly; can be earlier than previous on_status call

/track

tracking should be enabled at Agent-assigned state

Flow 3

/on_select (OOS)

available count should be updated as per the availability
error message should be in stringified JSON format as mentioned in the contract

Flow 4

/on_cancel

entire trail of the order object must be provided; new fulfillment for cancellation and quote_trail must be present

Flow 5

Flow is not correct as per the RTO scenario

Flow 6

/on_update (part cancel)

items/quantity/count should be in integer format for the new item object
duplicate objects in quote/breakup should be removed
quote/breakup/price should be the updated price and won't be 0 for item id: "8334bcef-7392-4bed-a2b1-e7c9f21a6020"
created_at and updated_at timestamps are not captured correctly

/on_update (liquidated)

quote/breakup is not correct; item price can't be -ve in quote
duplicate objects should be removed from quote/breakup

@wemakshaychavan

sandeepshahi commented 9 months ago

RET11

/on_search

np_type should be provided in bpp/descriptor/tags/bpp_terms
short_desc/long_desc should be provided for custom menu in /categories/descriptor
input type is marked as "text" for "select" based custom groups. eg: "toiCNh", "nlwArQ"
default customization must be set for a custom group where min=1 and is either a child of a base item or an already set default customization; eg: check for item: d064b7ad-0031-4a2c-b8a7-187cd423be7
maximum_value in default_selection is not captured correctly; should be the MRP
upper cap is not captured correctly in /tags/range; should be the total price of
unitized/measure/value should be in stringified number format; eg: check item: f796ece8-4dac-452d-bff0-2d7a317ba993
serviceability for category id "F&B" is not defined; hyperlocal serviceability should ideally be supported for F&B categories

/search (inc)

city must be "*"

/on_status

invoice must be provided in Order-picked-up and later states

/on_track

updated_at is not captured correctly; tracking should be enabled in Agent-assigned state?

/on_select (OOS)

error/message should be in the correct stringified JSON format (for F&B domain)

/update

FYI call for refund must be initiated upon receiving refund triggering states

@wemakshaychavan

sandeepshahi commented 9 months ago

RET10

Flow 1

/on_search

either one of statutory reqs packaged_commoditied or prepackaged food must be defined for the category as per the protocol key mapping
invalid enum code "nonveg" in /items/tags/veg_nonveg/code; enum should be defined as per the item;
country of origin should be in ISO 3166-1 format;

Flow 2

/on_init

provider/locations is missing
tracking attribute is missing

/confirm

tax_number of buyer app should be of 15 digits
tracking attribute is missing

/on_status

Packed state is missing
invoice must be provided from "Order-picked-up" state
updated_at is not captured correctly

Flow 4

/on_cancel

subscribe id of buyer app must be provided in cancellation/cancelled_by for buyer side cancellation
updated_at is not captured correctly
delivery charges should also be appended in quote_trail

Flow 5

/on_cancel

message_id should be unique
RTO must be initiated as part of flow 5; fulfillment type must be RTO

Flow 6

/update (Payment - FYI)

message_id should be unique

/on_update (part cancel)

quote/price and quote/breakup must be updated
updated_at timestamp is not captured correctly

/on_update (return_initiated)

actual pickup timestamp is missing
updated_at timestamp is not captured correctly

/on_update (Liquidated)

actual pickup timestamp is missing
items/quantity/count should be in integer format
updated_at timestamp is not captured correctly

@wemakshaychavan

sandeepshahi commented 9 months ago

RET11

similar issues as mentioned here https://github.com/ONDC-Official/v1.2.0-logs/issues/20#issuecomment-1931304446

@wemakshaychavan

ONDC-Official / v1.2.0-logs

Ref-Seller - compliance check #20

Full Catalog Pull

Incremental Pull

Ref-Seller-App (with LSP)

Seller Side Cancel

Update Flows

Seller Side Cancel

Return Flows

Seller Side Cancel

Update (Return) Flows

RET10

Flow 1

Flow 2

Flow 3

Flow 4

Flow 5

Flow 6

RET11

RET10

Flow 1

Flow 2

Flow 4

Flow 5

Flow 6

RET11