Tonetag (SA: RET11)- Compliance check

[sahil-ondc]

search_inc_refresh

• Transaction logs for search_inc_refresh not submitted

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/locations/time must have required property 'label'
• /message/catalog/bpp/providers/locations/time must have required property 'timestamp'
• /message/catalog/bpp/providers/items/quantity/available/count must be equal to one of the allowed values (99,0)
• /message/catalog/bpp/providers/items/category_id must be equal to one of the allowed values
• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
• value passed in serviceability tags should be same as passed in location/circle

on_search_inc_refresh

• Transaction logs for on_search_inc_refresh not submitted

select

• Timestamp for /on_search api cannot be greater than or equal to /select api
• City code mismatch in /search_full_catalog_refresh and /select

on_select

• Timestamp for /select api cannot be greater than or equal to /on_select api

on_init

• /message/order must have required property 'tags'
• /message/order/payment/@ondc/org/buyer_app_finder_fee_type must be equal to one of the allowed values (percent,amount)
• buyer_app_finder_fee_amount cannot be empty string in payment object

on_confirm

• /message/order/fulfillments/0/start/location must have required property 'address'

on_status

• /message/order/items/0/quantity/count must be integer
• /message/order/fulfillments/0 must have required property '@ondc/org/TAT'
• /message/order/quote/breakup/0/item must be object

@JagadeeswarDevalla

[jagadeeswar577]

@sahil-ondc

we have been submitted the revised logs in the below PR for retail too.

https://github.com/ONDC-Official/v1.2.0-logs/pull/250/commits

It's been merged also, and we have received few feedbacks for logistic flow.

But no updates on Retails logs yet, so please check and let us know if there are any feedbacks.

Thanks

[jagadeeswar577]

@sahil-ondc any updates here?

[sahil-ondc]

Group A

Flow 1

search_inc_refresh

• context/city should be '*' while sending search_inc_catalog request

on_search_full_catalog_refresh

• context/city should be as per the area_code provided in /message/catalog/bpp/providers/locations
• timestamp provided in /message/catalog/bpp/providers/items/time cannot be greater than context/timestamp
• /message/catalog/bpp/providers/categories/descriptor/images cannot have value empty string ""
• list cannot be empty of /message/catalog/bpp/providers/items/tags/custom_group
• /message/catalog/bpp/providers/items/category_ids should have unqiue and sequencial sequence as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.4b1aemczbswx

on_search_inc_catalog_refresh

• bpp/fulfillments sent in payload shoulnd't be part of /on_search_inc_refresh api
• bpp/descriptor sent in payload shoulnd't be part of /on_search_inc_refresh api
• location label (/bpp/providers/locations/time/label) for /on_search_inc_refresh should not be equal to /on_search_full_catalog_refresh.label

Flow 2

on_select

• context/timestamp for /select api cannot be equal to /on_select api
• /fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_ship (O2S) in /on_search

on_init

• context/timestamp for /init api cannot be equal to /on_init api
• /message/order/quote/breakup/item should be as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ks3uqu8tq83s
• billing issues
  • Key length mismatch for breakup.0.item
  • Key 'ttl' mismatch: PT30S !== P1D

on_confirm

• message/order must have required property 'tags'
• context/timestamp for /confirm api cannot be greater than or equal to /on_confirm api
• order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)

on_status

• /message/order/quote/breakup/0/@ondc/org/item_quantity/count must be integer
• Order id in /confirm and /on_status does not match

on_track

• /message/tracking must have required property 'tags'

Flow 3

on_select_out_of_stock

• /message/order/quote/breakup/item should be as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

on_status

• Order id in /confirm and /on_status does not match

Group B

Flow 4 and Flow 5

on_cancel

• transaction logs should be as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec

@jagadeeswar577

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• context/timestamp of search and on_search cannot be same
• /message/catalog/bpp/providers/items/time/timestamp should not be greater than /context/timestamp
• keys should not be sent with empty array (ex: offers, catalog_link)
• /message/catalog/bpp/providers/items/category_ids should have sequence starting from 1

on_search_inc_catalog_refresh

• /context/timestamp of /search_inc and on_search_inc cannot be same

Flow 2

select

• Buyer selects multiple items (> 1 qty for each item) for checkout As per the roll out sheet https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

on_select

• /fulfillments[0]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_ship (O2S) in /on_search

on_init

• provider_location should not be provided (deprecated)

Flow 3

on_select (out-of-stock)

• /message/order/quote/breakup/items should have quantity/available and quantity/maximum
• /error/message should be exactly as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.w0p6bcyawc9u

Flow 4 and Flow 5

on_cancel

• transaction logs should be as per the API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec

@jagadeeswar577

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• /message/catalog/bpp/fulfillments/2/type must be equal to one of the allowed values (Delivery,Self-Pickup,Buyer-Delivery)
• /message/catalog/bpp/fulfillments should be same as fulfillments provided in /message/catalog/bpp/providers

on_search_inc_catalog_refresh

• sequence of item id '13691071' with custom menu id '688081' has been changed to '1', but what about item id '13691021' which was provided as sequence '1' in on_search_full_catalog_refresh
• all the incremental scenarios must be supported (check contract for all the possible scenarios)

other flows

on_select

• /message/order/fulfillment/@ondc/org/provider_name should be mapped to logistics name not to delivery type

on_confirm

• /message/order/payment/@ondc/org/settlement_details should have valid bank_name, settlement_ifsc_code, settlement_bank_account_no
• provider_tax_number (pan number of merchant) should be provided in /tags/bpp_terms

@jagadeeswar577

[nishthamongaondc]

Flow 1

on_search_full_catalog_refresh

• Origin tag fields are missing for item

on_search_inc_refresh

• same category_id as on_search_full_catalog_refresh should not be sent in on_search_inc_refresh
• Similar Item as in /on_search_full_catalog_refresh api call, item id- 13691084

Flow 3

confirm

• /message/order/fulfillments/0 must have required property 'tracking'

@jagadeeswar577

[jagadeeswar577]

@nishthamongaondc

1) We are not clear with the below feedbacks.

**same category_id as on_search_full_catalog_refresh should not be sent in on_search_inc_refresh**
**Similar Item as in /on_search_full_catalog_refresh api call, item id- 13691084**

What do you mean by that?

For what ever categories or items present in the **on_search_full_catalog_refresh**, if there are any updates happen to them only those will be sent in **on_search_inc_refresh** responses right? 

So what is your feedback is referring to?

2) Regarding /message/order/fulfillments/0 must have required property 'tracking' in Confirm API, the payload is coming from Buyer APP, how we as a Seller App can fix that??

[nishthamongaondc]

Hi Jagadeeswar, Yes, if there are any updates only then it should be sent in incremental search. In your case, this item 13691084 was repetitive. Same goes for category_id.

Thank You

With Regards Nishtha Monga

On Tue, 20 Feb 2024 at 14:23, Jagadeeswar @.***> wrote:

@nishthamongaondc https://github.com/nishthamongaondc We are not clear with the below feedbacks.

same category_id as on_search_full_catalog_refresh should not be sent in on_search_inc_refresh Similar Item as in /on_search_full_catalog_refresh api call, item id- 13691084

What do you mean by that?

For what ever categories or items present in the on_search_full_catalog_refresh, if there are any updates happen to them only those will be sent in on_search_inc_refresh responses right?

So what is your feedback is referring to?

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1953741203, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3YNK2QL2HSPKNFKEFW5B3YURQADAVCNFSM6AAAAABAHIDHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTG42DCMRQGM . You are receiving this because you were mentioned.Message ID: @.***>

[jagadeeswar577]

Hi Nishtha ,

Thanks for the reply related to our point 1.

Please clarify on our point 2 in above comments, so that we can proceed ahead from our end.

Thank you!

[nishthamongaondc]

Hi,

Which point are you referring to for further clarification?

Thank You

With Regards Nishtha Monga

On Tue, 20 Feb 2024 at 16:46, Jagadeeswar @.***> wrote:

Hi Nishtha ,

Thanks for the reply related to our point 1.

Please clarify on our point 2 in above comments, so that we can proceed ahead from our end.

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1953994838, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3YNKZIANKSX5LOIWQFI5LYUSAYBAVCNFSM6AAAAABAHIDHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTHE4TIOBTHA . You are receiving this because you were mentioned.Message ID: @.***>

[jagadeeswar577]

Hi,

Regarding

/message/order/fulfillments/0 must have required property 'tracking' in Confirm API,

the payload is coming from Buyer APP, how we as a Seller App can update / fix that?

Thanks

[sahil-ondc]

@jagadeeswar577 You can ignore this issue, and proceed for the other fixes and resubmission

[jagadeeswar577]

Thank you @sahil-ondc for the update.

As per above confirmation we will submit the Retails logs for Flow-1 with the suggested feedback.

Regards Jagadeeswar

[jagadeeswar577]

@nishthamongaondc

Regarding below feedback

on_search_full_catalog_refresh

• Origin tag fields are missing for item

We couldn't find Origin tag fields any where in the document for F&B Catalog. But we can see it in the Document for Grocery Catalog Payload.

So as our payloads are F&B Only, let us know what we need to do here for this feedback??

@sahil-ondc

Thanks

[nishthamongaondc]

Hi,

Kindly check the API Contract : https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.4b1aemczbswx Tags are required in both bpp/providers and bpp/descriptor

Thank You

With Regards Nishtha Monga

On Wed, 21 Feb 2024 at 16:29, Jagadeeswar @.***> wrote:

@nishthamongaondc https://github.com/nishthamongaondc

Regarding below feedback

on_search_full_catalog_refresh Origin tag fields are missing for item

We couldn't find Origin tag fields any where in the document for F&B Catalog. But we can see it in the Document for Grocery Catalog Payload.

So as our payloads are F&B Only, let us know what we need to do here for this feedback??

Thanks

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1956398963, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3YNK5D4SFCPS5YIO7W35DYUXHSNAVCNFSM6AAAAABAHIDHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGM4TQOJWGM . You are receiving this because you were mentioned.Message ID: @.***>

[nishthamongaondc]

Flow 2

on_init

• context/timestamp difference between /ON_INIT and INIT should be greater than 5 sec

on_status_packed

• order/state should be \"In-progress\" for /on_status_In-progress
• fulfillments/state should be Packed for /on_status_Packed

@jagadeeswar577

[jagadeeswar577]

@nishthamongaondc

Why we receiving Feedbacks now for Flow-2?? as per this comment https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1954060864 , we resubmitted logs for flow 1 as there were no feedbacks on any other flows

@sahil-ondc

[jagadeeswar577]

Hi Team,

Can you let us know your updates on the above comments please.

1) We have submitted ONLY Flow-1 logs in the last commit as per your last feedbacks https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1954060864

2) Why we receiving now few Feedbacks for Flow-2, as there were no comments earlier for the same?

Flow 2: on_init: context/timestamp difference between /ON_INIT and INIT should be greater than 5 sec .... We are not clear about this feedback. Where we have any reference in the ONDC docs referring this kind of instructions?

Flow 2: on_status_packed

• order/state should be "In-progress" for /on_status_In-progress
• fulfillments/state should be Packed for /on_status_Packed

We have been submitted on_status logs for below cases, which will be generated from Logistic app to us asynchronously.

1. Agent Assigned
2. Order Picked Up
3. Out For Delivery
4. Order Delivered

So please review the same and let us know your feedback for us.

@nishthamongaondc @sahil-ondc @BLR-0118

Thanks

[sahil-ondc]

Flow 2

confirm

• /message/order/fulfillments/0 must have required property 'tracking' (SNP should have validations)

on_confirm

• /message/order/tags/bpp_terms should have required property 'np_type'

Flow 5

on_cancel

• /message/order/fulfillments/1 should have state 'Return_Initiated' (provided: RTO-Initiated)
• invalid quote_trail provided

@jagadeeswar577

[jagadeeswar577]

@sahil-ondc

In the above feedback, For Flow 5 : on_cancel

/message/order/fulfillments/1 should have state 'Return_Initiated' (provided: RTO-Initiated)

In the document it has values for that attribute as enum - "RTO-Initiated", "RTO-Delivered", "RTO-Disposed";

But you are saying to have state value to be 'Return_Initiated'

We are not clear about this, can you clarify us reg this?

Thanks

[sahil-ondc]

Flow 1

on_search

• accept_bap_terms should not be provided as part of phase 1 implementation
• timming should be provided on the provider tags as per the new construct provided in API contract

Flow 5

on_cancel

• invalid pre_cancel timestamp provided in /message/order/fulfillment/tags

Flow 6

• Part-cancellation, reverse-QC, Liquidation should be done in single order with multiple items

@jagadeeswar577

[sahil-ondc]

Flow 1

on_search_inc

• if no change in categories delta, categories should not be provided in on_search_inc

Flow 5

on_cancel (RTO)

• updated_at should be provided in pre_cancel state should be correct i.e. when order was last updated

on_status (rto-delivered)

• items should be mapped with forward fulfillment with quatity zero
• refund settlement should be provided as refund is initiated when return got picked up

Flow 6

• @ondc/org/settlement_details should have settlement details of part-cancellation
• reverse QC not submitted

@jagadeeswar577

[sahil-ondc]

Flow 1

on_search (full_catalog)

• /message/catalog/bpp/providers/items/tags/type is optional for non-customizable (standalone) SKUs
• start should not be provided in /message/catalog/bpp/providers/fulfillments
• /message/catalog/bpp/descriptor/symbol should be publically accessible
• /message/catalog/bpp/providers/categories/images should be publically accessible

on_search (inc_catalog)

• /message/catalog/bpp/providers/categories/images should be publically accessible
• /message/catalog/bpp/providers/items/tags/type is optional for non-customizable (standalone) SKUs

Flow 5

on_select

• tags/type should not be provided in quote/breakup for non-customizable product

on_confirm

• 'TAT' must be provided in message/order/fulfillments (id: 69d61ed1-7c06-4283-bb63-a157a0b00cb5)

on_status

• while fulfillment status is 'Picked' and after that /message/order must have required property 'documents' having invoice which should be publically accessible

on_cancel

• start/timestamp should only be once the order or return is picked up from the start location
• Rto delivery charges should have tags defining its fulfillment in breakup
• Rto cannot be picked before cancellation (pickup time provided: 2024-04-12T10:13:41.390Z, while cancellation is 2024-04-12T10:22:26.605Z)
• Rto fulfillment must have start and end locations
• misc charges as Convenience Fee was provided till on_status (out-for-delivery) suddenly missing in on_cancel

on_status (rto-delivered)

• invalid rto-delivered timestamp

Flow 6

• Same as above

on_update

• tags/type should not be provided in quote/breakup for non-customizable product

on_status (packed)

• @ondc/org/settlement_details should have refund settlement details of partial cancellation

@jagadeeswar577

[jagadeeswar577]

@sahil-ondc

Regarding below feedback

Flow 6

on_status (packed) @ondc/org/settlement_details should have refund settlement details of partial cancellation

We have already included the said details.

Attached log files below for ref

https://github.com/ONDC-Official/v1.2.0-logs/blob/master/ToneTag/Retail-Logs/Group-C/h.%20update_settlement_for_seller_partial_cancel.json

https://github.com/ONDC-Official/v1.2.0-logs/blob/master/ToneTag/Retail-Logs/Group-C/j.%20on_status_packed.json

Please let us know if anything missing here?

[jagadeeswar577]

Hi @sahil-ondc

Please let us know if there are any feedbacks, for the latest retail logs submitted by fixing the recent comments

https://github.com/ONDC-Official/v1.2.0-logs/tree/master/ToneTag/Retail-Logs

Thank You.

[Jagannath-wits]

ToneTag (SA) :RET:11

Flow 2

select

• tmpstmp: Timestamp for /on_search api cannot be greater than or equal to /select api

on_select

• prvdrLoc: provider.locations[1].id is missing in /on_select

on_init

• ffTracking: Tracking must be present for fulfillment ID: bc434721-36e9-4d40-9bb9-b4990fd607be in boolean form

confirm

• ffTracking: Fulfillment Tracking mismatch with the on_select call

on_confirm

• message.order.fulfillments[bc434721-36e9-4d40-9bb9-b4990fd607be]: 'TAT' must be provided in message/order/fulfillments

on_status_pending

• on_status_pending: JSON cannot be empty

on_status_picked

• schemaErr0: /message/order must have required property 'documents'

on_status_out_for_delivery

• Same as Above

on_status_delivered

• Same as Above

Flow 3

select_out_of_stock

• missing select_out_of_stock payload

Flow 4

on_cancel

• invldQuoteTrailPrices: quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm
• ordrupdtd: order.updated_at timestamp should be greater than order.created_at timestamp
• orderCrtd: order.created_at timestamp should match context.timestamp of confirm
• precancelState.updatedAt: precancel_state.updated_at of on_cancel is not equal with the on_confirm order.updated_at

Flow 5

on_cancel

• on_cancel_msgId: Message id should not be same with previous calls
• invldQuotePrices: item quote breakup prices for on_cancel should be equal to the total quote price.
• RTO.start.location/DeliveryFulfillment.end.location: RTO fulfillment start and Delivery fulfillment end location mismatch in on_cancel

Flow 6

on_update_part_cancel

• on_update_part_cancel_msgId: Message id should not be same with previous calls

on_status_packed

• schemaErr0: /message/order/fulfillments/0/agent must have required property 'name'
• schemaErr1: /message/order/fulfillments/0/agent must have required property 'phone'
• schemaErr2: /message/order/fulfillments/0/vehicle must have required property 'category'
• schemaErr3: /message/order/fulfillments/0/vehicle must have required property 'size'
• schemaErr4: /message/order/fulfillments/0/vehicle must have required property 'registration'
• ffTracking: Tracking must be present for fulfillment ID: Cancel-2024-04-25-137934 in boolean form

on_update_approval

• on_update_approval_msgId: Message id should not be same with previous calls

on_update_picked

• Same as Above

on_update_delivered

• Same as Above

on_update_liquidated

• on_update_liquidated_msgId: Message id should not be same with previous calls

@jagadeeswar577

[jagadeeswar577]

@Jagannath-wits

We have submitted Retail Logs for Flow-2, Flow-3, Flow-4, Flow-5, Flow-6 with latest feedback fixes. PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1637

We have tested the flows using log validation tool and below are reference screen shots with success.

For Flow 5 we received below report from the tool

"on_cancel": { "invldQuoteTrailPrices": "quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm", "RTOfulfillment.end": "RTO fulfillment end object is missing in on_cancel", "RTO.end.location/DeliveryFulfillment.start.location": "RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel" }

In the above errors,

"invldQuoteTrailPrices": "quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm". It seems invalid as quote will change when order is cancelled and added return logistic charges.

"RTOfulfillment.end": "RTO fulfillment end object is missing in on_cancel", "RTO.end.location/DeliveryFulfillment.start.location": "RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel"

For above 2 errors When order status is return_initiated, we don't need to add end location object as per API doc.

Thanks Jagadeeswar

[Jagannath-wits]

ToneTag : RET:11

Flow 1

On Search

• Long and short description should not be the same

Flow 2

On Status Packed

• VehicleRegistration: vehicle registration is only required only in case of "Self-Pickup"

On Status Picked

• MissingTags: Tags are mandatory in Delivery Object for on_status_picked.
• VehicleRegistration: vehicle registration is only required only in case of "Self-Pickup"

On Status Out For Delivery

• Same as above

On Status Delivered

• Same as above

Flow 3

• Same as above

Flow 5

On Cancel

InvldQuoteTrailPrices: Quote trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm.

• The sum of the quote and quote_trail for on_cancel should match the quote for on_confirm. Regardless of whether logistics are added or not.

RTOfulfillment.end: RTO fulfillment end object is missing in on_cancel.

• You can verify in the on_cancel (RTO flow) whether the end object indicates RTO fulfillment in the documentation. It is not explicitly stated that this information should not be provided. Additional details are specified for cases involving RTO-disposed and RTO-delivered.

On Status Packed

• VehicleRegistration: vehicle registration is only required only in case of "Self-Pickup"

On Status Picked

• MissingTags: Tags are mandatory in Delivery Object for on_status_picked.
• VehicleRegistration: vehicle registration is only required only in case of "Self-Pickup"

On Status Out For Delivery

• Same as above

Flow 6

On Status Picked

• MissingTags: Tags are mandatory in Delivery Object for on_status_picked.
• VehicleRegistration: vehicle registration is only required only in case of "Self-Pickup"

On Status Out For Delivery

• Same as above

On Status Delivered

• Same as above

On Update Interim Reverse QC

• Message Ids for /update_reverse_qc and /on_update_interim_reverse_qc api should be same

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}

On Update Approval

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}

On Update Picked

• Same as above

on_update_delivered

• Same as above

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"200","settlement_timestamp":"2024-05-16T05:49:33.535Z"}

On Update Interim Liquidated

• Message Ids for /update_liquidated and /on_update_interim_liquidated api should be same

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"200","settlement_timestamp":"2024-05-16T05:49:33.535Z"}

On Update Liquidated

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}

• Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"200","settlement_timestamp":"2024-05-16T05:49:33.535Z"}

@jagadeeswar577

[jagadeeswar577]

Hi @Jagannath-wits

Please let us know if there are any feedbacks, for the latest retail logs submitted by fixing the recent comments

https://github.com/ONDC-Official/v1.2.0-logs/tree/master/ToneTag/Retail-Logs

Thank You.

[Jagannath-wits]

Flow 4

On Cancel

• Initiated By: For reason_code 001, it shouldn't be initiated by 'ref-logistics-app-preprod.ondc.org', should be initiated by 'buyer-app-preprod-v2.ondc.org' i.e., bap_id.

Flow 5

On Cancel

• RTO End Time: Fulfillment type RTO end time should not be present in /on_cancel when state/desc/code is RTO-Initiated.

Flow 6

On Update Part Cancel

• Cancel Request: Cancel request is not present in the 'Cancel' fulfillment.

On Status Pending

• Fulfillment Range Error 0: /start/range/start_time "2024-05-27T08:48:43.083Z" of on_confirm mismatched with /start/range/start_time "2024-05-27T08:58:42.786Z" of on_status_pending for 'Delivery' fulfillment.
• Fulfillment Range Error 1: /start/range/end_time "2024-05-27T09:48:43.083Z" of on_confirm mismatched with /start/range/end_time "2024-05-27T09:13:42.786Z" of on_status_pending for 'Delivery' fulfillment.
• Fulfillment Range Error 2: /end/range/start_time "2024-05-27T08:48:43.083Z" of on_confirm mismatched with /end/range/start_time "2024-05-27T09:33:42.786Z" of on_status_pending for 'Delivery' fulfillment.
• Fulfillment Range Error 3: /end/range/end_time "2024-05-27T09:48:43.083Z" of on_confirm mismatched with /end/range/end_time "2024-05-27T09:48:42.786Z" of on_status_pending for 'Delivery' fulfillment.

On Status Packed

• Similar as above

On Status Picked

• Fulfillment Range Error 0: /start/range/start_time "2024-05-27T08:48:43.083Z" of on_confirm mismatched with /start/range/start_time "2024-05-27T08:59:40.467Z" of on_status_picked for 'Delivery' fulfillment.
• Fulfillment Range Error 1: /start/range/end_time "2024-05-27T09:48:43.083Z" of on_confirm mismatched with /start/range/end_time "2024-05-27T09:14:40.467Z" of on_status_picked for 'Delivery' fulfillment.
• Fulfillment Range Error 2: /end/range/start_time "2024-05-27T08:48:43.083Z" of on_confirm mismatched with /end/range/start_time "2024-05-27T09:34:40.467Z" of on_status_picked for 'Delivery' fulfillment.
• Fulfillment Range Error 3: /end/range/end_time "2024-05-27T09:48:43.083Z" of on_confirm mismatched with /end/range/end_time "2024-05-27T09:49:40.467Z" of on_status_picked for 'Delivery' fulfillment.
• Order Fulfillments End Time: Mismatch occurred while comparing 'Delivery' fulfillment object with on_status_pending on key 'end/time/range'.
• Order Fulfillments Start Time: Mismatch occurred while comparing 'Delivery' fulfillment object with on_status_pending on key 'start/time/range'.

On Status Out For Delivery

• Similar as above

On Status Delivered

• Similar as above

On Update Approval

• Return FF Start Time Range Start: Start time range of return fulfillment should be greater than or equal to context timestamp of on_update_approval.

On Update Picked

• Return FF Start Time Timestamp: Start time timestamp of return fulfillment is missing.

On Update Delivered

• message/order.payment/@ondc/org/settlement_details/0: Missing payment/@ondc/org/settlement_details as compare to update_settlement_reverse_qc i.e.{\"settlement_counterparty\":\"buyer\",\"settlement_phase\":\"refund\",\"settlement_type\":\"netbanking\",\"settlement_amount\":\"100\",\"settlement_timestamp\":\"2024-05-27T08:54:17.897Z\"}
• Return FF End Time Timestamp: Return FF end time timestamp of return fulfillment is missing.
• Return FF Start Time Timestamp: Start time timestamp of return fulfillment is missing.

@jagadeeswar577

[Jagannath-wits]

Flow 2

on_init

• payment.tags.bpp_collect is only required when BPP is collecting payment
• Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount,@ondc/org/settlement_details are required in payment object when buyer is collecting money.
• If BPP is collecting payment, then the payment details will be provided in on_init and carried forward. If only BAP is collecting, then "collected by" should be BAP in Confirm as provided , and the rest will be the same as currently provided.

On Status Pending

• routing.type should be sent when order is accepted.

Flow 3

on_select_oos

• if item with dynamic_id DI2 and its customization is also out of stock it should be provided in the order.error block as provided in contract.

Flow 4

on_cancel

• quote price should be 0 as order was cancelled pre-shipment

Flow 5

On_status_rto_delivered

• RTO_fulfillment.Instructions object not required.

Flow 6

On Update Part Cancel

• Question: Why is on_update_part_cancel sent before order is accepted?

@jagadeeswar577

[sandeepshahi]

Flow 1

/on_search

• store timing in /locations/time/schedule is not provided correctly; for fixed timings use "range" instead of "frequency" and "times"
• configuration of custom groups should be defined correctly; how can min=1 and max=100 for toppings with upto 2 options? check for similar issues
• for above point, "seq" is also not configured correctly for custom groups;
• a default customization must be set for custom group where config.min=1
• lower/upper range in items/price/tags/range is not calculated correctly;
• default_selection price is not calculated correctly
• enums (yes, no) for default in /items/tags/parent should be in lowercase
• some of the custom groups defined in /categories are not used in the menu; eg: "Addon-13691093"
• Why do some customizations have nested child custom groups, even though the base item already has all the custom groups mapped? This will lead to cyclic customization selection. For example, check item "13691091"

/on_search (inc)

• search req seems mocked
• push based incremental must be supported;
• why are multiple incremental calls provided with different txn and mssg ids?
• new categories (custom menu) should not be added in incremental calls

Flow 2

/on_confirm

• how can estimated pickup/delivery time ranges be provided even before the order is accepted by the seller?

/on_status

• PCC code should be generated when order is packed
• DCC code should be generated when order is out for delivery
• are both gps and url based tracking supported?
• "Agent-assigned" state is missing

/track

• must be supported

Flow 5

/on_cancel

• actual pickup timestamp is missing from cancelled forward shipment: "464f8bf9-1da0-4699-9eda-68f2129b13ab"
• item/tags/quote must be used in quote/breakup for RTO fulfillment tax
• quote line items with delta changes must be present in quote_trail; "misc" is missing
• esimated pickup/delivery time ranges should not change

/on_status (RTO)

• food orders are mostly RTO disposed instead of being delivered back to sellers

Flow 6

/on_update

• payment/params/amount should not change; must remain the same as the collected amount
• order/created_at timestamp should not change;
• Food orders are mostly liquidated and not returned back to the sellers (reverseqc flow is optional)

/on_update (approval)

• start/end details are missing in "Return" fulfillment
• answers for reverseqc_input should not be provided in approved state

/on_update (picked)

• why is tax added in the quote_trail; only the quote line items with delta changes should be provided
• line items in quote/breakup should not be removed; trail must be maintained
• quantity of returned items mapped with the forward shipment "94236544-a09a-46da-84a8-5e5dac3eac9d" should be 0 in /items

/on_update (liquidated flow)

• similar issues as above

@jagadeeswar577

[jagadeeswar577]

Flow 1

/on_search

• lower/upper range in items/price/tags/range is not calculated correctly;
• default_selection price is not calculated correctly

In our system merchants define only a fixed price for the item(s), we don't have any lower & upper range of prices

/on_search (inc)

why are multiple incremental calls provided with different txn and mssg ids? -> As per one of the earliest feedback from your team, we have tested the suggested scenarios like provider disable, store disable, store closed and store reopen and provided corresponding response payloads.

Flow 2

/on_confirm

• how can estimated pickup/delivery time ranges be provided even before the order is accepted by the seller?

From Logistics service provider we are getting this details in logistic's on_confirm response, same data we are adding and providing back to buyer in our seller on_confirm response.

/on_status

are both gps and url based tracking supported? We are sharing the both GPS coordinates of rider and tracking url that are coming from logistic's on_track response to buyer's track request.

• "Agent-assigned" state is missing
• /track must be supported

We are not seeing the above mentioned payloads in the https://github.com/ONDC-Official/log-validation-utility page, based on that we provided the list of payloads for this flow.

Flow 5

/on_cancel

item/tags/quote must be used in quote/breakup for RTO fulfillment tax --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation

quote line items with delta changes must be present in quote_trail; "misc" is missing --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation

esimated pickup/delivery time ranges should not change --> is this value should be same as in on_confirm payload? Please confirm.

Flow 6

/on_update

payment/params/amount should not change; must remain the same as the collected amount --> Is this value should be same as in on_confirm payload? Please confirm.

/on_update (approval)

• start/end details are missing in "Return" fulfillment
• answers for reverseqc_input should not be provided in approved state

As per retail doc we have added above attributes. Please let us know what is missing exactly?

/on_update (picked)

• line items in quote/breakup should not be removed; trail must be maintained
• quantity of returned items mapped with the forward shipment "94236544-a09a-46da-84a8-5e5dac3eac9d" should be 0 in /items

As per retail doc we have added above attributes. Please let us know what is missing exactly?

@sandeepshahi

[jagadeeswar577]

Hi @sandeepshahi, can you please let us know your comments for the above highlighted feedback points.

Thanks

[Jagannath-wits]

Flow 1

/on_search

• lower/upper range in items/price/tags/range is not calculated correctly;
• default_selection price is not calculated correctly

In our system merchants define only a fixed price for the item(s), we don't have any lower & upper range of prices

• It should be calculated properly based on the base item and its customizations

/on_search (inc)

why are multiple incremental calls provided with different txn and mssg ids? -> As per one of the earliest feedback from your team, we have tested the suggested scenarios like provider disable, store disable, store closed and store reopen and provided corresponding response payloads.

• Acknowledged

Flow 2

/on_confirm

• how can estimated pickup/delivery time ranges be provided even before the order is accepted by the seller?

From Logistics service provider we are getting this details in logistic's on_confirm response, same data we are adding and providing back to buyer in our seller on_confirm response.

/on_status

are both gps and url based tracking supported? We are sharing the both GPS coordinates of rider and tracking url that are coming from logistic's on_track response to buyer's track request.

• "Agent-assigned" state is missing
• /track must be supported

We are not seeing the above mentioned payloads in the https://github.com/ONDC-Official/log-validation-utility page, based on that we provided the list of payloads for this flow.

• Acknowledged, it will be updated in next update, but please provide these as per the contract.

Flow 5

/on_cancel

item/tags/quote must be used in quote/breakup for RTO fulfillment tax --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation

• please refer to contract examples

quote line items with delta changes must be present in quote_trail; "misc" is missing --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation

esimated pickup/delivery time ranges should not change --> is this value should be same as in on_confirm payload? Please confirm.

Flow 6

/on_update

payment/params/amount should not change; must remain the same as the collected amount --> Is this value should be same as in on_confirm payload? Please confirm.

/on_update (approval)

• start/end details are missing in "Return" fulfillment
• answers for reverseqc_input should not be provided in approved state

As per retail doc we have added above attributes. Please let us know what is missing exactly?

/on_update (picked)

• line items in quote/breakup should not be removed; trail must be maintained
• quantity of returned items mapped with the forward shipment "94236544-a09a-46da-84a8-5e5dac3eac9d" should be 0 in /items

As per retail doc we have added above attributes. Please let us know what is missing exactly?

@sandeepshahi

[sandeepshahi]

@jagadeeswar577, one clarification: For RTO fulfillment, the locations are mandatory

[sandeepshahi]

Flow 1

/on_search

• upper range in items/price/tags/range is not calculated correctly;
• why is display sequence of items in custom_menu starting from number 4? check for item: 13691105 (item/category_ids)

/on_search (inc)

• disabled store (permanently closed) should not be reopened; only the already enabled store can be opened/closed
• disable/close/open:
  • time/timestamp can't be future dated; it captures the event timestamp

FLow 4

/on_cancel

• all the quote/breakup line items with delta changes should be part of quote_trail; delivery and misc are missing

Flow 5

/on_cancel

• similar issues as in Flow 4
• discrepancy in the values of tags/cancel_request/initiated_by and cancellation/cancelled_by

/on_status (RTO)

• RTO-Disposed timestamp can't be future dated; check end/time/timestamp

Flow 6

/on_update (part cancel)

• order/created_at timestamp should not change;
• part cancelled item(s) should also be part of quote/breakup with remaining quantity

/on_status

• refund info should be appended to payment/@ondc/org/settlement_details as and when received from the buyer app

/on_update (liquidated flow)

• quantity of returned items mapped with forward shipment should become 0 in /items; total count of all items in /items should remain the same
• liquidated items should be present in quote/breakup with remaining quantity
• invalid key "@ondc/org/provider_name" in Liquidated fulfillment; the liquidated item doesn't go back to the seller

@jagadeeswar577

[jagadeeswar577]

Flow 1

/on_search

• upper range in items/price/tags/range is not calculated correctly;

As per above screen shots, for Item, Pepper Barbeque Chicken Pizza, we are sending the upper range amount that is possible for the item. Please let us know what is the issue here?

/on_search (inc)

• disable/close/open: time/timestamp can't be future dated; it captures the event timestamp

As per the documentation, the time/timestamp contains value at which time the store should close / open / disable in the day. As per above screen shots from documentation too we are not clear what is time/timestamp can't be future dated means ?

FLow 4

/on_cancel

• all the quote/breakup line items with delta changes should be part of quote_trail; delivery and misc are missing -

As per above screenshot, the delivery and misc charges are exists. Please let us know what is exactly missing here?

Flow 5

/on_status (RTO)

• RTO-Disposed timestamp can't be future dated; check end/time/timestamp -

Please let us know what timestamp need to append here to fix this? as we don't have a API documentation reference for this payload to cross check.

Flow 6

/on_update (part cancel)

• part cancelled item(s) should also be part of quote/breakup with remaining quantity --

Item (13691105) had quantity 2 when ordered, and while partial cancel, we removed both. So in this case as per above screen shot the quote/breakup is "0", so what has to be remained here in this case?

/on_update (liquidated flow)

• quantity of returned items mapped with forward shipment should become 0 in /items; total count of all items in /items should remain the same -

As per documentation forward item and return item quantity are same. So can you clarify us what change you are expecting here?

• liquidated items should be present in quote/breakup with remaining quantity -

  Item ordered with quantity 2, and we liquidated both. So what should be here as remaining quantity?

@sandeepshahi Please review above feedback points with our replies once and clarify us if there is some ambiguity.

Thanks

[sandeepshahi]

Flow 1

1. Ok
2. As mentioned, the timestamp should be <= context.timestamp and denotes the timestamp when event was captured; The incremental calls to close the store consist of range where you can provide the future dated timestamps; For other calls, you have to call the incremental API as and when the even changes

Flow 4

3. Check the quote_trail in /fulfillments and not quote.breakup

Flow 5

5. How can you call the RTO-disposed API when the RTO will be disposed in future? Please check the timestamp, it should be <=context.timestamp

Flow 6

6. quantity =0 in quote.breakup, should flow in the subsequent APIs (eg: on_status)
7. It should be 0 because 2-2=0

@jagadeeswar577

[shivang1131]

on_confirm

• The timestamp in context is more than the timestamp in fulfillments.start.range.start

• How are you providing pickup/delivery ranges in fulfillments with the order state as created?

@jagadeeswar577

[sandeepshahi]

@jagadeeswar577, please answer the above queries and complete the pending submissions on NP Portal

[jagadeeswar577]

@shivang1131 & @sandeepshahi

When the Buyer app confirms the order, we(seller side) confirms the order with the Logistic partner. So the logistic partner sends the on_confirm payload in response to our confirm request, which consists of the fulfilment related details.

Then we will prepare on_confirm response from our side to the buyer app by including the required details received from the logistic partner.

Sample on_confirm payload from Logistic App to Us:

on_confirm_payload_from_logistic_to_seller.json

Corresponding on_confirm payload from our end to the Buyer App:

on_confirm_payload_from_seller_to_buyer.json

So please check and let us know your thoughts.

Thanks