Open sahil-ondc opened 9 months ago
@sahil-ondc
we have been submitted the revised logs in the below PR for retail too.
https://github.com/ONDC-Official/v1.2.0-logs/pull/250/commits
It's been merged also, and we have received few feedbacks for logistic flow.
But no updates on Retails logs yet, so please check and let us know if there are any feedbacks.
Thanks
@sahil-ondc any updates here?
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.4b1aemczbswx
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ks3uqu8tq83s
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec
@jagadeeswar577
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.w0p6bcyawc9u
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec
@jagadeeswar577
@jagadeeswar577
@jagadeeswar577
@nishthamongaondc
1) We are not clear with the below feedbacks.
**same category_id as on_search_full_catalog_refresh should not be sent in on_search_inc_refresh**
**Similar Item as in /on_search_full_catalog_refresh api call, item id- 13691084**
What do you mean by that?
For what ever categories or items present in the **on_search_full_catalog_refresh**, if there are any updates happen to them only those will be sent in **on_search_inc_refresh** responses right?
So what is your feedback is referring to?
2) Regarding /message/order/fulfillments/0 must have required property 'tracking' in Confirm API, the payload is coming from Buyer APP, how we as a Seller App can fix that??
Hi Jagadeeswar, Yes, if there are any updates only then it should be sent in incremental search. In your case, this item 13691084 was repetitive. Same goes for category_id.
Thank You
With Regards Nishtha Monga
On Tue, 20 Feb 2024 at 14:23, Jagadeeswar @.***> wrote:
@nishthamongaondc https://github.com/nishthamongaondc We are not clear with the below feedbacks.
same category_id as on_search_full_catalog_refresh should not be sent in on_search_inc_refresh Similar Item as in /on_search_full_catalog_refresh api call, item id- 13691084
What do you mean by that?
For what ever categories or items present in the on_search_full_catalog_refresh, if there are any updates happen to them only those will be sent in on_search_inc_refresh responses right?
So what is your feedback is referring to?
— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1953741203, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3YNK2QL2HSPKNFKEFW5B3YURQADAVCNFSM6AAAAABAHIDHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTG42DCMRQGM . You are receiving this because you were mentioned.Message ID: @.***>
Hi Nishtha ,
Thanks for the reply related to our point 1.
Please clarify on our point 2 in above comments, so that we can proceed ahead from our end.
Thank you!
Hi,
Which point are you referring to for further clarification?
Thank You
With Regards Nishtha Monga
On Tue, 20 Feb 2024 at 16:46, Jagadeeswar @.***> wrote:
Hi Nishtha ,
Thanks for the reply related to our point 1.
Please clarify on our point 2 in above comments, so that we can proceed ahead from our end.
Thank you!
— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1953994838, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3YNKZIANKSX5LOIWQFI5LYUSAYBAVCNFSM6AAAAABAHIDHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTHE4TIOBTHA . You are receiving this because you were mentioned.Message ID: @.***>
Hi,
Regarding
/message/order/fulfillments/0 must have required property 'tracking' in Confirm API,
the payload is coming from Buyer APP, how we as a Seller App can update / fix that?
Thanks
@jagadeeswar577 You can ignore this issue, and proceed for the other fixes and resubmission
Thank you @sahil-ondc for the update.
As per above confirmation we will submit the Retails logs for Flow-1 with the suggested feedback.
Regards Jagadeeswar
@nishthamongaondc
Regarding below feedback
We couldn't find Origin tag fields any where in the document for F&B Catalog. But we can see it in the Document for Grocery Catalog Payload.
So as our payloads are F&B Only, let us know what we need to do here for this feedback??
@sahil-ondc
Thanks
Hi,
Kindly check the API Contract : https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.4b1aemczbswx Tags are required in both bpp/providers and bpp/descriptor
Thank You
With Regards Nishtha Monga
On Wed, 21 Feb 2024 at 16:29, Jagadeeswar @.***> wrote:
@nishthamongaondc https://github.com/nishthamongaondc
Regarding below feedback
on_search_full_catalog_refresh Origin tag fields are missing for item
We couldn't find Origin tag fields any where in the document for F&B Catalog. But we can see it in the Document for Grocery Catalog Payload.
So as our payloads are F&B Only, let us know what we need to do here for this feedback??
Thanks
— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1956398963, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD3YNK5D4SFCPS5YIO7W35DYUXHSNAVCNFSM6AAAAABAHIDHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGM4TQOJWGM . You are receiving this because you were mentioned.Message ID: @.***>
@jagadeeswar577
@nishthamongaondc
Why we receiving Feedbacks now for Flow-2?? as per this comment https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1954060864 , we resubmitted logs for flow 1 as there were no feedbacks on any other flows
@sahil-ondc
Hi Team,
Can you let us know your updates on the above comments please.
1) We have submitted ONLY Flow-1 logs in the last commit as per your last feedbacks https://github.com/ONDC-Official/v1.2.0-logs/issues/205#issuecomment-1954060864
2) Why we receiving now few Feedbacks for Flow-2, as there were no comments earlier for the same?
Flow 2: on_init: context/timestamp difference between /ON_INIT and INIT should be greater than 5 sec .... We are not clear about this feedback. Where we have any reference in the ONDC docs referring this kind of instructions?
Flow 2: on_status_packed
We have been submitted on_status logs for below cases, which will be generated from Logistic app to us asynchronously.
So please review the same and let us know your feedback for us.
@nishthamongaondc @sahil-ondc @BLR-0118
Thanks
@jagadeeswar577
@sahil-ondc
In the above feedback, For Flow 5 : on_cancel
/message/order/fulfillments/1 should have state 'Return_Initiated' (provided: RTO-Initiated)
In the document it has values for that attribute as enum - "RTO-Initiated", "RTO-Delivered", "RTO-Disposed";
But you are saying to have state value to be 'Return_Initiated'
We are not clear about this, can you clarify us reg this?
Thanks
@jagadeeswar577
@jagadeeswar577
@jagadeeswar577
@sahil-ondc
Regarding below feedback
on_status (packed) @ondc/org/settlement_details should have refund settlement details of partial cancellation
We have already included the said details.
Attached log files below for ref
Please let us know if anything missing here?
Hi @sahil-ondc
Please let us know if there are any feedbacks, for the latest retail logs submitted by fixing the recent comments
https://github.com/ONDC-Official/v1.2.0-logs/tree/master/ToneTag/Retail-Logs
Thank You.
Timestamp for /on_search api cannot be greater than or equal to /select api
provider.locations[1].id is missing in /on_select
Tracking must be present for fulfillment ID: bc434721-36e9-4d40-9bb9-b4990fd607be in boolean form
Fulfillment Tracking mismatch with the on_select call
'TAT' must be provided in message/order/fulfillments
JSON cannot be empty
/message/order must have required property 'documents'
quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm
order.updated_at timestamp should be greater than order.created_at timestamp
order.created_at timestamp should match context.timestamp of confirm
precancel_state.updated_at of on_cancel is not equal with the on_confirm order.updated_at
Message id should not be same with previous calls
item quote breakup prices for on_cancel should be equal to the total quote price.
RTO fulfillment start and Delivery fulfillment end location mismatch in on_cancel
Message id should not be same with previous calls
/message/order/fulfillments/0/agent must have required property 'name'
/message/order/fulfillments/0/agent must have required property 'phone'
/message/order/fulfillments/0/vehicle must have required property 'category'
/message/order/fulfillments/0/vehicle must have required property 'size'
/message/order/fulfillments/0/vehicle must have required property 'registration'
Tracking must be present for fulfillment ID: Cancel-2024-04-25-137934 in boolean form
Message id should not be same with previous calls
Message id should not be same with previous calls
@jagadeeswar577
@Jagannath-wits
We have submitted Retail Logs for Flow-2, Flow-3, Flow-4, Flow-5, Flow-6 with latest feedback fixes. PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1637
We have tested the flows using log validation tool and below are reference screen shots with success.
"on_cancel": { "invldQuoteTrailPrices": "quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm", "RTOfulfillment.end": "RTO fulfillment end object is missing in on_cancel", "RTO.end.location/DeliveryFulfillment.start.location": "RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel" }
In the above errors,
"invldQuoteTrailPrices": "quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm". It seems invalid as quote will change when order is cancelled and added return logistic charges.
"RTOfulfillment.end": "RTO fulfillment end object is missing in on_cancel", "RTO.end.location/DeliveryFulfillment.start.location": "RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel"
For above 2 errors When order status is return_initiated, we don't need to add end location object as per API doc.
Thanks Jagadeeswar
on_status_picked
.InvldQuoteTrailPrices: Quote trail price and item quote price sum for
on_cancel
should be equal to the price as inon_confirm
.
- The sum of the quote and quote_trail for on_cancel should match the quote for on_confirm. Regardless of whether logistics are added or not.
RTOfulfillment.end: RTO fulfillment end object is missing in
on_cancel
.
- You can verify in the on_cancel (RTO flow) whether the end object indicates RTO fulfillment in the documentation. It is not explicitly stated that this information should not be provided. Additional details are specified for cases involving RTO-disposed and RTO-delivered.
on_status_picked
.on_status_picked
.Message Ids for /update_reverse_qc and /on_update_interim_reverse_qc api should be same
Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}
Same as above
Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"200","settlement_timestamp":"2024-05-16T05:49:33.535Z"}
Message Ids for /update_liquidated and /on_update_interim_liquidated api should be same
Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}
Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"200","settlement_timestamp":"2024-05-16T05:49:33.535Z"}
Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"400","settlement_timestamp":"2024-05-16T05:45:59.949Z"}
Missing payment/@ondc/org/settlement_details as compare to the previous calls or not captured correctly i.e. {"settlement_counterparty":"buyer","settlement_phase":"refund","settlement_type":"netbanking","settlement_amount":"200","settlement_timestamp":"2024-05-16T05:49:33.535Z"}
@jagadeeswar577
Hi @Jagannath-wits
Please let us know if there are any feedbacks, for the latest retail logs submitted by fixing the recent comments
https://github.com/ONDC-Official/v1.2.0-logs/tree/master/ToneTag/Retail-Logs
Thank You.
/on_cancel
when state/desc/code
is RTO-Initiated./start/range/start_time "2024-05-27T08:48:43.083Z"
of on_confirm
mismatched with /start/range/start_time "2024-05-27T08:58:42.786Z"
of on_status_pending
for 'Delivery' fulfillment./start/range/end_time "2024-05-27T09:48:43.083Z"
of on_confirm
mismatched with /start/range/end_time "2024-05-27T09:13:42.786Z"
of on_status_pending
for 'Delivery' fulfillment./end/range/start_time "2024-05-27T08:48:43.083Z"
of on_confirm
mismatched with /end/range/start_time "2024-05-27T09:33:42.786Z"
of on_status_pending
for 'Delivery' fulfillment./end/range/end_time "2024-05-27T09:48:43.083Z"
of on_confirm
mismatched with /end/range/end_time "2024-05-27T09:48:42.786Z"
of on_status_pending
for 'Delivery' fulfillment./start/range/start_time "2024-05-27T08:48:43.083Z"
of on_confirm
mismatched with /start/range/start_time "2024-05-27T08:59:40.467Z"
of on_status_picked
for 'Delivery' fulfillment./start/range/end_time "2024-05-27T09:48:43.083Z"
of on_confirm
mismatched with /start/range/end_time "2024-05-27T09:14:40.467Z"
of on_status_picked
for 'Delivery' fulfillment./end/range/start_time "2024-05-27T08:48:43.083Z"
of on_confirm
mismatched with /end/range/start_time "2024-05-27T09:34:40.467Z"
of on_status_picked
for 'Delivery' fulfillment./end/range/end_time "2024-05-27T09:48:43.083Z"
of on_confirm
mismatched with /end/range/end_time "2024-05-27T09:49:40.467Z"
of on_status_picked
for 'Delivery' fulfillment.on_status_pending
on key 'end/time/range'.on_status_pending
on key 'start/time/range'.on_update_approval
.{\"settlement_counterparty\":\"buyer\",\"settlement_phase\":\"refund\",\"settlement_type\":\"netbanking\",\"settlement_amount\":\"100\",\"settlement_timestamp\":\"2024-05-27T08:54:17.897Z\"}
@jagadeeswar577
on_init
and carried forward. If only BAP is collecting, then "collected by" should be BAP in Confirm
as provided , and the rest will be the same as currently provided.routing.type
should be sent when order is accepted.on_update_part_cancel
sent before order is accepted?@jagadeeswar577
/on_search
/on_search (inc)
/on_confirm
/on_status
/track
/on_cancel
/on_status (RTO)
/on_update
/on_update (approval)
/on_update (picked)
/on_update (liquidated flow)
@jagadeeswar577
/on_search
In our system merchants define only a fixed price for the item(s), we don't have any lower & upper range of prices
/on_search (inc)
why are multiple incremental calls provided with different txn and mssg ids? -> As per one of the earliest feedback from your team, we have tested the suggested scenarios like provider disable, store disable, store closed and store reopen and provided corresponding response payloads.
/on_confirm
From Logistics service provider we are getting this details in logistic's on_confirm response, same data we are adding and providing back to buyer in our seller on_confirm response.
/on_status
are both gps and url based tracking supported? We are sharing the both GPS coordinates of rider and tracking url that are coming from logistic's on_track response to buyer's track request.
We are not seeing the above mentioned payloads in the https://github.com/ONDC-Official/log-validation-utility page, based on that we provided the list of payloads for this flow.
/on_cancel
item/tags/quote must be used in quote/breakup for RTO fulfillment tax --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation
quote line items with delta changes must be present in quote_trail; "misc" is missing --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation
esimated pickup/delivery time ranges should not change --> is this value should be same as in on_confirm payload? Please confirm.
/on_update
payment/params/amount should not change; must remain the same as the collected amount --> Is this value should be same as in on_confirm payload? Please confirm.
/on_update (approval)
As per retail doc we have added above attributes. Please let us know what is missing exactly?
/on_update (picked)
As per retail doc we have added above attributes. Please let us know what is missing exactly?
@sandeepshahi
Hi @sandeepshahi, can you please let us know your comments for the above highlighted feedback points.
Thanks
Flow 1
/on_search
- lower/upper range in items/price/tags/range is not calculated correctly;
- default_selection price is not calculated correctly
In our system merchants define only a fixed price for the item(s), we don't have any lower & upper range of prices
/on_search (inc)
why are multiple incremental calls provided with different txn and mssg ids? -> As per one of the earliest feedback from your team, we have tested the suggested scenarios like provider disable, store disable, store closed and store reopen and provided corresponding response payloads.
Flow 2
/on_confirm
- how can estimated pickup/delivery time ranges be provided even before the order is accepted by the seller?
From Logistics service provider we are getting this details in logistic's on_confirm response, same data we are adding and providing back to buyer in our seller on_confirm response.
/on_status
are both gps and url based tracking supported? We are sharing the both GPS coordinates of rider and tracking url that are coming from logistic's on_track response to buyer's track request.
- "Agent-assigned" state is missing
- /track must be supported
We are not seeing the above mentioned payloads in the https://github.com/ONDC-Official/log-validation-utility page, based on that we provided the list of payloads for this flow.
Flow 5
/on_cancel
item/tags/quote must be used in quote/breakup for RTO fulfillment tax --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation
quote line items with delta changes must be present in quote_trail; "misc" is missing --> We are not clear with this feedback, can you please share some reference log or an example in the retail documentation
esimated pickup/delivery time ranges should not change --> is this value should be same as in on_confirm payload? Please confirm.
Flow 6
/on_update
payment/params/amount should not change; must remain the same as the collected amount --> Is this value should be same as in on_confirm payload? Please confirm.
/on_update (approval)
- start/end details are missing in "Return" fulfillment
- answers for reverseqc_input should not be provided in approved state
As per retail doc we have added above attributes. Please let us know what is missing exactly?
/on_update (picked)
- line items in quote/breakup should not be removed; trail must be maintained
- quantity of returned items mapped with the forward shipment "94236544-a09a-46da-84a8-5e5dac3eac9d" should be 0 in /items
As per retail doc we have added above attributes. Please let us know what is missing exactly?
@sandeepshahi
@jagadeeswar577, one clarification: For RTO fulfillment, the locations are mandatory
/on_search
/on_search (inc)
/on_cancel
/on_cancel
/on_status (RTO)
/on_update (part cancel)
/on_status
/on_update (liquidated flow)
@jagadeeswar577
/on_search
As per above screen shots, for Item, Pepper Barbeque Chicken Pizza, we are sending the upper range amount that is possible for the item. Please let us know what is the issue here?
/on_search (inc)
As per the documentation, the time/timestamp contains value at which time the store should close / open / disable in the day. As per above screen shots from documentation too we are not clear what is time/timestamp can't be future dated means ?
/on_cancel
As per above screenshot, the delivery and misc charges are exists. Please let us know what is exactly missing here?
/on_status (RTO)
Please let us know what timestamp need to append here to fix this? as we don't have a API documentation reference for this payload to cross check.
/on_update (part cancel)
Item (13691105) had quantity 2 when ordered, and while partial cancel, we removed both. So in this case as per above screen shot the quote/breakup is "0", so what has to be remained here in this case?
/on_update (liquidated flow)
As per documentation forward item and return item quantity are same. So can you clarify us what change you are expecting here?
liquidated items should be present in quote/breakup with remaining quantity -
Item ordered with quantity 2, and we liquidated both. So what should be here as remaining quantity?
@sandeepshahi Please review above feedback points with our replies once and clarify us if there is some ambiguity.
Thanks
@jagadeeswar577
The timestamp in context is more than the timestamp in fulfillments.start.range.start
How are you providing pickup/delivery ranges in fulfillments with the order state as created?
@jagadeeswar577
@jagadeeswar577, please answer the above queries and complete the pending submissions on NP Portal
@shivang1131 & @sandeepshahi
When the Buyer app confirms the order, we(seller side) confirms the order with the Logistic partner. So the logistic partner sends the on_confirm payload in response to our confirm request, which consists of the fulfilment related details.
Then we will prepare on_confirm response from our side to the buyer app by including the required details received from the logistic partner.
on_confirm_payload_from_logistic_to_seller.json
on_confirm_payload_from_seller_to_buyer.json
So please check and let us know your thoughts.
Thanks
search_inc_refresh
on_search_full_catalog_refresh
on_search_inc_refresh
select
on_select
on_init
on_confirm
on_status
@JagadeeswarDevalla