search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 263 forks source link

mystore (BA: RET11) - compliance check #2059

Open sahil-ondc opened 3 months ago

sahil-ondc commented 3 months ago

Flow 1

on_sesarch

Flow 3

on_select_oos

Flow 5

on_cancel

Flow 6

on_update (part-cancellation)

@dharkum24

asifrazastorehippo commented 3 months ago

@sahil-ondc 1- Flow1- Item level rejection is sent on catalog rejection API calls, here we consume the correct ones and skip the rest. 2- Flow3- We got an error of out of stock of one product why validate the schema as well and send NACK to an error message, here we(The buyer) just triggered again select call with less item count as we got correctly "@ondc/org/item_quantity" remaining as 2 and place order successfully. 3- Flow 5 - Could you please highlight What is incorrect, we'll NACK it. 4- Flow 6 - Here we already triggered NACK in response and we submitted the on_update_response

cc: @dharkum24 @sandeepshahi

Jagannath-wits commented 3 months ago

1- Flow1- Item level rejection is sent on catalog rejection API calls, here we consume the correct ones and skip the rest.

  • Ok 2- Flow3- We got an error of out of stock of one product why validate the schema as well and send NACK to an error message, here we(The buyer) just triggered again select call with less item count as we got correctly "@ondc/org/item_quantity" remaining as 2 and place order successfully.
  • The item i.e out of stock is linked to an customization i.e the parent_item_id(dynamic item id which is created by buyer app in select) but there is no customization, so there should've been a nack for that from seller and as the item with customization is out of stock its customization will also be removed with it and provided in error message.

3- Flow 5 - Could you please highlight What is incorrect, we'll NACK it.

4- Flow 6 - Here we already triggered NACK in response and we submitted the on_update_response

  • Please select a different seller so update_settlement can be validated.
asifrazastorehippo commented 3 months ago

@Jagannath-wits could you please let Mystore connect with other seller np that was approved earlier we tried with almost all seller np and we got responses like currently preprod is not working or we don't have bandwidth. Lastly only eSamudaay is ready to test so we have generated the logs.

There is only a NACK issue, from our side we'll do that. If we can allow to move ahead with the above logs.

cc: @sandeepshahi @BLR-0118

Jagannath-wits commented 3 months ago

@asifrazastorehippo You can connect with other NP's via community call or slack, also in flow 2 and 3 please make sure that parent_item_id( dynamic_item_id) is generated for items with customizations and not for base items, the flow should be with customizations in order

BLR-0118 commented 3 months ago

@sahil-ondc @Jagannath-wits - what's the status of this?

Jagannath-wits commented 3 months ago

@sahil-ondc @Jagannath-wits - what's the status of this?

They haven't resubmitted the logs yet

dharkum24 commented 3 months ago

@BLR-0118 The complaince are with regards to seller. If seller has schema issues we have to NACK. We tried with different sellers but couldn't generate logs as few sellers don't have pre-prod environment as they are live on production. We have approached different sellers but couldn't get enough support. From buyer perspective our logs are fine We just have to NACK if its schema validation which we can do it but we are blocked in generating and submitting logs due to unavailability of any proper seller. We have submitted these flows with other domains too and those are approved cc:- @asifrazastorehippo

dharkum24 commented 2 months ago

@BLR-0118 your inputs on it please cc:- @asifrazastorehippo

asifrazastorehippo commented 2 months ago

@sandeepshahi as discussed yesterday, please have this check

dharkum24 commented 2 months ago

@sandeepshahi @BLR-0118 As suggested submitted Flow5 and flow 6 Please review and approve https://github.com/ONDC-Official/v1.2.0-logs/pull/2172 cc:- @asifrazastorehippo

sahil-ondc commented 2 months ago

Flow 1

Buyer should send ‘NACK’ for the following:

On Search

Search Inc

Flow 2 & 3

Buyer should send ‘NACK’ for the following:

on_select_out_of_stock

select

on_select

init

on_init

confirm

on_confirm

on_status_pending

on_status_packed

on_status_picked

on_status_out_for_delivery

on_status_delivered

Flow 4

cancel

City code mismatch in /search and /cancel

on_cancel

@asifrazastorehippo @dharkum24

asifrazastorehippo commented 2 months ago

@sahil-ondc we have submitted flow5 and flow6 as per the compliance given by @Jagannath-wits above. The city code is the same on Search and Cancel as I checked could you please highlight the city code on the Buyer side? For timestamp will check that For on_search issues, as I already mentioned this we are sending through catalog rejection. As I can see most issues are on the seller's np side, how do we go about it, please let us know?

Flow5 and Flow6 we have submitted with Chattybao with the help of @BLR-0118, could you please check that as well?

@sandeepshahi @BLR-0118 need your input's on it for how to go about seller np side

sahil-ondc commented 2 months ago

Buyer should send 'NACK' for the following :

Flow 5

On Select

Init

On Init

Confirm

On Confirm

On Status Pending

On Status Packed

On Status Picked

On Status Out for Delivery

On Cancel

On Status RTO Delivered/Disposed

Flow 6

update_liquidated

on_update_interim_liquidated

on_update_liquidated

update_settlement_liquidated

on_update_part_cancel

update_settlement_part_cancel

@dharkum24

asifrazastorehippo commented 2 months ago

@sahil-ondc 1- The title missing part issue occurred because of seller np 2- Params one we checked right now by placing an order now it is not occurring 3- order.created_at timestamp should match context.timestamp - In contract it is written is should not be future timestamp so here we are using our original order timestamp, not when we are triggering confirm and it is just millisecond difference or some. 4- In return quantity should be in string not an Integer handled

If we started NACKing for all issues then we wouldn't be able to submit logs on preprod @BLR-0118 Could you please let me know what needs to be further done from our side

dharkum24 commented 2 months ago

@sandeepshahi @BLR-0118 Mystore F&B seller app logs have been submitted PR id https://github.com/ONDC-Official/v1.2.0-logs/pull/2277 Please review. Also any inputs on above comments for buyer app logs cc:- @asifrazastorehippo

sandeepshahi commented 2 months ago

Flow 5

/select

/confirm

@dharkum24, @asifrazastorehippo, please fix the previously raised issues as well

sandeepshahi commented 2 months ago

@asifrazastorehippo, @dharkum24 please provide payload for /update (return liquidation) API with customized item

asifrazastorehippo commented 2 months ago

Please find an enclosed update for (return liquidation) API with customized item update_with_custom.json @sandeepshahi

asifrazastorehippo commented 2 months ago

Please look attached video for Mystore as a Buyer journey with a custom item

https://github.com/user-attachments/assets/55450965-b3e2-48d9-b5d1-f0139af01d75

asifrazastorehippo commented 2 months ago

@sandeepshahi please have a look as discussed done both

sandeepshahi commented 1 month ago

The BA (RET11) v1.2 logs and the demo video above are fine

@asifrazastorehippo @dharkum24