ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 247 forks source link

Sellersetu (SA : RET10,12,13,14,15,18) - Compliance check #2199

Closed Jagannath-wits closed 1 week ago

Jagannath-wits commented 1 month ago

Ret10

on_search

on_search_inc

on_search_inc

on_search && on_search_inc

@sellersetu-hub

sellersetu-hub commented 1 month ago

@Jagannath-wits Please review.

Jagannath-wits commented 1 month ago

Ret10

on_search


Ret14

on_search


Ret15


@sellersetu-hub

sellersetu-hub commented 1 month ago

Is time_to_ship the same for all domains? i.e., 15 minutes.

Yes,

sellersetu-hub commented 1 month ago

@Jagannath-wits What does this mean "Multiple variants not used in the catalog." . Do we have to add products with multiple variants of different attributes ?

Jagannath-wits commented 1 month ago

@Jagannath-wits What does this mean "Multiple variants not used in the catalog." . Do we have to add products with multiple variants of different attributes ?

@sellersetu-hub If a variant has been declared then it should be associated with atleast 2 items, in the above scenario 3 variants were declared but only one was used.

sellersetu-hub commented 1 month ago

@Jagannath-wits There's no variant with id 0644650988327 in our payload. Though Point 2 The variant e0350180-84b6-4168-9b93-fde05ee54d07 is not used anywhere is correct, will fix this.

Jagannath-wits commented 1 month ago

@Jagannath-wits There's no variant with id 0644650988327 in our payload. Though Point 2 The variant e0350180-84b6-4168-9b93-fde05ee54d07 is not used anywhere is correct, will fix this.

Updating the same above

Chaitanya-Keyal commented 1 month ago

@Jagannath-wits Raised PR #2252 Please review

sellersetu-hub commented 3 weeks ago

@Jagannath-wits PR is merged. Please review

sellersetu-hub commented 3 weeks ago

@Jagannath-wits @sandeepshahi awaiting reviews here

sahil-ondc commented 3 weeks ago

RET 10

Flow 1

On Search

Search Inc

RET 12

Flow 1

On Search

Search Inc

RET 13

Flow 1

On Search

Search Inc

RET 18

Flow 1

On Search

Search Inc

On Search Inc

@sellersetu-hub

sellersetu-hub commented 3 weeks ago

@sahil-ondc

gps doesn’t match with the given area_code

This matches,

sahil-ondc commented 3 weeks ago

RET 14

search (increment)

RET 15

on_search (full catalog)

search (increment)

@sellersetu-hub

sellersetu-hub commented 2 weeks ago

@sahil-ondc We have corrected logs and raised PR

sahil-ondc commented 2 weeks ago

RET 10, 12, 14, 15

On Search


RET 13

On Search

RET 18

On Search

@sellersetu-hub

sellersetu-hub commented 2 weeks ago

hi @sahil-ondc , RET18 and RET13 issues were identified and fixed by team on 25th and are raised in this PR, https://github.com/ONDC-Official/v1.2.0-logs/pull/2303 , Kindly merge and review.

sellersetu-hub commented 2 weeks ago

Also @sahil-ondc , I am able to match area code and gps from reverse geocoding, image

sellersetu-hub commented 2 weeks ago

@sahil-ondc Changes have been merged please review.

sellersetu-hub commented 2 weeks ago

Hi @sahil-ondc @sandeepshahi Awaiting revert here

sellersetu-hub commented 1 week ago

@sahil-ondc @sandeepshahi Please review.

shivang1131 commented 1 week ago

RET 13

on-search

inc on_search

RET 18

on-search

shivang1131 commented 1 week ago

@sellersetu-hub

Chaitanya-Keyal commented 1 week ago

@shivang1131

EAN code cannot be same for multiple items. Refrain from passing placeholder values.

The codes are same only for variants, variants aren't supposed to have different EAN codes right?

shivang1131 commented 1 week ago

No issues for this case then @Chaitanya-Keyal

sandeepshahi commented 1 week ago

@sellersetu-hub, please ensure the category_id is followed as per the updated taxonomy sheet

sandeepshahi commented 1 week ago

Logs approved for SA v1.2 (RET 10, 12, 13, 14, 15 and 18)

@sellersetu-hub

sellersetu-hub commented 1 week ago

@sellersetu-hub, please ensure the category_id is followed as per the updated taxonomy sheet

Sure,