Thrive - LBNP - compliance check

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0

9 stars 268 forks source link

Thrive - LBNP - compliance check #2423

Open abhinavv245 opened 1 month ago

abhinavv245 commented 1 month ago

Deferred RTS is missing (implement /update call)

/search

Please use payment type as 'POST-FULFILLMENT' as this is enabled yet on the network

/confirm

Is logistics order id and linked retail order id same?
if BAP is collecting payment, why is LBNP sharing its settlment details, it should come from LSP in on_init
LSP did not send any terms in on_init, which bpp_terms is LBNP using and accepting?

RTO Flow

/on_status

on_status calls for RTO Delivered/Disposed are missing

TAT breach

/cancel

use appropriate cancellation reason id for TAT breach

@Chintanrhl

Chintanrhl commented 1 month ago

Ok, i will fix above issues and update the logs.

Chintanrhl commented 1 month ago

/confirm

if BAP is collecting payment, why is LBNP sharing its settlment details, it should come from LSP in on_init - We are not getting settlement detail from LSP in on_init for preprod, it will works on prod properly?

abhinavv245 commented 1 month ago

@Chintanrhl in that case, do not send it. If you receive them, then only you may send and accept them.

Chintanrhl commented 1 month ago

Ok Got it.

Chintanrhl commented 1 month ago

only COD (POST-FULFILLMENT) is allowed in ondc buyer? because currently we are only allowing prepaid orders for retail.

can please give some more context about this? @abhinavv245

abhinavv245 commented 1 month ago

COD is ON-FULFILLMENT POST-FULFILLMENT here means the billing is done later. Like invoicing is done monthly or fortnightly.

So for logistics, if retail payment is prepaid, Buyer app collects the payment, which will settle it with the seller app. If seller app is the logistics buyer, it means it will collect the delivery charges from the Retail Buyer app. But for this logistics order, it will settle the amount later with the logistics service provider.

@Chintanrhl

Chintanrhl commented 1 month ago

ok, now i understood the scenario. Thank you

Chintanrhl commented 1 month ago

updated logs: https://github.com/ONDC-Official/v1.2.0-logs/pull/2519

abhinavv245 commented 1 month ago

Order Flow

/confirm

What terms are being accepted by LBNP here? Kindly remove this tag

/update

ready to ship is already marked yes in /confirm, what is the purpose of this update call?

@Chintanrhl

Chintanrhl commented 1 month ago

ready to ship is already marked yes in /confirm, what is the purpose of this update call? -> right now its just for flow and logs generation (as you mentioned earlier for RTS flow implementation) , we only use update call if we needs to change delivery instructions.

Chintanrhl commented 1 month ago

Updated logs https://github.com/ONDC-Official/v1.2.0-logs/pull/2583

amitkbadheka commented 3 weeks ago

hey @abhinavv245 any update here?