ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 270 forks source link

Paytm Seller App (F&B) - compliance check #282

Closed BLR-0118 closed 10 months ago

BLR-0118 commented 10 months ago
  1. Search_OnSearch:
    • location "1031222" is in provider.locations and all items are assigned to this location; however, timing & serviceability is defined for different location "rt4uzx3n";
    • short_desc / long_desc / images not defined for custom menu;
    • bpp/providers.fulfillments has id "F1" defined for delivery; however, different fulfillment id is assigned to items (100160);
    • item 1235217312:
      • unitized is mandatory;
      • difficult to figure out which is base item / customization without tags.type being defined for each item;
      • why is config being redefined for custom groups 159001, 157897 when there's no change in min/max/seq?
      • for item with base price of 0, either default selection price or range (lower/upper) should be defined so buyer app can show a price on the provider listing page;
      • contact_details_consumer_care format is invalid: need name, contact no, email id;
      • serviceability (location.circle), store timing in the old format is required until everyone starts supporting the new formats in 1.2 phase 2;
  2. Select_OnSelect:
    • can't find customizations 1235193295/1235188643 in on_search catalog;
  3. Confirm_OnConfirm:
    • default fulfillment state of "Pending" missing;
    • bpp_terms duplicated in /on_confirm;
    • /confirm should have "bap_terms", with tax no of buyer NP;
  4. On_Status:
    • pickup time (fulfillment.start.time.timestamp) should be updated only after order is picked up;
    • delivery time (fulfillment.end.time.timestamp) should be updated only after order is delivered; Following are also required:
    • search/on_search with variants;
    • on_select with out of stock for item / customizations;
    • other APIs(cancel, cancel with RTO, return, tracking APIs);
    • on_status logs for all state transitions (Pending -> Packed -> Order-picked-up -> Out-for-delivery -> Order-delivered); only Pending / Packed are provided;
    • pls submit logs for the "Group B" test scenarios here;
BLR-0118 commented 10 months ago

@Anupam1705

Anupam1705 commented 10 months ago
  1. Select_OnSelect: can't find customizations 1235193295/1235188643 in on_search catalog; >> Since Search/On_Search logs are between ONDC Buyer Reference App and Paytm Seller App and other transactional api logs are between Paytm buyer and Paytm Seller.
  2. Confirm_OnConfirm: default fulfillment state of "Pending" missing; >> This is already been passed under state.descriptor.code as Pending in on_confirm api
  3. On_Status: on_status logs for all state transitions (Pending -> Packed -> Order-picked-up -> Out-for-delivery -> Order-delivered); only Pending / Packed are provided; >> These are already been provided for all the states under on_status.json file for respective cases @BLR-0118
BLR-0118 commented 10 months ago

2 - why can't you send these customizations to ONDC buyer app (like others which you're sending)? without this, it's difficult to follow the flow; 3 - ok; 4 - not clear how the seller app is setting these statuses? @Anupam1705

BLR-0118 commented 10 months ago
  1. Search_OnSearch:
    • tag code "non-veg" is not valid; should be "non_veg";
    • contact_details_consumer_care is not consistent - check diff b/w item ids 1235193883, 1235193881;
    • what does time_to_ship of PT0M mean - product is ready, packed & ready to ship?
    • difficult to figure out which is base item / customization without tags.type being defined for each item;
    • why is config being redefined for custom groups 157920 when there's no change in min/max/seq?
    • no data for item with base price of 0, either default selection price or range (lower/upper) should be defined so buyer app can show a price on the provider listing page;
cheena-jain commented 10 months ago

Search_onSearch

BLR-0118 commented 10 months ago
  1. Search_OnSearch:
    • Context.timestamp for /on_search same as /search;
    • definition of nested customization group for item 1235222936 incorrect (should be as defined here); there are other items with this incorrect definition;
    • what's the type for item 1235217194 - non-customizable SKU? Name looks more like customization but no type defined; (other similar items such as 1235193827);
    • only supported unit for serviceability for hyperlocal is "km";
  2. Select_OnSelect here:
    • inside quote, item unit prices are based on item.price.maximum_value instead of item.price.value;
    • need usecase for customization out of stock / base item out of stock;
    • provider.locations should be added (it's there in order object in all other APIs);
  3. /on_status (packed):
    • how to interprete Context.message_id here - :SentTimeStamp:1702908054269: as it's the same in /confirm as well?
  4. /on_track:
    • since time for which gps coords sent will be earlier than when it's updated, tracking.location.updated_at > tracking.location.time.timestamp;
  5. /on_cancel (rto initiated & rto delivered):
    • order.state of "CANCELLED" is invalid (should be "Cancelled");
    • item audit trail is incorrect (should show count of 0 for forward shipment fulfillment) & the entire count assigned to RTO fulfillment;
    • since this is due to reason "011", why isn't /cancel from buyer app included in logs?
  6. Pls also include logs for merchant cancel of order before shipping (flow 4 in test scenarios linked shared above;
BLR-0118 commented 10 months ago

@Anupam1705

BLR-0118 commented 10 months ago
  1. Select_OnSelect (with customisation and variant):
    • customization group 157896 is defined with config of 0 min, 1 max in the catalog; however, in /select, the buyer is able to select 2 customizations for this customization group. This is incorrect;
  2. Select_OnSelect (normal product -> out of stock - customized product):
    • /select includes 2 items & 1 customization (1235220266, 1235188621, 1235193885) and all these items have quantity in /on_select quote exactly the same as in /select; hence, not clear what's out of stock??
    • error message for item/customization out of stock should follow the format here;
  3. Merchant Cancel (/on_cancel):
    • request you to follow the payload as defined here (exactly same as for RTO);
  4. Need customizable item with base price of 0 & customizations with price > 0 as explained in test scenarios here;
  5. Incremental catalog update - no logs submitted

pls resubmit logs only for the above;

BLR-0118 commented 10 months ago

@Anupam1705

BLR-0118 commented 10 months ago
  1. Incremental update:

    • location.time.timestamp is 2023-12-28T11:06:31.565Z while Context.timestamp is 2023-12-28T11:06:31.005Z, i.e. location disable event is future timestamp, which is invalid;
    • same issue with product update as well;
    • product_incremental: not sure what's exactly being updated: items 1235193882, 1235193883, etc. have exactly the same data as in the full catalog pull;
  2. Full catalog pull:

    • point 4 above is a common usecase in F&B and customizable item(s) corresponding to this has to be shared;
    • out_of_stock for customization with correct error format to be shared (ok for item, but error.type is invalid & needs to be corrected);
  3. Cancel_OnCancel:

    • quote.breakup format has changed from /on_confirm (parent_item_id, custom group info missing);
    • cancel reason code 004 is invalid (use one of the reason codes from here);
  4. Pls share following info:

    • Jira ticket no for 1 above;
    • Jira ticket for support for location.circle, location.timings;
BLR-0118 commented 10 months ago

@Anupam1705

BLR-0118 commented 10 months ago
  1. /on_select (out of stock - normal product) here:
    • item 1235193883 is out of stock and following details are in quote.breakup:
    • qty = 0 (correct);
    • item unit price = 60 (correct);
    • total price = item unit price * qty should be 0 (shown as 60);

Following are open issues which need to be fixed subsequently (with corresponding jira ticket nos):

BLR-0118 commented 10 months ago

logs cleared for F&B (RET11), subject to 1 above being fixed

BLR-0118 commented 10 months ago

@Anupam1705

Anupam1705 commented 10 months ago

@BLR-0118 Somehow, older payload is being sent here, will update it and send by today, this has already been fixed.

Anupam1705 commented 10 months ago

@BLR-0118 Please check the PR for updated payload ; https://github.com/ONDC-Official/v1.2.0-logs/pull/417

BLR-0118 commented 10 months ago

issue 1 above - verified as fixed; @Anupam1705