ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 217 forks source link

Ecom Express - LSP - compliance check #302

Open abhinavv245 opened 7 months ago

abhinavv245 commented 7 months ago

Flow 1

/on_search

Flow 2

/init

/on_init

/confirm

/on_update

/on_status

Flow 3

/on_cancel

/on_status

@AryanSinghEcom Kindly test with another logistics buyer in Pre Production and resubmit the logs

AryanSinghEcom commented 7 months ago

/on_search Sure, will correct it as mentioned

/on_init order/quote must have required property 'ttl' This is an error in the log verification utility. When I was testing using the utility, it informed that ttl is an extra field. Thats why I removed this. Can you please confirm?

/confirm I do not understand the error here, in the logs submitted, order id is CQ9CP72042 and the transaciton ID is:b7ada47b-fb73-4907-9a5b-734701342c5e

/on_update _context/timestamp difference between onupdate and update should be within 1 seconds Since in the backend for requests, these are apis of the testing environment, This can take a little more than a second. But rest assured this is unlikely to happen in the production

/on_status _Kindly submit unsolicited onstatus call for fulfillment state - 'Agent-assigned' This is not in our use case, these are more likely to occur for orders that are Immediate Delivery

_fulfillments/tags (ready_toship) not required Sure, will update my logic to remove this from on_status

pickup timestamp (fulfillments/start/time/timestamp) for fulfillment state 'Order-picked-up' is not recorded correctly, cannot be before RTS (ready to ship) was triggered in /update

delivery timestamp (fulfillments/end/time/timestamp) for fulfillment state 'Order-delivered' is not recorded correctly Sure, will update

how is payment status 'PAID' for payment type 'POST-FULFILLMENT' Ideally we will not accept anything other than prepaid orders (ON-ORDER). But since the seller we integrated with was sending POST-FULFILLMENT, I accomodated the requests for the same temporarily. Will correct this.

FLOW-3 Will do the required changes and update.

fulfillment of type 'Delivery' should be 'Cancelled' and another fulfillment of type 'RTO' will be added initiating the RTO (RTO-Initiated) with its start/time/timstamp can you please elaborate this a little further?

abhinavv245 commented 7 months ago

Clarifications

/on_init

on_status (Agent-assigned)

/confirm - you can ignore this one

/on_update

Flow 3

@AryanSinghEcom

abhinavv245 commented 6 months ago

@AryanSinghEcom Please resolve all previous issues identified above and the issues identified by the utility and resubmit the logs.

abhinavv245 commented 6 months ago

Flow 2 and 3

/on_init

@AryanSinghEcom

AryanSinghEcom commented 6 months ago