search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 270 forks source link

Bizom (Seller App - RET10/13/16/18) - Compliance check #353

Open sahil-ondc opened 10 months ago

sahil-ondc commented 10 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_refresh

Other Flows

on_confirm

on_status

common

@Akhil-873

samarthpatel-bizom commented 10 months ago

  1. /message/catalog/bpp/providers/items/quantity/available/count must be equal to one of the allowed values (99,0) : Isn't this for a BPP who stores inventory in binary format ? If a BPP has actual inventory count can they not share ?

  2. /message/order/fulfillments/end/time/timestamp should be in the provided range: These values are shared by logistics BPP at the actual event happens. Here as this was while testing, delivery was marked later and hence the timestamp was not in the range. Also this can occur in prod due to delayed delivery.

  3. /message/order/fulfillments/0 must have required property '@ondc/org/TAT': This is present in on_select, can't see in other APIs. Can you please mention where it is missing.

@sahil-ondc

sahil-ondc commented 10 months ago

  1. The actual inventory count can't be provided and updated accurately. Here the available count only indicates whether the item is available in the inventory (99 means available and 0 means out of stock)

  2. Please check with the logistics seller provider, or you can generate logs with any other LSP.

  3. Please check in on_confirm, on_status API calls.

AbhijeetONDC commented 10 months ago

Flow 1

on_search_full_catalog_refresh

message/catalog/bpp/providers[1] has duplicate items ids with message/catalog/bpp/providers[0]

Other Flows

on_init

Message/order/quote/breakup[0]/item should be as per API Contract

confirm

/message/order must have required property “tags” /message/order/quote/breakup[0]/item should be as per API Contract

on_confirm

Message/order/quote/breakup[0]/item should be as per API Contract

on_status

/message/order/fulfillments/0/@ondc/org/TAT must match format specified in API Contract /message/order/fulfillments/0/start/location must have required property “address” /message/order/payment/params must have required property “transaction_id”

common

Timestamp for /on_search api cannot be greater than or equal to other apis. All flows timestamp should be sequentially increasing.

@samarthpatel-bizom

samarthpatel-bizom commented 10 months ago

@AbhijeetONDC

sahil-ondc commented 10 months ago

ACK @samarthpatel-bizom

samarthpatel-bizom commented 10 months ago

@sahil-ondc https://github.com/ONDC-Official/v1.2.0-logs/pull/396 please check.

sahil-ondc commented 10 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_catalog_refresh

Flow 2

on_init

on_status

Flow 3

on_select

Flow 4

on_cancel

@samarthpatel-bizom

sumitagbizom commented 10 months ago

@sahil-ondc https://github.com/ONDC-Official/v1.2.0-logs/pull/465 please review this pr

sahil-ondc commented 10 months ago

Flow 1

on_search_full_catalog_refreh

on_search_inc_catalog_refresh

Common

on_select

on_confirm

@sumitagbizom

samarthpatel-bizom commented 10 months ago

  1. selling price of item /price/value with id: (1) can't be greater than the maximum price /price/maximum_value in /bpp/providers[0]/items[0]: This seems to be an manual error while gathering logs our system does not allow SP > MRP.

  2. Flows should be in sequential order as per the sheet: We have followed the same sheet and flow sequence, can you please highlight what exactly is the issue ?

@sahil-ondc can you please point out if anything else is there ? And can we just fix flow 1 typo and resubmit it along with other flows ?

sumitagbizom commented 10 months ago

@sahil-ondc https://github.com/ONDC-Official/v1.2.0-logs/pull/516 please review

samarthpatel-bizom commented 9 months ago

@sahil-ondc can you please review.

sahil-ondc commented 9 months ago

Flow 1

on_search

Flow 2

confirm

on_confirm

on_status

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec

@samarthpatel-bizom

samarthpatel-bizom commented 9 months ago

@sahil-ondc /message/order/tags should have property 'quote_trail': Can you please confirm whether this is part of phase 1 ?

samarthpatel-bizom commented 9 months ago

/message/order/fulfillments/end/time/timestamp should be provided range -> As this is a testing flow, we had marked delivered manually before time (we can't wait till that time and mark it). This will not be the case in PROD.

sandeepshahi commented 9 months ago

/message/order/fulfillments/end/time/timestamp should be provided range -> As this is a testing flow, we had marked delivered manually before time (we can't wait till that time and mark it). This will not be the case in PROD.

@samarthpatel-bizom

You may ignore this issue

samarthpatel-bizom commented 9 months ago

/message/order/tags should have property 'quote_trail' -> This seems to be a part of phase 2. Can you please confirm ? @sahil-ondc @bluecypher

sumitagbizom commented 9 months ago

https://github.com/ONDC-Official/v1.2.0-logs/pull/608 @sahil-ondc please review

sahil-ondc commented 9 months ago

Flow 4

on_cancel

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec

@sumitagbizom

sumitagbizom commented 9 months ago

@sahil-ondc can we just submit flow 4 logs after correcting the issue ?

sumitagbizom commented 9 months ago

@sahil-ondc https://github.com/ONDC-Official/v1.2.0-logs/pull/687 please review

sahil-ondc commented 9 months ago

Flow 2

on_confirm

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

@sumitagbizom

samarthpatel-bizom commented 9 months ago

@sahil-ondc

sahil-ondc commented 9 months ago

ACK @samarthpatel-bizom

sandeepshahi commented 9 months ago

@samarthpatel-bizom, PAN number of the merchant must be provided by all the SNPs in /on_confirm

sumitagbizom commented 9 months ago

@bluecypher https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.9sth5gn87hj1 As per the document provider_tax_number is required only if SNP is ISN.

sandeepshahi commented 9 months ago

@sumitagbizom, thanks for highlighting this, we will update the document.

sumitagbizom commented 9 months ago

@bluecypher https://github.com/ONDC-Official/v1.2.0-logs/pull/764 please review

samarthpatel-bizom commented 9 months ago

As per the discussion with @BLR-0118 we will be submitting flow 6 Return liquidation. Meanwhile can you please review other flows @bluecypher ?

sumitagbizom commented 9 months ago

https://github.com/ONDC-Official/v1.2.0-logs/pull/796 @bluecypher please check. Added flow 6 with return liquidation.

sahil-ondc commented 8 months ago

Flow 1

on_search_full_catalog

on_search_inc_catalog

other flows

select

on_status

@sumitagbizom

sumitagbizom commented 8 months ago

/message/order/provider must have required property 'locations' -> the select calls have the required field

/message/order/fulfillments/0/end/location/gps The gps co-ordinates should be precise atleast upto 6 digits after decimal -> we are sending the gps upto 6 decimal digits. Only in case the coordinate ends with 0 we trim the value and send. You can see the longitude is 6 digits. Also in flow 6 where the order is placed using a different location the gps has 6 digits.

/message/catalog/bpp/descriptor/tags/bpp_terms must have property np_type (ISN, MSN) -> should we also add "code":"accept_bap_terms"

@sahil-ondc

sumitagbizom commented 8 months ago

https://github.com/ONDC-Official/v1.2.0-logs/pull/872 @sahil-ondc please review

sahil-ondc commented 8 months ago

RET:13, RET:16

Flow 1

on_search

RET:18

Flow 1

on_search

RET:10

Flow 1

on_search

Flow 2

on_select

confirm

on_confirm

Flow 4

on_cancel

Flow 5

Flow 6

Note

Flow 1

on_search

Flow 4

on_cancel

@sumitagbizom

sumitagbizom commented 8 months ago

Flow 6: As discussed with supriyo we will only be submitting return with liquidation for phase 1. @sahil-ondc

sumitagbizom commented 8 months ago

@sahil-ondc As per our discussion have re-submitted flow 1,2,4,5. https://github.com/ONDC-Official/v1.2.0-logs/pull/948 please review

sahil-ondc commented 8 months ago

RET 18

on_search

RET 10

Flow 2

confirm

on_status

Flow 3

on_select

confirm

on_confirm

on_status

Flow 4

confirm

on_cancel

Flow 5

on_cancel

on_status (rto-delivered)

Flow 6

on_update (liquidate)

Note

@sumitagbizom

sumitagbizom commented 8 months ago

https://github.com/ONDC-Official/v1.2.0-logs/pull/1024 @sahil-ondc please review

cc: @BLR-0118

sahil-ondc commented 8 months ago

RET 10

Flow 2

confirm

on_confirm

on_status

Flow 3

on_select (out-of-stock)

select (available)

confirm

on_status

Flow 4

confirm

on_cancel

Flow 6

@sumitagbizom

samarthpatel-bizom commented 8 months ago

  1. /message/order must have required property 'tags' (SNP should have validation) -> We have disabled few validations in order to place orders. This will not be the case in PROD.

  2. context/timestamp difference between /on_select and /select should be less than 5 sec (current difference around 30sec) -> This might be a glitch as you can see in other /select and /on_select such high latency is not there.

  3. new context/transaction_id will be created for a new select call -> I believe transaction_id is kind of a session id where a buyer app can have same transaction_id for a user till the order is created, post which a new transaction_id will be generated. This is not in the control of Seller App.

  4. why delivery charges are not being refunded ? -> This is a business call for now, this might change.

  5. cancelled items should be mapped to RTO fulfillment -> A new fulfillment is created 2a8409d0-723d-4653-9a53-855e5109e72f + RTO and cancelled items are mapped to that fulfillment. Can you please tell us what's the issue here ?

  6. If delivery charges are not refunded, then it should not be provided in quote trail. -> Quote trail contains just item prices and not delivery price as it is not supposed to be refunded.

  7. Same issues as above -> There is the issue with the timestamp. Is there anything else ?

@sahil-ondc Can you please clarify these points.

samarthpatel-bizom commented 8 months ago

@sahil-ondc as per our discussion, we have raised PR for 3rd flow fixing common issues.

https://github.com/ONDC-Official/v1.2.0-logs/pull/1063

Please review.

samarthpatel-bizom commented 8 months ago

@sahil-ondc any update on this ?

samarthpatel-bizom commented 8 months ago

@sahil-ondc can we please get an update on this ?

cc: @BLR-0118

BLR-0118 commented 7 months ago

Flow 1

  1. full on_search:
    • why no EAN no for item 17?
    • use correct values for unitized qty, e.g.:
    • item 17: unitized.measure.unit should be "gram" (relevant enums here), value "500";
    • item 29: unit should be "gram", value "50", unitized.count can be 4 (as per swagger schema here, to be added in contract addendum;
    • for item 13, is country of origin really Germany? same for item 9 & USA;

Flow 2

  1. /on_confirm:

    • fulfillment TAT to be added;

  2. /on_status_accepted:

    • /on_select TAT is 1hr 55 min, but that's changed to 55m here & 35 min in /on_status_agent_assigned (less is ok, more is not);

  3. /on_track:

    • order id here is different from what's in /on_confirm; is this tracking for same or different order?

  4. All /on_status:

    • since tracking is true, gps_enabled should be set whenever tracking is on (and for intercity, url_enabled & url);
    • routing.type needs to be set for the buyer app to understand what statuses to process;

Flow 3

  1. /on_select_out_of_stock:
    • item.quantity.available.count definition has changed for item "11"?

Flow 4

  1. /on_cancel:
    • following need to be added: cancel_request, precancel_state;

Flow 6

  1. I understand that you won't do part cancel of order?
  2. No return with pickup?
BLR-0118 commented 7 months ago

@sumitagbizom @samarthpatel-bizom

BLR-0118 commented 7 months ago

pls resubmit for flow 1, 4 (and respond to queries above)

samarthpatel-bizom commented 7 months ago

Flow 1:

  1. why no EAN no for item 17? -> In prod these SKUs do have EAN but in here we are just checking other codes as well.
  2. use correct values for unitized qty -> ACK
  3. for item 13, is country of origin really Germany? same for item 9 & USA -> It's just to check internal system functionality.

Flow 2:

  1. /on_confirm fulfillment TAT to be added; -> ACK
  2. /on_status_accepted: -> on_status Accepted is there in the flow 2 folder.
  3. /on_track -> There seems to be some log collection error. If required let me know will resubmit.

Flow 3: /on_select_out_of_stock: item.quantity.available.count definition has changed for item "11"? -> In case of out of stock item we are passing actual available count instead of 0 as BAP can allow user to place an order within available item count.

Flow 4:

  1. cancel_request: following need to be added: cancel_request, precancel_state -> For cancel_request "only if fulfillment is cancelled;" is the note mentioned on the contract and here as the whole order got cancelled we have not added this.

Flow 6:

  1. I understand that you won't do part cancel of order? -> Yes as discussed we don't need this as of now.
  2. No return with pickup? -> Yes majority of items are grocery where return will get liquidated in case of damaged items.

@BLR-0118

samarthpatel-bizom commented 7 months ago

We will resubmit flow 1 and flow 4. @BLR-0118

samarthpatel-bizom commented 7 months ago

Flow1 & Flow4: resubmitted https://github.com/ONDC-Official/v1.2.0-logs/pull/1137

@BLR-0118

BLR-0118 commented 7 months ago

flow 1

  1. full_on_search:

    • unitized qty incorrect for item id 20, 19, 14, 13;
    • country of origin incorrect for item id 20;
    • in some cases, unitized qty is for entire pack (item id 15) & in other cases, it's for single unit in pack (18, 11, 5): pls fix this inconsistency;
    • for item id 17, shouldn't unitized qty be 500 gram?

  2. Can you pls respond to Flow 2, pt 4 above?