Adya (logistics BAP) - compliance check

abhinavv245 commented 10 months ago

Flow 1 (Order-process flow)

/search

Is it taking 4 days to prepare the order (mark rts=yes)? (provider/time/schedule/duration)

/on_search (buyer app should send NACK for schema errors)

how will Delhi to Bangalore order be fulfilled in 60 minutes
motorable distance is not recorded accurately (required for Immediate Delivery)
All categories in /categories array should have its items present in /items array
/on_search/context/timestamp must match format "date-time"
/on_search/message/catalog/bpp/providers/items/fulfillment_id must be string

/init

/init/message/order/items/fulfillment_id should be mapped to the id - "1" in /fulfillments
fulfillment_id - 1 of /items does not match with any id in fulfillments array in on_search api
empty locations array is not required
/init/message/order/fulfillments/tags are not required
/init/message/order/billing/tax_number should be valid

/on_init

/on_init/context/timestamp must match format "date-time"
/on_init/message/order must have required property 'payment'

/confirm

/confirm/message/order/items/fulfillment_id must be string
/confirm/message/order/fulfillments/end/instructions must have required property 'short_desc'
/confirm/message/order/payment must have required property 'collected_by'

/on_confirm

/on_confirm/context/timestamp must match format "date-time"
/on_confirm/message/order/items/fulfillment_id must be string
/on_confirm/message/order/quote object mismatches in /confirm and /on_confirm.
/on_confirm/message/order/fulfillments/start/time not required when ready to ship = no
/on_confirm/message/order/fulfillments/end/time not required when ready to ship = no
/on_confirm/message/order/fulfillments/end/instructions must have required property 'short_desc'
/on_confirm/message/order/payment must have required property 'collected_by'

/update

/update/message/order/fulfillments/end/instructions must have required property 'short_desc'

/on_update

/on_update/context/timestamp must match format "date-time"
/on_update/message/order/tags (bpp_terms and bap_terms) are not required
/on_update/message/order/items/fulfillment_id must be string
/on_update/message/order/fulfillments/start/time range and timestamp must match format "date-time"
/on_update/message/order/fulfillments/end/time range and timestamp must match format "date-time"
/on_update/message/order/fulfillments/end/instructions must have required property 'short_desc'
/on_update/message/order/payment must have required property 'collected_by'
/on_update/message/order/created_at mismatches in /confirm and /on_update

/status

/status/context/timestamp must be string

/on_status

payload for fulfillment state - Out-for-delivery should be provided
/on_status/context/timestamp must match format "date-time"
/on_status/message/order/tags (bpp_terms and bap_terms) are not required
/on_status/message/order/items/fulfillment_id must be string
/on_status/message/order/fulfillments/start/time range and timestamp must match format "date-time"
/on_status/message/order/fulfillments/end/time range and timestamp must match format "date-time"
/on_status/message/order/payment must have required property 'collected_by'
Pickup timestamp (fulfillments/start/time/timestamp) cannot change for fulfillment state - Order-delivered
Pickup timestamp (fulfillments/start/time/timestamp) cannot be provided for fulfillment state - Agent-assigned"
Delivery timestamp (fulfillments/end/time/timestamp) cannot be provided for fulfillment state - Agent-assigned"
Delivery timestamp (fulfillments/end/time/timestamp) cannot be provided for fulfillment state - Order-picked-up"

on_track

/on_track/context/timestamp must match format "date-time"

Flow 2 (Cancellation Flow)

similar issues as above

/on_cancel

Order state should be 'Cancelled' for fulfillment state - RTO-Initiated
Pickup timestamp (fulfillments/start/time/timestamp) is missing for fulfillment state - Cancelled

/on_status

RTO Delivery timestamp (fulfillments/end/time/timestamp) is missing for fulfillment state - RTO-Delivered",
RTO Pickup time (fulfillments/start/time/timestamp) cannot change for fulfillment state - RTO-Delivered"

abhinavv245 commented 10 months ago

Flow 1

null values should be removed

/on_search

/on_search/0/message/catalog/bpp/providers/0/categories/0/time/timestamp must match format "date"

/init

/init/0/message/order must have required property 'payment'"

confirm

'ttl' is not required in quote;

/on_confirm

@ondc/org/collection_amount is only required for payment type 'ON-FULFILLMENT'

/on_track

/on_track/0 time/timestamp or updated_at in /location cannot be future dated w.r.t context/timestamp

Flow 2

similar issues as above

/update

deferred ready_to_ship needs to be supported via /update call

/on_cancel

/on_cancel/0 created_at/updated_at must not be future dated
Message Id cannot be same for different sets of APIs (is same as confirm, buyer app should handle)

@kausic-eunimart

abhinavv245 commented 10 months ago

Flow 2

context/timestamp difference between on_action and action should be within 1 seconds

/on_search

motorable_distance between start and end point is not recorded correctly

/confirm

item duration does not match with the one provided in /on_search (LSP can send NACK)

/update

deferred RTS needs to be supported through update call

/on_cancel

/on_cancel/0/message/order/created_at mismatches in /confirm and /on_cancel
/on_cancel/0 created_at/updated_at must not be future dated

/on_status

Order state should be 'Cancelled' for fulfillment state - RTO-Delivered
Pickup timestamp (fulfillments/start/time/timestamp) cannot change for fulfillment state - Cancelled

@saravanamuthu-123

abhinavv245 commented 10 months ago

Flow 2

/search

CityCode 080 should match the city for the fulfillment start location 140301, 0172

/on_status

/on_status/2/message/order/quote price is not matching with the total breakup price (RTO-delivered)
Order state should be 'Cancelled' for fulfillment state - RTO-Delivered
Pickup timestamp (fulfillments/start/time/timestamp) cannot change for fulfillment state - Cancelled

/on_cancel

/on_cancel/0/message/order/quote price is not matching with the total breakup price\
/on_cancel/0/message/order/created_at mismatches in /confirm and /on_cancel
/on_cancel/0 created_at/updated_at must not be future dated
Pickup timestamp (fulfillments/start/time/timestamp) cannot change for fulfillment state - Cancelled

@saravanamuthu-123

sandeepshahi commented 9 months ago

/confirm

average pickup time (fulfillments/start/time/duration) can't change; should be the same as provided by LSP
quote price value changed in /on_init; should be NACK'd by BNP
price in linked_order can't change;

/track

tracking is set as false in /on_confirm; track should be disabled;

@saravanamuthu-123

BLR-0118 commented 8 months ago

"order process flow" - /confirm:
- PCC has the buyer contact no, which is incorrect;
"buyer cancel flow" - /cancel:
- reason code used is invalid for logistics buyer NP;

BLR-0118 commented 8 months ago

@saravanamuthu-123

BLR-0118 commented 7 months ago

/search:
- payment.type of "ON-ORDER", i.e. using wallet isn't enabled yet; pls use post fulfillment for post billing (what's working today);
/confirm:
- ready_to_ship is being marked as "yes" here after informing the LSPs (thru /search) that order prep time is 1 hr; this is incorrect;
- usage of OTP for PCC/DCC is incorrect (authorization block needs to be used for OTP) and OTP for DCC is never sent to LSP;
- what are the images being sent in fulfillment.start.instructions & fulfillment.end.instructions?

BLR-0118 commented 7 months ago

@saravanamuthu-123

ONDC-Official / v1.2.0-logs