Gofrugal (RET10) - compliance checks

[sandeepshahi]

/on_search

• callback response should not take longer to be sent; search was initiated 4 days ago;
• attribute sequence for variant groups: "19746-ONDC-1-5617-5617_Convn" and "19746-ONDC-1-5618-5618_Conv" should be "1"; since group is created on the basis of a single attribute
• placeholder images of items should not be sent; SNP should avoid sending images if not available
• please use the non-deprecated category_id for each item as per the enhanced subcategory list here
• statutory reqs should have valid values as per the category_id; eg: for category_id: "Beverages", statutory_reqs_prepackaged_food should have proper values instead of "NA"
• return window for grocery domain is set as 30 days; @ondc/org/return_window= P30D; is this intended?
• quantity/available/count should be either 99 or 0 as per the availability and exact inventory count should not be provided; (where 99 - available, 0 - out of stock)
• quantity/maximum/count should be either 99 (no cap) or any +ve value (if cap per order)

Flow 2

/on_select

• "@ondc/org/category" and "@ondc/org/TAT" mapping should be correct; Immediate Delivery should be used where delivery TAT <= 2 hours
• available and maximum count should not change; the logic remains the same as in /on_search catalog

/on_confirm

• estimated pickup (/fulfillments/start/time) and delivery time (/fulfillments/end/time) ranges can't be the same;

/on_status

• mapping of order and fulfillment state must be correct; order state can't be "In-progress" when fulfillment state is still "Pending"
• "settlement_status" can't be PAID and settlement_timemstmap can't be provided in "@ondc/org/settlement_details" until the order amount is settled by the collector
• Invoice should only be provided once the order is picked and thereafter; the label should be "Invoice" (upper case "I") in /documents

/on_track

• tracking should be set as true in previous APIs if tracking is enabled;

Flow 3

/on_select (OOS)

• quote price and quote breakup must be updated in OOS scenario; quantity and available count must be set as "3" (which is the available inventory count)

Flow 4

/on_cancel

• order/updated_at can't be future dated; should be <= context/timestamp
• as per phase 1: quantity/count should not be 0 in /items; only the corresponding fulfillment should be cancelled and quote is updated

Flow 5

/on_cancel (RTO)

• rto delivery charges need not be provided if 0;

/on_status (RTO-delivered)

• quote/price should not change in RTO-delivered state; should be the same as in RTO-Initiated state

@AbinayaM

[sandeepshahi]

@AbinayaM,

For Flow 4, pls follow cancel flow as mentioned in the contract v1.2

[AbinayaM]

@bluecypher Can you explain this issue : "quantity/maximum/count should be either 99 (no cap) or any +ve value (if cap per order)"

[sandeepshahi]

quantity.maximum.count depicts the maximum quantity of an item, a buyer can order in a cart.

@AbinayaM

[umaswam1974]

**"/on_cancel

as per phase 1: quantity/count should not be 0 in /items; only the corresponding fulfillment should be cancelled and quote is updated"**

      @bluecypher the count should be 0 for cancellation of full order. Quoting the contract here -

"items": [ { "id":"I1", "fulfillment_id":"F1", "quantity": { "count":0 } },

You have also mentioned that fulfillment should be cancelled. It is not mandatory to cancel the fulfillment. Only in case of multi fulfillment order, we can cancel the fulfillment otherwise it will always be a full order cancel. Please clarify if we are missing something here.

[umaswam1974]

@AbinayaM,

For Flow 4, pls follow cancel flow as mentioned in the contract v1.2

Could you be specific on the issue? unable to get your point.

[AbinayaM]

Error 1 : placeholder images of items should not be sent; SNP should avoid sending images if not available Explanation : All the item url are valid. Can you specify which are the placeholder image

Error 2 : /on_select (OOS) : quote price and quote breakup must be updated in OOS scenario; quantity and available count must be set as "3" (which is the available inventory count) Explanation : The given available count is 3. Then, what is the issue here?

@bluecypher

[AbinayaM]

@bluecypher Can you please respond on our queries.

[AbinayaM]

Resubmitted the v1.2.0 retail logs. Fixed all the above listed issues. And also validated with log validation utility. @bluecypher Please verify this pr

[BLR-0118]

Flow 1

1. /on_search (full catalog):

   • Context.timestamp is earlier than /search;
   • what does radius of 100,000 km mean? (note that earth radius is around 6000 km);
   • aren't you creating EAN codes for packaged items e.g. why are using 5:19609-ONDC-1-10205 for item 19609-ONDC-1-10205?
   • country of origin should be 3 letter ISO code e.g. IND, not India *though 3 letter code is being used correctly in some cases);
   • why aren't you using proper unitary measure (item.quantity.unitized.measure) e.g. for item 19609-ONDC-1-10205, why is it 1 unit, instead of "100 gram" as in the desc?
   • request proper use of item.quantity.maximum.count - "99" means no cap per order, any other non-zero value means cap per order; this is independent of item.quantity.available.count (where "0" means out-of-stock & "99" is default for in-stock); thus, when item is out-of-stock, available count becomes 0 but max count shouldn't change;

2. /on_search (incremental):

   • not sure what has changed for this item "19609-ONDC-1-10206" (common use cases in grocery are item going out of stock / in-stock or price change);

Flow 2

1. /on_select:

   • provider.locations is required;
   • fulfillment.type is required;

2. /on_init:

   • add provider.locations;
   • remove provider_location;

3. /on_status:

   • fulfillment.tracking was true up to /on_confirm (means tracking available) but became false from /on_status (agent assigned);
   • provider.locations had id up to /on_confirm but includes gps in /on_status;
   • fulfillment TAT included in /on_status, pls also add to /on_confirm;

4. /on_track:

   • to optimize tracking on buyer apps, pls also set "gps_enabled" or ("url_enabled" & "url") in /on_status as doc here;

Flow 3

1. /on_select (out of stock):
   • pls codify the error message as doc here;

Flow 4

1. /on_cancel:
   • payload is invalid;
   • new cancellation fulfillment should be created (with quote trail) & items assigned to it as doc here;
   • this is similar to what has been done for RTO (with exceptions noted below);

Flow 5

1. /on_cancel (RTO):
   • quote_trail is invalid (this should have the delta changes from the previous state of the order quote in /on_confirm);
   • also, since cancellation liabilities will come in now, pls add precancel_state for cancellation / RTO (doc in full contract doc);

Also: a. plans to support variants? b. when do you plan to enable flow 6 (a, b for grocery);

[BLR-0118]

@AbinayaM - if you need a call to discuss the above, we can connect

[AbinayaM]

Flow 4 /on_cancel: payload is invalid; new cancellation fulfillment should be created (with quote trail) & items assigned to it as doc here; this is similar to what has been done for RTO (with exceptions noted below);

We have done as per phase 1 contract. The quote_trail for forward fulfillment is required only if fulfillment is cancelled. In our case we are cancelling the order not the fulfillment. @BLR-0118

[BLR-0118]

@AbinayaM - request you to fix flow 4 /on_cancel as requested as everyone else has been asked to do the same;

[AbinayaMaran]

@BLR-0118 Fixed all the mentioned issues. And done all the above listed phase 2 change. Kindly verify this pr

[BLR-0118]

Flow 1

1. /on_search (full catalog):
   • item categorization not correct in some cases e.g. "19609-ONDC-1-10205" (Chocolate Complan) - is this fruits & vegetables?
   • item unitized qty not correct in some cases e.g.: a. 19609-ONDC-1-10210 - name shows "125 ml", unitized qty is "125 g"? b. 19609-ONDC-1-10214 - name is "Caramel milk shake", unitized qty is "2g"? c. 19609-ONDC-1-10223 - name is "Bread", unitized qty is "1 unit"? d. 19609-ONDC-1-10231 - name has "500 ml", unitized qty is "500 gram"?

• instead of defining serviceability of 500 km, why not make it Pan-India?

2. /on_search (incremental):
   • includes incremental update for provider "19746-ONDC-1" which is not in full pull; provider cannot be enabled thru incremental update as per contract;

Flow 2

1. /on_confirm:
   • remove pickup code in fulfillment.start.instructions & delivery code in fulfillment.end.instructions (as these aren't valid here);

[BLR-0118]

• request to send provider_tax_number (for the buyer NP to verify if seller NP is MSN or ISN);

Flow 3

1. /on_select (out of stock):
   • error.message is string, not array (check format here);

[BLR-0118]

Flow 4

1. /on_cancel:
   • quote.breakup: item_quantity for all cancelled items should become 0, so that total price for item will become equal to 0 (done correctly in flow 5);

Flow 5

1. /on_cancel (RTO initiated):
   • quote_trail shouldn't have delivery charge of 55.22 (as this hasn't changed in quote) or delivery charge of 0 for RTO fulfillment;

[BLR-0118]

@AbinayaMaran:

• flow 3 issue is blocker, pls fix & share the log for /on_select (out of stock) for me to clear logs for RET10;
• pls also fix the other issues & make a note here when done;

[AbinayaMaran]

• request to send provider_tax_number (for the buyer NP to verify if seller NP is MSN or ISN);

Do we need to send tax number of individual seller or Gofrugal's tax number?

[BLR-0118]

PAN no of provider i.e. individual seller

[AbinayaMaran]

@AbinayaMaran:

• flow 3 issue is blocker, pls fix & share the log for /on_select (out of stock) for me to clear logs for RET10;
• pls also fix the other issues & make a note here when done;

@BLR-0118 Fixed the blocker issue of on_select out of stock error message. And submitted log of with and without stock of select and on_select calls of Flow 3. Please check pr

[AbinayaMaran]

And we are working on the search issue.

[BLR-0118]

@AbinayaMaran - pls make sure the other issues are fixed before you deploy in Prod

[BLR-0118]

logs cleared for v1.2.0 (RET10)

[AbinayaMaran]

@AbinayaMaran - pls make sure the other issues are fixed before you deploy in Prod

Sure. We will update the remaining logs after the fix.

[AbinayaMaran]

@AbinayaMaran - pls make sure the other issues are fixed before you deploy in Prod

@BLR-0118 We have fixed all the above mentioned issues. Please verify the pr. We are working on the on_search weight issue. Will update it soon.

[AbinayaMaran]

@BLR-0118 As we discussed I have completed v1.2 phase 1 changes of partial cancel and submitted log for Flow 6 pr

[BLR-0118]

@AbinayaMaran - only problem in /on_update is that order isn't shipped but pickup time & delivery time is showing & this is incorrect;

[AbinayaMaran]

@AbinayaMaran - only problem in /on_update is that order isn't shipped but pickup time & delivery time is showing & this is incorrect;

@BLR-0118 We will check and correct it.

[AbinayaMaran]

@BLR-0118 We have removed pick up time and delivery time in on_update. Kindly check the pr

[BLR-0118]

@AbinayaMaran - log for flow 6 (partial cancel) ok;

[AbinayaMaran]

@BLR-0118 We have fixed all search issues. Kindly check it.pr

[BLR-0118]

Full catalog

1. item 19746-ONDC-1-4350, name seems to be toothbrush but category is "Stationery";
2. item 19746-ONDC-1-5619-5619_4_conv (sugar) shows price of 1000 for 1 kg; 19746-ONDC-1-5619-5619_3_conv (sugar) shows price of 500 for 500g?
3. no item grouping by variants, even though variant defn available?

[BLR-0118]

@AbinayaMaran

[AbinayaMaran]

@BLR-0118 Can you please explain the second point?