Craver (Buyer App) - Compliance check

[sahil-ondc]

Flow 1

Search Inc Refresh

• contextCityError: When sending a search_inc_catalog request, the city/context should be set to "*"

Other Flows

Select

The city code in /search_full_catalog_refresh and /select doesn't match

Init

• /message/order/billing/email can't be NULL
• /message/order/fulfillments/0/end/location/address/name needs to have at least 3 alphabets/characters
• /message/order/fulfillments/0/end/location/address/building needs to have at least 3 alphabets/characters
• The provider id in /select and /init doesn't match
• The provider location id in /select and /init doesn't match
• The values of address.name, address.building, and address.locality need to be unique
• The GPS coordinates in fulfillments[0].end.location don't match between /select and /init
• The Address.area_code in fulfillments[0].end.location doesn't match between /select and /init

Confirm

• /message/order/billing/email cant be NULL.
• The city code in /search and /confirm doesn't match
• The provider id in /on_search and /confirm doesn't match
• The provider location id in /on_search and /confirm doesn't match
• The Fulfillments[0].end.location.address.area_code doesn't match with area_code in /select
• The payment settlement_details in /on_init and /confirm don't match

Status

• Incomplete Status call
• Missing pending, picked_up, and delivered calls

@sadrohan

[sandeepshahi]

Please share the order flow for customizable items

Flow 1

/search

• invalid placeholder link of static terms; static terms should not be provided as part of phase 1, remove tags property
• is hyperlocal serviceability handled?

/search_inc

• full catalog has been sent as part of incremental search; how is this handled?

Flow 2

/select

• null is not a valid type for offers; "offers" property should not be provided if null/empty
• inaccurate geocoding of gps and area_code in /fulfillments/end/location/gps
• parent_item_id should not be created for non-customizable items

/init

• created_at and updated_at in /billing can't be future dated

/confirm

• remove static_terms and accept_bpp_terms block from tags (not a part of phase 1); bpp_terms would be accepted by the bap when terms and conditions in /on_init are accepted
• settlement_basis, settlement_window and withholding_amount are not a part of phase 1; should not be provided in payment object
• millisecond value in created_at and updated_at timestamps should be of 3 digits only

Flow 3

/select

• transaction id should be the same as in /select (OOS);

Flow 4

/cancel

• message/descriptor should only be provided for a particular fulfillment cancellation (only in case of TAT breach)
• post shipment cancellation should not be allowed for F&B orders

/on_cancel

• invalid order object; schema should be the same as mentioned in the contract; SNP must respond with a NACK

Flow 5

• invalid RTO flow; No /on_cancel call provided

Flow 6

• must be submitted for verification

@sanidhya-locus

[rudra-cruv]

@bluecypher The above issues has been resolved in the latest Commit.

[rudra-cruv]

@bluecypher Please merge this #964, before reviewing the logs.

[sandeepshahi]

Flow 1

/on_search

• How are following scenarios handled in the buyer app?
  • default customization must be set for a custom group where config.min=1 (minimum 1 item needs to be selected); eg: no default customization is set for custom group BFuMy5
  • veg_nonveg categorization is incorrect; eg: all the customizations in size based custom group: "BFuMy5" are marked as "egg"
  • PAN India serviceability is set for F&B products;

Flow 2

/confirm

• "static terms" and "accept_bpp_terms" objects should not be provided in /tags/bap_terms;

Flow 3

/on_select (OOS)

• error.message is not in correct format; BNP must respond with a NACK

/select_2

• context/transaction_id should not change; must remain the same for a particular session

Flow 4

/cancel

• descriptor should only be used for fulfillment level cancellation (in case of TAT breach);
• invalid fulfillment id in /descriptor/short_desc

Flow 5

• invalid RTO flow; RTO must be triggered through on_cancel

Flow 6

• refund must be initiated once the order is cancelled (part/full) or returned; BNP must provide FYI refund info to SNP in /update call

@rudra-cruv @sanidhyaagrawal

[rudra-cruv]

@sandeepshahi, Can you elaborate or give reference on how to achieve this, refund must be initiated once the order is cancelled (part/full) or returned; BNP must provide FYI refund info to SNP in /update call in Flow 6.

[sandeepshahi]

You have to call the /update API as mentioned in the contract here

@rudra-cruv

[rudra-cruv]

@Jagannath-wits

I think you have reviewed some other PR.

Flow - 2

Provider.locations[0].id matches in /select and /init

Flow - 3

No Item id in our Flows matches with food_item-170383210588937185,

Flow - 6(c)

We haven't submitted Flow-6(c) as it is inapplicable in F&B category.

[Jagannath-wits]

Flow 2

Select

• location_id[0]: location_id should be same for the item 6ff30f9d-6d0f-445b-a433-b9fb8ff4879b as in on_search
• location_id[1]: location_id should be same for the item 83af9e2e-bd0e-40fd-91e4-5d681963eb56 as in on_search
• location_id[2]: location_id should be same for the item 5783db53-17bd-457d-9218-f031940eacd8 as in on_search
• prvdLoc: provider.locations[0].id 65f0037a9a10a7d8a390c2ee mismatches in /on_search and /select

Confirm

• orderCrtd: order.created_at timestamp should match context.timestamp
• quantErr: Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select

Flow 3,4,5

same as above

Flow 6-a

Update

• fulfillmentID: Cancel fulfillment ID should be same as the one in /on_update API; You seem to have provided reason id

@rudra-cruv Please refer to this

[rudra-cruv]

@sandeepshahi @Jagannath-wits Please review the new Commit.

[sandeepshahi]

Flow 1

/on_search

• no default customization is set for custom groups where config.min = 1;
• default_selection prices are provided but no default customization is set. How is the buyer app rendering the default customizations?

/search (inc)

• is push based incremental refresh supported?

Flow 2

/select

• is the GPS and area_code mapping correct for delivery location? Reverse geocoding shows different area

/on_select

• prices in F&B are tax exclusive, separate line item is used to share the item level taxes; are all the line items handled as mentioned in the contract?

/init

• is the character validation of name + building + locality < 190 chars in place?

/on_init

• tax_number is incorrect; should be a valid GST number; BNP must respond with a NACK
• provider_tax_number should also be provided in tags/bpp_terms; BNP must respond with a NACK otherwise

/confirm

• is retry mechanism enabled?

Flow 4

/cancel

• descriptor should only be used for fulfillment level cancellation (in case of TAT breach);
• invalid fulfillment id in /descriptor/short_desc

/on_cancel

• cancelled items should be mapped to the newly created cancelled fulfillment
• item/fulfillment ids are invalid in quote_trail; also, id field is missing for delivery charge quote_trail
• multiple issues; BNP must respond with a NACK

Flow 5

• similar issues as in Flow 4

Flow 6

• similar issues as above

@rudra-cruv

[rudra-cruv]

Flow 1

1. We take the 0th index customization as the default one if config.min = 1 and no default customization is provided.
2. We calculate the default selection price dynamically during runtime based on the selection.

Flow 2

1. Yes the mapping is correct, the area has overlapping area codes. Hence, can be different on different systems.
2. The item price, taxes and charges are calculated separately at item level as well as at the cart level and displayed to the user. And are according the contract.
3. Yes, the validation of name + building + locality < 190 chars is in place.
4. The flows are simulated using a mock store on the ondc ref seller app, the tax number is only for testing purposes, and will be nacked if incorrect.
5. ondc ref seller app is does not have the functionality to add provider tax number.
6. Yes, Retry mechanism is enabled.

Flow 4

1. Cancelled items have been mapped to a new fulfillment id "9b2bc588-7bc1-4d0e-bb76-1c8f5640e484", the original fulfillment id was "76305f82-bb81-48f0-899b-3b3ef70dfe68"

@sandeepshahi

[rudra-cruv]

@sandeepshahi

Are these all the errors that needs to be fixed?, if there are more please inform us, So that we can fix them in the next PR. We want to close this as soon as possible.

[sanidhyaagrawal]

@sandeepshahi @Jagannath-wits bumping this.

[sandeepshahi]

@rudra-cruv, those were the comprehensive list of all the errors. Please refrain from manipulating the logs during resubmission and get the issues fixed at your end.

Please answer the following queries:

• is push based incremental refresh supported?
• are you using the timestamp at provider / item level for correct versioning while processing the catalogs (full/incremental) concurrently
• is /select being called for every change in cart, with the same transaction_id?
• while processing unsolicited callbacks, are you ensuring that each such callback response has a unique message_id for a specific transaction_id?
• is retry mechanism enabled for confirm/on_confirm flow as mentioned in the doc?
• are the cancellation reason codes received from SNP being validated?

Also, please share a demo of the app with the complete order flow.

[Jagannath-wits]

@rudra-cruv, those were the comprehensive list of all the errors. Please refrain from manipulating the logs during resubmission and get the issues fixed at your end.

Please answer the following queries:

• is push based incremental refresh supported?
• are you using the timestamp at provider / item level for correct versioning while processing the catalogs (full/incremental) concurrently
• is /select being called for every change in cart, with the same transaction_id?
• while processing unsolicited callbacks, are you ensuring that each such callback response has a unique message_id for a specific transaction_id?
• is retry mechanism enabled for confirm/on_confirm flow as mentioned in the doc?
• are the cancellation reason codes received from SNP being validated?

Also, please share a demo of the app with the complete order flow.

Flow 1

search_inc_refresh

• "contextCityError": context/city should be "*" while sending search_inc_catalog request.

Flow 2

select

• "location_id[0]": location_id should be the same for the item AQM_Item_Tea_1 as in on_search.
• "location_id[1]": location_id should be the same for the item AQM_Item_Bread_1 as in on_search.
• "prvdLoc": provider.locations[0].id AQM-BPP-PROVIDER-1-LOCATION-1 mismatches in /on_search and /select.

confirm

• "message.order.tags[0].list": Number of digits in tax number in message.order.tags[0].list should be 15 and not a placeholder.

Note :

"contextCityError": context/city should be "*" while sending search_inc_catalog request.

• This error was raiser earlier as well why is it still there ?
• Buyer app should send Nack when incorrect values are sent in on_action
• Also please respond to the previosuly asked questions

@rudra-cruv

[rudra-cruv]

@sandeepshahi @Jagannath-wits

@rudra-cruv, those were the comprehensive list of all the errors. Please refrain from manipulating the logs during resubmission and get the issues fixed at your end.

Please answer the following queries:

• is push based incremental refresh supported?
• are you using the timestamp at provider / item level for correct versioning while processing the catalogs (full/incremental) concurrently
• is /select being called for every change in cart, with the same transaction_id?
• while processing unsolicited callbacks, are you ensuring that each such callback response has a unique message_id for a specific transaction_id?
• is retry mechanism enabled for confirm/on_confirm flow as mentioned in the doc?
• are the cancellation reason codes received from SNP being validated?

Also, please share a demo of the app with the complete order flow.

• is push based incremental refresh supported? Ans - Yes, push based incremental refresh supported.

• are you using the timestamp at provider / item level for correct versioning while processing the catalogs (full/incremental) concurrently Ans - Yes, We save the provider level and item level information by comparing the timestamps in the catalog and on our end, to ensure the correct version is displayed to the user.

• is /select being called for every change in cart, with the same transaction_id? Ans - Yes, same transaction id is used for all the select calls for any cart changes within a single restaurant. The transaction id is changed if the user either completes the order or switches to a different restaurant as the current cart is dropped.

• while processing unsolicited callbacks, are you ensuring that each such callback response has a unique message_id for a specific transaction_id? Ans - Yes, we nack any duplicate messages on (transaction_id, message_id) with error code: 21001

• is retry mechanism enabled for confirm/on_confirm flow as mentioned in the doc? Ans - Yes, we re-try 3 times to /confirm the order before marking the order failed and issue refunds.

• are the cancellation reason codes received from SNP being validated? Ans - Yes, we check for inapplicable cancellation reason codes.

• Download link to the app - https://play.google.com/store/apps/details?id=dev.cruv.craver

[rudra-cruv]

@Jagannath-wits

@rudra-cruv, those were the comprehensive list of all the errors. Please refrain from manipulating the logs during resubmission and get the issues fixed at your end. Please answer the following queries:

• is push based incremental refresh supported?
• are you using the timestamp at provider / item level for correct versioning while processing the catalogs (full/incremental) concurrently
• is /select being called for every change in cart, with the same transaction_id?
• while processing unsolicited callbacks, are you ensuring that each such callback response has a unique message_id for a specific transaction_id?
• is retry mechanism enabled for confirm/on_confirm flow as mentioned in the doc?
• are the cancellation reason codes received from SNP being validated?

Also, please share a demo of the app with the complete order flow.

Flow 1

search_inc_refresh

• "contextCityError": context/city should be "*" while sending search_inc_catalog request.

Flow 2

select

• "location_id[0]": location_id should be the same for the item AQM_Item_Tea_1 as in on_search.
• "location_id[1]": location_id should be the same for the item AQM_Item_Bread_1 as in on_search.
• "prvdLoc": provider.locations[0].id AQM-BPP-PROVIDER-1-LOCATION-1 mismatches in /on_search and /select.

confirm

• "message.order.tags[0].list": Number of digits in tax number in message.order.tags[0].list should be 15 and not a placeholder.

Note :

"contextCityError": context/city should be "*" while sending search_inc_catalog request.

• This error was raiser earlier as well why is it still there ?
• Buyer app should send Nack when incorrect values are sent in on_action
• Also please respond to the previosuly asked questions

@rudra-cruv

• The issue context/city not being is because the AQM Test Runner asks for calling search incremental specifically on Delhi. We do support the in city.

• Flow-2 Issue:

  • select - We checked the payloads the location ids in select are matching with the location id in on_search
  • confirm - Will be Fixed.

[sandeepshahi]

Download link to the app - https://play.google.com/store/apps/details?id=dev.cruv.craver

@rudra-cruv, Please share the demo video instead of the app link. Also, why has the app been deployed without ONDC production keys?

[sanidhyaagrawal]

We had to placed the app in public beta mode for payment gateway verification. Currently, it is only being used internally by our testers, and we are not promoting it publicly, we can move it back to internal beta if needed.

Please find the demo video in the link below, in the video I have placed an order with customisations and cancelled it. Let me know if you want us to share videos for any other flows.

https://drive.google.com/file/d/1q278M5UGa3n4BvQOUHysEHwFUGTuC3or/view?usp=sharing

[rudra-cruv]

@sandeepshahi @Jagannath-wits What is the tax_number in message.order.tags[0]? We have tried our 15 digits GST number, 10 digits PAN and 10 digits TAN on the log validation utility but none is fixing the issue.