sahil-ondc commented 11 months ago

Flow 1

search_inc_refresh

incorrect json

on_search_full_catalog_refresh

/message/catalog/bpp~1providers/0/items/9/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)
category in serviceability construct should be one of the category ids bpp/providers[0]/items/category_id
value should be a valid range of pincodes (code:"val") for type 11 (intercity) in /bpp/providers[0]/tags[0]

Flow 2

on_init

/message/order/billing must have required property 'tax_number'

confirm

/message/order/payment must have required property '@ondc/org/settlement_basis'
/message/order/payment must have required property '@ondc/org/settlement_window'
/message/order/payment must have required property '@ondc/org/withholding_amount'

on_confirm

store name /fulfillments[0]/start/location/descriptor/name can't change from 'on_search'
payment object mismatches in /confirm & /on_confirm

Common

/message/order/billing/address must have required property 'building'
/message/order/fulfillments/0/end/location/address must have required property 'building'

@ShippuYadav

ShippuYadav commented 11 months ago

value should be a valid range of pincodes (code:"val") for type 11 (intercity) in /bpp/providers[0]/tags[0] Can you please explain where the issue is? */message/order/billing must have required property 'tax_number' Its optional and should be coming from buyer app

*store name /fulfillments[0]/start/location/descriptor/name can't change from 'on_search' It seems to be same

Please check this meanwhile Working on the rest of the mention point. @sharmasahil0331 Please check

ShippuYadav commented 11 months ago

@sharmasahil0331 Please check latest PR https://github.com/ONDC-Official/v1.2.0-logs/pull/55

sahil-ondc commented 11 months ago

on_search (full catalog refresh)

reverse geocoding of /message/catalog/bpp/providers/locations/gps is different from address/area_code

search (inc catalog refresh)

city must be "*" in incremental pull

on_search (inc catalog refresh)

/on_search/context/timestamp cannot be less than search/context/timestamp
/message/catalog/bpp/providers/items should be sent only in case of any updates

on_confirm

/message/order/fulfillments/0/tracking must be boolean

on_status

/message/order/fulfillments/0 must have required property '@ondc/org/TAT'
/message/order/fulfillments/0/end/time should have 'timestamp' only if state is 'Order-delivered'
/message/order/payment/@ondc/org/settlement_details/0 must have required property 'settlement_timestamp'

common

/message/order/payment must have required property '@ondc/org/settlement_basis'
/message/order/payment must have required property '@ondc/org/settlement_window'
/message/order/payment must have required property '@ondc/org/withholding_amount'

@ShippuYadav

ShippuYadav commented 11 months ago

Please check latest PR https://github.com/ONDC-Official/v1.2.0-logs/pull/60 @sharmasahil0331

sahil-ondc commented 10 months ago

confirm

/message/order/payment must have required property '@ondc/org/settlement_basis'
/message/order/payment must have required property '@ondc/org/settlement_window'
/message/order/payment must have required property '@ondc/org/withholding_amount'

on_confirm

payment object mismatches in /confirm & /on_confirm

common

value of address.name, address.building and address.locality should be unique
/message/order/fulfillments/0 must have required property 'tracking'

@ShippuYadav

ShippuYadav commented 10 months ago

Please check latest PR https://github.com/ONDC-Official/v1.2.0-logs/pull/64 @sharmasahil0331

sahil-ondc commented 10 months ago

on_search_full_catalog

locality and street cannot be same in /message/catalog/bpp_providers/locations/address

search_inc_catalog

/message/catalog should not contain fulfillment object

on_confirm

value of tax_number in message/order/tags/code/bap_terms should be same as the value passed in confirm call

@ShippuYadav

ShippuYadav commented 10 months ago

@sharmasahil0331 /message/catalog should not contain fulfillment object - I have not send fulfillment object inside inc search, Please clear this point. @sharmasahil0331 Please review this latest PR https://github.com/ONDC-Official/v1.2.0-logs/pull/74

ShippuYadav commented 10 months ago

@sharmasahil0331 Please check latest https://github.com/ONDC-Official/v1.2.0-logs/pull/86

ensservices commented 10 months ago

@bluecypher Please check

sahil-ondc commented 10 months ago

on_search_inc_refresh

/context/bpp_uri must match format url, it must includes https or www
Message Id for /search_inc_refresh and /on_search_inc_refresh api should be same

@ShippuYadav

ShippuYadav commented 10 months ago

@bluecypher Please check this PR https://github.com/ONDC-Official/v1.2.0-logs/pull/98 @sharmasahil0331

sandeepshahi commented 10 months ago

/on_search

pincode related serviceability is currently not supported by the buyer apps; use either of hyperlocal or PAN India

/on_search (incremental)

callback response should not take longer

/on_confirm

estimated pickup and delivery time ranges can't be the same

/on_status (Accepted)

order/updated_at should be updated as per the context/timestamp

/on_status (Order-picked-up)

order/updated_at can't be earlier than pickup timestamp (/fulfillments/start/time/timestamp)

/on_status (Order-delivered)

order/updated_at can't be earlier than delivery timestamp (/fulfillments/end/time/timestamp)

Flow 3

Not as per the test case scenario

@ShippuYadav

ShippuYadav commented 10 months ago

@sharmasahil0331 @bluecypher Please check https://github.com/ONDC-Official/v1.2.0-logs/pull/117

sandeepshahi commented 10 months ago

- variant groups/variants should be provided for validation

- Flow 4/5 in Group B should be submitted for validation

/on_search

item.available.count should be either 99 (inventory available) or 0 (out-of-stock)
item.maximum.count should be either default value 99 (no cap per order) or any other +ve value (cap per order)

/init & /on_init

lat/lng are invalid attributes in /billing and /fulfillments

/on_confirm

discrepancy in the estimated time ranges; delivery time can't be before pickup time

/on_status (picked)

invalid attribute "document"; should be "documents"

@ShippuYadav

ShippuYadav commented 10 months ago

I have fixed all the issue mentioned above @sharmasahil0331 @bluecypher Please find latest PR https://github.com/ONDC-Official/v1.2.0-logs/pull/144

sahil-ondc commented 9 months ago

/init & /on_init

lat/lng are invalid attributes in /billing

@ShippuYadav

sahil-ondc commented 9 months ago

@ShippuYadav As this is buyer application issue, so we can ignore this issue

BLR-0118 commented 9 months ago

Flow 1

/on_search (full):
- remove formatting from item short_desc/long_desc;
- unitized measure doesn't match product - does Axe sell in 3 kg packs?
- as per the enhanced category list here, this item should be in BPC instead of grocery;
/on_search (incremental):
- how can MRP of existing product change?

Flow 2

/on_select:
- unit price of 44790346678572 was 250 in full catalog pull, but showing as 299 here; there's no incremental catalog update with this change;

Flow 3

/on_select_out_of_stock:
- item.quantity.maximum.count should be 99 (default) if there's no cap per order or the cap per order; if item is out-of-stock, this can't change;

Flow 4 & 5

Cancel with reason code 012 & 014 trigger RTO; /on_cancel response is not valid (pls check the flow from here);

BLR-0118 commented 9 months ago

@ShippuYadav

BLR-0118 commented 9 months ago

Also, request you to pls fix error.message in flow 3 (on_select_out_of_stock) to send message as per the new format in the contract;

BLR-0118 commented 9 months ago

@NJ-Nitank

NJ-Nitank commented 9 months ago

@BLR-0118, Submitted updated logs for Ushop, https://github.com/ONDC-Official/v1.2.0-logs/pull/248

BLR-0118 commented 9 months ago

Flow 1:

/on_search:
- formatting is not removed - html tags replaced by bullet points; Flow 3:
/on_select_out_of_stock:
- error.message not correct - check here & contract doc on how it should be encoded; Flow 4 & 5:
- cancel & RTO flows are incorrect as it doesn't maintain the audit trail as per contract - check the contract doc on how the forward shipment fulfillment is cancelled & item qty count assigned to it becomes 0 & how a separate fulfillment of type "Cancel" is created to which items in forward shipment fulfillment is assigned;

BLR-0118 commented 9 months ago

@NJ-Nitank

NJ-Nitank commented 9 months ago

@BLR-0118 Sir, Here are the updated logs, Please review this PR https://github.com/ONDC-Official/v1.2.0-logs/pull/309

BLR-0118 commented 8 months ago

/on_cancel flow is wrong for flow 4 but is correct for flow 5; pls fix flow 4 to show correct payload (multiple quote_trail objects within same fulfillment instead of creating 2 separate fulfillments with same id);
for /on_select & /on_init, can you add provider.locations to Order (similar to what's in /on_confirm);
remove order.provider_location; also resubmit logs only for the above;

BLR-0118 commented 8 months ago

@NJ-Nitank

NJ-Nitank commented 8 months ago

Hello Sir @BLR-0118, As per the feedback, we have changed in payload.Please review this PR https://github.com/ONDC-Official/v1.2.0-logs/pull/356

BLR-0118 commented 8 months ago

logs cleared for v1.2.0 for grocery (RET10)

BLR-0118 commented 8 months ago

@NJ-Nitank

NJ-Nitank commented 8 months ago

@BLR-0118 Sir, Do we need to do it for fashion & BPC.

BLR-0118 commented 8 months ago

yes, you need to submit logs for /search & /on_search for these categories

NJ-Nitank commented 8 months ago

@BLR-0118 Sir, Please review this PR for Fashion & BPC Category. https://github.com/ONDC-Official/v1.2.0-logs/pull/402

ONDC-Official / v1.2.0-logs

ENS (Ushop) - Grocery: compliance check #53

Flow 1

Flow 2

Common

Flow 3

- variant groups/variants should be provided for validation

- Flow 4/5 in Group B should be submitted for validation

Flow 1

Flow 2

Flow 3

Flow 4 & 5