CSC - compliance check

[sahil-ondc]

search (inc_catalog)

• /message/intent/tags/list/end_time/value cannot be greater than /context/timestamp

on_search (full_catalog_refresh)

• Timestamp for search api cannot be equal to on_search api
• /message/catalog/bpp~1providers/0/locations/0/time must have required property 'label'
• message/catalog/bpp~1providers/0/locations/0/time must have required property 'timestamp'
• /message/catalog/bpp~1providers/0/locations/0/time/schedule/holidays/0 must match format 'date'
• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
• @ondc/org/contact_details_consumer_care should be in the format 'name,email,contactno' in /bpp/providers[0]/items
• serviceability construct /bpp/providers[0]/tags[0] should be defined as per the API contract (location is missing)
• category in serviceability construct should be one of the category ids bpp/providers[0]/items/category_id
• serviceability construct /bpp/providers[0]/tags[3] should be defined as per the API contract (type is missing)

on_select

• Timestamp for /select api cannot be equal to /on_select api
• quote.price.value 1264.40 does not match with the price breakup 1214.40

on_init

• /message/order/payment/@ondc~1org~1buyer_app_finder_fee_amount must be string
• Timestamp for init api cannot be equal to on_init api
• Quoted Price 1264.4 does not match with Net Breakup Price 1214.4 in /on_init
• Discrepancies between the quote object in /on_select and /on_init

confirm

• payment settlement_details mismatch in /on_init & /confirm
• Discrepancies between the quote object in /on_select and /confirm

on_confirm

• /message/order/fulfillments/0 must have required property 'state'
• /message/order/fulfillments/0/start must have required property 'time'
• /message/order/fulfillments/0/start/contact must have required property 'phone'
• /message/order/fulfillments/0/end must have required property 'time'
• /message/order/quote/breakup/2 must have required property '@ondc/org/item_id'
• /message/order/quote/breakup/3 must have required property '@ondc/org/item_id'
• Timestamp for /confirm api cannot be equal to /on_confirm api
• Discrepancies between the quote object /on_select and /on_confirm

on_status

• /message/order/payment/@ondc~1org~1settlement_details/0 must have required property 'settlement_timestamp'
• /message/order/fulfillments/0/end must have required property 'time'
• /message/order/fulfillments/0/start/contact must have required property 'phone'
• /message/order/fulfillments/0/start must have required property 'time'

common

• /message/order/quote/breakup/2/price/value must be string
• /message/order/quote must have required property 'ttl'

@Ashish0120

[insphere-ashish]

We have made the required changes and shall upload the logs as soon an possible

Please do provide further info on the points below :-

• Discrepancies between the quote object in /on_select and /on_init

• Discrepancies between the quote object in /on_select and /confirm

• serviceability construct /bpp/providers[0]/tags[0] should be defined as per the API contract (location is missing)

• serviceability construct /bpp/providers[0]/tags[3] should be defined as per the API contract (type is missing)

serviceability construct present in tags have both location and type, please elaborate on what is the issue in that as, for the category id issue in serviceability we have made the required changes for that

---

And for these two points in /on_confirm , the doc showed it to be optional

• /message/order/fulfillments/0/start must have required property 'time'
• /message/order/fulfillments/0/end must have required property 'time'

@sharmasahil0331

[sahil-ondc]

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/locations/time must have required property 'label'
• /message/catalog/bpp/providers/locations/time/schedule must have required property 'holidays'
• /message/catalog/bpp/providers/items must have required property '@ondc/org/time_to_ship'
• /message/catalog/bpp/providers/items/@ondc/org/statutory_reqs_prepackaged_food must have required property 'brand_owner_FSSAI_license_no'

search_inc_refresh

• Transaction logs for seaarch_inc_refresh not submitted

on_search_inc_refresh

• Transaction logs for seaarch_inc_refresh not submitted

on_init

• /message/order must have required property 'tags'

on_confirm

• message/order/fulfillments/start must have required property 'time'
• /message/order/fulfillments/start/contact/phone must NOT have more than 11 characters
• /message/order/fulfillments/end must have required property 'time'
• order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
• store name /fulfillments[0]/start/location/descriptor/name can't change

on_status

• /message/order/fulfillments must have required property '@ondc/org/TAT'
• /message/order/fulfillments/start/time must have required property 'range'
• /message/order/fulfillments/end/time must have required property 'range'
• delivery timestamp should match context/timestamp and can't be future dated

common

• Timestamp for /on_action api cannot be greater than or equal to /action api
• /message/order/payment must have required property '@ondc/org/settlement_basis'
• /message/order/payment must have required property '@ondc/org/settlement_window'
• /message/order/payment must have required property '@ondc/org/withholding_amount'

@Ashish0120

[sahil-ondc]

Group A

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/locations/time/schedule must have required property 'holidays'
• /message/catalog/bpp/providers/items must have required property '@ondc/org/time_to_ship'
• /message/catalog/bpp/providers/items/quantity/available/count must be equal to one of the allowed values (99,0)
• invalid context/city as per the GPS coordinates provided

search_inc_refresh

• search_inc_refresh transaction logs not submitted

on_search_inc_refresh

• on_search_inc_refresh transaction logs not submitted

on_init

• Timestamp for init api cannot be greater than or equal to on_init api

confirm

• /message/order/tags/0/list/0 must have required property 'value'

on_confirm

• Timestamp for /confirm api cannot be greater than or equal to /on_confirm api
• store name /fulfillments/start/location/descriptor/name can't change

@insphere-ashish

[insphere-ashish]

@sharmasahil0331 Group A changes has been added in the new PR https://github.com/ONDC-Official/v1.2.0-logs/pull/166 Please consider the Incremental logs generated with preprod.ondc.adya.ai for all Groups, increment changes can be reflected in there Also Changes from Group A feedback also updated on respective Group B flows

[sahil-ondc]

Group A

on_search_full_catalog_refresh

• /message/catalog/bpp/providers/0/items/3/@ondc/org/statutory_reqs_prepackaged_food must have required property 'brand_owner_FSSAI_license_no'
• /message/catalog/bpp/providers/0/items/3/@ondc/org/statutory_reqs_prepackaged_food must have required property 'other_FSSAI_license_no'
• /message/catalog/bpp/providers/0/items/3/@ondc/org/statutory_reqs_prepackaged_food must have required property 'importer_FSSAI_license_no'
• /message/catalog/bpp/providers/1/items/0/quantity/available/count must be equal to one of the allowed values (99,0)
• duplicate category id: 199 in bpp/providers[1]
• value passed in serviceability tags should be same as passed in location/circle

search_inc_refresh

• Transaction logs should be submitted in the PR

on_search_inc_refresh

• Transaction logs should be submitted in the PR

select

• Timestamp for /on_search api cannot be greater than or equal to /select api

on_init

• /message/order must have required property 'tags'

confirm

• /message/order/tags/0/list/0 must have required property 'value'

on_status

• /message/order/fulfillments/0/start must have required property 'time'
• /message/order/fulfillments/0/end must have required property 'time'

@insphere-ashish

[insphere-ashish]

@sharmasahil0331 Group A logs submitted in PR

[sandeepshahi]

Catalogs of all the subscribed domains should be provided for verification

Flow 1

/search (incremental)

• context/city should be "*"

/on_search

• gps and area_code mismatch for store's location in /bpp/providers/locations
• fulfillment id in bpp/fulfillments/id and bpp/providers/fulfillments/id should be the same
• invalid unit and value in /quantity/unitized/measure; should be unit= "unit" and value = "1"; uom enums are defined here
• only a single variant is defined for the respective variant groups (provider id: "45"); multiple variants should be provided for verification
• infeasible radius of 7000 km for hyperlocal serviceability; use PAN India serviceability instead

Flow 2

/on_confirm

• invalid location id in /fulfillments/start/location (store location)
• "bap_terms" (tax_number) is missing in /on_confirm and subsequent calls

/on_status

• actual pickup (/fulfillments/start/time/timestamp) and delivery (/fulfillments/end/time/timestamp) timestamp should only be provided at relevant states
• settlement_timestamp in "@ondc/org/settlement_details" should only be provided when the payment has been settled by the collector; should not be provided otherwise
• invoice in /documents should only be provided in Order-picked-up state and thereafter

Flow 3

/on_select (OOS)

• count of item: 1495 in /"@ondc/org/item_quantity" should be 5; since available count="5"

Flow 4

/cancel

• "012" is not a valid cancellation_reason_id initiated by BNP; SNP should respond with a NACK

/on_cancel

• count in @ondc/org/item_quantity will become 0 in case of cancellation

Flow 5

/on_cancel (RTO)

• RTO can't be initated in "Created" state
• items can't be empty
• pickup time range and actual pickup timestamp are missing for fulfillment "db7c5bef-bfd8-410a-a68e-8b153b75173b"
• invalid schema: "@ondc/org/item_quantity" should be an object with count property
• quote/price/value should be = sum of quote/breakup/price

@insphere-ashish

[sahil-ondc]

Group A

Flow 1

on_search_full_catalog_refresh

• invalid area_code as per gps provided in /message/catalog/bpp/providers/locations
• invalid context/city as per area_code provided in /message/catalog/bpp/providers/locations/address
• remove formatting form /message/catalog/bpp/providers/items/descriptor
• unit should be one of '["unit","dozen","gram","kilogram","tonne","litre","millilitre"]' provided in /message/catalog/bpp/providers/items/quantity/unitized/measure

search_inc_refresh

• context/city should be '*' while sending search_inc_catalog request

on_search_inc_catalog_refresh

• remove formatting form /message/catalog/bpp/providers/items/descriptor

Flow 2

on_select

• keys should be provided as per the api contract in /message/order/quote/breakup
• /message/order/tags must be array

on_confirm

• invalid context/city as per area_code provided in /message/order/fulfillment/end/location/address

@insphere-ashish

[sahil-ondc]

Entirely new Transaction logs should be submitted for any iteration of verification. (Group B)

@insphere-ashish

[insphere-ashish]

Group A

Flow 1

on_search_full_catalog_refresh

• invalid area_code as per gps provided in /message/catalog/bpp/providers/locations
• invalid context/city as per area_code provided in /message/catalog/bpp/providers/locations/address
• remove formatting form /message/catalog/bpp/providers/items/descriptor
• unit should be one of '["unit","dozen","gram","kilogram","tonne","litre","millilitre"]' provided in /message/catalog/bpp/providers/items/quantity/unitized/measure

search_inc_refresh

• context/city should be '*' while sending search_inc_catalog request

on_search_inc_catalog_refresh

• remove formatting form /message/catalog/bpp/providers/items/descriptor

Flow 2

on_select

• keys should be provided as per the api contract in /message/order/quote/breakup
• /message/order/tags must be array

on_confirm

• invalid context/city as per area_code provided in /message/order/fulfillment/end/location/address

@insphere-ashish

@bluecypher @sahil-ondc please do check the Group B flows too so if any issue found we can work on that too before next submission. Changes have been made as per the last feedback of Group B flows ( 1-5 ) in Group B flows.

on_search_full_catalog was updated and the changes were made a bit later and thus was edited to show its current state.. shall upload new as request but do please check the other Group B Flows so we can rectify the issues in both Group A and Group B together

---

[sandeepshahi]

Submit logs for only Group C (Group A and B need not be submitted separately)

Flow 1

/on_search

• unitized measure of item is not in sync with the description provided; eg: for item: 1583, unitized measure is set as 10 dozen whereas only 1 pc is mentioned in the description; check for other SKUs
• inaccurate mapping of gps and area_code in /bpp/providers/locations; check location id: Storeking-store-location-id-35

/on_search (incremental)

• No incremental delta changes

Flow 2

/on_select

• callback response should not take longer

/on_init

• provider_location attribute is not required

/on_confirm

• order/updated_at should be updated wrt change in the order
• @ondc/org/TAT is missing in /fulfillments

/on_status

• estimated pickup and delivery time ranges can't be the same
• @ondc/org/TAT in /fulfillments mismtaches with the TAT provided in /on_select
• invoice in /documents should only be provided in Order-picked-up state and thereafter

Flow 3

/on_select (OOS)

• error/message must be in the correct stringified object format as mentioned in the contract

Flow 4

/on_cancel

• context/timestamp can't be earlier than /cancel timestamp
• cancellation flow should be as per the contract here; a new cancellation related fulfillment should be created and all the items should be assigned to that fulfillment

Flow 5

/on_cancel

• actual pickup timestamp is missing in /fulfillments/start/time/timestamp
• quote/breakup/price/value should be in string format
• quote/price/value should be = sum of (quote/breakup/price/value)

/on_status

• either one of RTO-Delivered or RTO-Disposed call must be submitted for verification

@insphere-ashish

[sandeepshahi]

Flow 1

/on_search

• invalid value of available/maximum count for items of provider id=35; pls check previously raised issues for clarification
• holidays should be future dated

/on_search (incremental)

• only incremental delta changes should be provided; bpp/providers/categories is not required

Flow 2

/on_select

• available/maximum count issue in quote/breakup; logic remains the same as provided in the catalog

/on_init

• check previously raised issues; /provider_location is not required

/on_confirm

• check previously raised issues; order/updated_at should be updated wrt change in the order

/on_status

• pickup time range can't be past dated
• check previously raised issues; settlement_timestamp should not be provided unless settled by the collector

Flow 3, 4, 5

• check previously identified issues

@insphere-ashish

[sandeepshahi]

- /on_action callback responses should not take too long to be responded

/on_search

• Egg can't be categorized as veg; code should be non_veg instead
• placeholder values should not be provided in the catalog; check short_desc, long_desc, incorrectly mapped item images, fields in statutory reqs, back_image, mapping of category_id with item; eg: item id- 1580

/on_confirm

• quote/ttl should not change; remains the same as in /on_select

/on_status

• invoice link is not accessible

Flow 3

/on_select (OOS)

• available count in the quote should be updated as per the availability; cant' be 0 when @ondc/org/item_quantity/count = 3 and maximum count can't be 0 either
• invalid stringified object notation, can't be parsed; attributes and values should be enclosed in quotes: "[{'item_id':'1495','error':'40002'}]"

Flow 4

/on_cancel

• pre_cancel state should be provided in /fulfillments/tags for forward shipment fulfillment
• why is delivery charges and convenience fee included in the quote when order is cancelled before shipment

Flow 5

/on_status (RTO-Delivered)

• timestamp missing in /fulfillments/start/time
• time range in /fulfillments/end/ can't have null values; values should not change

@insphere-ashish

[insphere-ashish]

@bluecypher Could you please explain these a bit further ..

• /on_action callback responses should not take too long to be responded [ ==> you mean the init/on_init timestamp lag only ? Or some other too ? Please specify so we can look into it ]

---

[sandeepshahi]

- Please remove the old logs folder and provide only the most recent updated logs

/on_search

• "accept_bap_terms" tags block should be removed; static terms are not a part of phase 1;
• egg is not a valid "veg_nonveg" categorization for RET10; code should be "non_veg" instead

FLow 3

/on_select (OOS)

• count in /"@ondc/org/item_quantity" should be in integer format
• pls use escaped double quotes in error.message instead of single quotes as updated in contract;

Flow 4

/on_cancel

• All the adjusted quote line items must be included in the quote_trail (which includes delivery and convenience fees)

@insphere-ashish

[sahil-ondc]

RET 13

Flow 1

search

• context.domain should be 'RET:13'

on_search_full_catalog

• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
• /message/catalog/bpp/providers/items/tags should have mandatory attributes

search_inc_refresh

• ttl = PT30S as per the API Contract
• /message/intent/tags/list/end_time/value cannot be greater than /context/timestamp

RET 16

Flow 1

on_search_full_catalog

• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
• /message/catalog/bpp/providers/items/tags should have mandatory attributes

search_inc_refresh

• ttl = PT30S as per the API Contract
• /message/intent/tags/list/end_time/value cannot be greater than /context/timestamp

@insphere-ashish

[insphere-ashish]

RET 13

Flow 1

search

• context.domain should be 'RET:13'

on_search_full_catalog

• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
• /message/catalog/bpp/providers/items/tags should have mandatory attributes

search_inc_refresh

• ttl = PT30S as per the API Contract
• /message/intent/tags/list/end_time/value cannot be greater than /context/timestamp

RET 16

Flow 1

on_search_full_catalog

• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time
• /message/catalog/bpp/providers/items/tags should have mandatory attributes

search_inc_refresh

• ttl = PT30S as per the API Contract
• /message/intent/tags/list/end_time/value cannot be greater than /context/timestamp

@insphere-ashish

On feedback issues

• On fixed & split range timing - While doing V2 Seller QA testing, was asked by the QA team to show both

The other issues are fixed and a https://github.com/ONDC-Official/v1.2.0-logs/pull/1061 has been raised with changes .

[sandeepshahi]

RET 16

• item attributes must be defined inside "attribute" code; check contract for the schema
• invalid attribute color; should be "colour" instead; check enhanced subcategory list

RET 13

• unitized measure is not defined correctly; item description shows different value; eg: for item: "1590", unit measure is set as 250 gm whereas item description shows 100ml
• • item attributes must be defined inside "attribute" code; check contract for the schema
• Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers[0]/locations[0]/time; both need not be provided

@insphere-ashish

[sandeepshahi]

@insphere-ashish, hex code must be provided in “colour” attribute.

[insphere-ashish]

@sandeepshahi Fixes have been pushed, please review the updated logs in the PR

[sandeepshahi]

RET 13 & 16

• why are variant groups created for SKUs with no variants?

RET 16

• invalid attribute used for variant grouping; items such as wall clocks will consistently have a unit measure of 1 for all variants, should be based on size or other attributes as mentioned in the sheet here

@insphere-ashish

[sandeepshahi]

RET 13 & 16

/on_search

• please add item/descriptor/code; mandatory attribute (applicable for RET10 domain too)
• some of the items' images are not loading
• quantity in description is not matching with the mentioned quantity in quantity/unitized/measure
• locations/timestamp is not a valid attribute; captured in /locations/time

/on_search (inc)

• is incremental push supported? (mode = start)

RET 16

• incorrect attribute "color"; should be "colour" instead, as previously mentioned

@insphere-ashish

[insphere-ashish]

RET 13 & 16

/on_search

• please add item/descriptor/code; mandatory attribute (applicable for RET10 domain too)
• some of the items' images are not loading
• quantity in description is not matching with the mentioned quantity in quantity/unitized/measure
• locations/timestamp is not a valid attribute; captured in /locations/time

/on_search (inc)

• is incremental push supported? (mode = start)

RET 16

• incorrect attribute "color"; should be "colour" instead, as previously mentioned

@insphere-ashish

@sandeepshahi in regards to the feedback on the logs

for RET 13 & 16

• item/descriptor/code shows optional for both BPC , Home & Kitchen in the Doc
• items images were not loading due to changes in CDN on the server after logs build
• description is just text data and has no logical connection to quantity/unitized/measure linked to the item and as it is staging data the items and their variants created are just for testing purpose with dummy data
• (locations/timestamp is not a valid attribute; captured in /locations/time) - please elaborate this point on this point

/on_search (inc)

• is incremental push supported? (mode = start) - Yes, it is supported

RET 16

• items tags data got replaced with older data in db directly, due to which the tags was showing incorrect ( It was corrected for all other items, as can be seen in the other items and the last log)

[sandeepshahi]

@insphere-ashish,

RET 13 and 16

• item.descriptor/code is now mandatory for all the domains.
• Please make sure the server works correctly
• Please submit the correct data and replicate the accuracy in prod as well
• timestamp is not a valid attribute in /locations; its actual path is /locations/time

For Incremental pull: please submit the logs for verification

For RET 16, Please submit the logs for verification

[insphere-ashish]

@sandeepshahi RET13 and RET16 logs have been uploaded, kindly review the logs in PR.

[sandeepshahi]

RET 16

• incorrect attribute "color"; should be "colour" instead, as previously mentioned
• item/descriptor/code should be one of the standard codes eg: EAN

@insphere-ashish