Shadowfax (LSP) - compliance check

[BLR-0118]

1. /on_search:

   • why aren't you sending avg pickup time, motorable distance (will be very useful for hyperlocal);

2. /on_init:

   • no distinct line item for tax in quote?

3. /on_confirm:

   • payment.collection_amount isn't valid key (@ondc/org/collection_amount is valid);

4. /on_update:

   • PCC sent in /update (fulfillment.start.instructions.short_desc) is missing;

5. /on_track:

   • /track is sent after order is delivered, so /on_track response is invalid;
   • location.time.timestamp identifies the gps coordinates as of that time & tracking.updated_at is when this is updated in system - by definition, updated_at >= timestamp;

6. flow 2 & 3

   • rto_event values are missing for RTO;
   • request to add precancel_state to fulfillment that's being cancelled;

[BLR-0118]

@mallikharjun-p

[BLR-0118]

1. there's an issue with quote title_type (the new values are "delivery", "tax" etc as doc here). This isn't correct in most APIs from /on_init onward;
2. /on_init shows quote breakup for delivery charge & tax but all post-confirm APIs like /on_status only show the delivery charge;

[BLR-0118]

@mallikharjun-p - request you to pls fix the above & resubmit only for forward flow;

[BLR-0118]

above issues fixed but new issues:

1. /on_status - pickup time (fulfillment.start.time.timestamp) & delivery time (fulfillment.end.time.timestamp) missing;
2. /on_track - timestamp format is invalid (millisec should be 3 digits only);
3. /update & /on_update APIs to be shared; @mallikharjun-p

[BLR-0118]

1. /on_status APIs:

   • fulfillment.start.instructions containing pickup code/dtls & fulfillment end.instructions having delivery code/dtls are not in the order object here, even though they're in the order object in /on_update;

2. /on_track:

   • location.time.timestamp shows the timestamp for gps coordinates; this shows date of 30th Jan for this order which was placed on 1st Feb (05:10:41) - this is incorrect

[BLR-0118]

@mallikharjun-p - pls fix the above & resubmit logs for issues above

[BLR-0118]

1. /on_search:
   • category_id uses pascal case; thus, "Next Day Delivery" is valid, not "NEXT DAY DELIVERY";

[BLR-0118]

@mallikharjun-p - logs cleared for v1.2.0; pls make sure the above issue is fixed;