sahil-ondc commented 8 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp/providers/items/@ondc/org/statutory_reqs_prepackaged_food must have required property of 'other_FSSAI_license_no', 'importer_FSSAI_license_no'
/message/catalog/bpp/providers/items/@ondc/org/statutory_reqs_packaged_commodities/manufacturer_or_packer_address needs to have at least 3 alphabets/characters
/message/catalog/bpp/providers/items/time/timestamp cannot be greater than or equal to context/timestamp.
/message/catalog/bpp/providers/items/ quantity/unitized/measure should be according to following values enum - "unit", "dozen", "kilogram", "tonne", "litre", "millilitre"

search_inc_refresh

/context/action must be equal to search
context/city should be "*" while sending search_inc_catalog request

Flow 2

on_init

provider_location is deprecated
message/order/cancellation_terms/cancellation_fee is not according to schema
message/order/cancellation_terms/ short_desc is null

On select

Quoted Price in /on_select INR 103 does not match with the total price of items in /select INR 99

sandeepshahi commented 7 months ago

@udyamwell1

udyamwell1 commented 7 months ago

Thank you for the review. Will resolve these issues.

udyamwell1 commented 7 months ago

We have updated the logs as per suggestions. Please review this PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/647

udyamwell1 commented 6 months ago

@sahil-ondc sir, are their any more changes required in our seller app logs

NishthaMonga commented 6 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp~1descriptor must have required property 'tags'
/message/catalog/bpp~1providers/0/items/0/category_id Invalid category ID found for item for on_search
item/descriptor/code should be in this format - \"type:code\" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
@ondc/org/contact_details_consumer_care contactno should consist of 10 or 11 digits without any spaces or special characters in /bpp/providers[0]/items
In ONDC:RET10 @ondc/org/statutory_reqs_prepackaged_food following fields are valid 'nutritional_info', 'additives_info', 'brand_owner_FSSAI_license_no','other_FSSAI_license_no','importer_FSSAI_license_no'

Flow 2

on_status_packed, on_status_out_for_delivery logs missing

on_confirm

mandatory fields like np_type,provider_tax_number,etc missing in message/order/tags/bpp_terms for ON_CONFIRM

Flow 3

on_select_out_of_stock

/message/order/quote/breakup/0/item/quantity/available/count must be string
/message/order/quote/breakup/0/item/quantity/maximum/count must be string
Item's unit and total price mismatch for id: 656cce3fba463fe1cb78dd04

Flow 4

on_cancel

/message/order must NOT have additional properties (tags)
/message/order/fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Cancelled,RTO-Initiated)
/message/order/fulfillments/0/start/contact/phone must NOT have more than 11 characters
/message/order/fulfillments/0/end must have required property 'time'
/message/order/quote/breakup/1/item must have required property 'price'
Item count should be 0 for /on_cancel in forward shipment
fulfillment type cancel is missing in /on_cancel
The count of cancellation fulfillmentsn is not equal to the count of forward fulfillments or invalid fulfillment id.
Cancel object is mandatory for on_cancel
Delivery state should be Cancelled for on_cancel
Pre Cancel is mandatory for on_cancel
Reason ID is mandatory field for on_cancel
Initiated_by is mandatory field for on_cancel

Flow 5

on_cancel

RTO Id is mandatory field for on_cancel

@udyamwell1

udyamwell1 commented 5 months ago

@sahil-ondc We have updated the logs as per your feedback. Please review it: https://github.com/ONDC-Official/v1.2.0-logs/pull/1440

Jagannath-wits commented 4 months ago

Flow 1

on_search_inc_refresh

city: context/city should be "*" in /on_search_inc_refresh

Flow 2

on_init

provider_tax_number: Invalid format for provider_tax_number in on_init
fulfillments[mp2_sdd_f1]: /message/order/fulfillment of type 'delivery' should not have tags
tags: 'provider_tax_number' should have a valid PAN number format

on_confirm

schemaErr0: /message/order/tags/1/list/0/value Value for tax_number must be a valid tax number i.e alphanumeric with 15 characters
provider_tax_number: provider_tax_number must be present for on_confirm
message/order/tags/bap_terms: bap_terms terms is not required for now! in on_confirm

on_status_pending

The routing tag is mandatory for fulfillment delivery in the on_status calls.
on_status_pending_msgId: Message id should not be same with previous calls
order_state: Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress

on_status_picked

schemaErr0: /message/order must have required property 'documents'
on_status_picked_msgId: Message id should not be same with previous calls

on_status_out_for_delivery

schemaErr0: /message/order must have required property 'documents'
on_status_out_for_delivery_msgId: Message id should not be same with previous calls
ordrState: order/state should be "In-progress" for /on_status_out-for-delivery
noOrdrOut_for_delivery: fulfillments/state Should be out-for-delivery for /on_status_Out-for-delivery

on_status_delivered

schemaErr0: /message/order must have required property 'documents'
schemaErr1: /message/order/fulfillments/0/end/time delivery time should not be present until order is delivered
txnId: Transaction Id should be same from /select onwards
onStatusOdrId: Order id in /confirm and /on_status_delivered do not match
tmpstmp1: Timestamp for /on_confirm api cannot be greater than or equal to /on_status_delivered api
tmpstmp: Created At timestamp for /on_status_delivered should be equal to context timestamp at confirm
ordrState: order/state should be "Completed" for /on_status_delivered
noOrdrDelivered: fulfillments/state should be Order-delivered for /on_status_Order-delivered

Flow 4

on_cancel

invldQuoteTrailPrices: quote_trail price and item quote price sum for on_cancel should be equal to the price as in on_confirm

Flow 5

on_cancel

on_cancel_msgId: Message id should not be same with previous calls
tmpstmp: Timestamp for /on_confirm api cannot be greater than or equal to /on_cancel api
RTOfulfillment.start: RTO fulfillment start object is missing in on_cancel
RTOfulfillment.end: RTO fulfillment end object is missing in on_cancel
RTO.start.location/DeliveryFulfillment.end.location: RTO fulfillment start or Delivery fulfillment end location is missing in on_cancel
RTO.end.location/DeliveryFulfillment.start.location: RTO fulfillment end or Delivery fulfillment start location is missing in on_cancel

Flow 6-b

on_update_interim

message/order/fulfillments/tags: on_update must have initiated_by code in fulfillments/tags/list

on_update_approval

schemaErr0: /message/order/fulfillments/1/start/location must have required property 'id'
on_update_approval_msgId: Message id should not be same with previous calls
context/timestamp: context/timestamp should be greater than message/order/updated_at timestamp
message/order/fulfillments/tags: on_update must have initiated_by code in fulfillments/tags/list

on_update_picked

schemaErr0: /message/order/fulfillments/1/start/location must have required property 'id'
schemaErr1: /message/order/payment/params must have required property 'transaction_id'
on_update_picked_msgId: Message id should not be same with previous calls
invldQuotePrices: Item quote breakup prices for /on_update should be equal to the net price.
context/timestamp: context/timestamp should be greater than message/order/updated_at timestamp
message/order/fulfillments/tags: on_update must have initiated_by code in fulfillments/tags/list

update_settlement missing

on_update_delivered

schemaErr0: /message/order/fulfillments/1/start/location must have required property 'id'
on_update_approval_msgId: Message id should not be same with previous calls
invldQuotePrices: Item quote breakup prices for /on_update should be equal to the net price.
context/timestamp: context/timestamp should be greater than message/order/updated_at timestamp
message/order/fulfillments/tags: on_update must have initiated_by code in fulfillments/tags/list

Flow 6-a(Part-cancel) Missing

@udyamwell1

udyamwell1 commented 4 months ago

We have updated logs as per the feedback and added the Missing part of Flow 6. Please review it. And let us know if any changes are required. https://github.com/ONDC-Official/v1.2.0-logs/pull/1559

@Jagannath-wits

Jagannath-wits commented 4 months ago

Flow 1

on_search_full_catalog_refresh:

prvdr0tags/serviceability: Serviceability construct is mandatory in /bpp/providers[0]/tags.
prvdr0tags/timing: Timing construct is mandatory in /bpp/providers[0]/tags. Why are the tags and categories empty in bpp/provider; make sure you provide support for varients as well as custom groups & menu please resubmit flow 1

@udyamwell1

udyamwell1 commented 4 months ago

Thanks for the review. Have you checked all the flows? Only flow 1 is required changes or other flows also? Please let us know

udyamwell1 commented 4 months ago

@Jagannath-wits

Jagannath-wits commented 4 months ago

Thanks for the review. Have you checked all the flows? Only flow 1 is required changes or other flows also? Please let us know

Yes did check other flows as well, but when resubmitting I'd suggest submitting other flows as well for review @udyamwell1

udyamwell1 commented 4 months ago

So, we need to update Flow 1 and resubmit it along with the other flows as they are without update? Am I correct?

@Jagannath-wits

Jagannath-wits commented 4 months ago

So, we need to update Flow 1 and resubmit it along with the other flows as they are without update? Am I correct?

Correct @udyamwell1 Please make sure the varients, custom_groups,etc are implemented

udyamwell1 commented 4 months ago

We have updated Flow-1 as per the feedback and re-uploaded all the logs. Please review: https://github.com/ONDC-Official/v1.2.0-logs/pull/1651

udyamwell1 commented 4 months ago

@Jagannath-wits

udyamwell1 commented 4 months ago

@Jagannath-wits Logs got merged. Please review it when you get the time.

Jagannath-wits commented 4 months ago

Udyamwell RET:10

Flow 1

On Search

bpp_provider/categories: In categories.descriptor.name please provide reasonable varient names and not placeholder names.
Every item has same EAN code i.e. "1:001234561". It can't be same.
Long and short description should not be the same
Image link is not accessible for the item_id : 6647addb438ef5dc40bac769 and for other item_ids as well. For e.g : https://seller.udyamwell.in/api/uploads/1715973409762-Screenshot

Inc Search

Is push based inc_search supported?

Flow 2

On Select

fulfillment0/@ondc/org/category: In Fulfillment0, @ondc/org/category is not a valid value in on_select and should have one of these values Immediate Delivery, Standard Delivery, Express Delivery.

On Status

The routing tag is mandatory for fulfillment delivery in the on_status calls.

Flow 3

On Select Out Of Stock

Same as above
error/message: The error message is not a valid one. As you must provide a valid error message as per the docs. For Example: [{"item_id":"I1","error":"40002"},{"item_id":"I2","error":"40002"},{"item_id":"I3","error":"40002"}].

Flow 5

On Cancel

End.time.range for RTO Fulfillment is not required.
End.timestamp for RTO Fulfillment should be provided in on_status RTO-Delivered or RTO-Disposed and not in RTO-initiated and not before that.

Flow 6

on_status_pending

How can on_status_pending have @ondc/org/settlement_details of on_update_part cancel when the precancel state is of on_status_pending? It should come after the precancel_state
Settlement_timestamp wont change after update_settlement

on_status

How is the settlement_timestamp different from update_settlement_part_cancel? how can it be there before update_settlement?
carry forward the exact @ondc/org/settlement_details of update_settlement forward i.e without changing settlement_type or timestamp

Update Settlement Reverse QC

Same as above
Also in you on_update part cancel and following you have provided precancel_state and other tags in delivery fulfillment which is not required , please remove that as well. As part cancel is only initiated before the items are packed due to non availability of stock.
Dummy invoice url should not be provided. eg :https://invoice_url

On Update liquidated

Why is only one @ondc/org/settlement_details of part-cancel carried forward here and not reverse-qc as well ? { "settlement_counterparty": "buyer", "settlement_phase": "refund", "settlement_type": "upi", "settlement_amount": "2380", "settlement_timestamp": "2024-05-19T10:27:32.784Z" }

Update Settlement Liquidated

Same as above

@udyamwell1

udyamwell1 commented 3 months ago

Hello @Jagannath-wits,

I have a few clarifications needed. Could you please answer the following questions?

Besides the existing utility, is there any new utility available for validating logs? 2.In Flow 1 -> on_search -> 1st point needs more clarification
Can you please clarify the requirements for inc_search?

Thank you and regards, Sachin

Jagannath-wits commented 3 months ago

Hello @Jagannath-wits,

I have a few clarifications needed. Could you please answer the following questions?

Besides the existing utility, is there any new utility available for validating logs? 2.In Flow 1 -> on_search -> 1st point needs more clarification

Can you please clarify the requirements for inc_search?

Thank you and regards, Sachin

No, there is no other utility apart from the one hosted
Rather than naming the varients as group 0 etc, you can name it as size variants, etc depending on item.
So, there are 2 modes of inc_search i.e 1-time and regular incremental refresh in the contract and both should be supported on page no. 13 @udyamwell1

udyamwell1 commented 3 months ago

Thank you for the clarification.

Additionally, we need your guidance on clearing these logs promptly. New issues arise frequently due to system upgrades or other factors, and we seek your advice to address them swiftly. This situation makes it feel like we have never gone live on the network. As a small early-stage startup with limited resources and dependency for revenue on the our ONDC enabled app, we are reaching out for assistance and guidance. Kindly help us and provide guidance, @Jagannath-wits

Jagannath-wits commented 3 months ago

Thank you for the clarification.

Additionally, we need your guidance on clearing these logs promptly. New issues arise frequently due to system upgrades or other factors, and we seek your advice to address them swiftly. This situation makes it feel like we have never gone live on the network. As a small early-stage startup with limited resources and dependency for revenue on the our ONDC enabled app, we are reaching out for assistance and guidance. Kindly help us and provide guidance, @Jagannath-wits

I understand.

Also in you on_update part cancel and following you have provided precancel_state and other tags in delivery fulfillment which is not required , please remove that as well. As part cancel is only initiated before the items are packed due to non availability of stock.
Dummy invoice url should not be provided. eg :https://invoice_url
The routing tag is mandatory for fulfillment delivery in the on_status calls.

@udyamwell1

udyamwell1 commented 3 months ago

Thank-you so much, will do it also.

On Wed, 22 May, 2024, 12:43 pm Jagannath Padhy, @.***> wrote:

Thank you for the clarification.

Additionally, we need your guidance on clearing these logs promptly. New issues arise frequently due to system upgrades or other factors, and we seek your advice to address them swiftly. This situation makes it feel like we have never gone live on the network. As a small early-stage startup with limited resources and dependency for revenue on the our ONDC enabled app, we are reaching out for assistance and guidance. Kindly help us and provide guidance, @Jagannath-wits https://github.com/Jagannath-wits

I understand.

Also in you on_update part cancel and following you have provided precancel_state and other tags in delivery fulfillment which is not required , please remove that as well. As part cancel is only initiated before the items are packed due to non availability of stock. @udyamwell1 https://github.com/udyamwell1

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/614#issuecomment-2124036447, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUDZZ6ND7DPVTUCL3M6LYDZDRARLAVCNFSM6AAAAABCFZ25OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUGAZTMNBUG4 . You are receiving this because you were mentioned.Message ID: @.***>

udyamwell1 commented 3 months ago

Thank you for the clarification. Additionally, we need your guidance on clearing these logs promptly. New issues arise frequently due to system upgrades or other factors, and we seek your advice to address them swiftly. This situation makes it feel like we have never gone live on the network. As a small early-stage startup with limited resources and dependency for revenue on the our ONDC enabled app, we are reaching out for assistance and guidance. Kindly help us and provide guidance, @Jagannath-wits

I understand.

Also in you on_update part cancel and following you have provided precancel_state and other tags in delivery fulfillment which is not required , please remove that as well. As part cancel is only initiated before the items are packed due to non availability of stock.

Dummy invoice url should not be provided. eg :https://invoice_url

The routing tag is mandatory for fulfillment delivery in the on_status calls.

@udyamwell1

Can you please give more clarification on 1st point.

Jagannath-wits commented 3 months ago

Also in you on_update part cancel and following you have provided precancel_state and other tags in delivery fulfillment which is not required , please remove that as well. As part cancel is only initiated before the items are packed due to non availability of stock.

precancel_state and other tags in delivery fulfillment is not required is all, as part cancel is only initiated before the items are packed due to non availability of stock so it's understood. So please remove the tags from delivery fulfillment object.

@udyamwell1

udyamwell1 commented 3 months ago

Please review the updated logs: https://github.com/ONDC-Official/v1.2.0-logs/pull/1706

udyamwell1 commented 3 months ago

@Jagannath-wits

udyamwell1 commented 3 months ago

Logs got merged @Jagannath-wits Please check.

sandeepshahi commented 3 months ago

Flow 1

/on_search

geocoding of store address is incorrect; the GPS coordinates and area code don't match. Why was the address partly patched?
ean code is mostly of 13 digits; placeholder values should not be provided in /items/descriptor/code
mapping of category_id and statutory reqs must be correct as per the sheet; both the objects need not be provided
placeholder value should not be provided for statutory reqs. eg: manufacturer of dairy milk can't be Udyamwell;
Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for Delivery and Order, you can use enum "All"

/on_search (inc)

why is the context/timestamp same as full catalog pull; mocked request are not allowed
item is disabled but the timestamp (items/time/timestamp) remains the same. how can item be enabled/disabled at the same time?

Flow 2

/on_select

For delivery TAT <= 2hrs, "Immediate Delivery" can be provided in "@ondc/org/category"
How is the delivery TAT ("@ondc/org/TAT") calculated here?
1. The gps coordinates of the store shows address in Punjab; Punjab to Bangalore delivery can't be done in 60 minuts
2. Even if store pincode is considered as 560066, the shipment can't be done 15 minutes (considering 45 minutes to ship the product as per the catalog)

/on_init

cancellation_terms need not be provided; not a part of current phase

/on_confirm

the total delivery tat is just 1 hour but pickup time ranges around 3 days. Why is this not calculated correctly?
"person" in fulfillments/start/ is not a valid attribute
"bap_terms" missing in /tags

/on_status (pending)

why are the estimated pickup time ranges changed? if not available in /on_confirm, no need to provide there
estimated pickup and delivery time ranges can't be same; delivery must only start once the pickup ends; also the time ranges must be future dated, and not earlier than context timestamp
incorrect mapping of order and fulfillment state; How can agent be assigned when order is just Accepted; pls check the fulfillment and order state mapping in the contract
routing and tracking info must be provided on or before agent assigned state; tracking should be provided since tracking is set as true

/on_status (picked)

how can shipment from punjab to bengaluru be P2P?

/on_track

must be provided if tracking = true

Flow 3

similar issues as above

/on_select (OOS)

item was completely out of stock; how can 2 quantities become available later?

Flow 5

/on_cancel

end/location/id is missing for RTO fulfillment
terminal state of RTO (delivered/disposed) must be provided through /on_status call
time range for RTO need not be provided; RTO is intiated at a fixed timestamp

Flow 6

/on_update (part cancel)

how can seller part cancel the order even before accepting it? please share the screenshot of the workflow?
for part cancellation, existing forward shipment need not be modified; tags/cancel_request will be part of the cancel type shipment: UWC1 and no need to provide precancel_state
"003" is not a valid "reason_id" for cancellation initiated by SNP; check here

/on_update (interim)

context/timestamp can't be same as in /update
fulfillment id for return type is invalid; should be the same as provided by buyer app in /update

/on_update (approval)

actual return pickup timestamp can't be provided; must be provided in the picked state
estimated ranges can't be past dated; must be feasible and realistic
start/location/id is invalid for return fulfillment; should be provided for end/location

/on_update (picked/delivered)

return fulfillment id mapped with item is incorrect; as mentioned earlier should be the one sent by buyer app

@udyamwell1

udyamwell1 commented 3 months ago

@sandeepshahi We have updated al the flows as per your feedback. Please review it: https://github.com/ONDC-Official/v1.2.0-logs/pull/1825

sahil-ondc commented 3 months ago

Flow 1

on_search_full_catalog_refresh

schemaErr0: "/message/catalog/bpp~1providers/0/tags/2/list/4/code Serviceability must have this value 'val' instead of 'value'"
images: "images link are not accessible, For e.g. 'https://seller.udyamwell.in/api/uploads/1715973409762-Screenshot 2024-05-18 at 12.45.01 AM.png'"

on_search_inc

Question: "What is itmes in the bpp/providers ?"

Flow 2

on_track

Question: "Why on_track payload is empty ?"

on_status_pending

delivery_time: "How is the delivery TAT ('@ondc/org/TAT') calculated here? The gps coordinates of the store shows address in Punjab; Punjab to Bangalore delivery can't be done in 60 minutes"

on_status_picked

time/range: "How the pickup time/range has so much difference between each other, which is more than actual TAT. Also end/time/range/ is starting before actual pickup time/range. How ?"
P2P: "how can shipment from punjab to bengaluru be P2P?"

Flow 4

select

tmpstmp: "Timestamp for /on_search api cannot be greater than or equal to /select api"

on_init

message.order: "'cancellation_terms' in /message/order should not be provided as those are not enabled yet"

on_confirm

sellerGpsErr: "store gps location /fulfillments[0]/start/location/gps can't change"
tags_bap_terms: "Tags should have same and valid gst_number as passed in /confirm"

Flow 5

terminal state of RTO (delivered/disposed) must be provided through /on_status call

Flow 6

on_status_pending

message/order.fulfillments/0: "start/time/range is missing in on_status_pending for 'Delivery' fulfillment"
message/order.fulfillments/0/start/person: "'start/person' in 'Delivery' fulfillment is not required in on_status_pending on key"

on_status_packed

message/order.fulfillments/1/start/location: "Mismatch occurred while comparing 'Delivery' fulfillment object with on_status_pending on key 'start/location/locality'"

on_update_part_cancel

part_cancel: "how can seller part cancel the order even before accepting it? please share the screenshot of the workflow?"

on_update_approval

Return.start.time: "Return fulfillment start time object is missing in on_update_approval"

@udyamwell1

udyamwell1 commented 3 months ago

Hello, @sahil-ondc

To clarify, most of the issues mentioned in this review are repetitive and were previously resolved. Some issues, specifically:

Flow 1: Some issues, like the missing on_track payload, occurred due to an error on our end. We have updated Flow 2 with the on_track file and made minor changes to Flow 1. You can review it.
Images Issue: The images are accessible and are displayed in the reference app. The links mentioned in the flow were broken, but we have updated them with accessible links.
on_search_inc:
- Question: "What is itmes in the bpp/providers?"
- Answer: This was a spelling mistake on our part. It should be "items." We have updated it.
Flow 2:
- on_track:
- Question: "Why is the on_track payload empty?"
- Answer: The on_track file was missed due to a mistake on our end. We have updated the on_track file. Please review it.

Other flows and issues are repetitive and have already been resolved on our side. Please recheck.

@sahil-ondc

udyamwell1 commented 3 months ago

We have made the changes as per feedback . Please review: https://github.com/ONDC-Official/v1.2.0-logs/pull/1872

@sandeepshahi @sahil-ondc

sahil-ondc commented 2 months ago

Flow 1

on_search (full_catalog)

geocoding of store address is incorrect; the GPS coordinates and area code don't match. Why was the address partly patched?
EAN number should be valid (item.id: 66464eb66b5922ef1a1df3e6)
range provided in locations should be in sync with range provided in timing tags

Flow 2, 3, 6

on_init

location_id is not valid property in /message/order/items

on_status (picked)

/message/order/fulfillment/start/range should not be prior than context/timestamp
tracking info must be provided on or before agent assigned state; tracking should be provided since tracking is set as true
@ondc/org/provider_name should remain same as provided in on_select

on_track

provided gps should be in between of start and end locations

Flow 5

on_cancel

end/location/id is missing for RTO fulfillment

on_status (rto-disposed)

rto-fulfillment/state should not be RTO-Initiated

Note

brand_owner_FSSAI_license_no, other_FSSAI_license_no, importer_FSSAI_license_no should not be placeholder as provided in API contract

@udyamwell1

udyamwell1 commented 2 months ago

@sahil-ondc @sandeepshahi We have updated the logs based on the feedback. Please review. https://github.com/ONDC-Official/v1.2.0-logs/pull/1915

sandeepshahi commented 2 months ago

Flow 1

/on_search (inc)

why is the EAN code changing for the same item?

/on_select

delivery TAT provided in @ondc/org/TAT should be feasible

Flow 2

/on_status

routing info should be provided on or before Agent-assigned state and then in subsequent APIs

Flow 4

/on_cancel

placeholder values of pickup/delivery time ranges should not be provided. why are these being provided when the order is getting cancelled?

Flow 5

/on_cancel (RTO)

values in estimated pickup time range should not change

/on_status (RTO delivered)

invalid timestamp provided in fulfillments/end/time for fulfillment: "a30bd68e-c571-4d1d-a2a4-3a9925023930"
RTO delivery timestamp is missing

Flow 6

/on_update (part cancel)

how can part cancellation be triggered even before the order is accepted by the seller?
for above point, since the order is getting accepted in on_update (part cancel) call, why is the status call being provided again later?

@udyamwell1

sandeepshahi commented 2 months ago

@udyamwell1, part cancellation and item.descriptor.code (capturing EAN/HSN/GTIN etc.) need to be implemented on the frontend.

udyamwell1 commented 2 months ago

Dear @sandeepshahi , The HSN Code and variant feature is done from the backend side. the frontend part was also developed. We will make these features live on our app by this weekend.

Regarding Part-cancellation, as it's not compulsory so as per your instruction we are providing a timeline for this part. Part cancellation feature will be implemented in the first week of next month.

Thanks for approving the logs.

ONDC-Official / v1.2.0-logs

Udyamwell (SA: RET10) - compliance checks #614

Flow 1

on_search_full_catalog_refresh

search_inc_refresh

Flow 2

on_init

On select

Flow 1

on_search_full_catalog_refresh

Flow 2

on_status_packed, on_status_out_for_delivery logs missing

on_confirm

Flow 3

on_select_out_of_stock

Flow 4

on_cancel

Flow 5

on_cancel

Flow 1

on_search_inc_refresh

Flow 2

on_init

on_confirm

on_status_pending

on_status_picked

on_status_out_for_delivery

on_status_delivered

Flow 4

on_cancel

Flow 5

on_cancel

Flow 6-b

on_update_interim

on_update_approval

on_update_picked

update_settlement missing

on_update_delivered

Flow 6-a(Part-cancel) Missing

Flow 1

Udyamwell RET:10

Flow 1

Flow 2

Flow 3

Flow 5

Flow 6

Flow 1

Flow 2

Flow 3

Flow 5

Flow 6

Flow 1

on_search_full_catalog_refresh

on_search_inc

Flow 2

on_track

on_status_pending

on_status_picked

Flow 4

select

on_init

on_confirm

Flow 5

Flow 6

on_status_pending

on_status_packed

on_update_part_cancel

on_update_approval

Flow 1

on_search (full_catalog)

Flow 2, 3, 6

on_init

on_status (picked)

on_track

Flow 5

on_cancel

on_status (rto-disposed)

Note

Flow 1

Flow 2