search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 245 forks source link

Tipplr (SA) - compliance check #650

Open sahil-ondc opened 7 months ago

sahil-ondc commented 7 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_catalog_refresh

Flow 2

on_select

on_init

on_confirm

on_status (delivered)

Flow 3

on_select (out-of-stock)

Other Flows

on_cancel

@punithraj

punithrj26 commented 7 months ago

@sahil-ondc

for flow 2,

  1. Item's unit and total price mismatch for id: food_item-170383210597342600 We have added two differ unit prices to show the scratched value on the buyer app.
  2. Quoted Price in /on_select INR 190 does not match with the total price of items in /select INR 152 We will not be knowing the end location before select api, once we know the end location we will add the delivery charges to the quote so the difference of 38 between select and on_select quote.

Working on other points thank you.

punithrj26 commented 7 months ago

Hi @sahil-ondc Have raised a PR #716 with the corrected flow as required. Have uploaded as required. Please go through them.

sahil-ondc commented 6 months ago

Flow 1

on_search_full_catalog

on_search_inc_catalog

Flow 2

on_confirm

on_status (out-for-delivery)

Flow 3

Note

Flow 4

on_cancel

Note

@punithrj26

punithrj26 commented 6 months ago

Hi @sahil-ondc Have raised a PR #902 with the corrected flow as required. Have uploaded as required. Please go through them.

nishthamongaondc commented 6 months ago

Flow 1

on_search_full_catalog_refresh

Flow 2

on_select

on_init

on_confirm

on_status_out_for_delivery

on_status_delivered

@punithrj26

NishthaMonga commented 6 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_refresh

Flow 2

on_select

NOTE

on_status_packed,on_status_picked logs missing

@punithrj26

sahil-ondc commented 5 months ago

Flow 1

on_search_full_catalog_refresh

search_inc_refresh

on_search_inc_refresh

Flow 2

on_select

on_init

confirm

on_confirm

@punithrj26

sahil-ondc commented 5 months ago

Flow 1

on_search

search_inc

Flow 2

on_select

on_init

on_confirm

on_status

@punithrj26

sahil-ondc commented 5 months ago

Flow 1

on_search

Flow 2

select

on_select

on_init

on_confirm

Flow 3

Flow 5

on_cancel

Flow 6

@punithrj26

sahil-ondc commented 5 months ago

Flow 1

on_search_full_catalog

Flow 2

select

on_status

Flow 4

on_cancel

Flow 5

Flow 6

@punithrj26

sahil-ondc commented 4 months ago

Flow 1

on_search (full_catalog)

Flow 2

on_select

on_init

on_status

Flow 3

Flow 4

on_cancel

Flow 5

on_cancel

Flow 6

@punithrj26

sahil-ondc commented 3 months ago

Logs submitted with repeated issues

Flow 1

on_search (full catalog)

customizable catalog should be provided

Flow 2

on_select

on_init

on_confirm

on_status

Flow 3

Flow 4

on_cancel

Flow 5

on_cancel (rto)

Flow 6

on_status

Note

@punithrj26

sahil-ondc commented 2 months ago

Flow 1

on_search

Flow 2

on_confirm

on_status_picked

on_status_delivered

Flow 3

on_select_out_of_stock

Flow 5

@punithrj26

punithrj26 commented 2 months ago

@sahil-ondc Hi we have worked on changes mentioned in compliance. #1866

Comments as per compliance: If the timing construct for order and delivery are the same, you can use the enum 'All' instead. Our reply: We dont support Pickup option, If we give “All” it will take pickup also, so We intentionally added Delivery and Order.

Please go through ad give us a feedback.

Thank you.

sahil-ondc commented 2 months ago

Flow 2

on_init

on_status (packed)

on_status (picked)

Flow 5

on_cancel

Flow 6

on_status (pending)

on_status (picked)

@punithrj26

sahil-ondc commented 2 months ago

Flow 1

on_search (full catalog refresh)

on_search (inc catalog refresh)

Flow 2, 3, 4

on_select

on_init

on_status

Flow 5

Flow 6

on_update (part-cancellation)

on_update (interim liquidate)

on_update (liquidated)

@punithrj26

srinii99 commented 2 months ago

@sahil-ondc @sandeepshahi

Hi Sandeep / Sahil,

We have fixed all the issues and have raised the PR # 1989

We have also reviewed previous issue which was raised and ensure none of the issues are repeated. I have also attached the status report for the same.

Request you to kindly validate the logs and provide us the feedback if any.

Thanks for all the help

Regards, Srini ONDC_Issue_Logs.xlsx

@punithrj26

Jagannath-wits commented 1 month ago

Tipplr

Flow 1

on_search

search_inc

Flow 2

on_status

Flow 5

on_cancel

on_status_rto_delivered

Flow 6

On Update Part Cancel

on_update_interim_liquidated

@punithrj26

punithrj26 commented 1 month ago

@Jagannath-wits

Hi jagannath,

We are able to see the mentioned merchant-16470689776923676 in on_search of flow 1 "Merchant-16470689776923676 provider does not exist in on_search." Available here https://github.com/ONDC-Official/v1.2.0-logs/blob/master/Tipplr/tipplr-v1.2-logs(F%26B-RET11)-03-July/Flow_1/2.%20on_search_full_catalog_refresh.json

Our latest logs are available in this folder: https://github.com/ONDC-Official/v1.2.0-logs/tree/master/Tipplr/tipplr-v1.2-logs(F%26B-RET11)-03-July.

Can you please confirm that you have used the same folder mentioned above for the log verification process.

Thank you.

srinii99 commented 1 month ago

Hi ONDC team,

Looks like you have validated old logs.

Kindly refer PR 1989, this contains the new logs.

Kindly confirm

Thanks, Srini

On Thu, 11 Jul, 2024, 18:27 Jagannath Padhy, @.***> wrote:

Tipplr Flow 1 on_search

  • Don't provide placeholder offers as offers are not enabled yet.
  • You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same.

search_inc

  • Static terms are not enabled yet; please remove bap_terms.

on_search_inc

  • Merchant-16470689776923676 provider does not exist in on_search.

Flow 2 on_init

  • Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount, and @ondc/org/settlement_details are required in the payment object when the buyer is collecting money.
  • @.***/org/TAT" should remain the same as on_select throughout the flow.

on_status

  • If tracking is true, a tracking object should be provided.

Flow 5 on_cancel

on_status_rto_delivered

  • Payload missing. RTO_fulfillment.end.time.timestamp should be updated here as defined in contract and the quote trail will follow same as on_cancel. @punithrj26 https://github.com/punithrj26

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/650#issuecomment-2222873413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7K7FXW2R4ISXWBAGR4XULZLZ6MHAVCNFSM6AAAAABCO4UBE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRSHA3TGNBRGM . You are receiving this because you commented.Message ID: <ONDC-Official/v1 .@.***>

Jagannath-wits commented 1 month ago

Tipplr

Flow 1

on_search

  • Don't provide placeholder offers as offers are not enabled yet.
  • You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same.

search_inc

  • Static terms are not enabled yet; please remove bap_terms.

Flow 2

on_status

  • If tracking is true, a tracking object should be provided.

Flow 5

on_cancel

  • Reason should be the same in order.cancellation and cancel_request.
  • Reason code and initiated_by should be mapped correctly according to the sheet.
  • Won’t you charge for delivery as the out is already out for delivery.
  • RTO_fulfillment not captured correctly. Please refer to contract.

on_status_rto_delivered

  • RTO_fulfillment not captured correctly. Please refer to contract.
  • RTO_fulfillment.end.time.timestamp should be updated here as defined in contract and the quote trail will follow same as on_cancel.

Flow 6

On Update Part Cancel

  • Question: Why is on_update_part_cancel sent before order is accepted?

on_update_interim_liquidated

  • invoice should not be updated after on_status_picked

@punithrj26

@srinii99 @punithrj26 Please refer to the updated issues now

srinii99 commented 1 month ago

@Jagannath-wits @sandeepshahi @sahil-ondc

Thanks for the feedback , below are our comments :

Flow 1 : on_search 1 . Don't provide placeholder offers as offers are not enabled yet. - REMOVED THE PLACEHOLDER

  1. You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same - SELECTING 'ALL' WILL ENABLE PICKUP OPTION, SINCE WE DON'T SUPPORT PICKUP OPTION, WE HAVE DISABLED 'ALL ' OPTION. ALREADY DISCUSSED THE SAME WITH SANDEEP / SAHIL ABOUT THIS AND THEY HAD AGREED WITH OUR SUGGESTION.

search_inc

  1. Static terms are not enabled yet; please remove bap_terms - REMOVED THE STATIS TERMS

Flow 2 on_status

  1. If tracking is true, a tracking object should be provided- WE HAVE MADE THE NECESSARY CHANGES

Flow 5 on_cancel

  1. Reason should be the same in order.cancellation and cancel_request - WE HAVE MADE THE NECESSARY CHANGES
  2. Reason code and initiated_by should be mapped correctly according to the [sheet] - CORRECTED (https://docs.google.com/spreadsheets/d/1_qAtG6Bu2we3AP6OpXr4GVP3X-32v2xNRNSYQhhR6kA/edit?gid=1095388031#gid=1095388031).
  3. Won’t you charge for delivery as the out is already out for delivery - NO WE ARE NOT CHARGING WHEN THE ORDER IS CANCELLED , SINCE WE HAVE OUR OWN DELIVERY FLEET AND THE CUSTOMER WOULD HAVE PAID FOR DELIVERY WHILE PLACING, HENCE WE ARE NOT CHARGING AGAIN.
  4. RTO_fulfillment not captured correctly. Please refer to contract - WE DON'T HAVE RTO DELIVERY SINCE IT IS AN FOOD ITEM, HENCE WE ARE DISPOSING THE ITEM

Flow 6 On Update Part Cancel

  1. Question: Why is on_update_part_cancel sent before order is accepted? - BASED ON OUR DISCUSSION WITH SANDEEP, WE WERE ADVISED TO UPDATE PART CANCEL IF ONE OF THE ITEM IS OUT OF STOCK. SO BEFORE ACCEPTING THE ORDER, IF ANY ITEM IS OUT OF STOCK, WE CANCEL THAT PARTICULAR ITEM AND THEN ACCEPT THE ORDER.

on_update_interim_liquidated

  1. invoice should not be updated after on_status_picked : WE CROSSED CHECKED THE INVOICE AND NO WHERE IT IS GETTING CHANGED. AS SOON AS THE ORDER IS ACCEPTED, WE ARE GENERATING THE INVOICE, IN CASE PART CANCELLATION, WE ARE UPDATING THE INVOICE, ELSE WE ARE KEEPING THE SAME TILL THE ORDER IS DELIVERED.
srinii99 commented 1 month ago

@Jagannath-wits @sahil-ondc @sandeepshahi

Hi Jagannath,

We have made the necessary changes as per your feedback. Before we raise the PR, can you please provide us your feedback for the below comments, so that if any changes we can fix else we can go ahead and raise the PR.

Flow 1 : on_search 1.You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same -

OUR COMMENT ;

Selecting 'ALL' will enable pickup option, since we dont support pickup optkion, we have disabled 'ALL' option. We have already discussed this issue with Sandeep/ Sahil and they have agreed with our suggestions.

Flow 5 on_cancel

1.Won’t you charge for delivery as the out is already out for delivery -

Our Comment : NO, we are not charging when the order is cancelled, since we have our own delivery fleet and the customer while placing the order , would have paid for the delivery, hence we are not charging again.

2.RTO_fulfillment not captured correctly. Please refer to contract - Our Comment : We dont have RTO Delivery since this is an perishable items, hence we dispose the item

Flow 6 On Update Part Cancel

Question: Why is on_update_part_cancel sent before order is accepted? -

Our Comment : Based on our discussion with Sandeep, we were advised to update part cancel if one of the items are out of stock. So, before accepting the order, if any item is out of stock, we cancel that particular item and then accept the order.

on_update_interim_liquidated

invoice should not be updated after on_status_picked :

Our Comment : We crossed checked the invoice and no where it is getting changed. As soon as the order is accepted, we are generating the invoice. In case of part cancellation, we are updating the invoice, else we are keeping the same invoice

Jagannath-wits commented 1 month ago

Flow 1 : on_search 1.You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same -

OUR COMMENT ;

Selecting 'ALL' will enable pickup option, since we dont support pickup opttion, we have disabled 'ALL' option. We have already discussed this issue with Sandeep/ Sahil and they have agreed with our suggestions.

- 'All' only covers timing for order and the provided fulfillments and not all types of fulfillments

Flow 5 on_cancel

1.Won’t you charge for delivery as the out is already out for delivery -

Our Comment : NO, we are not charging when the order is cancelled, since we have our own delivery fleet and the customer while placing the order , would have paid for the delivery, hence we are not charging again.

2.RTO_fulfillment not captured correctly. Please refer to contract - Our Comment : We dont have RTO Delivery since this is an perishable items, hence we dispose the item

Flow 6 On Update Part Cancel

Question: Why is on_update_part_cancel sent before order is accepted? -

Our Comment : Based on our discussion with Sandeep, we were advised to update part cancel if one of the items are out of stock. So, before accepting the order, if any item is out of stock, we cancel that particular item and then accept the order.

on_update_interim_liquidated

invoice should not be updated after on_status_picked :

Our Comment : We crossed checked the invoice and no where it is getting changed. As soon as the order is accepted, we are generating the invoice. In case of part cancellation, we are updating the invoice, else we are keeping the same invoice

- Ok please, proceed with the fixes @srinii99 @punithrj26

srinii99 commented 1 month ago

Hi ONDC Team,

We have made the necessary changes as per the suggestions above and have submitted the logs, the PR # 2061

@sandeepshahi Can you please merge the logs @Jagannath-wits
It would be really helpful , if you could review the logs ( once merged) and provide us the feedback , so that we can work on it immediately . Appreciate your quick response.

Thanks, Srini

punithrj26 commented 1 month ago

@Jagannath-wits Hi Jagannath,

Our Pr is merged in master. Can you please go through our logs and give feedback on it.

Thanks.

punithrj26 commented 1 month ago

@Jagannath-wits @sandeepshahi

Hi Team,

Please let us know the status of the uploaded logs.

Thanks.

sandeepshahi commented 1 month ago

Flow 1

/on_search

/inc search

Flow 2

/on_select

/on_confirm

/on_status

Flow 3

/on_select (OOS)

Flow 4

/on_cancel

Flow 5

/on_cancel (RTO)

/on_status (disposed)

Flow 6

/on_update (interim)

/on_update (liquidated)

@punithrj26 @srinii99

@Jagannath-wits, FYR

sandeepshahi commented 3 weeks ago

Flow 1

/on_search

@punithrj26 @srinii99