Open sahil-ondc opened 7 months ago
@sahil-ondc
for flow 2,
Working on other points thank you.
Hi @sahil-ondc Have raised a PR #716 with the corrected flow as required. Have uploaded as required. Please go through them.
@punithrj26
Hi @sahil-ondc Have raised a PR #902 with the corrected flow as required. Have uploaded as required. Please go through them.
@punithrj26
on_status_packed,on_status_picked logs missing
@punithrj26
/message/catalog/bpp~1providers/0/locations/0/address/area_code
must NOT have fewer than 6 characters./message/catalog/bpp~1providers/1/locations/0/address/area_code
must NOT have fewer than 6 characters./bpp/providers[0]/locations[0]/time
./on_search
.bpp/providers[0]/items/category_id
./message/intent/tags/list/start_time/value
cannot be greater than or equal to /context/timestamp
./message/intent/tags/list/end_time/value
cannot be greater than /context/timestamp
./on_search_full_catalog_refresh
api call, item id- food_item-166989377662162031
./select
and /on_select
./on_search
and /confirm
.food_item-170383210808146459
./on_search
and /confirm
./on_search
and /on_confirm
./fulfillments[0]/start/location/descriptor/name
can't change.food_item-170383210808146459
.message/order/tags/bpp_terms
for ON_CONFIRM.@punithrj26
@punithrj26
@punithrj26
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
@punithrj26
https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795
@punithrj26
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.4b1aemczbswx
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ks3uqu8tq83s
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ks3uqu8tq83s
@punithrj26
food_item-170383210588937185
?['UUK7SZXN4K:1]
, it's been used in multiple items./message/order/fulfillment/start/range/start
should not be less than context/timestamp
.start/time/timestamp
for 'Delivery' fulfillment is not in the given range provided.end/time/timestamp
for 'Delivery' fulfillment is not in the given range provided.dynamic_item_id
, refer to this error message: "[{\"dynamic_item_id\":\"DI1\",\"item_id\":\"I1\",\"error\":\"40002\"}, {\"dynamic_item_id\":\"DI2\",\"customization_id\":\"C15\",\"customization_group_id\":\"CG3\",\"error\":\"40002\"}]"
./on_status
call.@punithrj26
@sahil-ondc Hi we have worked on changes mentioned in compliance. #1866
Comments as per compliance: If the timing construct for order and delivery are the same, you can use the enum 'All' instead. Our reply: We dont support Pickup option, If we give “All” it will take pickup also, so We intentionally added Delivery and Order.
Please go through ad give us a feedback.
Thank you.
@punithrj26
@punithrj26
@sahil-ondc @sandeepshahi
Hi Sandeep / Sahil,
We have fixed all the issues and have raised the PR # 1989
We have also reviewed previous issue which was raised and ensure none of the issues are repeated. I have also attached the status report for the same.
Request you to kindly validate the logs and provide us the feedback if any.
Thanks for all the help
Regards, Srini ONDC_Issue_Logs.xlsx
@punithrj26
bap_terms
.order.cancellation
and cancel_request
.on_update_part_cancel
sent before order is accepted?@punithrj26
@Jagannath-wits
Hi jagannath,
We are able to see the mentioned merchant-16470689776923676 in on_search of flow 1 "Merchant-16470689776923676 provider does not exist in on_search." Available here https://github.com/ONDC-Official/v1.2.0-logs/blob/master/Tipplr/tipplr-v1.2-logs(F%26B-RET11)-03-July/Flow_1/2.%20on_search_full_catalog_refresh.json
Our latest logs are available in this folder: https://github.com/ONDC-Official/v1.2.0-logs/tree/master/Tipplr/tipplr-v1.2-logs(F%26B-RET11)-03-July.
Can you please confirm that you have used the same folder mentioned above for the log verification process.
Thank you.
Hi ONDC team,
Looks like you have validated old logs.
Kindly refer PR 1989, this contains the new logs.
Kindly confirm
Thanks, Srini
On Thu, 11 Jul, 2024, 18:27 Jagannath Padhy, @.***> wrote:
Tipplr Flow 1 on_search
- Don't provide placeholder offers as offers are not enabled yet.
- You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same.
search_inc
- Static terms are not enabled yet; please remove bap_terms.
on_search_inc
- Merchant-16470689776923676 provider does not exist in on_search.
Flow 2 on_init
- Only @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount, and @ondc/org/settlement_details are required in the payment object when the buyer is collecting money.
- @.***/org/TAT" should remain the same as on_select throughout the flow.
on_status
- If tracking is true, a tracking object should be provided.
Flow 5 on_cancel
- Reason should be the same in order.cancellation and cancel_request.
- Reason code and initiated_by should be mapped correctly according to the sheet https://docs.google.com/spreadsheets/d/1_qAtG6Bu2we3AP6OpXr4GVP3X-32v2xNRNSYQhhR6kA/edit?gid=1095388031#gid=1095388031 .
- Won’t you charge for delivery as the out is already out for delivery.
- RTO_fulfillment not captured correctly. Please refer to contract.
on_status_rto_delivered
- Payload missing. RTO_fulfillment.end.time.timestamp should be updated here as defined in contract and the quote trail will follow same as on_cancel. @punithrj26 https://github.com/punithrj26
— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/650#issuecomment-2222873413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7K7FXW2R4ISXWBAGR4XULZLZ6MHAVCNFSM6AAAAABCO4UBE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRSHA3TGNBRGM . You are receiving this because you commented.Message ID: <ONDC-Official/v1 .@.***>
Tipplr
Flow 1
on_search
- Don't provide placeholder offers as offers are not enabled yet.
- You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same.
search_inc
- Static terms are not enabled yet; please remove
bap_terms
.Flow 2
on_status
- If tracking is true, a tracking object should be provided.
Flow 5
on_cancel
- Reason should be the same in
order.cancellation
andcancel_request
.- Reason code and initiated_by should be mapped correctly according to the sheet.
- Won’t you charge for delivery as the out is already out for delivery.
- RTO_fulfillment not captured correctly. Please refer to contract.
on_status_rto_delivered
- RTO_fulfillment not captured correctly. Please refer to contract.
- RTO_fulfillment.end.time.timestamp should be updated here as defined in contract and the quote trail will follow same as on_cancel.
Flow 6
On Update Part Cancel
- Question: Why is
on_update_part_cancel
sent before order is accepted?on_update_interim_liquidated
- invoice should not be updated after on_status_picked
@punithrj26
@srinii99 @punithrj26 Please refer to the updated issues now
@Jagannath-wits @sandeepshahi @sahil-ondc
Thanks for the feedback , below are our comments :
Flow 1 : on_search 1 . Don't provide placeholder offers as offers are not enabled yet. - REMOVED THE PLACEHOLDER
search_inc
Flow 2 on_status
Flow 5 on_cancel
Flow 6 On Update Part Cancel
on_update_interim_liquidated
@Jagannath-wits @sahil-ondc @sandeepshahi
Hi Jagannath,
We have made the necessary changes as per your feedback. Before we raise the PR, can you please provide us your feedback for the below comments, so that if any changes we can fix else we can go ahead and raise the PR.
Flow 1 : on_search 1.You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same -
OUR COMMENT ;
Selecting 'ALL' will enable pickup option, since we dont support pickup optkion, we have disabled 'ALL' option. We have already discussed this issue with Sandeep/ Sahil and they have agreed with our suggestions.
Flow 5 on_cancel
1.Won’t you charge for delivery as the out is already out for delivery -
Our Comment : NO, we are not charging when the order is cancelled, since we have our own delivery fleet and the customer while placing the order , would have paid for the delivery, hence we are not charging again.
2.RTO_fulfillment not captured correctly. Please refer to contract - Our Comment : We dont have RTO Delivery since this is an perishable items, hence we dispose the item
Flow 6 On Update Part Cancel
Question: Why is on_update_part_cancel sent before order is accepted? -
Our Comment : Based on our discussion with Sandeep, we were advised to update part cancel if one of the items are out of stock. So, before accepting the order, if any item is out of stock, we cancel that particular item and then accept the order.
on_update_interim_liquidated
invoice should not be updated after on_status_picked :
Our Comment : We crossed checked the invoice and no where it is getting changed. As soon as the order is accepted, we are generating the invoice. In case of part cancellation, we are updating the invoice, else we are keeping the same invoice
Flow 1 : on_search 1.You can provide a timing object with type ‘All’ if the timing for both order and fulfillments is the same -
OUR COMMENT ;
Selecting 'ALL' will enable pickup option, since we dont support pickup opttion, we have disabled 'ALL' option. We have already discussed this issue with Sandeep/ Sahil and they have agreed with our suggestions.
- 'All' only covers timing for order and the provided fulfillments and not all types of fulfillments
Flow 5 on_cancel
1.Won’t you charge for delivery as the out is already out for delivery -
Our Comment : NO, we are not charging when the order is cancelled, since we have our own delivery fleet and the customer while placing the order , would have paid for the delivery, hence we are not charging again.
2.RTO_fulfillment not captured correctly. Please refer to contract - Our Comment : We dont have RTO Delivery since this is an perishable items, hence we dispose the item
Flow 6 On Update Part Cancel
Question: Why is on_update_part_cancel sent before order is accepted? -
Our Comment : Based on our discussion with Sandeep, we were advised to update part cancel if one of the items are out of stock. So, before accepting the order, if any item is out of stock, we cancel that particular item and then accept the order.
on_update_interim_liquidated
invoice should not be updated after on_status_picked :
Our Comment : We crossed checked the invoice and no where it is getting changed. As soon as the order is accepted, we are generating the invoice. In case of part cancellation, we are updating the invoice, else we are keeping the same invoice
- Ok please, proceed with the fixes @srinii99 @punithrj26
Hi ONDC Team,
We have made the necessary changes as per the suggestions above and have submitted the logs, the PR # 2061
@sandeepshahi
Can you please merge the logs
@Jagannath-wits
It would be really helpful , if you could review the logs ( once merged) and provide us the feedback , so that we can work on it immediately . Appreciate your quick response.
Thanks, Srini
@Jagannath-wits Hi Jagannath,
Our Pr is merged in master. Can you please go through our logs and give feedback on it.
Thanks.
@Jagannath-wits @sandeepshahi
Hi Team,
Please let us know the status of the uploaded logs.
Thanks.
/on_search
/inc search
/on_select
/on_confirm
/on_status
/on_select (OOS)
/on_cancel
/on_cancel (RTO)
/on_status (disposed)
/on_update (interim)
/on_update (liquidated)
@punithrj26 @srinii99
@Jagannath-wits, FYR
/on_search
/on_status (RTO)
/on_update (part cance/liquidatedl)
@punithrj26 @srinii99
Flow 1
on_search_full_catalog_refresh
on_search_inc_catalog_refresh
Flow 2
on_select
on_init
on_confirm
on_status (delivered)
Flow 3
on_select (out-of-stock)
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.w0p6bcyawc9u
Other Flows
on_cancel
https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.yzl8pn3ixxec
@punithraj