search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 270 forks source link

nStore (SA) - compliance check #656

Closed sahil-ondc closed 7 months ago

sahil-ondc commented 9 months ago

Flow 1

search_full_catalog_refresh

on_search_full_catalog_refresh

search_inc_refresh

on_search_inc_refresh

Flow 2

select

on_select

init

on_init

confirm

on_confirm

on_status

Flow 3

on_select (out-of-stock)

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

Flow 4

on_cancel

Note

https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

@nstoretech

sahil-ondc commented 9 months ago

Flow 1

on_search_full_catalog_refresh

search_inc_refresh

on_search_inc_refresh

Flow 2

select

on_init

on_confirm

on_status

Flow 3

select (out-of-stock)

Other Flows

@nstoretech

arunraj-nstore commented 9 months ago

provider_tax_number is required only if np_type is 'ISN' as per the document. Is it required to add it in the payload though we are MSN.

Also we are sending different message_id for on_status payload.

sahil-ondc commented 8 months ago

Flow 1

on_search_full_catalog

on_search_inc

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

Flow 5

on_cancel

Other flows

on_select

on_init

@nstoretech

arunraj-nstore commented 8 months ago

We managed the UOM (unit of measure) as a part of the product attribute in our system to make the product extensively configurable. So that we used 'item.attribute.Quantity' for making a variant group instead of 'item.unitized.measure' to avoid hardcoding of UOMs in our product...So we are sending the uom as single unit and the variant values under respective product attributes. This way we will be compliant with ONDC specs without hardcoding UOM and also don't need to change our product...We are happy to discuss this over a call and sort out if needed.

BLR-0118 commented 8 months ago

@arunraj-nstore - sorry, this won't work; since we have an attribute for unitized measure, you're required to populate it correctly;

BLR-0118 commented 8 months ago

Flow 1

  1. /on_search (full catalog):

    • use proper unitized qty e.g. item 100 should have unitized qty of 500 gram instead of 1 unit;
    • item.tags.attribute.quantity is invalid: pls use only the attributes listed here;
    • day_from can't be greater than day_to;
    • use meaningful buyer-readable name for variant "V2" instead of "Variant Group 2";

  2. /on_search (incr):

    • not sure what's changed for item 100 for it to be a part of incremental update (common use cases like item being out of / in inventory, price change is not shown);

Flow 2

  1. /on_select:

    • TAT of 0 days for F2 isn't correct (should be < 1 hr if F1 is for 1 hr);
    • remove quote.type until enabled;

  2. /on_init:

    • pls add fulfillment TAT;

  3. /on_confirm:

    • provider_tax_number should be PAN no;

  4. /on_status (accepted):

    • invoice should be added at Order-picked-up;

  5. All fulfillment states to be provided (including Agent-assigned, Out-for-delivery);

Flow 3

  1. /on_select (out of stock):
    • error.message format is invalid;

Flow 4

  1. /on_cancel:
    • cancel_request should be for F1;
    • pls add precancel_state;

Flow 5

  1. /on_cancel:
    • quote.breakup[] is invalid: e.g. for item 115, unit price (126) * qty (0) shows total price of 40.50??
    • quote_trail is invalid because of the above;
    • all other issues for flow 4 apply here;

Flow 6a

  1. /on_update:
    • part cancel initiated by merchant; reason code & cancelled by are both invalid;

Flow 6b,c

  1. /on_update:

    • fulfillment id for return request is wrong (has to match return request id);
    • entire return request should be shown in the return fulfillment (return initiated);
    • quote_trail missing in return liquidated;

  2. pls also share log for return pickup failure, leading to return failure;

BLR-0118 commented 8 months ago

@arunraj-nstore @nstoretech

arunraj-nstore commented 8 months ago

@BLR-0118 Please help us to get clarification on the following items.

on_init: pls add fulfillment TAT - As per the document it is added in on_confirm. Should I need to add it on_init. on_cancel: pls add precancel_state - As per the document, it is an optional parameter and only required if fulfillment is cancelled. Is it required to be added.

BLR-0118 commented 8 months ago

@arunraj-nstore - whatever's been requested needs to be taken care of

BLR-0118 commented 8 months ago

Group A

  1. /on_search (full catalog):
    • all products shown are branded, surprising there's no EAN no?
    • you may want to use the optional attribute "brand" for these branded items;
  2. /on_confirm:
    • start & end time slot are same (11:56-12:16);
    • if start time slot is 11:56-12:16 & since TAT is 1 hr, shouldn't end slot be 12:56-13:16?
  3. for flow 2 hyperlocal, pls add routing.type=P2P & send all statuses (Agent-assigned, Packed are missing);

Group B

  1. Flow 5 is specifically for RTO, i.e. when order has left the seller premises & may have to be returned back; there are additional attrs in cancel_request which need to be added;

Group C (flow 7)

  1. return_1_initiated:
    • /on_update for return initiated is a solicited response, should have same message_id as return request;
    • what does the start timeslot for return fulfillment indicate?
  2. return_1_liquidated:
    • what does start.location for return fulfillment mean in this case?
  3. return_2_approved:
    • pickup location should actually be the buyer address, not store address;
  4. return_2_picked:
    • items[] is wrong as all count for item 100 is assigned to fulfillment F1;

pls resubmit for flow 6b & c (return with liquidation, return with pickup) where all the other issues (above) can be checked;

BLR-0118 commented 8 months ago

@arunraj-nstore

arunraj-nstore commented 8 months ago

Hi Supriyo,

We have re-submitted the logs for flow 6b&c as requested. Please review.

https://github.com/ONDC-Official/v1.2.0-logs/pull/1068

Thanks Arunraj Selvam

On Thu, 7 Mar, 2024, 2:19 pm Supriyo Ghosh, @.***> wrote:

@arunraj-nstore https://github.com/arunraj-nstore

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/656#issuecomment-1982987053, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6IQLQJKDEB7MJORH5MAN2TYXASZZAVCNFSM6AAAAABCPDSU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBSHE4DOMBVGM . You are receiving this because you were mentioned.Message ID: @.***>

BLR-0118 commented 7 months ago

@arunraj-nstore - point 3 for Group A above not yet handled. Pls have it fixed & update here. No need to resubmit logs

arunraj-nstore commented 7 months ago

@BLR-0118

We have updated the routing.type and packed state. Here is the payload link for your reference. http://jsonblob.com/1219555085033267200

We are currently not supporting the "Agent-Assigned" status and we will definitely work on this post we go live with V1.2. Thank you

BLR-0118 commented 7 months ago

logs cleared for v1.2.0 (RET10), subject to caveat above;