Fynd (RET12) - compliance check

[sahil-ondc]

on_search_full_catalog_refresh

• /message/catalog must have required property 'bpp/fulfillments'
• location in serviceability construct should be one of the location ids bpp/providers[0]/locations
• serviceability construct /bpp/providers[0]/tags should be defined as per the API contract

on_select

• Item's unit and total price mismatch for id: 7818364_XXL

on_init

• Buyer app finder fee can't change in /on_init

confirm

• payment settlement_details mismatch in /on_init & /confirm

on_confirm

• /message/order/fulfillments/0/end must have required property 'person'
• store name /fulfillments[0]/start/location/descriptor/name can't change
• Buyer app finder fee can't change in /on_confirm

on_status

• /message/order/fulfillments/0/start/time must have required property 'range'
• /message/order/fulfillments/0/end must have required property 'time'
• /message/order/fulfillments/0/end/instructions must have required property 'short_desc'

@tusharmoraye

[tusharmoraye]

on_search_full_catalog_refresh

• /message/catalog must have required property 'bpp/fulfillments'
  => It is as per 1.2 schema. The one you pointed out was probably in 1.1. Please correct us if needed

• location in serviceability construct should be one of the location ids bpp/providers[0]/locations
  => Should we repeat the servicability construct for each location or repeat 'category' block if our lcoation serves multiple location or please explain how to handle multiple?

• serviceability construct /bpp/providers[0]/tags should be defined as per the API contract => please explain how to handle as mentioned above

on_select

• Item's unit and total price mismatch for id: 7818364_XXL
  => The difference of 0.01 is there, we shall check and do it

on_init

• Buyer app finder fee can't change in /on_init
  => We shall do it

confirm

• payment settlement_details mismatch in /on_init & /confirm.
  => This is from BuyerApp side. Please explain what shall we do to take this forward

on_confirm

• /message/order/fulfillments/0/end must have required property 'person'
  => We shall do it

• store name /fulfillments[0]/start/location/descriptor/name can't change
  => Please explain from which request are you comparing?

• Buyer app finder fee can't change in /on_confirm
  => We shall do it

on_status

• /message/order/fulfillments/0/start/time must have required property 'range' => We shall do it

• /message/order/fulfillments/0/end must have required property 'time' => We shall do it

• /message/order/fulfillments/0/end/instructions must have required property 'short_desc' => We shall do it @sharmasahil0331

[tusharmoraye]

@sharmasahil0331 updated logs as per the comments here #75

[sahil-ondc]

on_search_full_catalog_refresh

• Serviceability should be in a unique combination of provider+location+category
• Locality and Street shouldn't be same in message/catalog/bpp/provider/locations/address

on_search_inc_catalog_refresh

• /message/catalog should not contain bpp/fulfillments and bpp/descriptor
• /context/message_id should be same in /search and /on_search

select

• /context/city is not mapped as per the /message/order/fulfillments/end/location/gps
• area_code is not mapped as per the gps provided in /message/order/fulfillments/end/location

on_select

• quote.price.value 22000 does not match with the price breakup 16001.00

on_init

• fulfillment id F670 does not exist in /on_select
• Discrepancies between the quote object in /on_select and /on_init (quantity key was present in on_select in item_id: 7818317_XL but not in on_init )

on_confirm

• area_code is not mapped as per the gps provided in /message/order/fulfillments/end/location
• @ondc/org/buyer_app_finder_fee_type in message/order/fulfillments/payment should be percent

@tusharmoraye

[tusharmoraye]

@sharmasahil0331 fixed issues here #79 need more clarification on the serviceability issue in on_search

[sandeepshahi]

Flow 1

/on_search (full catalog)

• category is not a valid attribute in /bpp/providers/items/tags/attribute
• all the SKUs in a variant group can't have the same attribute value; (variant grp is created on the basis of colours but the colours are same for all the associated SKUs)
• returnable for fashion category is set as false. is this intended?

incremental search

• time range to request the incremental catalog can't be future dated

Flow 2/3

/on_select

• prices in quote/breakup for RET12 should be tax inclusive; no need to provide separate line item

/on_confirm

• estimated delivery time range (fulfillments/end/time/range) is not in sync with the O2D TAT (P2D)
• settlement_basis in /payment should be provided by the seller app in /on_init

/on_status

• /documents for Invoice should only be provided when fulfillment state is Order-picked-up and thereafter
• PCC code (fulfillments/start/instructions) is required when fulfillment state is "Packed"
• DCC code (fulfillments/end/instructions) should be generated when fulfillment is "Out-for-delivery"
• DCC code is 3 (=no delivery code); the value of DCC in /fulfillments/end/instructions/short_desc is not required in this case

Flow 3

/on_select (updated)

• quantity/maximum/count and quantity/available/count in quote/breakup should be in string format

@tusharmoraye

[BLR-0118]

Flow 1

1. /on_search_2247:

   • remove "accept_bap_terms" (until static terms are enabled);
   • item.quantity.available.count has 2 values: "0" (means - out-of-stock), "99" (means - in stock); how to interprete "971"?
   • item.quantity.maximum.count has default value of "99" (means - no cap per order) or any non-default value that identifies cap per order; does "971" mean a cap of 971 items per order?
   • catalog search by city "08288" returns store located in pincode "40053"; this should return stores located in city "08288";
   • item attribute "colour" should have the hex code as value; you can also use "colour_name" to send the colour name;
   • item.descriptor.code is of type "5" (others); others in fashion are using hsn code (type:4);
   • pls use more meaningful description for variant group as this is what buyer apps will render on UX;

2. /on_search_767:

   • similar issues as above but this uses colour hex codes;
   • pls don't send formatted text e.g. as in item.descriptor.long_desc ("

     Long description, manufacturer_or_packer_name ("$saree"), item.descriptor.name ("$Yellow Tank Top" or "@#$%^Light Blue Tank Top");

3. /inc_catalog_refresh_on_search:

   • difficult to identify incremental changes since timestamp for this is before the full refresh;
   • what's changed for this item - 7803931_30?

Flow 2

1. /on_init:
   • remove provider_location;
   • remove cancellation_terms, everything in bpp_terms (except tax_number, provider_tax_number);

Flow 3

1. /on_select: for item level errors, error.message should be as per the format here;

Flow 4

1. /on_confirm:
   • fulfillment TAT of "P1032D" is a typo?? the difference between the start & end time ranges is about 1 month;
   • flow 4 onward, fulfillment.start.location & fulfillment.end.location are the same even though for the items in flow 4, the catalog shows location id of 11853 (pin code 201009);
   • pls add precancel_state;

Flow 5

1. /on_cancel (RTO):
   • cancelled_by should be the bpp_id (not bap_id) as this is initiated by seller & the appropriate reason code (013) used;
   • pls add precancel_state;

Flow 6

1. /on_update (return delivered) - should have delivery timestamp (return fulfillment.end.time.timestamp);

[BLR-0118]

@azharsayyed05 - pls fix the above & make a note here; also, resubmit logs for flow 3 only;

[BLR-0118]

Flow 3

1. All calls /select onward uses Context.city as "*" - this should actually be the city where fulfillment to be delivered;
2. logic & values for item available & max qty should be followed as per above;

[BLR-0118]

@azharsayyed05 - I'm clearing the logs; pls make sure the above is taken care of.

[BLR-0118]

@azharsayyed05 - for intercity shipments, pls make sure you update routing.type to "P2H2P" and provide the intercity statuses as per the contract;

[azharsayyed05]

@BLR-0118

Flow 3

1. context.city as “*” we are receiving from buyer app hence it is getting added in all calls
2. Item available and maximum is already changed as per logic, Please verify

regarding intercity shipments and routing type, we will be exploring this and will update you if there is any blockers/doubts

[BLR-0118]

from catalog log here:

• colour should be sent in html colour format (prepended by "#");
• our understanding was that colour hex code will be sent for all items (except colours like black & white where there's no colour);
• "millennial pink" has colour code #F3CFC6 which should be used (instead of not sending colour code);
• for items 7803924*, all reqd attributes not being sent (e.g. brand); due to this, some buyer apps may reject these items;

from return log here & here:

• quote.price.value should be string (strange that's wrong only here);
• quote entries are incorrect: quote.price.value should be "4000", quote.breakup[] has 2 entries for item "7803924_L" for qty 2 & 1 (not sure why the qty 1 entry is here as that was part cancelled earlier);

[BLR-0118]

@azharsayyed05 - pls take care of the above