Wits Adapter (RSP) — compliance checks

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0

9 stars 248 forks source link

Wits Adapter (RSP) — compliance checks #718

Closed sandeepshahi closed 6 months ago

pratik-mazumdar commented 7 months ago

settle

message.settlement.settlements[0].state is not allowed
message.settlement.settlements[0].settlement_reference_no is not allowed
message.settlement.settlements[1].payer_bank_code with value ""HDFC0000000"" is invalid IFSC Code
message.settlement.settlements[1].payee_bank_code is invalid "HDFC900008" IFSC Code

on_settle

message.settlement.settlements[0].error_code is not allowed when state is 01
message.settlement.settlements[0].error_message is not allowed when state is 01

receiver_recon

message.orderbook.orders[0].payment.@ondc/org/settlement_details[0].settlement_ifsc_code with value "HDFC900008" is invalid ifsc code.
"message.orderbook.orders[0].payerdetails.payer_bank_code" with value ""HDFC0000000"" is invalid ifsc code.

on_receiver_recon

Is fine.

pratik-mazumdar commented 7 months ago

collector_recon

bap_id must be buyer app, not seller application
bap_uri must be buyer's app, not seller application
message.orderbook.orders.collected_by is "BAP" then @ondc/org/settlement_details.settlement_counterparty must be seller-app
message.orderbook.orders.@ondc/org/settlement_details.settlement_reference is not allowed
message.orderbook.orders.@ondc/org/settlement_details.settlement_timestamp is not allowed

on_collector_recon

bap_id must be buyer app, not seller application
bap_uri must be buyer's app, not seller application

sandeepshahi commented 7 months ago

/collector_recon

payment object should remain the same as in the retail txn; "@ondc/org/buyer_app_finder_fee_type" should be percent (lower case 'p')
calculation of withholding tax amount and withholding tax GST doesn't seem correct.

/receiver_recon

bap_id/uri and bpp_id/uri seem incorrect; receiver recon is called by RSP/collector to the receiver
settlement_reference in "@ondc/org/settlement_details" should match with the settlement_reference_no in /on_settle; check for order with id: 61f54041-affd-4ace-a4a6-ef4cd6390a43

/recon_status and /on_recon_status must also be supported

Notes:

settlement amount can be consolidated for a collector-receiver pair in /settle and a single settlement id can be created by the RSP

@vishal-wits

sandeepshahi commented 6 months ago

/settle

settlements/timestamp can't be the same as orderbook timestamp;

/on_settle

bap, bpp id/uri seem incorrect

@vishal-wits

sandeepshahi commented 6 months ago

Please share the logs for the above 2 payloads.

vishal-wits commented 6 months ago

@bluecypher, we have checked bap, bpp_id and bpp_uri seems correct, as we have generated settle and on_settle from ONDC mock server. Can you please elaborate what is the issue ?

"bpp_id": "products-rsp-nodejs.thewitslab.com",
"bap_id": "rsf-mock-service.ondc.org",
"bpp_uri": "https://products-rsp-nodejs.thewitslab.com",
"bap_uri": "https://rsf-mock-service.ondc.org"

sandeepshahi commented 6 months ago

Logs approved for RSP v1.0.0

@vishal-wits