Closed BLR-0118 closed 6 months ago
@NajeebMohammed - pls resubmit logs as whatever is shared can't be verified;
/on_search (full refresh):
/on_search (incr):
/on_select:
/on_status (agent assigned):
/on_status (order delivered):
/track & /on_track are required for F&B;
Hi @NajeebMohammed - pls fix the issues above & resubmit for flows 3, 4. 5; if you need any clarifications, let's connect; also, what are your plans on flow 6 (a, b) as doc here?
Flow 1
- /on_search (full refresh):
- pls remove "accept_bap_terms" (will be enabled with static terms);
- there are 37 custom menu items defined (in flat structure); it'll be difficult for a buyer app to render this in limited screen real-estate;
- all items in F&B should have type defined (e.g. items without type - 64677c095b34453159581116, 64677c095b34453159581117, 64639b831527f9bdba11a619);
- for items with price of 0 (e.g. 64ba6b25b21b773b4ff31a07), consider using either of the following (default_selection or upper/lower as defined here) to properly guide buyers in the provider listing page;
- /on_search (incr):
- for item 64677c095b34453159581116, max/avail qty is changed to 1000; means what?
- in F&B, common scenarios such as store closure (definite duration), store closure (indefinite duration) + reopening need to be supported thru incremental refresh; hope this is supported?
/on_select:
fulfillment.tracking is false in /on_select, /on_init but true in /on_confirm; can't we make it true everywhere as tracking is required for f&b orders;
/on_status (pending):
/on_status (order picked up):
/on_track:
Flow 3 - ok;
Flow 5 - same issues as in flow 4;
@NajeebMohammed - pls resubmit flow 2, 4,, 6b;
/on_select:
/on_init:
/on_confirm:
/on_status_pending:
/on_status_order_pickedup:
/on_track:
/on_cancelRTO_initiated:
/on_status_RTO_delivered:
@NajeebMohammed - pls fix the above & resubmit flows 2, 5 & 6 only;
/on_confirm: fulfillment TAT is 1hr 49min but pickup slot is between 11:08 (when order placed) & 12:13 (gap of 1 hr 5min): how's this possible? ES> These are sample numbers calculated based on TAT provided by the LSP. In produciton these numbers will make more sense.
gps_enabled, url_enabled, url should be set only when the order can be tracked (i.e. either at Agent-assigned or Order-picked-up); ES> We are receiving this from loadshare and we are passing as is.
Flow 5: for F&B, fulfillment state should be updated to RTO-Disposed (RTO-Delivered is only if items are returned back to store); ES> Loadshare doesn't support RTO-Disposed. Although we are passing rto flag as no, they are still returning RTO-Delivered. We are passing in as is. Should work ok in production.
Flow 6. no flows for merchant part cancel (6a), return with liquidation (6b); ES> part cancel we dont support. Full cancel (merchant rejection) already submitted.
@NajeebMohammed - pls have the above fixed & resubmit for flows 2 & 5; also, has "zomatoCatalog" key been removed from /on_search?
- Context.timestamp date is 2nd march 24 but location.updated_at & location.time.timestamp dates are 1st Aug 23?
This data is coming from loadshare. We have notified them and they said its sample data.
@NajeebMohammed - pls have the above fixed & resubmit for flows 2 & 5; also, has "zomatoCatalog" key been removed from /on_search?
Yes, this is removed.
@NajeebMohammed - clearing logs but pls make sure 1 above is fixed & 2 is checked
Flow 1
/on_search (catalog full refresh):
difficult to correlate full & incremental catalog refresh as incremental refresh is for items which aren't in full catalog refresh; are all items in incremental refresh new?
Flow 2