ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 261 forks source link

Pincode (SNP) - compliance check (RET10) #750

Open BLR-0118 opened 8 months ago

BLR-0118 commented 8 months ago
  1. /on_search:
    • bpp/descriptor should have np_type;
    • bpp/providers.descriptor should have short_desc, long_desc;
    • bpp/providers.time.label should be lower case, i.e. "enable";
    • bpp/providers.fulfillments.contact should have phone, email;
    • bpp/providers.locations.circle.radius should have unit "km";
    • bpp/providers.locations.time.days should have days of week for which store is open;
    • items.descriptor.code should have the format "type:value";
    • every location in bpp/providers.locations should have unique id (provider U2401051545006596622948_FC2401051545006606622004 doesn't have location id);
    • items.descriptor should have long_desc;
    • item.quantity.unitized needs to be populated with net qty;
    • item.quantity.maximum & item.quantity.available values are string;
    • item.quantity.available has default value of "99" (means - in-stock), "0" (means - out-of-stock);
    • item.quantity.maximum has default value of "99" (means - no cap per order) or any other value identifying cap per order;
    • item.category_id should match a category in this list;
    • item.location_id should match a unique id defined for the location (see above);
    • item.item_id & item.customization_grp_id are not valid keys and should be removed;
    • either or both of statutory_reqs_packaged_commodities / statutory_reqs_prepackaged_food should be populated for item;
    • following keys need to be provided for item: return_window, seller_pickup_return, contact_details_consumer_care;
    • catalog should have "ttl" defined for bpp/provider;
    • for provider, following needs to be defined: serviceability, store timings;
BLR-0118 commented 8 months ago

Flow 1

  1. /on_select:

    • item.quantity.maximum & item.quantity.available values are string;
    • item.quantity.available has default value of "99" (means - in-stock), "0" (means - out-of-stock);
    • item.quantity.maximum has default value of "99" (means - no cap per order) or any other value identifying cap per order;
    • for items, maximum_value can't be greater than value;
  2. /on_init:

    • pls remove provider_location;
    • tax_number & provider_tax_number also reqd for BAP to verify whether seller is MSN/ISN;
    • settlement_details for seller required for settlement to happen thru RSF;
  3. /confirm:

    • should have BAP tax_number (for TCS by BPP on BFF);
  4. /on_confirm:

    • start location of fulfillment is required;
    • fulfillment status should be "Pending";
    • tax_number & provider_tax_number also reqd for BAP to verify whether seller is MSN/ISN;
    • settlement_details for seller required for settlement to happen thru RSF;
  5. /on_status (1 to 4):

    • fulfillment.start details should be available;
    • pickup time & delivery time to be populated at pickup / delivery status change;
BLR-0118 commented 8 months ago

Flow 2

  1. /on_cancel:

    • cancel fulfillment should be created and items assigned to cancel fulfillment;
    • quote_trail to be added in cancel fulfillment;
    • quote.breakup has duplicate line items for item_id 437029gq9nD80i4HXXHKokX7cP;
    • quote.price is not adding up to quote.breakup.price (for all line items);
  2. pls set Context.version to "1.2.0" for all requests & responses;

BLR-0118 commented 8 months ago

@thsubaku9 - also need logs for item out of stock (flow 3), RTO (flow 5), part cancel & return liquidation (flow 6) as doc here;

thsubaku9 commented 8 months ago

Acknowledged, will get all these issues sorted

BLR-0118 commented 7 months ago
  1. /on_search2:
    • pls add np_type to bpp/descriptor (details in the contract);
    • pls add bpp/providers.images[] as most buyer apps show this on the provider listing page;
    • pls use this enum for item.quantity.unitized.measure.unit;
    • locations.time.label should be "enable" (as for items);
    • pls also add serviceability, store timings as per the new construct under bpp/providers.tags.serviceability and bpp/providers.tags.timing respectively;
  2. request to also share logs for the full order flow, cancellation, part return/cancel as doc here;
BLR-0118 commented 7 months ago

@thsubaku9

thsubaku9 commented 7 months ago

Acknowledged @BLR-0118 Will be fixing + submitting logs for pre order flows first. Followed by casewise fixing and submitting post order flows