ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 268 forks source link

Paytm GC (IGM) - compliance check #751

Open Rishabh-ondc opened 9 months ago

Rishabh-ondc commented 9 months ago

Item Flow issue

on_issue

on_issue_status

Clarificaitons

Fulfillment/ Payment

@harshitlearning09 @deepalibansal_bitbucket

Anupam1705 commented 9 months ago

@Rishabh-ondc

on_issue_status

context.message_id different from issue_status, is this an unsolicited call? - Yes, this is an unsolicited call

Clarifications

Context object should be same as the transaction APIs context object. (location object instead of country and city attributes directly) - This should be handled at buyer end. We are creating the context in the same way as receiving from buyer end. Is this a specific change required for GV IGM?

Fulfillment/ Payment :

Timestamps for issue.created_at and updated_at in issue API is same - this is as expected from previous logs feedback https://github.com/ONDC-Official/verification-logs/issues/1229

Rishabh-ondc commented 9 months ago

This should be handled at buyer end. We are creating the context in the same way as receiving from buyer end. Is this a specific change required for GV IGM?

Yes this should be handled by NPs in the GV construct

Timestamps for issue.created_at and updated_at in issue API is same - this is as expected from previous logs feedback

The timestamps are the same across all logs is the issue

RupalSingla commented 7 months ago

item "on_issue": "created_at": "context timestamp should be greater than or equal to updated_at in on_issue"

fulfillment _on_issue_status "igmTxnId": "transaction ID mismatch in /issue and /on_issue_status"

@Anupam1705

RupalSingla commented 7 months ago

ON_ISSUE AND ON_ISSUE_STATUS : timestamp for respondent_actions.updated_at in issue cannot be more than espondent_actions.updated_at in issue. Respondant action object's timestamp cannot be changed .

Pls consider all the above comments ..

LOG CLEARED FOR VERSION 1.0.0 @Anupam1705

Anupam1705 commented 7 months ago

@RupalSingla For point item "on_issue": "created_at": "context timestamp should be greater than or equal to updated_at in on_issue" Its just 1 ms difference as context.timstamp = "timestamp": "2024-03-26T13:15:02.223Z", updated_at in on_issue = "updated_at": "2024-03-26T13:15:02.224Z",

It may be delay in processing, but it wont happen in general

Secondly, I am not clear with this point : ON_ISSUE AND ON_ISSUE_STATUS : timestamp for respondent_actions.updated_at in issue cannot be more than espondent_actions.updated_at in issue. Respondant action object's timestamp cannot be changed . Can you please elaborate this or we can have a call maybe for this?

RupalSingla commented 6 months ago

timestamp for respondent_actions.updated_at in issue cannot be more than espondent_actions.updated_at in issue. Respondant action object's timestamp cannot be changed . Can you please elaborate this or we can have a call maybe for this?

timestamp in respondent action in on_issue and and on_issue_statusfor processing actions shouldnot change